vkrause created this revision.
vkrause added reviewers: Frameworks, svuorela.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.
REPOSITORY
R280 Prison
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10433
AFFECTED FILES
.gitignore
vkrause created this revision.
vkrause added reviewers: Frameworks, svuorela.
Restricted Application added a project: Frameworks.
vkrause requested review of this revision.
REVISION SUMMARY
This matches the behavior of all the 2D codes.
REPOSITORY
R280 Prison
REVISION DETAIL
elvisangelaccio added inline comments.
INLINE COMMENTS
> dfaure wrote in fileundomanager.cpp:404
> Where's the corresponding call to slotUnlock?
>
> I think you only wanted to update the state of the action, maybe better to do
> that directly.
You mean just an `emit undoAvailable(false);` ?
davidedmundson added a comment.
Cool in principle, few nitpicks.
INLINE COMMENTS
> barcodequickitem.cpp:37
> +BarcodeQuickItem::BarcodeQuickItem(QQuickItem *parent)
> +: QQuickPaintedItem(parent)
> +{
Is createBarcode a heavy function? It sounds like it could be.
If so I'd recommend
davidedmundson abandoned this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7085
To: davidedmundson, #plasma
Cc: plasma-devel,
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks for your work. I am hesitant about the choice of an audio tape. I fear
people under 30 will not recognize it.
I would like to propose trying the tape with the current color and
dfaure added inline comments.
INLINE COMMENTS
> udsentrytest.cpp:227
> +/**
> + * Test to verify that move semantics work. This is only useful when ran
> through callgrind.
> + */
... or gdb, or perf, or with debug output in the cpp file, or
> udsentrytest.cpp:234
> +
ngraham added a comment.
Would you mind re-basing this on master? I can reproduce the issue and would
be happy to test the patch.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8958
To: aleksejshilin, #frameworks
Cc: broulik, ngraham, michaelh
aleksejshilin updated this revision to Diff 26872.
aleksejshilin added a comment.
- Don't consider mouse moves which are smaller than drag distance
- Don't pass the ignored mouse release event to the base class
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
aleksejshilin added inline comments.
INLINE COMMENTS
> ngraham wrote in kurlnavigatormenu.cpp:85
> Will this still work if the user is using the mouse in left-handed mode?
Quoting Qt documentation [1]:
> | Qt::LeftButton | The left button is pressed, or an event refers to the left
> button.
aleksejshilin added a comment.
Hi again. :)
Any news on this? Is there anything I should improve?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8958
To: aleksejshilin, #frameworks
Cc: broulik, ngraham, michaelh
ngraham added inline comments.
INLINE COMMENTS
> kurlnavigatormenu.cpp:85
> +// it unless mouse was moved.
> +if (m_mouseMoved || (btn != Qt::LeftButton)) {
> +QAction *action = actionAt(event->pos());
Will this still work if the user is using the mouse in left-handed mode?
ngraham added a comment.
OK cool. The patch works for me! +1. Get a code review from someone else
before committing.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8958
To: aleksejshilin, #frameworks
Cc: broulik, ngraham, michaelh
markg updated this revision to Diff 26868.
markg added a comment.
Update test.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10414?vs=26839=26868
BRANCH
udsentry_reductions
REVISION DETAIL
https://phabricator.kde.org/D10414
AFFECTED FILES
markg marked 7 inline comments as done.
markg added a comment.
Seems my unittest skills have become a bit rusty over the years of basically
not contributing patches to KDE ;)
Thank you for the comments, David!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10414
To:
markg added a comment.
@dfaure i can make the test much more complete if you want.. But it's more
complex thus i left it out.
I can store the UDSEntry in a QDataStream which would be backed by a
QByteArray. That can be hashed!
Then i can do the same after moving operations and compare
ngraham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/126/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sat, 10 Feb 2018 17:04:27 +
Build duration:
5 min 45 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/108/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Sat, 10 Feb 2018 17:04:27 +
Build duration:
9 min 15 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/128/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sat, 10 Feb 2018 17:04:27 +
Build duration:
16 min and counting
JUnit Tests
Name: (root)
ijanssen updated this revision to Diff 26877.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10114?vs=25981=26877
REVISION DETAIL
https://phabricator.kde.org/D10114
AFFECTED FILES
src/filewidgets/kfilewidget.cpp
To: ijanssen, #plasma, dfaure
Cc: ngraham,
ijanssen added a comment.
In https://phabricator.kde.org/D10114#203764, @ngraham wrote:
> It doesn't merge cleanly on master. Can you re-base it?
I've updated diff.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc:
aleksejshilin added a comment.
In https://phabricator.kde.org/D8958#203931, @ngraham wrote:
> OK cool. The patch works for me! +1.
Great, thanks a lot!
> Get a code review from someone else before committing.
I don't have push access, so no worries. :)
REPOSITORY
R241
pgkos updated this revision to Diff 26878.
pgkos added a comment.
This is a simpler implementation - the diff changes roundToIconSize so it
uses scaled units.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7849?vs=19612=26878
REVISION
pgkos added a comment.
In my opinion, roundToIconSize should operate on scaled units - it is used
multiple times in a few plasmoids - all calls from them to roundToIconSize
assume it will operate on scaled units.
The method, as it is now, is useless, because QML code has no access to
ngraham added a comment.
Thanks. Confirmed the fix, BTW.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ngraham added a comment.
To commit this for you, I need an email address. Can you provide one?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma, dfaure
Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
progwolff,
ijanssen added a comment.
In https://phabricator.kde.org/D10114#203996, @ngraham wrote:
> To commit this for you, I need an email address. Can you provide one?
alave...@gmail.com
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10114
To: ijanssen, #plasma,
28 matches
Mail list logo
