D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Letting KIO::Job handle these prompts is pointless because

D10569: Bump shared-mime-info to 1.3

pino created this revision. pino added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. pino requested review of this revision. REVISION SUMMARY Bump the build time requirement, and assumed runtime, version of

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207435 , @mvourlakos wrote: > > Would you please add a HACK so that we know when to remove this? > > You mean as a comment ? Yes, preferably with the Qt bug number and some explanation.

D10568: Handle privilege operation confirmation prompts in SlaveBase

chinmoyr created this revision. chinmoyr added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY This way a confirmation dialog is always shown if the

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

chinmoyr edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10567 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10533: [Icon Item] Set filtering on FadingNode texture

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures the fading node's texture has the

D10531: [QmlObjectIncubationController] Don't call incubate() while already incubating

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10531 To: broulik, #plasma, mart Cc: jtamate, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10536: Kill QmlObjectIncubationController

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY All it does is slow things down

D10536: Kill QmlObjectIncubationController

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. doesn't seem to harm the interactivity of the system while loading popups in the background, so ship it :) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10536

D10536: Kill QmlObjectIncubationController

mart added a comment. anyways, i'll try it together with the preload stuff and see if there is some noticeable difference, for better of for worse REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D10536 To: broulik, #plasma Cc: mart, davidedmundson,

D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

broulik planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7534 To: broulik, kde-frameworks-devel, dfaure Cc: #frameworks, michaelh

D10531: [QmlObjectIncubationController] Don't call incubate() while already incubating

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY During incubation we're still getting

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

mwolff added a comment. In D7968#206500 , @whiting wrote: > Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing

D10533: [Icon Item] Set filtering on FadingNode texture

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10533 To: broulik, #plasma, davidedmundson Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10536: Kill QmlObjectIncubationController

mart added a comment. In D10536#206818 , @davidedmundson wrote: > I can't think of a situation where I'd want to process anything other than the thing I'm waiting on. uuh, user input? REPOSITORY R296 KDeclarative REVISION DETAIL

D10537: Convert from old connect syntax to new one

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY Starting plasmashell with callgrind I noticed a line: QObject::connect: No such slot

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D9814 To: broulik, #frameworks, davidedmundson, apol Cc: apol, emmanuelp, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Feb 2018 12:33:43 + Build duration: 7 min 15 sec and counting

D10512: try to preload certain applets in a smart way

mart added a comment. sooo, benchmarks: i tracked the time that occurs between mouse click and the return of setExpanded, which is reasonably near to the popup actually appearing (numbers consistent doing things more than once) this is done on a fairly fast machine, would be interesting

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

broulik added a comment. Ping REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D9814 To: broulik, #frameworks, davidedmundson Cc: emmanuelp, michaelh

D10537: Convert from old connect syntax to new one

broulik added inline comments. INLINE COMMENTS > listjob.cpp:140 > +QObject::connect(job, ::entries, q, > +[this](KIO::Job* job,KIO::UDSEntryList list) > +{gotEntries(job, list);} ); `const KIO::UDSEntryList &` REPOSITORY

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

apol added a comment. +1 looks sensible. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D9814 To: broulik, #frameworks, davidedmundson Cc: apol, emmanuelp, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/65/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Thu, 15 Feb 2018 12:33:44 + Build duration: 17 min and counting JUnit

D10536: Kill QmlObjectIncubationController

This revision was automatically updated to reflect the committed changes. Closed by commit R296:8b10c4657f6e: Kill QmlObjectIncubationController (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10536?vs=27234=27236 REVISION DETAIL

D10531: [QmlObjectIncubationController] Don't call incubate() while already incubating

broulik abandoned this revision. broulik added a comment. Superseded by D10536 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10531 To: broulik, #plasma, mart Cc: jtamate, plasma-devel, #frameworks, michaelh,

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

davidedmundson added inline comments. INLINE COMMENTS > kiconloader.cpp:542 > > +startPoint /= pix.devicePixelRatio(); > + Typically it's a lot easier to do everything in logical co-ordinates, rather than effectively convert co-ordinates to device pixels and then convert back.

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/38/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Feb 2018 12:33:43 + Build duration: 4 min 57 sec and counting

D10531: [QmlObjectIncubationController] Don't call incubate() while already incubating

jtamate added a comment. Also measured scientifically accurate with a stopwatch 2:34 minutes in callgrind wihtout the patch. I refs: 10,827,698,978 2:20 minutes in callgrind with the patch.I refs: 10,668,473,812 +1 REPOSITORY R242 Plasma Framework (Library)

D10536: Kill QmlObjectIncubationController

davidedmundson added a comment. This made my system ironically more responsive than it was before, even with the QML cache cleared. I guess a lot changed in Qt since it was written. I can't think of a situation where I'd want to process anything other than the thing I'm waiting on.

D10533: [Icon Item] Set filtering on FadingNode texture

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c05b1bdec790: [Icon Item] Set filtering on FadingNode texture (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: abetts, michaelh, ngraham

D10537: Convert from old connect syntax to new one

jtamate updated this revision to Diff 27238. jtamate edited the test plan for this revision. jtamate added a comment. fixed broulik comment. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10537?vs=27235=27238 REVISION DETAIL

D9814: [KIconLoader] Take into account devicePixelRatio for overlays

This revision was automatically updated to reflect the committed changes. Closed by commit R302:0b59d17d5949: [KIconLoader] Take into account devicePixelRatio for overlays (authored by broulik). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE

D9675: Don't show context menu menu if right-clicking outside

broulik added a comment. Ping REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks Cc: michaelh

D10543: fix crashing with duplicate entries

apol added inline comments. INLINE COMMENTS > karchive.cpp:832-833 > +<< "has entry" << entry->name() << "already"; > +delete d->entries.take(entry->name()); > return; > } Haven't looked at the code yet, but this doesn't make much sense. Since it's

D10543: fix crashing with duplicate entries

sandsmark created this revision. sandsmark added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY some zip files apparently can have duplicate entry names, which weren't handled correctly. TEST

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27263. mart added a comment. - less aggressive preload policy REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27169=27263 BRANCH mart/preload REVISION DETAIL

D10543: fix crashing with duplicate entries

apol added inline comments. INLINE COMMENTS > karchive.cpp:829 > { > -if (d->entries.value(entry->name())) { > -/*qCWarning(KArchiveLog) << "directory " << name() > -<< "has entry" << entry->name() << "already";*/ > -delete entry; > +if

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27275. sandsmark added a comment. actually do the correct thing REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=27254=27275 REVISION DETAIL https://phabricator.kde.org/D10543 AFFECTED FILES

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27276. sandsmark added a comment. handle stuff a bit prettier. I don't think there's a "right" way to handle this, so parsing is a bit best-effort, but at least it doesn't crash anymore. REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE

D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY It has been a little bit confusing that the prefix dir of

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij @mart we need to revert this... with frameworks 5.43 it reverses list items always!!! The issue is still present when the PlasmaComponents3.ComboBox is used in the Latte settings window, that is the items are not aligned correctly in

D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns

kossebau added a comment. Anpther option I considered was to promote instead KRunner:: as C++ namespace, using a namespace alias for the time until KF6. Unsure where KRunner is heading in the future and how decoupled from Plasma it should be at all (possible reuse in other systems?), I

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207260 , @mvourlakos wrote: > @mart I fixed this issue by changing these lines to: > > 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > 114

D9675: Don't show context menu menu if right-clicking outside

wbauer added a comment. I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks Cc: wbauer, michaelh

D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns

broulik added a comment. I would actually prefer the class to be `KRunner::AbstractRunner` but that's obviously not something we could change. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10554 To: kossebau, broulik Cc: #frameworks, michaelh

D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns

kossebau added a comment. In D10554#207285 , @broulik wrote: > I would actually prefer the class to be `KRunner::AbstractRunner` but that's obviously not something we could change. Okay. I will play with a patch for namespace aliasing

D10543: fix crashing with duplicate entries

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the fix! INLINE COMMENTS > karchive.cpp:471 > } else { > -//qCWarning(KArchiveLog) << "Found" << path << "but it's not a > directory"; > +

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @mart I fixed this issue by changing these lines to: 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft 114LayoutMirroring.childrenInherit: true REPOSITORY R242 Plasma Framework (Library) REVISION

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

dhaumann accepted this revision. dhaumann added a comment. Yes, looks ok, will integrate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10509 To: mmustac, #ktexteditor, ngraham, #kate, cullmann, dhaumann Cc: dhaumann, #frameworks, michaelh, kevinapavew,

D10509: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text Upppercase, Lowercase and Capitalize

This revision was automatically updated to reflect the committed changes. Closed by commit R39:6a3599b9e803: Add icons for KTextEditor Document-Export, Bookmark-Remove and Formatting Text… (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/26/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Feb 2018 20:36:01 + Build duration: 24 min and counting JUnit Tests

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27281. sandsmark added a comment. prettify REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=27276=27281 REVISION DETAIL https://phabricator.kde.org/D10543 AFFECTED FILES src/karchive.cpp To: sandsmark,

D10543: fix crashing with duplicate entries

sandsmark updated this revision to Diff 27286. sandsmark added a comment. an actual fix, which passes all unit tests. REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=27281=27286 REVISION DETAIL https://phabricator.kde.org/D10543 AFFECTED FILES

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > krun.cpp:1619 > + > +if (qGuiApp) { > +QTimer::singleShot(0, qGuiApp, [=]() { Actually, KMessageBox requires qApp, not just qGuiApp. (Then

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e3a80661c9cd: Stuff the Couldnt find executable message box into a queued lambda (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10405?vs=27048=27285#toc REPOSITORY R241

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. Thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/133/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Thu, 15 Feb 2018 18:48:15 + Build duration: 5 min 49 sec and counting JUnit Tests Name:

D10551: autotest for crashing in KArchiveDirectory::addEntry

sandsmark created this revision. sandsmark added reviewers: dfaure, apol. sandsmark added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sandsmark requested review of this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10551

D10543: fix crashing with duplicate entries

sandsmark added a dependency: D10551: autotest for crashing in KArchiveDirectory::addEntry. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10543 To: sandsmark, dfaure, #frameworks Cc: apol, michaelh

D10551: autotest for crashing in KArchiveDirectory::addEntry

sandsmark added a dependent revision: D10543: fix crashing with duplicate entries. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10551 To: sandsmark, dfaure, apol Cc: #frameworks, michaelh

D10405: Stuff the "Couldn't find executable" message box into a queued lambda

hein added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/135/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Feb 2018 18:48:15 + Build duration: 30 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/115/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Feb 2018 18:48:15 + Build duration: 12 min and counting JUnit Tests Name:

D9675: Don't show context menu menu if right-clicking outside

wbauer added a comment. In D9675#207283 , @wbauer wrote: > I suppose that would fix https://bugs.kde.org/show_bug.cgi?id=373653 ? Just tried it myself, and it does fix it. REPOSITORY R263 KXmlGui REVISION DETAIL

D9675: Don't show context menu menu if right-clicking outside

ngraham edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D9675 To: broulik, #frameworks Cc: wbauer, michaelh

D10554: Change include namespace from KRunner/ to Plasma/, to match C++ ns

kossebau abandoned this revision. kossebau added a comment. Bummer, no straight namespace aliasing possible: "Plasma::" namespace prefixed is used in some signal/slot signatures, and Qt's string-based signal/slot gets in the way here, moc cannot know about any possible aliases, so there is

D10494: update handle- icons for kirigami

andreask added a comment. submitted REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10494 To: andreask, alex-l, mart Cc: matheusm, mmustac, ngraham, #frameworks, michaelh

D10494: update handle- icons for kirigami

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:55b56d236e9b: update handle- icons for kirigami (authored by andreask). REPOSITORY R266 Breeze Icons CHANGES SINCE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/52/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Feb 2018 23:58:12 + Build duration: 2 min 54 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/49/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Feb 2018 23:58:12 + Build duration: 3 min 29 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.7/52/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.7 Date of build: Thu, 15 Feb 2018 23:58:12 + Build duration: 5 min 57 sec and counting JUnit Tests

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. > Would you please add a HACK so that we know when to remove this? You mean as a comment ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel,