D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. The only component I could find to be affected by this change is `baloo-widgets`. I have already adapted it to this change. And yes, it will handle both. It will take a some time to publish it because some other stuff has to get reviewed first. I you know of

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Well, in a library that 99% relies on a database, having no database is not something that can be gracefully handled (the returned nullptr is asserted on as well in the function that

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

ngraham added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks Cc: #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

ngraham added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, #dolphin Cc: #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

ngraham added a comment. Thanks for the patch! Please remove "bug 390748" from the title and instead add "BUG: 390748" to its own line in the Summary section. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R241 KIO REVISION DETAIL

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

meven created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. meven requested review of this revision. REPOSITORY R241 KIO BRANCH bug-390748-make-kio-delete-asynchronous REVISION DETAIL

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

meven added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

ivan added a comment. @hein This is not really as simple as 'accept without a comment'. I don't mind this patch to be merged, but keep in mind that it just turns users for which plasma crashes (for which we get an explicit message as to why) into users who do not have certain parts

D10681: preload the expander (the dialog) too

broulik added inline comments. INLINE COMMENTS > appletquickitem.cpp:295 > +qint64 time = 0; > +if (QLoggingCategory::defaultCategory()->isInfoEnabled()) { > +time = QDateTime::currentMSecsSinceEpoch(); You should check the PlasmaQuick category, not the default one REPOSITORY

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein added a comment. @ivan So you wrote a method that can return null, but the call sites aren't actually prepared to handle that gracefully? :) But I was waiting for your review for that context. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

meven edited the summary of this revision. meven edited the test plan for this revision. meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, #dolphin, dfaure Cc: ngraham, #frameworks, michaelh

D10591: forcefully activate popup windows when they open

broulik added a comment. If we were to do this, we need to first make Device Notifier not freak out when you have a wonky USB cable. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: broulik, davidedmundson,

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

meven retitled this revision from "bug 390748 Always use a job to delete files to avoid freezing process waiting on IO" to "BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To:

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

meven edited the summary of this revision. meven edited reviewers, added: ngraham; removed: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10512: try to preload certain applets in a smart way

anthonyfieroni added inline comments. INLINE COMMENTS > mart wrote in appletquickitem.cpp:57-68 > > So Adaptive can a default even environment variable is not setted? > > yes, adaptive is the default > > > Furthermore you can make a static function to access value > > it's done anyways only

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/68/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 20 Feb 2018 10:18:16 + Build duration: 5 min 33 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/65/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Feb 2018 10:18:16 + Build duration: 15 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/41/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Feb 2018 10:18:16 + Build duration: 4 min 31 sec and counting

D10671: Fix auto-mount regression

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I added a similar check in Storage Volume but did not here.. :/ I can confirm that those "Loop Devices" are still ignored, which is good. REPOSITORY R245 Solid REVISION DETAIL

D10669: Reduce plasmashell frozen time

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH polling (branched from master) REVISION DETAIL https://phabricator.kde.org/D10669 To: jtamate, #plasma, #frameworks, mart Cc: plasma-devel, davidedmundson, michaelh,

D10512: try to preload certain applets in a smart way

mart added inline comments. INLINE COMMENTS > anthonyfieroni wrote in appletquickitem.cpp:57-68 > So Adaptive can a default even environment variable is not setted? > Furthermore you can make a static function to access value > > AppletQuickItemPrivate::PreloadPolicy

D10681: preload the expander (the dialog) too

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY when preloading, preload the expander as well, and

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/66/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Feb 2018 13:56:27 + Build duration: 21 min and counting JUnit

D10681: preload the expander (the dialog) too

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10681?vs=27605=27606#toc REPOSITORY R242 Plasma Framework (Library)

D10518: Use QWidget to see if the window is visible

This revision was automatically updated to reflect the committed changes. Closed by commit R289:09e848b68d7c: Use QWidget to see if the window is visible (authored by apol). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10518?vs=27182=27612 REVISION

D10684: [Drop Job] Create proper trash file on linking

broulik created this revision. broulik added reviewers: Frameworks, Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma wants to remove the default trash

D10684: [Drop Job] Create proper trash file on linking

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10684 To: broulik, #frameworks, #plasma, hein Cc: plasma-devel, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10681: preload the expander (the dialog) too

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appletquickitem.cpp:294 > +{ > +qint64 time = QDateTime::currentMSecsSinceEpoch(); > +createFullRepresentationItem(); wrap this line in

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 69 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/69/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 20 Feb 2018 13:56:27 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/42/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Feb 2018 13:56:27 + Build duration: 55 min and counting

D10691: Fix plasmashell crash when database is broken

kpiwowarski created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kpiwowarski requested review of this revision. REVISION SUMMARY BUG:390774 TEST PLAN Compiled and plasmashell doesn't crash when open kicker

D10691: Fix plasmashell crash when database is broken

ngraham added reviewers: Plasma, Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks Cc:

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski retitled this revision from "Fix plasmashell crash when database is broken" to "[kactivities-stats] Fix plasmashell crash when database is broken". REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma, #frameworks, hein Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10694: epubextractor: Handle multiple subjects better

michaelh created this revision. michaelh added reviewers: mgallien, dfaure. michaelh added projects: Baloo, Dolphin, Frameworks. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Instead of returing one long word of

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. The problem with any changes to the extractors its that the baloo database of users will not be refreshed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: #frameworks, ashaposhnikov, michaelh,

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#210409 , @michaelh wrote: > @mgallien Then they won't benefit from this until a file is reindexed. > Users with baloo disabled will benefit, because in that case `baloo_filemetadata_temp_extractor` will

D10671: Fix auto-mount regression

dkhlestkov added a comment. dsx@yandex.ru REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. @mgallien Then they won't benefit from this until a file is reindexed. Users with baloo disabled will benefit, because in that case `baloo_filemetadata_temp_extractor` will extract the data on-the-fly. Reindexing just the ebooks can be done with: find

D10671: Fix auto-mount regression

ngraham added a comment. In D10671#209941 , @dkhlestkov wrote: > In D10671#209868 , @ngraham wrote: > > > we will need an email address to land this patch if it is accepted > > > How do I