D10826: Introduce DocumentId class

michaelh added inline comments. INLINE COMMENTS > svuorela wrote in documentid.cpp:67 > if you make operator DeviceIdAndInode explicit, you probably end up with a > bit better behavior. > > Else the compiler happily converts a documentid to a deviceidandinode in > order to make various

D10803: handle more tags in taglibextractor

michaelh added a comment. A thumbnail extractor might be better suited for this job. On my system(tumbleweed) there is a `kde-audio-thumbnail.` I don't know anything more about it. Maybe `ffmpeg-thumbnails` can do that? REPOSITORY R286 KFileMetaData REVISION DETAIL

D10899: Don't make Headings 20% transparent, to match Kirigami

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY We recently removed Kirigami Headings' slight transparency,

D10694: epubextractor: Handle multiple subjects better

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. In D10694#214996 , @michaelh wrote: > In D10694#213712 , @mgallien wrote: > > >

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/75/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 27 Feb 2018 19:13:21 + Build duration: 8 min 49 sec and counting

D10902: Don't make Titles 20% transparent either

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10902: Don't make Titles 20% transparent either

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10899: Don't make Headings 20% transparent, to match Kirigami

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10899 To: ngraham, #plasma Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 51 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/51/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Feb 2018 19:13:21 + Build duration: 4 min 48 sec and counting

D10902: Don't make Titles 20% transparent either

ngraham created this revision. ngraham added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY If it didn't make sense to have Headings be 20% opaque

D10899: Don't make Headings 20% transparent, to match Kirigami

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10899 To: ngraham, #plasma Cc: #frameworks, michaelh

D10899: Don't make Headings 20% transparent, to match Kirigami

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH opaque-headers (branched from master) REVISION DETAIL https://phabricator.kde.org/D10899 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10902: Don't make Titles 20% transparent either

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10902: Don't make Titles 20% transparent either

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10899: Don't make Headings 20% transparent, to match Kirigami

ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10899 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D10902: Don't make Titles 20% transparent either

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/78/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 27 Feb 2018 19:13:21 + Build duration: 30 min and counting JUnit

D10803: handle more tags in taglibextractor

mgallien added a comment. In D10803#214655 , @astippich wrote: > In D10803#213783 , @michaelh wrote: > > > In D10803#213767 , @astippich wrote: > > >

D10902: Don't make Titles 20% transparent either

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10902 To: ngraham, #plasma, mart Cc: #frameworks, michaelh

D8532: [WIP] Restrict file extractor with Seccomp

ossi added a comment. > But i'm not sure if thats feasible. launching subprocesses is no biggie; e.g., the kprocess test does it. if you're lucky, a few env variables will be sufficient. in the worst case, you'd need to chroot and do bind mounts or something like that, which is of

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dfaure added a comment. "the destination file gets deleted only if some data has been written into it" ... ah I see, that's a great solution indeed, I like it. About moving: if the file was fully copied, (but the source not yet deleted), good catch. This requires a similar solution in

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

elvisangelaccio added a comment. @dmitrio: you can click on the "Plan Changes" action, no need to abandon this revision and create a new one. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure Cc: elvisangelaccio, ngraham,

D10824: Delete IdleSlave having temporary authorization

lbeltrame added a reviewer: Frameworks. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr, dfaure, #frameworks Cc: #frameworks, michaelh

D10273: Create proper SocketAddress

lbeltrame added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks, dfaure Cc: ossi, thiago, dfaure, michaelh

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. In D10694#213712 , @mgallien wrote: > To me, it is necessary to have a test that ensures that possible existing clients are not affected by your change. Could you add it ? The new behaviour will break clients.

D10857: Change qSort to std::sort in simplifiedUrlList

apol added a comment. I'd say the bottom line is qSort is deprecated in favor of std::sort. @jtamate make sure you are profiling release builds. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10857 To: jtamate, #frameworks, dfaure Cc: markg, apol, michaelh

D10857: Change qSort to std::sort in simplifiedUrlList

markg added a comment. In D10857#214867 , @jtamate wrote: > In D10857#214607 , @dfaure wrote: > > > I'm not opposed to the idea, but measuring CPU usage is a rather misleading indicator. What if it

D10719: Highlighting for OpenSCAD

julianstirling updated this revision to Diff 28190. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10719?vs=27770=28190 REVISION DETAIL https://phabricator.kde.org/D10719 AFFECTED FILES autotests/input/highlight.scad

D10719: Highlighting for OpenSCAD

julianstirling added a comment. `git diff HEAD^^ HEAD > ../PatchCombined.patch` has hopefully done the trick. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10719 To: julianstirling, dhaumann Cc: dhaumann, ngraham, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/76/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 27 Feb 2018 22:26:18 + Build duration: 7 min 22 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/79/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 27 Feb 2018 22:26:18 + Build duration: 7 min 4 sec and counting JUnit

D10803: handle more tags in taglibextractor

michaelh added a comment. In D10803#215270 , @mgallien wrote: > This is not necessary. You could use a QImage or a QPixmap. You can put them in a QVariant and they should be converted to an empty QString. Please consider writing a plugin

D10903: Preserve fragment when redirecting from http to https

guoci created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. guoci requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10903 AFFECTED FILES src/ioslaves/http/http.cpp

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/52/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 27 Feb 2018 22:26:17 + Build duration: 4 min 55 sec and counting

D8532: [WIP] Restrict file extractor with Seccomp

michaelh added a project: Baloo. michaelh added a subscriber: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8532 To: davidk, apol, ossi Cc: #baloo, detlefe, ngraham, nicolasfella, #frameworks, ashaposhnikov, michaelh, spoorun, alexeymin

D8532: [WIP] Restrict file extractor with Seccomp

michaelh added a comment. I don't know Seccomp. But as far as I understood this, the same concers apply to the `baloo_file_temp_extractor` baloo-widgets is using. Naivly I suggest to implement this KFileMetadata because both executables are using it. I don't know if that is possible or

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. achauvel requested review of this revision. REVISION SUMMARY It seems to be quite popular since it got more than 1000 downloads on kde.store.org in a week,

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

ngraham added a comment. FWIW, Breeze shadows can now be turned off entirely (System Settings > Application Style > Window Decorations > Breeze > Click on the little Settings button in the corner > Shadows > Size: None), so the only thing this really adds is opaque backgrounds. Not sure