D10081: Don't assert if used incorrectly from dbus

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R268:7d272782a55e: Dont assert if used incorrectly from dbus (authored by graesslin). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10081?vs=26098=28562 REVISION

D10235: [server] Add support for the frame semantics of Pointer version 5

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R127:b6bd28ab0492: [server] Add support for the frame semantics of Pointer version 5 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10235?vs=26336=28563#toc REPOSITORY

D10993: Fix protocol selection in KUrlNavigator

2018-03-04 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > aleksejshilin wrote in kurlnavigator.cpp:349 > > Is this in order to get smb:// instead of smb: ? > > Yes. > > > It looks correct, but not for "file", > > Why not? If I read RFC 8089 correctly, for host rule it references RFC 3986 > which

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox added a comment. I can confirm that this patch does fix the build on musl. Thank you! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/5/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 04 Mar 2018 08:46:27 + Build duration: 16 min and counting

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. In D11011#217980 , @awilcox wrote: > I can confirm that this patch does fix the build on musl. Thank you! I will push this after David's review. I hope it's not a problem? REPOSITORY R241 KIO BRANCH master

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 34 - Fixed!

2018-03-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Mar 2018 08:49:09 + Build duration: 11 min and counting JUnit Tests Name:

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread A . Wilcox
awilcox added a comment. That's fine with me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks, michaelh

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 5 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Mar 2018 08:49:10 + Build duration: 15 min and counting JUnit Tests Name:

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > sharefd_p.h:85 > +msg.msg_iovlen = 1; > +msg.msg_control = _buf; > +msg.msg_controllen = sizeof cmsg_buf; Looks good, it's just a bit inconsistent that iov_base points to io_buf (without &) and msg_control points to _buf

D11013: Remove trailing data in the protocol parameter in findProtocol

2018-03-04 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The paramter can receive things like: - smb:/// - zip:/home/user/Download/.../Encoder.php

D10989: Check for nullptr in indexForNode

2018-03-04 Thread Jaime Torres Amate
jtamate added a dependency: D11013: Remove trailing data in the protocol parameter in findProtocol. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10989 To: jtamate, #frameworks, dfaure Cc: michaelh

D11013: Remove trailing data in the protocol parameter in findProtocol

2018-03-04 Thread Jaime Torres Amate
jtamate added a dependent revision: D10989: Check for nullptr in indexForNode. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11013 To: jtamate, #frameworks, dfaure Cc: michaelh

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 08:49:09 + Build duration: 57 min and counting JUnit Tests

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

2018-03-04 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > chinmoyr wrote in slavebase.cpp:147 > Now I feel stupid for doing this. Apart from that I am not even confident > about this change because it involves changes in KAuth (Obviously I am not > sure about them either). How about we drop this and the

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 29 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 11:21:34 + Build duration: 5 min 37 sec and counting

D11013: Remove trailing data in the protocol parameter in findProtocol

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. It's called protocol, it's supposed to be just the protocol. The bug is in the caller. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11013 To: jtamate,

D11010: Add MSG_SLAVE_STATUS_V2 to slave interface

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11010 To: chinmoyr, dfaure Cc: #frameworks, michaelh

D10993: Fix protocol selection in KUrlNavigator

2018-03-04 Thread Алексей Шилин
aleksejshilin added inline comments. INLINE COMMENTS > dfaure wrote in kurlnavigator.cpp:349 > Well, OK, it's not that it's *incorrect* for file:, it just seems unnecessary > to make that method call. So given that we have an if() already, why not only > do it in the else? > Well, OK, it's

D10993: Fix protocol selection in KUrlNavigator

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix_kurlnavigator_protocol_selection REVISION DETAIL https://phabricator.kde.org/D10993 To: aleksejshilin, #frameworks, dfaure Cc: michaelh

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 28573. chinmoyr added a comment. used & REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11011?vs=28551=28573 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 AFFECTED FILES

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in slavebase.cpp:147 > That looks like horrible API ;) > A getter that optionally makes changes, based on a boolean... urgh ;) > > "Duplicating" a for loop isn't really duplication, go for a different method. Now I feel stupid for

D10927: Apply fixes to simple clazy warnings

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH clazyfixes REVISION DETAIL https://phabricator.kde.org/D10927 To: fabiank, dfaure Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 136 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/136/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 10:41:18 + Build duration: 11 min and counting JUnit Tests Name:

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in klauncher.cpp:1114 > This deletes the Slave C++ class, but it doesn't actually kill the ioslave. > So why do it? > > I'm confused now. Do you want to kill the ioslave (then call slave->kill()) > or do you want to reuse that

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:62 > any particular reason not to use QFile::remove() here as well? I didn't want to include QFile. That's the only reason. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:62 > uhm, you're still using it in this very line, just differently ;) *head-desk* I think I have to get my eyes checked. I will change it right away. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread David Faure
dfaure added a comment. No, that deletes the IdleSlave QObject, but the slave process is still running then. IdleSlave::~IdleSlave() { } Not much happening there ;) Yes, that makes me wondering if the SLAVE_MAX_IDLE thing actually works. Hmm, and

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-03-04 Thread David Faure
dfaure added a comment. Can someone explain to me how switching from pointers to values is making anything faster, or is a first step towards making anything faster? This step in itself can only make things slower due to more "copying" (refcount updating). REPOSITORY R241 KIO REVISION

D10273: Create proper SocketAddress

2018-03-04 Thread Oswald Buddenhagen
ossi added inline comments. INLINE COMMENTS > dfaure wrote in fdsender.cpp:24 > In that case I don't understand why SocketAddress takes a QByteArray and not > a std::string Because ossi suggested it to unify the API and avoid one > conversion to std::string in fdereceiver? But then we have

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. @ossi I think the changes in file_unix.cpp from D9966 also belong here(?) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

D10822: Store temporary authorization status in IdleSlave

2018-03-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks (I just realized we need a similar comment next to the enum value MSG_SLAVE_STATUS though) REPOSITORY R241 KIO BRANCH D10822 REVISION DETAIL

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-03-04 Thread Mark Gaiser
markg added a comment. In D10742#218171 , @dfaure wrote: > Can someone explain to me how switching from pointers to values is making anything faster, or is a first step towards making anything faster? This step in itself can only make things

D10993: Fix protocol selection in KUrlNavigator

2018-03-04 Thread Алексей Шилин
aleksejshilin updated this revision to Diff 28571. aleksejshilin added a comment. - Move setting authority to the else branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10993?vs=28519=28571 BRANCH fix_kurlnavigator_protocol_selection REVISION DETAIL

D10411: Create socket file in user's runtime directory

2018-03-04 Thread David Faure
dfaure added a comment. That doesn't look like an atomic commit. In this commit, "path" changes from relative to absolute, but the caller hasn't been updated to actually send an absolute path? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr,

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: michaelh

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH D10567 REVISION DETAIL https://phabricator.kde.org/D10567 To: chinmoyr, dfaure Cc: fvogt, #frameworks, michaelh

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:147 > > -bool hasTempAuth() > +bool hasTempAuth(bool revoke = false) > { That looks like horrible API ;) A getter that

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > klauncher.cpp:1114 > +mSlaveList.removeAll(slave); > +slave->deleteLater(); > +} This deletes the Slave C++ class, but it doesn't

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 8 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/8/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Mar 2018 10:57:18 + Build duration: 17 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 - Build # 8 - Fixed!

2018-03-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20WindowsMSVCQt5.10/8/ Project: Frameworks breeze-icons kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 04 Mar 2018 11:06:39 + Build duration: 8 min 36 sec and counting

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-03-04 Thread Oswald Buddenhagen
ossi added inline comments. INLINE COMMENTS > fdreceiver.cpp:62 > } > +::unlink(QFile::encodeName(m_path)); > } any particular reason not to use QFile::remove() here as well? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr,

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread Oswald Buddenhagen
ossi added a comment. that contradicts the comments i added to both reviews. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

D10822: Store temporary authorization status in IdleSlave

2018-03-04 Thread David Faure
dfaure added a comment. Thanks. Can you just add one comment, for the future? INLINE COMMENTS > idleslave.cpp:91 > +} > +} else { > +if (!stream.atEnd()) { // compat code for KF < 5.45. TODO KF6: remove REPOSITORY R241 KIO REVISION DETAIL

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. Sorry, I meant D10411 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 10 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/10/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 04 Mar 2018 10:41:18 + Build duration: 1 hr 51 min and counting JUnit Tests

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. Actually deleteLater() does kill the slave. I placed a qDebug statement in there and immediately after the message I am getting kdeinit5: PID $slave_pid terminated. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D10824 To: chinmoyr,

D10822: Store temporary authorization status in IdleSlave

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > idleslave.cpp:70 > deleteLater(); > -} else if (cmd != MSG_SLAVE_STATUS) { > +} else if (cmd != MSG_SLAVE_STATUS_V2) { > qCritical()

D10993: Fix protocol selection in KUrlNavigator

2018-03-04 Thread Алексей Шилин
This revision was automatically updated to reflect the committed changes. Closed by commit R241:37868c2c57f7: Fix protocol selection in KUrlNavigator (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10993?vs=28571=28574 REVISION DETAIL

D10437: Update file ioslave's temporary authorization list

2018-03-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. (Reusing the same phab request is fine in this case, because there were no review comments yet. Once there are, and they don't apply to a completely redesigned commit, then indeed better

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes. Closed by commit R241:2a2a8a0fe5ab: Do not assume layout of msghdr and iovec structure (authored by chinmoyr). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11011?vs=28573=28576 REVISION

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 156 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/156/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Mar 2018 10:41:18 + Build duration: 16 min and counting JUnit Tests Name: (root)

D10312: FileUndoManager: don't delete non-existing local files

2018-03-04 Thread David Faure
dfaure added a comment. Looks good, just minor issues left. INLINE COMMENTS > fileundomanagertest.cpp:735 > +FileUndoManager::self()->recordCopyJob(copyJob); > +const bool ok = copyJob->exec(); > +QVERIFY(ok); This isn't Q_ASSERT, it's ok to perform the operation

D10543: fix crashing with duplicate entries

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D10543 To: sandsmark, dfaure, #frameworks Cc: apol, michaelh

D11019: Remove left-over code from kdelibs splitting time

2018-03-04 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. TEST PLAN Building/installing kinit still works, projects using

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. Neither SlaveBase::exit nor Slave::kill is called. I also commented the line in ConnectionBackend which removes the socket file but even then the slave process terminated. At this point I have no idea why is this working. REPOSITORY R303 KInit REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 11 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/11/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 04 Mar 2018 12:33:16 + Build duration: 1 hr 19 min and counting JUnit Tests

D11019: Remove left-over code from kdelibs splitting time

2018-03-04 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH removekdelibssplitcode REVISION DETAIL https://phabricator.kde.org/D11019 To: kossebau, dfaure Cc: #frameworks, michaelh

D11019: Remove left-over code from kdelibs splitting time

2018-03-04 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R303:3bcf7a1b3421: Remove left-over code from kdelibs splitting time (authored by kossebau). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11019?vs=28595=28599 REVISION

D10820: Send slave's polkit authorization status to the host

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slavebase.cpp:150 > +#ifdef Q_OS_UNIX > +QSet::const_iterator it = m_tempAuths.begin(); > +while (it != m_tempAuths.end()) { This can't be a

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread David Faure
dfaure added a comment. Can you explain a bit more in the commit log why this is better? I guess it comes from a discussion elsewhere, but better have the info here and in git in the end. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr, #frameworks,

D10568: Handle privilege operation confirmation prompts in SlaveBase

2018-03-04 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Just minor requests INLINE COMMENTS > slavebase.cpp:127 > +QString m_warningMessage; > +bool m_confirmationAsked; > int m_privilegeOperationStatus; move next to the

D10818: Store PolicyKit action which the slave is authorized to perform

2018-03-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks ok, but this commit is a bit too small ;) It would make more sense to integrate this with the code that's calling addTemporaryAuthorization, so we can see how that all works.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Mar 2018 10:41:18 + Build duration: 8 min 19 sec and counting JUnit Tests Name: (root)

D11011: Do not assume layout of msghdr and iovec structure

2018-03-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Thanks, this is good to go in. In fact I'll put it in 5.44 since it fixes a compilation error. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11011 To: chinmoyr, dfaure, awilcox Cc: #frameworks,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 157 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/157/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Mar 2018 10:57:52 + Build duration: 6 min 52 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 137 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/137/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 10:57:18 + Build duration: 7 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 04 Mar 2018 11:12:59 + Build duration: 9 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 7 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sun, 04 Mar 2018 11:12:59 + Build duration: 8 min 56 sec and counting JUnit Tests Name:

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

2018-03-04 Thread Oswald Buddenhagen
ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:62 > I didn't want to include QFile. That's the only reason. uhm, you're still using it in this very line, just differently ;) REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D9966: [KIO] Fix issues with sharing of file descriptor

2018-03-04 Thread Oswald Buddenhagen
ossi added a comment. looks good, though technically speaking this still fixes two separate issues. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10822: Store temporary authorization status in IdleSlave

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 28577. chinmoyr added a comment. Added support for MSG_SLAVE_STATUS REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10822?vs=28543=28577 BRANCH D10822 REVISION DETAIL https://phabricator.kde.org/D10822 AFFECTED

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread Oswald Buddenhagen
ossi added a comment. the idea is that you can do directory-based access controls on file-based sockets, while the abstract namespace has no controls. otoh, only linux has the abstract namespace, and it supports peer credential verification as well, so this doesn't actually add any

D10822: Store temporary authorization status in IdleSlave

2018-03-04 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 28581. chinmoyr added a comment. added the required comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10822?vs=28577=28581 BRANCH D10822 REVISION DETAIL https://phabricator.kde.org/D10822 AFFECTED FILES

D10409: In linux don't use abstract socket to share file descriptor

2018-03-04 Thread Oswald Buddenhagen
ossi added a comment. not sure why; the changes are semantically separate. my suggestion was to put this before D10273 , thus reducing the latter's size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10409 To: chinmoyr,

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread David Faure
dfaure added a comment. Interesting. But are you sure that neither Slave::kill() nor SlaveBase::exit() is called? It can't just be the deleteLater that does this, unless I'm missing something (e.g. closing the pipe makes the slave die with SIGPIPE maybe) REPOSITORY R303 KInit REVISION

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 30 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/30/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 04 Mar 2018 17:33:12 + Build duration: 6 min 22 sec and counting

D10446: Add KLanguageName

2018-03-04 Thread Albert Astals Cid
aacid added a comment. ping? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10446 To: aacid Cc: #frameworks, michaelh

D8964: Fix two bugs in KMessageWidget

2018-03-04 Thread Albert Astals Cid
aacid planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks Cc: ngraham, dhaumann, anthonyfieroni, #frameworks, michaelh

D10168: Use nullptr for passing a null pointer to crc32

2018-03-04 Thread Albert Astals Cid
aacid added a comment. ping? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D10168 To: aacid Cc: #frameworks, michaelh

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

2018-03-04 Thread Albert Astals Cid
aacid planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10166 To: aacid Cc: cgiboudeaux, dhaumann, #frameworks, #build_system, michaelh

D10824: Delete IdleSlave having temporary authorization

2018-03-04 Thread David Faure
dfaure added a comment. I tested what happens in the current code when an idle job is killed. My testcase was configuring to use KIO in componentchooser ("open http urls in an application based on the contents on the URL") and then `kioclient5 exec www.kde.org`. This puts the slave on hold

D10927: Apply fixes to simple clazy warnings

2018-03-04 Thread Fabian Kosmale
This revision was automatically updated to reflect the committed changes. Closed by commit R284:29e7a1d89278: Apply fixes to simple clazy warnings (authored by fabiank). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10927?vs=28288=28597 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 12 - Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/12/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 04 Mar 2018 20:02:04 + Build duration: 1 hr 32 min and counting JUnit Tests

D9973: ktooltipwidget: Fix tooltip positioning

2018-03-04 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > elvisangelaccio wrote in ktooltippositiontest.cpp:71 > Weird, I usually use `qPrintable()` for this, but > > QTest::addRow(qPrintable(QStringLiteral("small/%1").arg(i.key( > > still gives me the compiler warning. Not sure what is going on

Re: Fallback Icon Theme

2018-03-04 Thread Martin Kostolný
Thanks, Albert, for your answer and point of view! We actually need the icons since quite a lot of them is misisng and Krusader looks (e.g. with Adwaita) quite unfinished with default configuration. We also get bug reports about missing icons. From your opinions and opinions I've already heard

D9973: ktooltipwidget: Fix tooltip positioning

2018-03-04 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ktooltippositiontest.cpp:39-52 > +void KTooltipPositionTest::init() > +{ > +m_container = new QWidget(); > +m_target = new

Re: Global Dependency and Release Freeze

2018-03-04 Thread Ben Cooksley
Hi all, We've now finished catching up on everything and getting the CI system settled down again so we're now able to lift the freeze. I'll start sorting out the releases which have been requested shortly. There is still some lingering breakage impacting Akonadi and KIO however those can be

D4911: add Baloo DBus signals for moved or removed files

2018-03-04 Thread Matthieu Gallien
mgallien added a comment. In D4911#199527 , @cullmann wrote: > @cullmann: T7860 lists some of my observations wrt samba shares. I don't know NFS, can you enlighten me regarding deviceids and inodes on NFS? >

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 158 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/158/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 05 Mar 2018 04:15:12 + Build duration: 33 min and counting JUnit Tests Name: (root)

D11037: balooctl: checkDb should also verify the last known url for the documentId.

2018-03-04 Thread James Smith
smithjd created this revision. smithjd added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REVISION SUMMARY Report orphan documentId's. REPOSITORY R293 Baloo

D10446: Add KLanguageName

2018-03-04 Thread Aleix Pol Gonzalez
apol added a comment. Makes sense to me anyway. Is there any other code that could use this API? INLINE COMMENTS > klanguagename.cpp:45 > + > +return QString(); > +} shouldn't this be equivalent to nameForCodeInLocale(code, QLocale().code())? > klanguagename.cpp:65 > +

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-04 Thread James Smith
smithjd created this revision. smithjd added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-purgeDb (branched from master) REVISION DETAIL

D10997: Fix conversion of AccessPoint flags to capabilities

2018-03-04 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D10997 To: fvogt, #frameworks, jgrulich, kfunk Cc: #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 13 - Still Failing!

2018-03-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/13/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 05 Mar 2018 04:15:12 + Build duration: 6 min 11 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 138 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/138/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 05 Mar 2018 04:15:12 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

2018-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 05 Mar 2018 04:15:12 + Build duration: 16 min and counting JUnit Tests Name: (root)