D10807: fileindexerconfig: Exclude Vaults by default

michaelh abandoned this revision. michaelh added a comment. Too naive approach REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, michaelh,

D10292: change 32px icons for playlist shuffle and repeat

ngraham accepted this revision. ngraham added a comment. Agreed. They look great to me! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: andreask, ngraham, #frameworks, michaelh

D10776: Make it possible to generate po files in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit R249:5a70e96795f1: Make it possible to generate po files in parallel (authored by apol). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=29024=29113 REVISION

D11181: Resolve symlinks in QML import paths

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11181 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

D10807: fileindexerconfig: Exclude Vaults by default

rkflx added a comment. Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham, #plasma Cc: rkflx, alexeymin,

D10810: fileindexerconfigtest: Add vault test

michaelh abandoned this revision. michaelh added a comment. see D10807 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10810 To: michaelh, #baloo, #frameworks, ngraham Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11190: Make sure we are taking into account hte size of the element when styling

apol created this revision. apol added reviewers: Frameworks, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D11189 REPOSITORY R858 Qt

D9829: Don't create 2 msgbox (one of them crashes) when can't change rights

jtamate abandoned this revision. jtamate added a comment. With the changes in https://phabricator.kde.org/D10376 this patch is not needed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9829 To: jtamate, #frameworks, anthonyfieroni, dfaure Cc: ngraham, michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

jtamate abandoned this revision. jtamate added a comment. With the changes in https://phabricator.kde.org/D10376 this patch is not needed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9862 To: jtamate, #frameworks, dfaure Cc: michaelh

D11193: Sonnet : use current hunspell API

rjvbb created this revision. rjvbb added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY The hunspell backend uses three deprecated hunspell API functions; this patch fixes that. TEST PLAN Works as

D10292: change 32px icons for playlist shuffle and repeat

ngraham added a comment. Agreed. Can you post screenshots of all the icons? I'll evaluate. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask Cc: andreask, ngraham, #frameworks, michaelh

D10292: change 32px icons for playlist shuffle and repeat

astippich added a comment. after D11049 where the frames for the media buttons were removed I think this is quite needed for a consistent look and feel. I also added 32px version for no repeat and no shuffle which I need for a toggle button for #elisa

D10803: handle more tags in taglibextractor

michaelh added a comment. In D10694#222086 , @astippich wrote: > Also, since this discussion also applies for the taglibextractor: Is a string list preferred for new properties in KFileMetadata when multiple entries are possible? I think right

D10292: change 32px icons for playlist shuffle and repeat

astippich updated this revision to Diff 29110. astippich added a comment. - add more 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=26512=29110 BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292

D11038: balooctl: Add prune option to remove stale file index entries

michaelh added a comment. It's crashing for me. Here's the backtrace: Thread 1 "balooctl" received signal SIGSEGV, Segmentation fault. 0x7770ccbe in Baloo::WriteTransaction::removeDocument (this=0x0, id=4294969360) at

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/92/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 01:18:56 + Build duration: 13 min and counting JUnit

D10807: fileindexerconfig: Exclude Vaults by default

michaelh added a comment. In D10807#222173 , @rkflx wrote: > Did you already look at which approach Tracker uses regarding filesystems? Are they just indexing everything? Nope, good you reminded me. Made a note for myself T8066

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 01:22:11 + Build duration: 33 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/18/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 01:18:06 + Build duration: 2 min 39 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 01:18:06 + Build duration: 3 min 32 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 16 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/16/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 01:22:11 + Build duration: 2 hr 13 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 164 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/164/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 01:22:11 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/67/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 01:18:56 + Build duration: 5 min 37 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 144 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/144/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 01:22:11 + Build duration: 15 min and counting JUnit Tests Name:

D11172: Explicitly set content type to form data

leinir added a comment. In D11172#221854 , @apol wrote: > Which warning? How does changing to "application/x-www-form-urlencoded" help? Sorry, i forgot to add it in the description. Specifically, this warning: content-type missing in

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux edited the test plan for this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh

D11173: Actually vote when clicking stars in the list view

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D11173 To: leinir, #knewstuff, #frameworks, sitter, apol Cc: michaelh, ZrenBot

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a comment. Disclaimer: I'm not really happy with this solution. The alternative is to call find_program(KI18N_PYTHON_EXECUTABLE) with a list of known names (python3.7 python3.6 python2.7 ...) and remove the find_package(PythonInterp) line. REPOSITORY R249 KI18n

D11172: Explicitly set content type to form data

apol added a comment. Which warning? How does changing to "application/x-www-form-urlencoded" help? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D11172 To: leinir, #frameworks Cc: apol, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. cgiboudeaux requested review of this revision. REVISION SUMMARY Due to CMake caching the variables, anything depending on ki18n would be unable to call

D11172: Explicitly set content type to form data

This revision was automatically updated to reflect the committed changes. Closed by commit R235:dfdbf55a4cda: Explicitly set content type to form data (authored by leinir). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11172?vs=29065=29075 REVISION DETAIL

D11177: Provide QML import paths to androiddeployqt

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY This makes the qmlimportscanner find our QML

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

cgiboudeaux added a project: Build System. cgiboudeaux added a subscriber: Build System. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11176 To: cgiboudeaux Cc: #build_system, #frameworks, michaelh

D11172: Explicitly set content type to form data

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D11172 To: leinir, #frameworks, apol Cc: apol, #frameworks, michaelh

D11173: Actually vote when clicking stars in the list view

This revision was automatically updated to reflect the committed changes. Closed by commit R304:77e5c43a881c: Actually vote when clicking stars in the list view (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11173?vs=29066=29076

D11172: Explicitly set content type to form data

leinir added a reviewer: Frameworks. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D11172 To: leinir, #frameworks Cc: #frameworks, michaelh

D11173: Actually vote when clicking stars in the list view

leinir retitled this revision from "Actually vote when clicking stars in the details view" to "Actually vote when clicking stars in the list view". leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D11173 To: leinir,

D11172: Explicitly set content type to form data

leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. leinir requested review of this revision. REVISION SUMMARY Without this patch, Attica will make a lot of noise when interacting with an OCS server, in the

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. In D10694#221719 , @michaelh wrote: > This is bad! I have learned baloo itself doesn't handle stringlists. Which in my view would be the natural way to handle token-like items like tags, keywords and subject(s). Until

D11173: Actually vote when clicking stars in the details view

leinir created this revision. leinir added reviewers: KNewStuff, Frameworks, sitter. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. leinir requested review of this revision. REVISION SUMMARY This connects up the ratings widget with the engine, using the

D11153: Use correct item URL for Create New context menu

prukgaber added a comment. Thank you for accepting. I do not have a developer account though. So somebody will have to push the patch for me please. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

broulik updated this revision to Diff 29085. broulik added a comment. - Bail out if contentsOpacity is zero, just because the device is mounted and visible doesn't mean it shows its capacity bar (only on hover it would) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KUserFeedback UUID question

Hi Volker, Have some questions. I've read Telemetry discussion in kde-community mailing list, however some KUserFeedback logic is not quite clear: https://www.mail-archive.com/kde-community@kde.org/msg03898.html You said data is submitted once per week to a server. How the user is identified

D11177: Provide QML import paths to androiddeployqt

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11177 To: vkrause, #build_system, apol Cc: #frameworks, michaelh

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin,

D11177: Provide QML import paths to androiddeployqt

This revision was automatically updated to reflect the committed changes. Closed by commit R240:553be332f2e3: Provide QML import paths to androiddeployqt (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11177?vs=29078=29090

D11181: Resolve symlinks in QML import paths

vkrause created this revision. vkrause added a reviewer: Build System. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Frameworks. vkrause requested review of this revision. REVISION SUMMARY qmlimportscanner fails when provided

D11088: [KFilePlacesView] Call KDiskFreeSpaceInfo only if neccessary

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11088 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D10694: epubextractor: Handle multiple subjects better

astippich added a comment. In D10694#221734 , @mgallien wrote: > In D10694#221719 , @michaelh wrote: > > > This is bad! I have learned baloo itself doesn't handle stringlists. Which in my view

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. In D10694#221734 , @mgallien wrote: > I believe this is quite the opposite. I am already getting strings list for some audio metadata. That would be great. Please point me to the respective code in elisa. I want

D11183: Sonnet: don't impose the default client

rjvbb created this revision. rjvbb added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY Sonnet has a hidden default client concept (hidden because the standard configuration dialog doesn't expose the

D10776: Make it possible to generate po files in parallel

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 To: apol, #frameworks, sitter Cc: michaelh