D11583: Add platform detection and adjustment to kded

2018-04-06 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right? REPOSITORY R297 KDED BRANCH platform-detection REVISION DETAIL https://phabricator.kde.org/D11583 To:

D11982: Use statbuf consistently

2018-04-06 Thread Michael Heidelbach
michaelh updated this revision to Diff 31515. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11982?vs=31474=31515 BRANCH statbuf (branched from master) REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kdiroperatordetailview.cpp:103 > QHeaderView *headerView = header(); > -headerView->setSectionResizeMode(QHeaderView::Interactive); > +headerView->setSectionResizeMode(1, QHeaderView::Stretch); >

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
michaelh added a comment. $ ctest -R advanced -V F5795958: AdvancedQueryParserTest REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich,

D11828: Simplify orPostingIterator and make it faster

2018-04-06 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > orpostingiterator.cpp:44 > { > -m_docId = 0; > -if (m_iterators.isEmpty()) { > -return 0; > +// first call > +if (m_nextId == 0) { Move this to the constructor? > orpostingiterator.cpp:47 > +for (auto it =

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey edited the summary of this revision. sharvey added reviewers: ngraham, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Kai Uwe Broulik
broulik added a comment. Thanks for updating! I think this patch makes sense (and seems to work well) but I'm not too familiar with `QTreeView`, let's wait a bit for further feedback and merge it once Frameworks 5.45 has been tagged. REPOSITORY R241 KIO REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey marked an inline comment as done. sharvey added a comment. In D11993#241387 , @ngraham wrote: > This patch is a breath of fresh air when using Detailed View or Detailed Tree View. You can resize the window and open and close the preview

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale
fabiank created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. fabiank requested review of this revision. REVISION SUMMARY Previously, KDirOperatorDetailView::setModel called resetResizing before QTreeView::setModel

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
michaelh marked 4 inline comments as done. michaelh added inline comments. INLINE COMMENTS > bruns wrote in advancedqueryparsertest.cpp:264 > Adds no information, just use QString() here (and twice below) This test fails. "no optimization" serves as a flag, that it's expected to fail and as

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. F5795938: Screenshot_20180406_145748.png Before (from user bug report) F5795942: Screenshot_20180406_145619.png After (mine) REPOSITORY R241 KIO REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. So. Much. Better. Now. This patch is a breath of fresh air when using Detailed View or Detailed Tree View. You can resize the window and open and close the preview without wanting

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
michaelh updated this revision to Diff 31519. michaelh added a comment. - Distinguish tests REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31518=31519 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
michaelh updated this revision to Diff 31512. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31428=31512 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > broulik wrote in kdiroperatordetailview.cpp:103 > For first colum you want to set it to `0`, here it blew up the "Size" column > to full width I got misled by my manual adjustment of the columns from

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey updated this revision to Diff 31517. sharvey added a comment. - Fix incorrect column index REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31516=31517 BRANCH column-widths (branched from master) REVISION DETAIL

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adjust column sizing options so that "last" column is no longer the largest. First column

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > advancedqueryparsertest.cpp:229 > +QTest::addColumn("failmessage"); > +const QString nofail; > +QString searchInput; remove >

D11982: Use statbuf consistently

2018-04-06 Thread Michael Heidelbach
michaelh marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11982 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale
fabiank added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11998 To: fabiank, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo, bruns Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11685: Implement single click on line number to select line of text

2018-04-06 Thread Randy Kron
rkron marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: rkron, mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns,

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns added a comment. Can you add the output of the failing tests here verbatim? INLINE COMMENTS > michaelh wrote in advancedqueryparsertest.cpp:264 > This test fails. "no optimization" serves as a flag, that it's expected to > fail and as message why. See lines 217-219. That's why I

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
michaelh updated this revision to Diff 31518. michaelh added a comment. - Add 'fallback' test REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11907?vs=31512=31518 BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL

D11826: Simplify Term operator&& and ||

2018-04-06 Thread Stefan Brüns
bruns added a dependent revision: D12005: Fix merging of terms in the AdvancedQueryParser. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 To: bruns, #baloo, michaelh Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun,

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The code merged compatible terms only if the left hand

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns added a dependency: D11826: Simplify Term operator&& and ||. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey marked 3 inline comments as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperatordetailview_p.h:56 > Don't leave code commented out like this; if it's not used anymore, delete it! Remnants of testing. Won't do that again. REPOSITORY R241 KIO BRANCH

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

2018-04-06 Thread Fabian Kosmale
fabiank created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. fabiank requested review of this revision. TEST PLAN Run the steps described in the testplan of D12001 . Without the

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham added a comment. Question: is `expandNameColumn()` even needed anymore with this change? REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: broulik, #frameworks, michaelh,

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham added a comment. I wasn't able to find any regressions stemming from removing that code, and once gone, I was able to hack out even more code that seemed to exist purely in support of it. Here's a diff that applies on top of this patch: https://paste.kde.org/p9z7riqdo REPOSITORY

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. Give me a moment to comment it out again and re-check. I thought it was, but let me run another test. REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: broulik,

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. I'm not familiar with the issue but the patch makes 100% sense. REPOSITORY R241 KIO BRANCH fixConnectWarning REVISION DETAIL https://phabricator.kde.org/D11998 To: fabiank, dfaure, ngraham, apol Cc: apol, ngraham, #frameworks,

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey updated this revision to Diff 31545. sharvey added a comment. - Remove leftover commented-out code; restore variable declaration REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31540=31545 BRANCH arcpatch-D11993 REVISION DETAIL

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Ok, this is ready now. Thanks! REPOSITORY R293 Baloo BRANCH advancedqueryparsertest (branched from master) REVISION DETAIL https://phabricator.kde.org/D11907 To: michaelh, #baloo,

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham added a comment. And while we're digging into this code, it would be quite nice to set `QHeaderView::ResizeToContents` for the other two columns so they always display the correct width and never have to be resized. That even fits under the umbrella of the patch's title "tweak

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. In the works... REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey updated this revision to Diff 31540. sharvey added a comment. - Remove unneeded resize code; ensure other columns fill to contents REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11993?vs=31517=31540 BRANCH arcpatch-D11993 REVISION DETAIL

D11826: Simplify Term operator&& and ||

2018-04-06 Thread Stefan Brüns
bruns updated this revision to Diff 31541. bruns edited the test plan for this revision. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11826?vs=31160=31541 BRANCH baloo_term_cleanup REVISION DETAIL https://phabricator.kde.org/D11826 AFFECTED FILES

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Fabian Kosmale
fabiank added a comment. I'm to tired to test this myself, but could you please test this with the edge case where some file names are so long that they don't fit in the view? Also, Stretch disables manual resizing, right?' If that is also deemed useful, we could adapt the solution from

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham added a comment. Got a few code niggles, detailed below. Function-wise, this is a vast usability improvement. And in case you have a really excessively long file name, you can just use Tree view (the non-details version), which only has one column. INLINE COMMENTS >

D12006: Make list of subterms in debug output easier to spot

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY '(' was used for both delimiting Terms and list of

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Christoph Feck
cfeck added a comment. I vaguely remember there was some code to delay resizing of the columns until all items were loaded for performance reasons. Please check the commit history before deleting code. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Confirmed that this fixes the issue, and it makes sense, code-wise. I did not see any resizing-related regressions. REPOSITORY R241 KIO BRANCH fixConnectWarning REVISION DETAIL

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

2018-04-06 Thread Fabian Kosmale
fabiank added reviewers: mart, dfaure, mlaurent. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D12002 To: fabiank, mart, dfaure, mlaurent Cc: #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. All seems to be well with the removal of the extraneous resizing code. Here's the result of a test with a ridiculously long filename: F5796698: Screenshot_20180406_195204.png I think that looks perfectly reasonable.

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. Also, yes - Stretch has disabled the ability to manually resize the columns. Columns 1 & 2 are set to fit the size of their contents, while column 0 fills all the remaining space. Resizing the dialog results in only the Name column (column 0) to change size; the

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D11993 REVISION DETAIL https://phabricator.kde.org/D11993 To: sharvey, ngraham, dfaure Cc: fabiank, broulik, #frameworks, michaelh, ngraham, bruns

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Scott Harvey
sharvey added a comment. I'll give that a test. I'm sure I can find a file (or make one up) with an absurdly long filename. Once I figure out why @ngraham's uploaded diff won't apply... grr. REPOSITORY R241 KIO BRANCH column-widths (branched from master) REVISION DETAIL

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12005 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 58 - Fixed!

2018-04-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/58/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 07 Apr 2018 05:30:35 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!

2018-04-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sat, 07 Apr 2018 05:30:35 + Build duration: 10 min and counting JUnit Tests Name: (root)

D11826: Simplify Term operator&& and ||

2018-04-06 Thread Michael Heidelbach
michaelh added a comment. Couldn't test. This has to rebased first. It doesn't really matter as I had tested this before. Just land it. Wrt "Test Plan": Most people just write 'make test' otherwise the commit message will be very long. REPOSITORY R293 Baloo BRANCH baloo_term_cleanup

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Nathaniel Graham
ngraham added a comment. In D11993#241607 , @cfeck wrote: > I vaguely remember there was some code to delay resizing of the columns until all items were loaded for performance reasons. Please check the commit history before deleting code.

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Parsing of e.g. "a OR ((b AND c) AND d)" currently

D11907: advancedqueryparsertest: Add more tests

2018-04-06 Thread Michael Heidelbach
This revision was automatically updated to reflect the committed changes. michaelh marked 3 inline comments as done. Closed by commit R293:1ea0b94497c3: advancedqueryparsertest: Add more tests (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Stefan Brüns
bruns added a dependent revision: D11888: Handle adjacent special characters correctly. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns updated this revision to Diff 31550. bruns added a comment. token.size() > 0 -> !token.isEmpty() renamed tokens to tokenList Use testcase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11888?vs=31161=31550 BRANCH

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns marked 6 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns added a dependency: D12007: Add test case for parsing of double opening '(('. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Michael Heidelbach
michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12007: Add test case for parsing of double opening '(('

2018-04-06 Thread Michael Heidelbach
michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

2018-04-06 Thread Stefan Brüns
bruns edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11583: Add platform detection and adjustment to kded

2018-04-06 Thread Martin Flöser
graesslin added a comment. In D11583#241314 , @apol wrote: > I wonder if all this code should be ifdef'd for Qt 5.10 though. The premise is that this won't be a problem with Qt 5.11, right? Let's wait for it to happen, then we can still

D11583: Add platform detection and adjustment to kded

2018-04-06 Thread Martin Flöser
graesslin added a comment. Btw could someone please push for me. I'm not around the next two weeks REPOSITORY R297 KDED BRANCH platform-detection REVISION DETAIL https://phabricator.kde.org/D11583 To: graesslin, #frameworks, #plasma, apol, romangg Cc: michaelh, ngraham, bruns

D12005: Fix merging of terms in the AdvancedQueryParser

2018-04-06 Thread Michael Heidelbach
michaelh added a comment. lgtm. Please rebase (preferrably after landing D11826 ), so I can run the test. Cherry Pick Failed! Exception Command failed with error #1! COMMAND git cherry-pick 'arcpatch-D11907' REPOSITORY R293

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

2018-04-06 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Build System, Frameworks. Restricted Application added projects: Frameworks, Build System. apol requested review of this revision. REVISION SUMMARY Mark as deprecated the redundant variables and focus on the difference. REPOSITORY R240 Extra

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 29 - Fixed!

2018-04-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 11:21:50 + Build duration: 7 min 7 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 10 - Fixed!

2018-04-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Apr 2018 11:21:50 + Build duration: 5 min 57 sec and counting JUnit Tests Name:

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 19 - Fixed!

2018-04-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 11:21:50 + Build duration: 2 min 34 sec and counting JUnit Tests

D11982: Use statbuf consistently

2018-04-06 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Baloo, bruns. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R293 Baloo BRANCH statbuf

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

2018-04-06 Thread Kai Uwe Broulik
broulik added a comment. There's still something borked with it. It works once for a new file but when I undo, delete and undo again it breaks or sometimes still doesn't work at all. :( REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11987 To: broulik, #frameworks,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/57/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Apr 2018 15:29:45 + Build duration: 8 min 20 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 208 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/208/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 15:29:45 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 207 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/207/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 06 Apr 2018 14:38:25 + Build duration: 14 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 187 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/187/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 15:29:45 + Build duration: 9 min 27 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/56/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 06 Apr 2018 14:38:25 + Build duration: 16 min and counting JUnit Tests Name: (root)

D11987: [CopyJob] Pass resolved URL to finalDestUrl so looking up trash filename works

2018-04-06 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY In case of `desktop:/` KIO which rewrites URLs, looking up the URL the trashed file got didn't work.

D11984: Android: Explicitly point at upstream documentation and deprecate duplicated concepts

2018-04-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 31491. apol added a comment. Typo REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11984?vs=31482=31491 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11984 AFFECTED FILES

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 186 - Still Unstable!

2018-04-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/186/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 14:38:25 + Build duration: 11 min and counting JUnit Tests Name:

D11685: Implement single click on line number to select line of text

2018-04-06 Thread Randy Kron
rkron updated this revision to Diff 31505. rkron added a comment. - Revise patch per review comments. Added comments and removed code to fix view scrolling inconsistancy when dragging over line numbers. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D11685: Implement single click on line number to select line of text

2018-04-06 Thread Randy Kron
rkron edited the summary of this revision. rkron edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate,

D11982: Use statbuf consistently

2018-04-06 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > basicindexingjob.cpp:54 > QT_STATBUF statBuf; > -if (QT_LSTAT(url.data(), ) != 0) { > +if (filePathToStat(url.constData(), statBuf) != 0) { > return false; Unneeded conversion, filePathToStat takes QByteArray >