D12271: Don't remove trailing whitespace from cursor line

sraizada added a comment. Would it be appropriate to add this as a config option in the settings? Because to me, keeping the sort of whitespace you describe seems like the better behavior: doSomething(a, b, | ^ is correct. But obviously there are differing opinions on this, and a

D12228: kdirlister new connect syntax

jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12228 To: jtamate, dfaure, #frameworks Cc: michaelh, ngraham, bruns

D12269: Don't install plugins within lib on android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D12269 To: apol, vkrause Cc: #frameworks, #build_system, michaelh, ngraham, bruns

D10494: update handle- icons for kirigami

andreaska added a comment. In D10494#220993 , @mart wrote: > As discussed on the channel, the icon should be one of these forms, for me are both ok > F5744901: handle-right.png I am for this

D12271: Don't remove trailing whitespace from cursor line

sraizada added a comment. Forgot to put this in the first submission: it fails test 66 vimode_keys, I believe this may be related to bug 392858 - vi mode :q (quit) command works in Kate but not KWrite https://bugs.kde.org/show_bug.cgi?id=392858 Every other test passes. REPOSITORY R39

D12271: Don't remove trailing whitespace from cursor line

sraizada created this revision. sraizada added a reviewer: KTextEditor. sraizada added a project: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. sraizada requested review of this revision. REVISION SUMMARY When the

D11137: overflow-menu as view-more-symbolic, and horizontal

andreaska accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH phab/overflow REVISION DETAIL https://phabricator.kde.org/D11137 To: mart, #vdg, andreaska Cc: Fuchs, #frameworks, michaelh, ngraham, bruns

D12228: kdirlister new connect syntax

jtamate updated this revision to Diff 32362. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. I have renamed one private slot because I didn't find a better solution. QOverload seems to work only for signals, not for slots.

D12271: Don't remove trailing whitespace from cursor line

anthonyfieroni added a comment. But if you do this do_work(); | will not remove trailling space after ';' before corsor. You should explicit chaeck that you have only whitespace on the line. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/131/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 17 Apr 2018 11:45:03 + Build duration: 2 min 48 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.10/60/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 17 Apr 2018 11:54:53 + Build duration: 36 sec and counting CONSOLE

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.10 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.10/38/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.10 Date of build: Tue, 17 Apr 2018 11:54:53 + Build duration: 38 sec and counting CONSOLE OUTPUT

D12270: Create a public function to access the actionMenu

broulik added a comment. This bug is 15 years old and no proof to this claim was provided. Also, the wording as "subclasses can add" suggests a virtual method REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12270 To: ngraham, #frameworks Cc: broulik, michaelh,

D12271: Don't remove trailing whitespace from cursor line

dhaumann added a comment. @sraizada I am just seeing that this is your first KDE patch, nice! I hope that you do not get discouraged by my comments, I am just trying to find good solutions that work for everyone, and in this case, the solution this patch proposed did not work out in the

D12271: Don't remove trailing whitespace from cursor line

dhaumann added a comment. The behavior that is proposed here was like Kate behaved before, and as result we got bug reports that not all trailing spaces were removed. So we removed this. I can see that when saving very often, this may be annoying. On the other hand, the current

D12273: [KCMControls GridDelegate] Show tooltip only if one is set

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY Avoids a black empty rectangle showing if none is assigned

D11652: Don't show the background if Button.flat

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D11652 To: apol, #plasma, mart Cc: mart, #frameworks, michaelh, ngraham, bruns

D11652: Don't show the background if Button.flat

This revision was automatically updated to reflect the committed changes. Closed by commit R242:49ef90bcb985: Dont show the background if Button.flat (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11652?vs=31309=32377

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/106/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 17 Apr 2018 11:45:03 + Build duration: 2 min 40 sec and counting

D12282: Look into subdirectories for dictionaries

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REVISION SUMMARY This allow us better support for dictionaries provided by

D12282: Look into subdirectories for dictionaries

vonreth added a reviewer: mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D12282 To: vonreth, mlaurent Cc: #frameworks, michaelh, ngraham, bruns

D12283: Allow to load dictionaries form a rcc

vonreth edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Remove indent and commit it :) Thanks INLINE COMMENTS > hunspellclient.cpp:104 > +} > +return QString(); > +} fix indent REPOSITORY R246 Sonnet BRANCH master

D12283: Allow to load dictionaries form a rcc

vonreth added a reviewer: mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: #frameworks, michaelh, bruns

D12283: Allow to load dictionaries form a rcc

vonreth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. vonreth requested review of this revision. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 AFFECTED FILES

D12269: Don't install plugins within lib on android

This revision was automatically updated to reflect the committed changes. Closed by commit R240:dbe4d2d7f9d6: Dont install plugins within lib on android (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12269?vs=32356=32401

D12282: Look into subdirectories for dictionaries

This revision was automatically updated to reflect the committed changes. Closed by commit R246:27e33da43fe6: Look into subdirectories for dictionaries (authored by vonreth). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12282?vs=32392=32393 REVISION DETAIL

D12270: Create a public function to access the actionMenu

ngraham added a comment. If you'd like, I can abandon the diff and WONTFIX the bug. I'm just trying to fix low-hanging fruit issues as I triage old KIO bugs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12270 To: ngraham, #frameworks Cc: broulik, michaelh, ngraham,

D12282: Look into subdirectories for dictionaries

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12282 To: vonreth, mlaurent Cc: #frameworks, michaelh, ngraham, bruns

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32422. michaelh added a comment. - Apply suggested changes - Correct summary error - Repair cleaning - Comment some decisions REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32321=32422 BRANCH

D12295: Supporting nested brackets for Kate autobrackets

sraizada created this revision. sraizada added a reviewer: KTextEditor. sraizada added a project: KTextEditor. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. sraizada requested review of this revision. REVISION SUMMARY With

D12222: baloodb: Use complete access filtering for all outputs

michaelh added a comment. I went I little overboard with `remove_if` and had to repair. Device filtering is also broken see inline comment. INLINE COMMENTS > databasesanitizer.cpp:160 > const QByteArray rootPath = > QFile::encodeName(vol.rootPath()); >

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32413. chinmoyr added a comment. Fix compilation error REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10409?vs=32412=32413 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10409 AFFECTED FILES

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr abandoned this revision. chinmoyr added a comment. Changes split in D12291 and D10411 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi

D6199: Allow deleting from write-protected location in dolphin

chinmoyr abandoned this revision. chinmoyr added a comment. Not required due to design changes REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D6199 To: chinmoyr, elvisangelaccio, #frameworks, #dolphin Cc: Zren, dfaure, #konqueror

D10409: In linux don't use abstract socket to share file descriptor

chinmoyr updated this revision to Diff 32412. chinmoyr edited the summary of this revision. chinmoyr added a comment. Removed dependency on D10273 Rebased on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10411: Create socket file in user's runtime directory

chinmoyr updated this revision to Diff 32414. chinmoyr edited the summary of this revision. chinmoyr added a comment. Rebased on D10409 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10411?vs=26832=32414 BRANCH master

D6834: [KNewFileMenu] Enable creating new files in read-only folders

chinmoyr abandoned this revision. chinmoyr added a comment. Not required due to design changes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr, dfaure Cc: #frameworks, michaelh, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr created this revision. chinmoyr added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Limiting file ioslave to recieve file descriptor only from root owned process helps to make sure that

D12227: Save the dialog view settings even when canceling

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

This revision was automatically updated to reflect the committed changes. Closed by commit R135:7b742db8ddfd: Save the dialog view settings when closing the dialog without hitting the… (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 219 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/219/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 17 Apr 2018 22:30:30 + Build duration: 5 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 198 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/198/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 17 Apr 2018 22:30:30 + Build duration: 10 min and counting JUnit Tests Name:

D12227: Save the dialog view settings even when canceling

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH save-dialog-view-settings-on-cancel (branched from master) REVISION DETAIL https://phabricator.kde.org/D12227 To: ngraham, #frameworks, davidedmundson Cc: michaelh, bruns

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH save-view-config-on-close-and-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D12240 To: ngraham,

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, dfaure Cc: elvisangelaccio, ngraham, anthonyfieroni, meven, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/68/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 17 Apr 2018 22:30:30 + Build duration: 6 min 15 sec and counting JUnit Tests Name: (root)

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:196 > + summary.accessible += (info.deviceId == > deviceId && info.accessible ? 1 : 0); > + return info.deviceId ==

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32426. michaelh added a comment. - Filter by device id REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32422=32426 BRANCH sanitize-dry (branched from master) REVISION DETAIL

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked 6 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D1 To: michaelh, #baloo, #frameworks Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a comment. In D12047#246715 , @michaelh wrote: > > Corrupt the database > > As described in BUG: 392877? yes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh,

D12222: baloodb: Use complete access filtering for all outputs

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:179 > + > +bool isMounted(const quint32 id) { > +return m_devices.mounted.contains(id); `isMounted(id)` can be implemented as `getStorageInfo(id).isValid()` > databasesanitizer.cpp:183 > + > +bool

D11753: baloodb: Add clean command

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks, bruns Cc: bruns, cfeck, smithjd, ashaposhnikov,

D12233: Avoid manipulation of lists with quadratic complexity

bruns added inline comments. INLINE COMMENTS > fileindexscheduler.cpp:148 > + [](const QString& file) { > +return file.startsWith(dir); > +}); indent by 4, please. And align `});`

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/107/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 18 Apr 2018 03:41:31 + Build duration: 5 min 37 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/132/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 18 Apr 2018 03:41:31 + Build duration: 6 min 5 sec and counting