D12538: Select item without clicking the Open/Save button

anemeth added a comment. In D12538#254239 , @jtamate wrote: > I'm one of those that choose a file and add a "_2" to the filenames. ;-) > > Please, please, ask the KDE Usability Project about this change. This patch is part of task

D11828: Simplify orPostingIterator and make it faster

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, michaelh, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12025: Terminate query execution early if subterm returns empty result set

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12025 To: bruns, #baloo, michaelh, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12544: Don't select file extension

anemeth updated this revision to Diff 33162. anemeth added a comment. - Clarify comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33161=33162 BRANCH select_filename_only (branched from master) REVISION DETAIL

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12371: fix always reproducible crash

dfaure added a comment. After the setHost and the setPath, it'll be smb://host/path, so that one doesn't have any effect (unless both host and path are empty). And this is in the special() command so it doesn't get into the app's KCoreDirLister. REPOSITORY R241 KIO REVISION DETAIL

D12371: fix always reproducible crash

anthonyfieroni added a comment. So, it should be Dolphin even empty path + '/' will result in error? And in other review concatPath can make it, what you think? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To: jtamate, dfaure, #frameworks, apol Cc:

D12538: Select item without clicking the Open/Save button

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL

D12544: Don't select file extension

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham,

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12335 To: bruns, #baloo, michaelh, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12544: Don't select file extension

ngraham added a comment. Nice! But I notice that even though the correct part of the text is selected, the field doesn't actually receive focus. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh,

D12336: Replace several Q_ASSERTs with proper checks

broulik added inline comments. INLINE COMMENTS > documenturldb.cpp:107 > { > -Q_ASSERT(id > 0); > -Q_ASSERT(!name.isEmpty()); > +if (!docId || name.isEmpty()) { > +return; Didn't you mean `id`? > documenturldb.cpp:172 > { > -Q_ASSERT(docId > 0); > +if

D12544: Don't select file extension

anemeth added a comment. In D12544#254411 , @ngraham wrote: > Nice! But I notice that even though the correct part of the text is selected, the field doesn't actually receive focus. Well, that was (will be) included in D12538

D12544: Don't select file extension

ngraham added a comment. Why don't we do it here, since it's more related--or even in a separate patch, since now that I test without the patch, it seems that it's actually an unrelated pre-existing bug. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To:

D12544: Don't select file extension

anemeth added a comment. In D12544#254419 , @ngraham wrote: > Why don't we do it here, since it's more related--or even in a separate patch, since now that I test without the patch, it seems that it's actually an unrelated pre-existing bug.

D12545: Set focus on the filename line edit when a file is selected

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg Cc: ngraham,

D12385: Thumbnail smooth scaling in filepicker

rkflx accepted this revision. rkflx added a comment. Thanks Kai, great questions. I think I can answer them: In D12385#250511 , @broulik wrote: > What's the performance penalty of that? I don't see any performance issues, both when

D12328: Enable preview by default in the filepicker dialog

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. Thanks, `arc patch` now works great for me, automatically applying the dependent revision as it should. In D12328#254098 , @anemeth

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33165. anemeth removed a subscriber: rkflx. anemeth added a comment. Moved filename line edit focus to D12545 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33159=33165 BRANCH

D12545: Set focus on the filename line edit when a file is selected

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This is clearly what the code was //trying// to do, based on inline comments: https://cgit.kde.org/kio.git/tree/src/filewidgets/kfilewidget.cpp#n1176 However, are we sure

D12538: Select item without clicking the Open/Save button

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In double-click mode, this eliminates the desirable behavior whereby after a single click, the name field becomes focused so you can type a new name. We want to keep that,

D12538: Select item without clicking the Open/Save button

anemeth added a comment. Whoops, some unintentional changes made it in, will fix soon... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33156. anemeth added a comment. Focus filename lineEdit on highlight REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33137=33156 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12371: fix always reproducible crash

anthonyfieroni added a comment. @dfaure, off i mean smb:/// it can be seen in smb slave https://phabricator.kde.org/source/kio-extras/browse/master/smb/kio_smb_mount.cpp$66 But why? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To: jtamate, dfaure,

D12125: Avoid inserting an invalid "Size" property from the Filesystem interface

bruns marked an inline comment as done. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12125 To: bruns, #frameworks Cc: broulik, #frameworks, michaelh, bruns

D12336: Replace several Q_ASSERTs with proper checks

bruns added a reviewer: Frameworks. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, michaelh, #frameworks Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12545: Set focus on the filename line edit when a file is selected

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH focus_lineedit (branched from master) REVISION DETAIL

D9408: extractors: Hide warnings from system headers

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. Please have a look at the issue. Thanks INLINE COMMENTS > CMakeLists.txt:35 > +target_include_directories(kfilemetadata_exiv2extractor SYSTEM PRIVATE >

D12545: Set focus on the filename line edit when a file is selected

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12355: [API dox] New UI marker @info:placeholder

kossebau added a comment. Would push then on Sun. April 29th, if no-one has objections or comments. Cmp. also D12353 Also created task T8589 for the KDE HIG to provide some guidelines for placeholder text usage &

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham added a comment. In D10663#254549 , @dmitrio wrote: > Then I probably didn't understand what was proposed in the discussed bug report. When you start writing to the existing file the data that have been in the destination file before

D12544: Don't select file extension

anemeth updated this revision to Diff 33173. anemeth added a comment. Only enable it for save dialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33162=33173 BRANCH select_filename_only (branched from master) REVISION DETAIL

D12544: Don't select file extension

anemeth added a comment. Turns out this was already implemented before, but was not currently utilized. These 3000+ lines files are hard to overwiev... I removed these checks: `&& !locationEdit->isVisible()` I assume at one point the filename line edit was once set to hide/show on

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

dmitrio added a comment. Then I probably didn't understand what was proposed in the discussed bug report. When you start writing to the existing file the data that have been in the destination file before the operation become lost. If we want to be able to restore content of destination

D12538: Select item without clicking the Open/Save button

ngraham added a comment. We also need to fix the apps that erroneously supply their own overwrite dialog instead of letting the dialog handle it--as illustrated in Alex's video: the overwrite dialog appears only after the file dialog is gone, because it's a specia, thing that Kate displays

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33159. anemeth added a comment. Sorry, now fixed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33157=33159 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12518: [Button Styles] Fill height and vertical align

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:c9e8e2e717f2: [Button Styles] Fill height and vertical align (authored by broulik). REPOSITORY R242 Plasma

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/120/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 26 Apr 2018 15:20:23 + Build duration: 2 min 37 sec and counting

D12371: fix always reproducible crash

dfaure added a comment. Anthony: do you mean smb:// ? file:/// with 3 slashes is most definitely correct (file://kk would mean a hostname of "kk"). And file://kk doesn't appear anywhere in the output, so surely there's no problem there. The question is which piece of code confuses smb://

D12538: Select item without clicking the Open/Save button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (As mentioned before, this can't and won't land until other things have been fixed and implemented first) REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master)

D12385: Thumbnail smooth scaling in filepicker

ngraham added reviewers: elvisangelaccio, rkflx. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfeck, broulik, ngraham, #frameworks, michaelh,

D10078: Add separate lib KF5::DBusRunner

kossebau updated this revision to Diff 33152. kossebau added a comment. - make MatchReply a QObject & change isValid to isFinished (+ signal) + allows to make MatchReplyPrivate unaware of AbstractRunnerPrivate by using the signal for unregistering + closer in API terms to existing *Reply

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254334 , @broulik wrote: > Does the file dialog have those selector overlays Dolphin has? No; see https://bugs.kde.org/show_bug.cgi?id=185793 We'll need to fix that before this lands. REPOSITORY

D12538: Select item without clicking the Open/Save button

ngraham added a comment. Thanks, that's better. This makes me realize that there's a pre-existing bug: the selected text includes the filename extension, and it probably shouldn't. We should fix that in another patch though. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/145/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 26 Apr 2018 15:20:23 + Build duration: 12 min and counting JUnit

D12538: Select item without clicking the Open/Save button

broulik added a comment. Does the file dialog have those selector overlays Dolphin has? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

ngraham added a comment. @jtamate, it's a valid concern, but if you don't want the single-click behavior, you should turn off single-click. Once we fix the lack of selection markers, then it will be easier to select an existing file whose name you want the saved file 's name to begin with.

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33157. anemeth added a comment. Remove unintentional changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33156=33157 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D9408: extractors: Hide warnings from system headers

kfunk added a reviewer: mgallien. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D9408 To: kfunk, mgallien Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D9408: extractors: Hide warnings from system headers

kfunk updated this revision to Diff 33121. kfunk added a comment. Restricted Application added a project: Baloo. Rebased REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=24101=33121 BRANCH master REVISION DETAIL

D11685: Implement single click on line number to select line of text

rkron added a comment. Would someone please land this for me? Thanks. REPOSITORY R39 KTextEditor BRANCH Bug372503 (branched from master) REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff,

D12156: implement reading of rating tag

astippich added a comment. In D12156#252575 , @mgallien wrote: > If I have correctly understood the ideas behind the conception of Baloo, we should probably prefer to store the rating with a "native" solution instead of the xattr one that is

D12328: Enable preview by default in the filepicker dialog

anemeth added a comment. The .upd is being automatically copied to `/usr/share/apps/kconf_update/` In the kconf_update log file `/home/alex/.kde4/share/apps/kconf_update/log/update.log` I found the following entry: 2018-04-25T21:41:56 Checking update-file

Re: kfilemetadata compile failure

On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote: > kfilemetadata does not compile in KDE neon from git master currently > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error: > ‘AVCodecParameters’ does not name a type > 12:27:35 const AVCodecParameters*

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

cfeck created this revision. cfeck added a reviewer: alexmerry. cfeck added a project: Frameworks. Restricted Application added a subscriber: Frameworks. cfeck requested review of this revision. REVISION SUMMARY The GIMP image loader had a limit to 16K x 16K pixels, because this would already

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. Ping. We are scaling 128px icons to lower sizes. In this case smooth transformation does not really affect performance. Can someone confirm that this is the right approach? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION

D9408: extractors: Hide warnings from system headers

kfunk updated this revision to Diff 33189. kfunk added a comment. Add PRIVATE REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=33121=33189 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9408 AFFECTED FILES

D9408: extractors: Hide warnings from system headers

mgallien accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D9408 To: kfunk, mgallien Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/146/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Apr 2018 03:29:25 + Build duration: 8 min 54 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 121 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/121/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 27 Apr 2018 03:29:25 + Build duration: 12 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 84 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/84/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 27 Apr 2018 03:28:55 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 235 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/235/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Apr 2018 03:28:55 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 213 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/213/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 27 Apr 2018 03:28:55 + Build duration: 22 min and counting JUnit Tests Name:

D12512: ScrollViewKCM

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH mart/ScrollViewKCM REVISION DETAIL https://phabricator.kde.org/D12512 To: mart, #plasma, hein Cc: hein, #frameworks, michaelh, bruns

D12538: Select item without clicking the open/save button

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12538: Select item without clicking the Open/Save button

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth retitled this revision from "Select item without clicking the open/save button" to "Select item without clicking the Open/Save button". anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a

D12538: Select item without clicking the Open/Save button

jtamate added a comment. I'm one of those that choose a file and add a "_2" to the filenames. ;-) Please, please, ask the KDE Usability Project about this change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: jtamate,

D12512: ScrollViewKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c175bbfc8861: ScrollViewKCM (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12512?vs=33111=33141 REVISION DETAIL

D11685: Implement single click on line number to select line of text

ngraham closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11685 To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann Cc: dhaumann, rkron, mwolff, ngraham, #ktexteditor, #kate, #frameworks, michaelh, kevinapavew, bruns, demsking,

D12538: Select item without clicking the Open/Save button

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: jtamate, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham edited the summary of this revision. ngraham added a dependency: D12545: Set focus on the filename line edit when a file is selected. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham added a dependent revision: D12544: Don't select file extension. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham Cc: ngraham, #frameworks, michaelh, bruns

D12545: Set focus on the filename line edit when a file is selected

rkflx requested changes to this revision. rkflx added a comment. Hm, this breaks selecting files and even navigating directories with the keyboard (e.g. via the arrow keys), and as such cannot possibly be something we want. I could imagine a different spin here: [⇥] should switch focus

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. In D12545#254477 , @rkflx wrote: > In D12545#254475 , @ngraham wrote: > > > Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior

D12328: Enable preview by default in the filepicker dialog

rkflx accepted this revision. rkflx added a subscriber: elvisangelaccio. rkflx added a comment. This revision is now accepted and ready to land. LGTM now (even though you ignored the "newline" I suggested…) I'd appreciate a second opinion from #Frameworks

D12328: Enable preview by default in the filepicker dialog

ngraham accepted this revision. ngraham added a comment. The idea behind D12321 was to increase buy-in, since one of the objections was that most previews are a useless regression at small icon sizes. Text files still won't be previewed by default at any

D12336: Replace several Q_ASSERTs with proper checks

bruns updated this revision to Diff 33171. bruns added a comment. fix variable name REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12336?vs=32529=33171 BRANCH db_robustness2 REVISION DETAIL https://phabricator.kde.org/D12336 AFFECTED FILES

D12544: Don't select file extension

ngraham added a comment. This is so nice! Let me test extensively... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Let's only enable this behavior for the Save dialogs. For the Open dialogs, it seems sensible that you'd actually want the whole text selected (but not focused, see D12545

D12544: Don't select file extension

anemeth added a comment. There will be some problems with files that have multiple extensions, for example .tar.gz or .tar.bz We could create a list of the most common multiextension filetypes, but I only know these two and Google isn't helpful. Can some of you help me out here? Should

D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#254475 , @ngraham wrote: > Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior only when clicking, and only for the save dialog. Yeah, but not sure I

D12544: Don't select file extension

ngraham added a comment. In D12544#254467 , @anemeth wrote: > There will be some problems with files that have multiple extensions, for example .tar.gz or .tar.bz > We could create a list of the most common multiextension filetypes, but I

D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#254479 , @ngraham wrote: > No, it doesn't actually work. Turn on double-click, Aha! This is what I'm missing. It should be mentioned in the summary if non-default settings are used :D REPOSITORY R241

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. #frameworks or @elvisangelaccio, any objections, or can we land this soon? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth,

D12336: Replace several Q_ASSERTs with proper checks

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12336 To: bruns, #baloo, michaelh, #frameworks Cc: broulik, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Good point @rkflx, we definitely don't want to break keyboard navigation. We want this behavior only when clicking, and only for the save dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham,

D12545: Set focus on the filename line edit when a file is selected

ngraham added a comment. Good point. :) So yes, this is an enhancement for the double-click use case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33167. anemeth added a comment. - Rename .upd file - Add Version=5 to .upd file CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33103=33167 BRANCH preview_default (branched from master) REVISION DETAIL

D12328: Enable preview by default in the filepicker dialog

anemeth marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. When you cancel an overwrite operation in the middle with this patch, the destination file is destroyed. REPOSITORY R241 KIO REVISION DETAIL