Re: kfilemetadata compile failure

On mardi 15 mai 2018 01:14:12 CEST Albert Astals Cid wrote: > El dilluns, 14 de maig de 2018, a les 22:33:12 CEST, Matthieu Gallien va > > escriure: > > I was meaning to have a fix on top of v5.46.0 that may be released as a > > v5.46.1 if needed. > > Ah, that's up to David if he thinks it makes

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 15 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ java.io.IOException: remote file operation failed:

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Even old OpenSuSE Leap 42.3 has ffmpeg 3.3.4, so this seems fine ;-) REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D12886 To: mgallien,

D12895: WIP: Add KFileItemActionsPlugin

broulik created this revision. broulik added reviewers: Plasma, VDG, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows to share files from Dolphin's file

D12896: Add Telegram plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a "Share via Telegram plugin". It's

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

bruns accepted this revision. bruns added a comment. +1 REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D12886 To: mgallien, dfaure, michaelh, jriddell, bruns Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D12235: Add XDG Output Protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:4705c38ff12b: Add XDG Output Protocol (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12235?vs=34190=34201 REVISION DETAIL

D12848: Set fix steps for icon sizes

rkflx added a comment. > In the open/save dialog use the same fixed icon sizes for the zoom slider as Dolphin. So we could also change Dolphin to support continuous zoom instead? As the summary is quite sparse, I'm not sure what the patch is about: Is it about consistency, or is there

D12734: Scale up folder icon before creating preview overlays

rkflx added a comment. In D12734#262368 , @muhlenpfordt wrote: > Ok to commit? Sure, go ahead  REPOSITORY R320 KIO Extras BRANCH scale-up-folder-icon (branched from Applications/18.04) REVISION DETAIL

D12787: Ignore more types of source files

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Not tested by me, by looks good in general. REPOSITORY R293 Baloo BRANCH more-excluded-source-files (branched from master) REVISION DETAIL https://phabricator.kde.org/D12787 To:

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Kind request to review ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks,

D12578: fix some issues reported by clazy

mgallien added a comment. In D12578#262831 , @bruns wrote: > @mgallien - I think this is trivial to fix up - can you do, so we have one less request open? I will do but as I had started working on that as a low priority task, I have not

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 15 May 2018 14:40:33 + Build duration: 5 min 51 sec and counting JUnit Tests

D12233: Avoid manipulation of lists with quadratic complexity

bruns added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Apparently @michaelh is MIA - how do we proceed here? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo, bruns Cc:

D12895: WIP: Add KFileItemActionsPlugin

abetts added a comment. +1 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 15 May 2018 14:40:33 + Build duration: 5 min 40 sec and counting JUnit Tests

D12895: WIP: Add KFileItemActionsPlugin

ngraham added a comment. Fantastic! I've wanted this for so long! That "send as email attachment" item you have in your Dolphin context menu... is that a separate service item provided by KMail that will become obsolete with this new share menu? Seems kinda redundant to have them

D12578: fix some issues reported by clazy

bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. @mgallien - I think this is trivial to fix up - can you do, so we have one less request open? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12578 To: mgallien, #baloo,

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 15 May 2018 14:40:33 + Build duration: 6 min 45 sec and counting JUnit Tests

D12734: Scale up folder icon before creating preview overlays

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bafc90d730f2: Scale up folder icon before creating preview overlays (authored by muhlenpfordt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, mlaurent. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY Since "Use

D12235: Add XDG Output Protocol

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D12235 To: davidedmundson, romangg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12235: Add XDG Output Protocol

davidedmundson updated this revision to Diff 34190. davidedmundson added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Add check for if values haven't really changed Renamed a var A few more comments REPOSITORY R127 KWayland

D12896: Add Telegram plugin

ngraham added a comment. If it's 99% identical except for the name and command, would it make more sense to create a generic "send to app/service" plugin that you can feed different executables into? Then we could even expose that configuration in the UI somewhere to allow people to easily

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

This revision was automatically updated to reflect the committed changes. Closed by commit R286:3415015e3d45: check that ffmpeg is at least version 3.1 that introduce the API we require (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

jtamate created this revision. jtamate added reviewers: Kate, Frameworks. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jtamate requested review of this revision. REVISION SUMMARY Most of the time was spent

D12896: Add Telegram plugin

apol added inline comments. INLINE COMMENTS > telegramplugin.cpp:53 > +foreach(const QJsonValue& val, array) { > +ret += toPath(val.toString()); > +} toUrl().toLocalFile(). Also I would Check if(url.isLocalFile()). > telegramplugin.cpp:61 > +

D12896: Add Telegram plugin

nicolasfella updated this revision to Diff 34213. nicolasfella added a comment. - Use url.toLocalfile() REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34200=34213 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12896

Re: kfilemetadata compile failure

El dimarts, 15 de maig de 2018, a les 9:09:23 CEST, David Faure va escriure: > On mardi 15 mai 2018 01:14:12 CEST Albert Astals Cid wrote: > > El dilluns, 14 de maig de 2018, a les 22:33:12 CEST, Matthieu Gallien va > > > > escriure: > > > I was meaning to have a fix on top of v5.46.0 that may be

D12898: Add missing header

maximilianocuria created this revision. maximilianocuria added reviewers: Frameworks, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. maximilianocuria requested review of this revision. REVISION SUMMARY xdgforeign

D12858: [KCharSelect] Fix table cell width

elvisangelaccio added a comment. +1, tested with Qt 5.11 RC1. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12858 To: cfeck, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D12848: Set fix steps for icon sizes

ngraham added a comment. In D12848#262776 , @rkflx wrote: > I'm confused: First you propose a common widget, and then you say Gwenview needs arbitrary zoom levels? A common widget could easily support both steps and continuous zooming

D12233: Avoid manipulation of lists with quadratic complexity

ngraham added a comment. You could commandeer it and finish it yourself I guess. :-( I'll see if I can contact Michael. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: michaelh, #baloo, bruns Cc: ngraham, kde-frameworks-devel, jtamate, bruns,

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I saw this happen with kdecoration from git since

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

ltoscano added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12905 To: heikobecker, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

ltoscano added a comment. Looks fine by me, let's see if there are other comments. INLINE COMMENTS > KF5I18NMacros.cmake.in:138-139 > > -file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname}) > -install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION >

D12848: Set fix steps for icon sizes

elvisangelaccio added a comment. I'd also prefer adding continuous zooming in Dolphin rather than removing it here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: elvisangelaccio, broulik, rkflx, ngraham, kde-frameworks-devel,

D12578: fix some issues reported by clazy

mgallien updated this revision to Diff 34223. mgallien added a comment. fix some issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12578?vs=33247=34223 BRANCH arcpatch-D12578 REVISION DETAIL https://phabricator.kde.org/D12578 AFFECTED FILES

D12578: fix some issues reported by clazy

bruns added inline comments. INLINE COMMENTS > searchstore.cpp:163 > if (term.operation() == Term::And || term.operation() == Term::Or) { > QList subTerms = term.subTerms(); > QVector vec; `const QList subterms = ...` REPOSITORY R293 Baloo REVISION

D12388: Output device color curves correction

graesslin added inline comments. Restricted Application added a subscriber: kde-frameworks-devel. INLINE COMMENTS > outputchangeset.cpp:91 > } > + > bool OutputChangeSet::positionChanged() const nitpick: added unrelated new line > outputdevice_interface.cpp:427 > + > +

D12895: WIP: Add KFileItemActionsPlugin

elvisangelaccio added inline comments. INLINE COMMENTS > purposefileitemaction.desktop:1-8 > +[Desktop Entry] > +Type=Service > +Name=Share file > +X-KDE-Library=purposefileitemaction > +X-KDE-Submenu=Share > +Icon=document-share > +ServiceTypes=KFileItemAction/Plugin Why not just starting with

D12896: Add Telegram plugin

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in telegramplugin.cpp:61 > Instead of finding the program, we could execute using > `org.telegram.desktop.desktop`, it would allow it to work even if it's > installed from appimage/flatpak. > > I'm not sure how this would work

D12896: Add Telegram plugin

nicolasfella marked 2 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12756: [KDateTable] Use a more visible red color

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. So what's our path forward? I'd prefer to land this as-is since it does indeed fix the bug for now, and then we can have a larger discussion regarding what to do about the fact that `KWidgetsAddons`

D12787: Ignore more types of source files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7529727e4624: Ignore more types of source files (authored by ngraham). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12787?vs=34155=34241 REVISION DETAIL

D12896: Add Telegram plugin

apol added inline comments. INLINE COMMENTS > nicolasfella wrote in telegramplugin.cpp:61 > How would I do that? https://api.kde.org/frameworks/kio/html/classKIO_1_1DesktopExecParser.html

D12647: Move the inline preview button into the menu

ngraham added a comment. Friendly ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH ref_upd (branched from master) REVISION DETAIL https://phabricator.kde.org/D12892 To: maximilianocuria, #frameworks, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham,