D13403: Android: Make it possible to override a target's APK directory

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Some projects such as marble

D13403: Android: Make it possible to override a target's APK directory

apol added a dependent revision: D13404: Make it possible to build Marble with KDE Android tooling. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13403 To: apol, #frameworks Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12696: Use the new uds implementation

bruns added inline comments. INLINE COMMENTS > martinkostolny wrote in udsentry.cpp:106 > sftp slave crashes here when entering directory with links Any chance you can attach a debugger (or load the core file with gdb) and provide the values of 'udsField' and 'value'? REPOSITORY R241 KIO

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13406 To: habacker, ilic Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

cullmann added a comment. I can push that change, if OK. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: acooligan, kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, cullmann, michaelh, kevinapavew, bruns,

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Corner case: what if only need to update cachedBackground(i.e. enabledBorders and frameSize are okay)? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh,

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. In D13384#275224 , @zzag wrote: > Corner case: what if only need to update cachedBackground(i.e. enabledBorders and frameSize are okay)? Delete `shouldUpdate` and wrap if (refcount() == 1) {} into another if

D13384: FrameSvg: Do not wreck shared mask frames

zzag planned changes to this revision. zzag added a comment. Add comments describing CFG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

cullmann added a comment. I followed the "I think it was agreed this is an improvement, so i'm going to suggest we commit it." comment from above. In any case, it is an improvement to the old situation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To:

D12696: Use the new uds implementation

martinkostolny added a comment. Thanks for guidance regarding getting additional debug info. I'll try to get it soon :). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh,

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

heikobecker marked an inline comment as done. heikobecker added a comment. Considering the feedback I'll probably merge this in a few days if no objections turn up in the meantime. INLINE COMMENTS > ltoscano wrote in KF5I18NMacros.cmake.in:138-139 > I guess that those two lines are the

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY On runtime KF5I18n_DIR points to the same path as CMAKE_CURRENT_LIST_DIR, but adds

D12513: CVE-2018-10361: privilege escalation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:c81af5aa1d4f: CVE-2018-10361: privilege escalation (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

cgiboudeaux added a comment. -1, this change would break the autotests. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D13406 To: habacker, ilic Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

romangg added a comment. How is a change of neighbors supposed to work for clients already bound to the proxy objects? For example consider virtual desktop grid: D1 D2 D3 D4 Compositor removes `D3` and let `D4` flow back to the left: D1 D2 D4 `desktop_removed`

D13033: Expose getter method for KConfig::addConfigSources

davidedmundson added a dependent revision: D13034: Add mechanism to notify other clients of config changes over DBus. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13033 To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13034: Add mechanism to notify other clients of config changes over DBus

davidedmundson added dependencies: D13033: Expose getter method for KConfig::addConfigSources, D13032: Fix cleanup of kconfigtest kdeglobals. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik Cc: broulik, zzag,

D13032: Fix cleanup of kconfigtest kdeglobals

davidedmundson added a dependent revision: D13034: Add mechanism to notify other clients of config changes over DBus. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13032 To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

ltoscano accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D12905 To: heikobecker, ilic, ltoscano Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

acooligan added a comment. In D12513#269889 , @aacid wrote: > Also not sure if useful but since kio is getting support for writting to "root owned" files we should investigate if maybe we can just simply drop this code altogether? As

D13402: FrameSvg: Simplify updateSizes

zzag created this revision. zzag added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY if (hintXXXMargin > -1) { // ... }

D13384: FrameSvg: Do not wreck shared mask frames

zzag updated this revision to Diff 35749. zzag added a comment. Update sizes only if enabled borders or frame size have been changed REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13384?vs=35705=35749 BRANCH

D13302: check for needed version of libavcode, libavformat and libavutil

This revision was automatically updated to reflect the committed changes. Closed by commit R286:461f8ec81b81: check for needed version of libavcode, libavformat and libavutil (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

This revision was automatically updated to reflect the committed changes. heikobecker marked an inline comment as done. Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty dir when no po files exist (authored by heikobecker). REPOSITORY R249 KI18n CHANGES SINCE LAST

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275538 , @bruns wrote: > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... > If you wan't your commits to stay separated, you have to do a `git

D13216: Overhaul the file index scheduler.

bruns added a comment. In D13216#275546 , @smithjd wrote: > In D13216#275538 , @bruns wrote: > > > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been

D13216: Overhaul the file index scheduler.

bruns added a comment. In D13216#275581 , @smithjd wrote: > According to the arc documentation, a --merge commit should land the commits separately. Still, **I** can not see the individual commits. REPOSITORY R293 Baloo REVISION

D13384: FrameSvg: Do not wreck shared mask frames

zzag updated this revision to Diff 35806. zzag added a comment. Rename `shouldUpdateSizes` back to `shouldUpdate` That's for a possible future diff: the mask frame should be updated if maskFrame->imagePath != frame->imagePath. That's an unrelated change because this diff tries to

D13216: Overhaul the file index scheduler.

smithjd added a comment. According to the arc documentation, a --merge commit should land the commits separately. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D13216: Overhaul the file index scheduler.

ngraham added a comment. For future reference, the preferred method to implement a multi-commit patch chain is with multiple Phabricator revisions. See https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project REPOSITORY R293 Baloo REVISION DETAIL

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. In D13384#275246 , @zzag wrote: > Add comments describing CFG. As it turns out, that's not necessary. The code is pretty much "self-explanatory". Anyway, I'd like to proceed with code review. REPOSITORY R242

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275582 , @bruns wrote: > In D13216#275581 , @smithjd wrote: > > > According to the arc documentation, a --merge commit should land the commits separately. > >

D13216: Overhaul the file index scheduler.

bruns added a comment. @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... If you wan't your commits to stay separated, you have to do a `git checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next commit, `arc

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 35812. smithjd added a comment. Separate out the content indexer halt on quit. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35811=35812 BRANCH master-scheduler-updateConfig (branched from master) REVISION

D13425: Quit the file indexer when closing.

smithjd created this revision. smithjd added reviewers: bruns, mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35810. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35730=35810 BRANCH

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added reviewers: mgallien, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns,

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH mastger-scheduler-updateConfig (branched from master)

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel,

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change, halt the file indexer and run a file changed check when the file watches are updated." to "On config change halt the file indexer and run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 38 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/38/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 08 Jun 2018 03:51:22 + Build duration: 1 min 43 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Fri, 08 Jun 2018 03:51:22 + Build duration: 2 min 42 sec and counting JUnit Tests

D13365: Fixed the cursor(caret) width in kate

brauch added a comment. I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept commits with only one name fragment. Something equivalent to the western first/last name pair is required. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To:

D13398: [KFileItem] Check most local URL for whether it's shared

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13398 To: broulik, gregormi, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#275130 , @brauch wrote: > I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept commits with only one name fragment. Something equivalent to the western first/last name pair is required.

D13365: Fixed the cursor(caret) width in kate

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e6f87dd57008: Fix caret width (authored by shubham, committed by brauch). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13365?vs=35683=35735 REVISION DETAIL

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. Thank you Brauch for committing it on my behalf. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D13398: [KFileItem] Check most local URL for whether it's shared

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a44fa03029c8: [KFileItem] Check most local URL for whether its shared (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13398?vs=35734=35736

D12696: Use the new uds implementation

jtamate added a comment. In D12696#275105 , @martinkostolny wrote: > Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only?

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/47/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 07 Jun 2018 07:24:37 + Build duration: 7 min 26 sec and counting JUnit Tests

D13302: check for needed version of libavcode, libavformat and libavutil

jriddell accepted this revision. jriddell added a comment. This revision is now accepted and ready to land. latest patch works well in neon REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D13302 To: mgallien, romangg, adridg, jriddell Cc:

D12696: Use the new uds implementation

martinkostolny added a comment. Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only? Here is a crash log: log_kio_sftp: readdir: "/mnt/ext/files" , details: "2"