D14020: RPM Spec: add MIME type

nibags added a reviewer: Framework: Syntax Highlighting. nibags added a project: Framework: Syntax Highlighting. nibags edited subscribers, added: Framework: Syntax Highlighting; removed: kde-frameworks-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D13549: Switch KIO::convertSize() to KFormat::formatByteSize()

pino closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13549 To: pino, dfaure, aacid Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 51 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/51/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Tue, 10 Jul 2018 03:35:48 + Build duration: 10 min and counting JUnit Tests Name:

D14020: RPM Spec: add MIME type

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY Obtained from `shared-mime-info`:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/75/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 10 Jul 2018 05:40:48 + Build duration: 6 min 13 sec and counting JUnit Tests

D14009: [Plasma PluginLoader] Cache plugins during startup

zzag added inline comments. INLINE COMMENTS > pluginloader.cpp:194-196 > +const QString pluginName = name.section(QLatin1Char('/'), -1); > > +QVector plugins; Nitpick: IMHO, it would be better to move these two down (right before `if (useRuntimeCache) {`). So, cache invalidation and

D13816: Make KItinerary work as a static library

lepagevalleeemmanuel added a comment. > Right, that works for plugins. There is even https://codereview.qt-project.org/#/c/195680/ since 5.11 allowing us to hook "plugin loading", for things covered by static construction in the dynamic case. The patch here is looking more at something like

D13571: Correct KFormat::formatBytes examples

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this is an improvement. Even if it can be improved even more, I believe it is better to push this instead of postponing a commit. REPOSITORY R244 KCoreAddons BRANCH

D14006: Fix WebDAV destination header on COPY and MOVE operations

ngraham added a comment. Does this fix any of the bugs here? https://bugs.kde.org/buglist.cgi?component=webdav_id=1529637=kio=--- REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik updated this revision to Diff 37473. broulik added a comment. - Move code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14009?vs=37470=37473 REVISION DETAIL https://phabricator.kde.org/D14009 AFFECTED FILES

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a comment. In D14006#289680 , @ngraham wrote: > Does this fix any of the bugs here? https://bugs.kde.org/buglist.cgi?component=webdav_id=1529637=kio=--- Nope, it doesn't fix any of them. REPOSITORY R241 KIO REVISION

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/74/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Tue, 10 Jul 2018 03:35:48 + Build duration: 8 min 31 sec and counting JUnit Tests

D11193: Sonnet : use current hunspell API

This revision was automatically updated to reflect the committed changes. Closed by commit R246:0a96acf251ba: Use the current hunspell API (authored by rjvbb). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11193?vs=29246=37434 REVISION DETAIL

D12872: ScalableTest, add "scalable" plasma-browser-integration

heikobecker added a comment. +1 Btw, this is BUG: 393999 REPOSITORY R266 Breeze Icons BRANCH scalable_pbi (branched from master) REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: heikobecker,

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb edited the summary of this revision. rjvbb edited reviewers, added: Frameworks; removed: Framework: Syntax Highlighting. rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop Style. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/72/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 09 Jul 2018 10:36:23 + Build duration: 6 min 25 sec and counting JUnit Tests

D14001: Replace Gitorious web shortcut by GitLab

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Gitorious has been shut down TEST PLAN

D13698: Improve ECMAddAppIconMacro.

kossebau added a comment. Seems this was pushed only after the tagging of 5.48 was done on Saturday night, so too late for that release. If this should be still part of 5.48, get in contact with dfaure so he could consider moving the tag/release pointer to include this commit, or please

D13828: Revert "updated Japanese holidays (in Japanese and English)"

winterz added a comment. please close this REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13921: Don't show confirmation dialog for Trash action by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7d15dad5e427: Dont show confirmation dialog for Trash action by default (authored by aleksejshilin). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13921: Don't show confirmation dialog for Trash action by default

aleksejshilin edited the summary of this revision. REPOSITORY R241 KIO BRANCH dont_confirm_trash REVISION DETAIL https://phabricator.kde.org/D13921 To: aleksejshilin, dfaure, #frameworks, #dolphin, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14001: Replace Gitorious web shortcut by GitLab

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14001 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

jtamate updated this revision to Diff 37422. jtamate edited the summary of this revision. jtamate added a comment. Created the bug report referenced in the summary and code. Changed the strings to compare, they can be anything. > Perhaps there is a remote possibility of closing a view

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 09 Jul 2018 07:52:42 + Build duration: 1 min 47 sec and counting JUnit Tests

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13898 To: jtamate, dfaure, #frameworks Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

dfaure added a comment. The comments indicate that this isn't supposed to happen, but just to make sure, you can use #elif on line 941/942. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13898 To: jtamate, dfaure, #frameworks Cc: bruns, kde-frameworks-devel, michaelh,

D13670: Add subseq operator to match sub-sequences

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D13670 To: michaeleden, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/38/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Mon, 09 Jul 2018 07:52:42 + Build duration: 6 min 13 sec and counting JUnit Tests

D13627: [KSharedDataCache] Assume lock before flush changes

anthonyfieroni added a comment. @mpyne , i'm unsure about file deletion and sync other than that it looks correct. Finding best lock algorithm can be *potential* problem, but surely it's not my best. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To:

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37424. jtamate edited the summary of this revision. jtamate added a comment. Fixed targetPath of links. Question: If there any chance that st_birthtime and __st_birthtime are both present in the same OS? If affirmative, the entry of __st_birthtime

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37427. jtamate added a comment. Use st_birthtime or __st_birthtime but not both. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13898?vs=37424=37427 REVISION DETAIL

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

broulik added a comment. Why, or who, is setting this environment variable? Plasma-integration sets `QQuickStyle` depending on whether there is a `QApplication` or not, so this makes no sense. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D14003: Require out-of-source build

ngraham created this revision. ngraham added reviewers: dfaure, cfeck, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY KService doesn't build if you try

D12872: ScalableTest, add "scalable" plasma-browser-integration

ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH scalable_pbi (branched from master) REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham,

D12872: ScalableTest, add "scalable" plasma-browser-integration

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH scalable_pbi (branched from master) REVISION DETAIL https://phabricator.kde.org/D12872 To: maximilianocuria, #frameworks, dfaure, andreaska, andreask, ngraham Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham,

D14001: Replace Gitorious web shortcut by GitLab

This revision was automatically updated to reflect the committed changes. Closed by commit R241:777bf25b6a46: Replace Gitorious web shortcut by GitLab (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14001?vs=37443=37444 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 73 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/73/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 09 Jul 2018 11:56:58 + Build duration: 5 min 10 sec and counting JUnit Tests

D14003: Require out-of-source build

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D14003 To: ngraham, dfaure, cfeck, #frameworks Cc: kde-frameworks-devel, michaelh,

D12865: transferjob new connect syntax

jtamate updated this revision to Diff 37448. jtamate added a comment. Sorry, I should have updated this revision earlier. There are two methods than can not be removed from the Q_PRIVATE_SLOT definitions, otherwise the invokeMethod will fail. if (m_closedBeforeStart) {

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Mon, 09 Jul 2018 13:09:49 + Build duration: 1 min 45 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 09 Jul 2018 13:09:49 + Build duration: 1 min 24 sec and counting JUnit Tests

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:6b452ae9892d: Use non deprecated fastInsert in file.cpp (first of many to come) (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/74/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 09 Jul 2018 14:36:05 + Build duration: 4 min 41 sec and counting JUnit Tests

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Similar to KPackage's cache this

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. dantti requested review of this revision. REVISION SUMMARY The Destination header must always be QUrl::FullyEncoded so that special characters can

D14006: Fix WebDAV destination header on COPY and MOVE operations

dantti added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14006 To: dantti, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8532: [WIP] Restrict file extractor with Seccomp

davidk added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I was asked in private about the current state of libseccomp integration and why there was no progress in a long time. The current state is, that I have implemented seccomp

D14008: Use QTEST_GUILESS_MAIN

heikobecker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY Allowing the tests to pass without a running X server. REPOSITORY R235

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin Cc: kde-frameworks-devel, bruns, meven, ltoscano, #frameworks, michaelh, ngraham

D13571: Correct KFormat::formatBytes examples

bruns marked 2 inline comments as done. bruns added a comment. ping! REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13571 To: bruns, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns