D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Christoph Cullmann
cullmann added a comment. I am wondering: Do we really need to have unique IDs over all definitions? Actually I would think it would be much nicer to have all formats for one definition in a vector and having the index as the unique id. The lookup is faster and it is easier to understand.

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-07-29 Thread Safa Alfulaij
safaalfulaij added a comment. In D14345#297340 , @ngraham wrote: > 1. Does this mean that PlasmaComponents is semi or fully deprecated or "legacy", and we should be porting Plasma stuff to Kirigami instead? > 2. Since there's no Kirigami

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Volker Krause
vkrause added a comment. The whole format id code is indeed not used here, this was purely added based on the requirements I got from you guys :) So feel free to change whatever is necessary. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14451 To:

Re: how to get the list of keywords in KSyntaxHighlighting

2018-07-29 Thread Dominik Haumann
Hi Alexander, sorry for the delay, I only now saw your mail. Jonathan meanwhile posted a patch that adds this: https://phabricator.kde.org/D14434 I definitely can see that adding these functions: QStringList keywordListsNames() const; QStringList keywordList(const QString& name) const;

Pre-review CI

2018-07-29 Thread Bhushan Shah
Hello, So in previous email about staging repository I talked about pre-review CI [1]. After some time, we finally have some code in ci-tooling which can handle the pre-review CI for KDE repositories. And for initial pilot run we want to enable it for frameworks repositories. We have several

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY With

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-29 Thread David Faure
dfaure added a comment. OK I see, this is because KMail doesn't enable autosaving, but instead saves in the KMMainWin destructor, after the window (and all children) have been hidden. I'll try whether porting KMail to setAutoSaveSettings solves it. REPOSITORY R263 KXmlGui REVISION

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Christoph Cullmann
cullmann added a comment. I think an issue is the inclusion of definition in each other. I think ATM the formats are really only per definition, that means if the ids would be definition local, one will have clashs. I think ATM there is no way to get formats for definitions that got

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann added a comment. > e.g. for the customization of coloring you want to present the list of all formats a highlighting has, including the included ones. (even if later the color of the included ones is not stored per including highlighting) The included ones behave differently in

D14457: Forward-define X509 structure

2018-07-29 Thread Luca Carlon
luc4 created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. luc4 requested review of this revision. REVISION SUMMARY Forward-define X509 structure even when Qt ssl support is available. REPOSITORY R239

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann added a comment. I just had a look into the code - the Format IDs are currently not used at all by KSyntaxHighlighting. Instead, all format lookups are done via the Format name. And that by definition means that the Format looksups are per Definition, since Formats from different

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann added a comment. Btw, thinking more about it: I believe we do want globally unique IDs for a very simple reason. Think of e.g. bracket matching where multiple Definitions are included (e.g.: html { . For the last '}', we want to find the matching attribute '{'. With globally

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Christoph Cullmann
cullmann added a comment. e.g. for the customization of coloring you want to present the list of all formats a highlighting has, including the included ones. (even if later the color of the included ones is not stored per including highlighting) Otherwise you are right, a global

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Christoph Cullmann
cullmann added a comment. I think if we have 1. formats() per definition 2. some "includedDefinitions" we can build up the needed format list per highlighting that will allow us to map the syntax-highlighting formats to the KTextEditor::Attribute we need internally and in our

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-29 Thread Wolfgang Bauer
wbauer added a comment. In D13808#299791 , @ngraham wrote: > In the Bugzilla ticket, it was mentioned that KMail (and only KMail) still suffers from the issue even with this patch, so it might be a KMail-specific issue. For reference:

D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled

2018-07-29 Thread David Faure
dfaure closed this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D14447 To: dfaure, sandsmark, mlaurent Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns

D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled

2018-07-29 Thread Laurent Montel
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14447 To: dfaure, sandsmark, mlaurent Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-29 Thread David Faure
dfaure added a comment. https://phabricator.kde.org/D14454 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D13808 To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck Cc: anthonyfieroni, marten, asturmlechner, wbauer, aacid, ngraham,

D14434: add functions to access keywords

2018-07-29 Thread Dominik Haumann
dhaumann added subscribers: asemke, cullmann, vkrause. dhaumann added a comment. In general looks good to me, so +1. I would like to have another +1 from @cullmann, @vkrause or @asemke What I wonder is whether you really need the keyword lists from the Definition, or whether you want

D14434: add functions to access keywords

2018-07-29 Thread Volker Krause
vkrause added a comment. No objection from me, assuming you have a use-case for this (auto-completion?). REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: vkrause, cullmann, asemke,

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-07-29 Thread Nathaniel Graham
ngraham added a comment. I feel like the whole point of having these Plasma-ish wrappers is because they have extra features not present in the base Qt classes. If we just use QQC2 `TextField`s everywhere, then every one that wants a clear button (for example) needs to implement it for

Re: Pre-review CI

2018-07-29 Thread Friedrich W. H. Kossebau
Am Sonntag, 29. Juli 2018, 13:15:10 CEST schrieb Bhushan Shah: > Hello, > > So in previous email about staging repository I talked about pre-review > CI [1]. After some time, we finally have some code in ci-tooling which can > handle the pre-review CI for KDE repositories. And for initial pilot

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

2018-07-29 Thread Alexander Schlarb
tundracomp added a comment. Oh, I see! This wasn't obvious to me. Is this better now? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D14468: Add QVector Definition::includedDefinitions() const

2018-07-29 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This function returns

D14468: Add QVector Definition::includedDefinitions() const

2018-07-29 Thread Dominik Haumann
dhaumann updated this revision to Diff 38723. dhaumann added a comment. - Add @since tag REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14468?vs=38722=38723 BRANCH addIncludedDefinitions (branched from master) REVISION DETAIL

D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14434: add functions to access keywords

2018-07-29 Thread Alexander Semke
asemke accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH keywordlist REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann, asemke Cc: vkrause, cullmann, asemke,

D14434: add functions to access keywords

2018-07-29 Thread Alexander Semke
asemke added a comment. In D14434#299932 , @dhaumann wrote: > In general looks good to me, so +1. I would like to have another +1 from @cullmann, @vkrause or @asemke +1 > What I wonder is whether you really need the keyword lists

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann updated this revision to Diff 38720. dhaumann added a comment. - Update REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14451?vs=38695=38720 BRANCH addFormatGetters (branched from master) REVISION DETAIL

Re: how to get the list of keywords in KSyntaxHighlighting

2018-07-29 Thread Dominik Haumann
On Sun, Jul 29, 2018 at 6:16 PM, Alexander Semke wrote: > Hi Dominik, > >> sorry for the delay, I only now saw your mail. >> Jonathan meanwhile posted a patch that adds this: >> https://phabricator.kde.org/D14434 > Yes, I saw it already. Will this make into the 5.49 release of the frameworks? > >

Re: gettext makes supporting multiple languages translations in ki18n impossible

2018-07-29 Thread Albert Astals Cid
El diumenge, 29 de juliol de 2018, a les 21:45:27 CEST, Karl Ove Hufthammer va escriure: > Albert Astals Cid skreiv 29. juli 2018 19:31: > > Ideally one would be able to query gettext about whether the translation > > exists or not (basically having an option to return nullptr in the above > >

D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The JobDialog window is treated as a

D14449: Display used space in GiB also

2018-07-29 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a reviewer: Frameworks. ngraham added a comment. This revision now requires changes to proceed. Thanks for tackling this bug! I approve of the idea here, but the presentation you've chosen doesn't seem ideal. How about this instead?

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

2018-07-29 Thread Alexander Schlarb
tundracomp set the repository for this revision to R289 KNotifications. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D12674 To: tundracomp Cc: kde-frameworks-devel,

D14449: Display used space in GiB also

2018-07-29 Thread Shubham
shubham added a comment. In D14449#300147 , @rkflx wrote: > In D14449#300086 , @ngraham wrote: > > > Device capacity: 94.4 Gib > > Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 184 - Still Unstable!

2018-07-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/184/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 29 Jul 2018 19:16:31 + Build duration: 6 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 337 - Still Unstable!

2018-07-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/337/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 29 Jul 2018 19:16:31 + Build duration: 6 min 18 sec and counting JUnit Tests Name:

D14434: add functions to access keywords

2018-07-29 Thread Dominik Haumann
dhaumann added a comment. @asemke Are you sure you reference the correct Task? I cannot find anything about keyword lists in your link. Besides that, my change request with respect to API naming still stands. @jpoelen Before committing, lets have another review round, could you

D14471: Add Theme::TextStyle Format::textStyle() const;

2018-07-29 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This is required for

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

2018-07-29 Thread Alexander Schlarb
tundracomp added a comment. I build a Qt app with „just enough“ KDE-integration for the Flatpak sandbox where I have no use for this KPackage stuff. I know I could just include the install handlers in the build and drop them afterwards, but that would require a build KNS (and all of *its*

gettext makes supporting multiple languages translations in ki18n impossible

2018-07-29 Thread Albert Astals Cid
I have just realized that gettext has no way of differentiating a translation that is the same of the original over a translation that doesn't exist. That is, char *gettext (const char *__msgid) Will return "foo" for the message "foo" in both cases, when the translation of "foo" to the

Re: gettext makes supporting multiple languages translations in ki18n impossible

2018-07-29 Thread Albert Astals Cid
El diumenge, 29 de juliol de 2018, a les 22:26:56 CEST, Albert Astals Cid va escriure: > El diumenge, 29 de juliol de 2018, a les 21:45:27 CEST, Karl Ove Hufthammer > va escriure: > > Albert Astals Cid skreiv 29. juli 2018 19:31: > > > Ideally one would be able to query gettext about whether the

D14473: Fix KCatalog::translate when translation is same as original text

2018-07-29 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We need to be compare the pointer passed to gettext with the one we get back. If it

Re: how to get the list of keywords in KSyntaxHighlighting

2018-07-29 Thread Alexander Semke
Hi Dominik, > sorry for the delay, I only now saw your mail. > Jonathan meanwhile posted a patch that adds this: > https://phabricator.kde.org/D14434 Yes, I saw it already. Will this make into the 5.49 release of the frameworks? > However, pushing this further, what Kate also needs is a way go

D14464: Cancel privilege operation for read-only target with the current user as owner

2018-07-29 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY If the target file (in case of chown,

D14449: Display used space in GiB also

2018-07-29 Thread Henrik Fehlauer
rkflx added a comment. In D14449#300086 , @ngraham wrote: > Device capacity: 94.4 Gib > Device usage:==-- 24% full (71.9 GiB free, 22.5 GiB used) > That's much better. Another proposal built on top of that: Device

D14467: Auth Support: Drop privileges if target is not owned by root

2018-07-29 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: dfaure, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY For actions chown, chmod and utime,

D14451: Add Repo::formatFromId(), Definition::formatFromId() and ::formats()

2018-07-29 Thread Dominik Haumann
dhaumann updated this revision to Diff 38721. dhaumann added a comment. Update REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14451?vs=38720=38721 BRANCH addFormatGetters (branched from master) REVISION DETAIL

D14451: Add Definition::::formats()

2018-07-29 Thread Dominik Haumann
dhaumann retitled this revision from "Add Repo::formatFromId(), Definition::formatFromId() and ::formats()" to "Add Definitionformats()". dhaumann edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14451 To: dhaumann,

D13805: Present error dialog when user tries to create directory named "." or ".."

2018-07-29 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:54298c16f37a: Present error dialog when user tries to create directory named . or .. (authored by tmarshall, committed by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10040: Add serial number and EISA ID to OutputDevice interface

2018-07-29 Thread David Edmundson
davidedmundson updated this revision to Diff 38733. davidedmundson added a comment. Instead of modifying the geometry event use two new events to remain fully compatiable. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25806=38733 BRANCH

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 94 - Still Unstable!

2018-07-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/94/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 29 Jul 2018 19:16:31 + Build duration: 6 hr 57 min and counting JUnit Tests Name:

D14457: Forward-declare X509 structure

2018-07-29 Thread Luca Carlon
luc4 retitled this revision from "Forward-define X509 structure" to "Forward-declare X509 structure". luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4 Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10040: Add serial number and EISA ID to OutputDevice interface

2018-07-29 Thread David Edmundson
davidedmundson updated this revision to Diff 38734. davidedmundson added a comment. exciting whitespace change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=38733=38734 BRANCH output_changes REVISION DETAIL

D14449: Display used space in GiB also

2018-07-29 Thread Nathaniel Graham
ngraham added a comment. +1 for using the same label but putting the information on more than one line like @rkflx suggests. I think there are basically three important pieces of information here: - Percentage free (for people who don't understand what a "GiB" is--the "Simple by

D14449: Display used space in GiB also

2018-07-29 Thread Henrik Fehlauer
rkflx added a comment. In D14449#300327 , @ngraham wrote: > Here's another idea for how to express everything while remaining compact in the horizontal dimension: > > Device capacity: -- 24% full >22.5 GiB

Re: Pre-review CI

2018-07-29 Thread Bhushan Shah
On Sun, Jul 29, 2018 at 05:00:19PM +0200, Friedrich W. H. Kossebau wrote: > 1 job means one huge build log to look at, or? In that case I would prefer > separate jobs. Given review requests are prone to fail. Thing is, you don't care about the pre-review CI jobs as long as they are passing, but

D14449: Display used space in GiB also

2018-07-29 Thread Dominik Haumann
dhaumann added a comment. We have other places where such information is displayed, e.g. the disk quota applet: https://kate-editor.org/2015/08/02/plasma-5-keeping-an-eye-on-the-disk-quota/ Maybe this is useful for input :) REPOSITORY R241 KIO REVISION DETAIL

D14360: Remove custom icon selection for trash

2018-07-29 Thread Shubham
shubham added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D13869: [solid] Notify when interface to mounted fs is lost

2018-07-29 Thread Anthony Fieroni
anthonyfieroni added a comment. Ping, anything unclear ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham