D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij added a comment. Tbh I don't fully understand the `struct` and `find` statments (just saw working similar code and edited-copy-pasted). I prefer if someone can continue this instead of me. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To:

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Stefan Brüns
bruns added a comment. You should start with a) a use case b) show it actually matches the needs of different languages. For e.g. englisch and the most european languages, two different positions are sufficent. Also, the AndListType and the UnitListType are identical. What is

D14707: autotests: skip '/' fstab check with zfs

2018-08-10 Thread Stefan Brüns
bruns added a comment. In D14707#305773 , @dfaure wrote: > OK maybe I misunderstood the comment "Welcome to the wondeful world of / on zfs with boot-environments :)." > > If it's not related to zfs then two options: > > 1. allowing for

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij updated this revision to Diff 39425. safaalfulaij added a comment. Fix test No unrelated changes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14733?vs=39418=39425 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14733

D14733: [KFormat] Add human readable list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij retitled this revision from "[KFormat] Add human readble list displaying function" to "[KFormat] Add human readable list displaying function". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To: safaalfulaij, #frameworks Cc: bruns,

D14732: Actually allow to set the refresh rate for device statistics

2018-08-10 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D14732 To: volkov, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij added a comment. In D14733#306325 , @bruns wrote: > You should start with > a) a use case > b) show it actually matches the needs of different languages. > > For e.g. englisch and the most european languages, two different

D14702: Java: add binaries & hex-float, and support underscores in numbers

2018-08-10 Thread Nibaldo González
nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14702 To: nibags, dhaumann, cullmann, vkrause, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, cullmann, sars,

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Safa Alfulaij
safaalfulaij created this revision. safaalfulaij added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Add formatList() to convert

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 40 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/40/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 Aug 2018 14:43:47 + Build duration: 1 min 16 sec and counting JUnit Tests

D14733: [KFormat] Add human readble list displaying function

2018-08-10 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > kformattest.cpp:396 > + > +QStringList testDate; > +QCOMPARE(format.formatList(testDate), QStringLiteral("")); Why test**Date**? > kformat.h:287 > * > - * e.g. given formatDuration(6), returns "1.0 minutes" > + * e.g.

D14730: Sort returned formats in Definition::formats() by id

2018-08-10 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e23573cc90f3: Sort returned formats in Definition::formats() by id (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14702: Java: add binaries & hex-float, and support underscores in numbers

2018-08-10 Thread Nathaniel Graham
ngraham added a comment. > - BUG 386391 This needs to be on its own line (not as part of a bulleted list) and there needs to be a colon. Like this: `BUG: 386391` REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14702 To: nibags, dhaumann,

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. The KF5_HOST_TOOLING approach in kconfig does not work because it is not poss In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with

Re: purpose unittests on Windows

2018-08-10 Thread Ben Cooksley
On Fri, Aug 10, 2018 at 7:28 PM David Faure wrote: > > Any idea why purpose can't find the KIO http and file protocols -- on Windows? > > https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/76/testReport/junit/(root)/TestSuite/alternativesmodeltest/ > >

D9387: Add cross compile support for kconfig_compiler and kconf_update.

2018-08-10 Thread Ralf Habacker
habacker added a comment. In D9387#180530 , @apol wrote: > Yes, defining KF5_HOST_TOOLING should be enough, kconf_update will need to be exported with kconfigcompiler though, at the moment it's not. that means host tooling support

purpose unittests on Windows

2018-08-10 Thread David Faure
Any idea why purpose can't find the KIO http and file protocols -- on Windows? https://build.kde.org/view/Frameworks/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.10/76/testReport/junit/(root)/TestSuite/alternativesmodeltest/ That's very odd, because the dependency from purpose on kio is

D14730: Sort returned formats in Definition::formats() by id

2018-08-10 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Sorting the formats()

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-10 Thread Nathaniel Graham
ngraham added a comment. +1 conceptually, as this seems relevant to the privacy initiative as well. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14723 To: fvogt, #frameworks Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14666: Fixes memory leak in KUrlComboBox::setUrl

2018-08-10 Thread David Hallas
hallas updated this revision to Diff 39393. hallas added a comment. Rebased REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14666?vs=39265=39393 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14666 AFFECTED FILES

D14724: autotests: don't fail if an unrelated window shows up.

2018-08-10 Thread David Faure
dfaure created this revision. dfaure added reviewers: hein, drosca. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Running anything else in parallel to this test

D14722: KPluginMetaData: convert empty string to empty stringlist.

2018-08-10 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R244:6be0ee1d0e6e: KPluginMetaData: convert empty string to empty stringlist. (authored by dfaure). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

2018-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/46/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 10 Aug 2018 10:14:11 + Build duration: 15 min and counting JUnit Tests

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-10 Thread David Faure
dfaure added a comment. +1, looks good to me (I just wonder how well KDE applications actually behave with KWallet disabled...) REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14723 To: fvogt, #frameworks Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/46/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 Aug 2018 11:30:56 + Build duration: 4 min 35 sec and counting JUnit Tests

Re: KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 46 - Fixed!

2018-08-10 Thread David Faure
On vendredi 10 août 2018 13:35:32 CEST CI System wrote: > BUILD SUCCESS YES !!! :-) Finally. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 18 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/18/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 10 Aug 2018 09:56:46 + Build duration: 54 sec and counting

KDE CI: Frameworks kpackage kf5-qt5 AndroidQt5.11 - Build # 12 - Still Failing!

2018-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20AndroidQt5.11/12/ Project: Frameworks kpackage kf5-qt5 AndroidQt5.11 Date of build: Fri, 10 Aug 2018 09:56:46 + Build duration: 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 24 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 10 Aug 2018 10:14:11 + Build duration: 50 sec and counting

D14666: Fixes memory leak in KUrlComboBox::setUrl

2018-08-10 Thread David Hallas
hallas closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14666 To: hallas, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 213 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/213/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 10 Aug 2018 10:42:36 + Build duration: 5 min 16 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2018-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 Aug 2018 11:24:12 + Build duration: 5 min 11 sec and counting JUnit Tests

D14722: KPluginMetaData: convert empty string to empty stringlist.

2018-08-10 Thread David Faure
dfaure created this revision. dfaure added reviewers: apol, mpyne, davidedmundson, arichardson. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-10 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Frameworks. Restricted Application added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY Users are greeted by this dialog on the first request by any application. Even if they press cancel, the dialog will

D14723: Add option to disable KWallet entirely in the new wallet dialog

2018-08-10 Thread Fabian Vogt
fvogt added a comment. This fixes part of a downstream bug report: https://bugzilla.opensuse.org/show_bug.cgi?id=1104462 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D14723 To: fvogt, #frameworks Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14722: KPluginMetaData: convert empty string to empty stringlist.

2018-08-10 Thread Alex Richardson
arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R244 KCoreAddons BRANCH convert_empty_string_to_stringlist REVISION DETAIL https://phabricator.kde.org/D14722 To: dfaure, apol, mpyne, davidedmundson,

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

2018-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/101/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 Aug 2018 10:14:11 + Build duration: 5 min 48 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

2018-08-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/44/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Fri, 10 Aug 2018 10:22:52 + Build duration: 2 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 212 - Failure!

2018-08-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/212/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 10 Aug 2018 10:22:31 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 19 - Fixed!

2018-08-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/19/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 10 Aug 2018 11:24:11 + Build duration: 34 sec and counting

D14730: Sort returned formats in Definition::formats() by id

2018-08-10 Thread Dominik Haumann
dhaumann updated this revision to Diff 39411. dhaumann added a comment. - Update comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14730?vs=39408=39411 BRANCH sort-formats (branched from master) REVISION DETAIL

D14730: Sort returned formats in Definition::formats() by id

2018-08-10 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think any sorting is better than the current "random" hash order. REPOSITORY R216 Syntax Highlighting BRANCH sort-formats (branched from master) REVISION DETAIL

D14732: Actually allow to set the refresh rate for device statistics

2018-08-10 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. volkov requested review of this revision. REVISION SUMMARY Set the DBus property of the NetworkManager, not the internal property that doesn't

D14732: Actually allow to set the refresh rate for device statistics

2018-08-10 Thread Alexander Volkov
volkov added reviewers: Frameworks, jgrulich. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D14732 To: volkov, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns