D14661: Force reevaluation of Predicates if interfaces are removed

2018-08-14 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Not pretty but if it works.. Thanks! REPOSITORY R245 Solid BRANCH test REVISION DETAIL https://phabricator.kde.org/D14661 To: bruns, #frameworks, broulik, ngraham, apol Cc: apol,

D14661: Force reevaluation of Predicates if interfaces are removed

2018-08-14 Thread Anthony Fieroni
anthonyfieroni added a reviewer: apol. anthonyfieroni added a subscriber: apol. anthonyfieroni added a comment. Since solid does not have a maintainer, you can wait for @apol or @broulik or ship it before 5.50 tagging. REPOSITORY R245 Solid REVISION DETAIL

D11838: Turn on line numbers by default

2018-08-14 Thread Christoph Cullmann
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R40:d7b19c5abffc: turn on line numbers and line modifications per default for Kate (authored by cullmann). CHANGED PRIOR

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fix-replace-newline-empty-lines (branched from master) REVISION DETAIL https://phabricator.kde.org/D14847 To: dhaumann, jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni,

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: jsalatas, ltoscano, kfunk, cullmann, anthonyfieroni, mwolff. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY The problem

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Dominik Haumann
dhaumann abandoned this revision. dhaumann added a comment. Fixed in D14847 in a different way. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: dhaumann, #ktexteditor, jsalatas Cc: kde-frameworks-devel, mwolff,

D14828: remove highlighting download dialog

2018-08-14 Thread René J . V . Bertin
rjvbb added a comment. Downloading already didn't work for me since quite a while (the operation never completed) but what does this mean for highlighting files I write myself (or someone's mom does)? > Other users who do not follow the latest development releases [...] are likely not

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Dominik Haumann
dhaumann updated this revision to Diff 39737. dhaumann added a comment. - Optimize by checking isEmpty() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14847?vs=39736=39737 BRANCH fix-replace-newline-empty-lines (branched from master) REVISION

D14817: Convert manual install test to an autotest

2018-08-14 Thread Luigi Toscano
ltoscano added a comment. This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt 5.10): - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/

D13940: Add syntax highlighting support for Stan

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0a39f67256b3: Add syntax highlighting support for Stan (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13940?vs=37388=39723#toc REPOSITORY R216 Syntax Highlighting

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:c90064799dfb: Fix crash when replacing \n around empty lines (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14847?vs=39737=39738

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-08-14 Thread Nathaniel Graham
ngraham added a comment. So from in-person conversations this week, it seems like we have a few paths forward here: - Upstream the features we wrote into our PlasmaComponents TextField and then just use that. **Downsides**: lengthy process, will take forever before we can actually use

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Dominik Haumann
dhaumann commandeered this revision. dhaumann edited reviewers, added: jsalatas; removed: dhaumann. dhaumann added a comment. Reassign REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: dhaumann, #ktexteditor, jsalatas Cc: kde-frameworks-devel, mwolff,

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok :P REPOSITORY R39 KTextEditor BRANCH fix-replace-newline-empty-lines (branched from master) REVISION DETAIL https://phabricator.kde.org/D14847 To: dhaumann, jsalatas,

D9247: Extend Scripting API to allow executing commands

2018-08-14 Thread Christoph Cullmann
cullmann accepted this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9247 To: dhaumann, cullmann, mwolff, kfunk Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14847: Fix crash when replacing \n around empty lines

2018-08-14 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Better test with (a.isEmpty() && b.isEmpty()) for the special case to avoid comparing long lines again. REPOSITORY R39 KTextEditor REVISION DETAIL

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann, martinwalch, turbov. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This change relicenses the

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. brauch requested review of this revision. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES

D14778: Disable loading of translations when using 'C' locale

2018-08-14 Thread Albert Astals Cid
aacid added a comment. Honestly i think that test in kformattest is wrong and that it should contain it's own small minitranslation so that stuff works fine and then it should be QCOMPARE(format.formatDecimalDuration(10), QStringLiteral("10 milliseconds")); instead of

D14819: Get rid of deprecated QWeakPointer usage

2018-08-14 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Replace by `QPointer` TEST PLAN - Compiles,

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch added reviewers: michalsrb, dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D14826: inline note interface wip #2

2018-08-14 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:765 > +// Draw inline notes > +auto inlineNotes = m_view->inlineNotes(range->line()); > +foreach (const KTextEditor::InlineNote& inlineNote, inlineNotes) { const > katerenderer.cpp:766 > +

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-08-14 Thread David Edmundson
davidedmundson added a comment. > Upstream the features we wrote into our PlasmaComponents TextField and then just use that. Downsides: lengthy process, will take forever before we can actually use it here. Yes, but there's also no real rush from a PC POV. > Finally fix the Qt bug

D12768: Allow wrapping selection off top/bottom of autocomplete results

2018-08-14 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: cullmann, #ktexteditor, sraizada Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, brauch, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7,

D12768: Allow wrapping selection off top/bottom of autocomplete results

2018-08-14 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann added a reviewer: sraizada. cullmann added a comment. I don't think such a behavior change is wanted. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12768 To: cullmann, #ktexteditor, sraizada Cc: dhaumann, cullmann,

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Christoph Cullmann
cullmann closed this revision. cullmann added a comment. Ok, then we just close this and wait for the next update. Thanks for the work on that! REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann,

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 52 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/52/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 14 Aug 2018 21:52:22 + Build duration: 41 sec and counting CONSOLE

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
habacker added a comment. In D14817#308903 , @ltoscano wrote: > This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-08-14 Thread David Edmundson
davidedmundson added a comment. > Placeholder text looks good with fractional scale factors (PC3 and QQC2 ones have this, PC2 and QQC1 ones do not) No, this is where we have crossed wires. PC3, QQC2 and PC2 look good. We control the renderType. Only QQC1 desktop theme has the

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-08-14 Thread Nathaniel Graham
ngraham added a comment. Ah, I'm sorry. I'm getting my patches confused. The PC2 TextField's bug is that it doesn't show placeholder text properly with light themes when software rendering isn't being used. I'm open to other ways of fixing that. REPOSITORY R242 Plasma Framework (Library)

D5802: ViewPrivate, KateSearchBar, KateVi::MatchHighlighter: use selection foreground for search highlights

2018-08-14 Thread Sven Brauch
brauch added a comment. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Can't we simply update our shipped schemas, and expect users with custom schemas to fix them? REPOSITORY R39 KTextEditor REVISION DETAIL

KDE CI: Frameworks kdoctools kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kdoctools kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 Aug 2018 21:24:06 + Build duration: 1 min 1 sec and counting JUnit Tests

D9247: Extend Scripting API to allow executing commands

2018-08-14 Thread Christoph Cullmann
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:72c51e15659f: Extend Scripting API to allow executing commands (authored by dhaumann, committed by cullmann).

D14345: Give the PlasmaComponents3 TextField the ability to have a Clear button

2018-08-14 Thread Nathaniel Graham
ngraham added a comment. To back up a bit, the issue is that we currently have no TextField with has the following characteristics: 1. Has built-in functionality for clear and password reveal buttons, so each client doesn't need to re-invent the wheel (PC2 one has this, PC3, QQC1, and

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Alex Turbov
turbov added a comment. @cullmann, Up to you... When I'll fix it for the cases I've found (trying to write the `hightlighting.rst` test file) I come back w/ a new PR :) REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann,

D12587: Indentation script for R

2018-08-14 Thread Christoph Cullmann
cullmann added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Given it seems nobody has time to do tests, I will merge this. We can still remove it again but just letting rot this nice contribution in the phabricator won't help any R

D12587: Indentation script for R

2018-08-14 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12587 To: devillemereuil, #ktexteditor, #rkward, cullmann Cc: kwrite-devel, kde-frameworks-devel, cullmann, tfry, dhaumann, michaelh,

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
habacker added a comment. I applied a fix to use absolute pathes. Unfortunally windows builds have an additional issue: > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/36/console 21:26:34 -- Installing: C:/CI/workspace/Frameworks kdoctools kf5-qt5

D12587: Indentation script for R

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:467cf37fd04f: Indentation script for R (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12587?vs=33259=39754 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 128 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/128/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 15 Aug 2018 03:45:12 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 198 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/198/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:45:42 + Build duration: 8 min 1 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 48 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/48/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 15 Aug 2018 03:45:46 + Build duration: 6 min 42 sec and counting

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 217 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/217/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 15 Aug 2018 03:45:12 + Build duration: 14 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 218 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/218/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Aug 2018 03:45:12 + Build duration: 18 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 121 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/121/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Wed, 15 Aug 2018 03:45:42 + Build duration: 20 min and counting CONSOLE

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 373 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/373/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:45:11 + Build duration: 1 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 - Build # 124 - Failure!

2018-08-14 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.10/124/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 15 Aug 2018 03:45:42 + Build duration: 19 min and counting

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Anthony Fieroni
anthonyfieroni added a comment. I'm aware of that it will fix the crash but functionally still will be missing, but i'll give a try. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor, dhaumann Cc: kde-frameworks-devel, mwolff,

D14274: Modelines: add byte-order-mark & small fixes

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:bffb66cb3ed8: Modelines: add byte-order-mark small fixes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 153 - Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/153/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 Aug 2018 14:55:59 + Build duration: 1 min 56 sec and counting

D8964: Fix two bugs in KMessageWidget

2018-08-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. I just tested again with KWrite - I think it behaves good there. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8964 To: aacid, #frameworks, dhaumann Cc: kde-frameworks-devel, ngraham, dhaumann,

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 97 - Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/97/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Aug 2018 14:55:59 + Build duration: 6 min 10 sec and counting

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment. Sure, I can do that, but I'd like to get feedback on the final form first :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart,

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:43396e0a9773: Optimize many syntax highlighting files and fix the / char of SQL (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11543?vs=31565=39719#toc REPOSITORY

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread Christoph Feck
On 14.08.2018 15:03, Ben Cooksley wrote: Currently CI jobs are all created within a flat namespace, meaning that it is quite difficult to view the overall status of an individual project. Additionally, it creates the issue that the main default view can take a significant amount of time to load.

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 98 - Still Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/98/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Aug 2018 15:08:04 + Build duration: 1 min 46 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 154 - Still Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/154/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 Aug 2018 15:08:04 + Build duration: 5 min 17 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 155 - Fixed!

2018-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/155/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Tue, 14 Aug 2018 15:13:22 + Build duration: 2 min 15 sec and counting

D14274: Modelines: add byte-order-mark & small fixes

2018-08-14 Thread Christoph Cullmann
cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14274 To: nibags, turbov, dhaumann, cullmann, vkrause, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh,

D14274: Modelines: add byte-order-mark & small fixes

2018-08-14 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. I needed to revert this again, as we get tests failures:

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 99 - Still Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/99/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Aug 2018 15:10:44 + Build duration: 6 min 30 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 100 - Fixed!

2018-08-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/100/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Tue, 14 Aug 2018 15:17:15 + Build duration: 1 min 39 sec and counting

D14778: Disable loading of translations when using 'C' locale

2018-08-14 Thread Ralf Habacker
habacker abandoned this revision. habacker added a comment. How to handle single/plural form then ? QString KFormatPrivate::formatDecimalDuration(quint64 msecs, int decimalPlaces) const { ... //: @item:intext %1 is a whole number //~ singular %n millisecond //~ plural

D14829: Remove warning about old kiosk feature that no longer applies.

2018-08-14 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D14829 To: dfaure, davidedmundson, arichardson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14828: remove highlighting download dialog

2018-08-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. But along with this change, please change the docbook in kate.git: We have doc/katepart/configuring.docbook Download Highlighting Files...

D14828: remove highlighting download dialog

2018-08-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:705f8e0419c4: remove highlighting download dialog (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14828?vs=39686=39688 REVISION DETAIL

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch added a comment. Thanks for the feedback! I will try doing a few more things with this interace and then maybe discuss again with the other kate people here at Akademy about which one they like better. About the tracking, I don't think anything is needed on the side of the

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 - Build # 35 - Unstable!

2018-08-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/35/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.10 Date of build: Tue, 14 Aug 2018 14:07:08 + Build duration: 5 min 38 sec and counting

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

2018-08-14 Thread Laurent Cimon
xciml updated this revision to Diff 39700. xciml added a comment. Hi! Good idea, what about this? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14236?vs=38102=39700 REVISION DETAIL https://phabricator.kde.org/D14236 AFFECTED FILES

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Christoph Cullmann
cullmann added a comment. Hmm, should we not commit this state at least as is? Or do you want to do a new request including a new state & tests? I would be fine with just pushing this as an intermediate step, too. REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate,

D4234: Change algorithm for autobrace.

2018-08-14 Thread Christoph Cullmann
cullmann added a reviewer: brauch. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4234 To: cactus, #ktexteditor, mwolff, brauch Cc: kde-frameworks-devel,

D12295: Supporting nested brackets for Kate autobrackets

2018-08-14 Thread Christoph Cullmann
cullmann added a subscriber: brauch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: sraizada, #ktexteditor, #kate, cullmann, dhaumann Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, bruns, demsking, head7,

D12295: Supporting nested brackets for Kate autobrackets

2018-08-14 Thread Christoph Cullmann
cullmann added a reviewer: brauch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12295 To: sraizada, #ktexteditor, #kate, cullmann, dhaumann, brauch Cc: brauch, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, bruns, demsking,

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Dominik Haumann
dhaumann added a comment. Hm, can you send a patch that fixes this? :-) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor, dhaumann Cc: kde-frameworks-devel, mwolff, anthonyfieroni, dhaumann, kfunk, ltoscano, kwrite-devel,

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Sorry for the delay. Shall we take care of this? REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann,

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Christoph Cullmann
cullmann accepted this revision. REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, #frameworks, michaelh, ngraham, bruns

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-08-14 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess ok - if issues arise, we have to fix them :-) REPOSITORY R216 Syntax Highlighting BRANCH sql2 REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen,

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Herald added a project: Kate. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I was just about to merge this patch. But the crash still happens for

D14826: inline note interface wip #2

2018-08-14 Thread Michal Srb
michalsrb added a comment. Thank you for working on this. This interface would work for the kdev-sourceinfo use case just as well as the old one. I think the problem with the old interface that you described is valid. This version gives more flexibility to the `InlineNotesProvider` with

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment. Sorry folks for the endless period of no activity. After some talking with ngraham I removed the laptop metaphor for a much more general standalone display. Also the projection screen was swapped out. My last feedback was that the window icons were too detailed.

D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Kai Uwe Broulik
broulik added a comment. While you're at it can't you move them to plasma-framework? Having them in Breeze makes it not work with other themes and also they are only shown in the context of Plasma anyway REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Alex Turbov
turbov marked an inline comment as done. turbov added a comment. I'm using this syntax 'till nowadays from my repo... I know about some not covered cases in it, but have no time these days to improve it even more %) Most of the time I quite satisfied w/ it... and sorry for the tests :(

D7245: Improve reStructuredText highlighting

2018-08-14 Thread Alex Turbov
turbov added a comment. You can just close this MR, I'll be back sometime later w/ highlighting example and tests... REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_syntax_highlighting, dhaumann, cullmann Cc: cullmann, dhaumann, #frameworks, michaelh,

D6473: Crash when replacing new lines with spaces

2018-08-14 Thread Anthony Fieroni
anthonyfieroni added a comment. About me when line(...) is accessed it should check for nullptr as well if (auto l = line(a)) { return l->accessor(); }

D14817: Convert manual install test to an autotest

2018-08-14 Thread Ralf Habacker
This revision was automatically updated to reflect the committed changes. Closed by commit R238:f0cc8b2ccb4a: Convert manual install test to an autotest (authored by habacker). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-14 Thread Ralf Habacker
habacker updated this revision to Diff 39684. habacker edited the summary of this revision. habacker added a comment. - after feedback from ecm maintainers the fix could be refactored to not be depending on ecm patch REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch added a comment. Sample patch for KDevelop's problem highlighter plus screenshot: F6192637: hl.png F6192639: inline-problems.diff REPOSITORY R39 KTextEditor REVISION DETAIL

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Dominik Haumann
dhaumann added a comment. For those who are curious: This change is required since modelines.xml is a file that is included in many other xml files via IncludeRules. Given our policy of new highlighting files should be MIT licensed, this also applies to included definitions. That's why this

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Volker Krause
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH relicense-modelines-mit (branched from master) REVISION DETAIL https://phabricator.kde.org/D14824 To: dhaumann, vkrause, cullmann, martinwalch, turbov Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Alex Turbov
turbov accepted this revision. turbov added a comment. I agree w/ relicense REPOSITORY R216 Syntax Highlighting BRANCH relicense-modelines-mit (branched from master) REVISION DETAIL https://phabricator.kde.org/D14824 To: dhaumann, vkrause, cullmann, martinwalch, turbov Cc:

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:857a277110d5: Relicense modelines.xml to MIT license (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14824?vs=39680=39685

D14828: remove highlighting download dialog

2018-08-14 Thread Christoph Cullmann
cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY rational: 1. there is one frameworks release per month

D14829: Remove warning about old kiosk feature that no longer applies.

2018-08-14 Thread David Faure
dfaure closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14829 To: dfaure, davidedmundson, arichardson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch updated this revision to Diff 39692. brauch added a comment. add missing files REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14826?vs=39682=39692 BRANCH inlinenotes REVISION DETAIL https://phabricator.kde.org/D14826 AFFECTED FILES

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread David Faure
On mardi 14 août 2018 15:03:42 CEST Ben Cooksley wrote: > Hi all, > > Currently CI jobs are all created within a flat namespace, meaning > that it is quite difficult to view the overall status of an individual > project. Additionally, it creates the issue that the main default view > can take a

D10587: Restore KTextEditor Document Dbus bindings

2018-08-14 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann edited reviewers, added: lukedashjr; removed: cullmann. cullmann added a comment. As said, I agree a fix for the unsaved documents vs. no swap files problem is wanted, but a single use case is not enough to bring back the dbus overhead per

D10587: Restore KTextEditor Document Dbus bindings

2018-08-14 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: cullmann, dhaumann, gregormi, lukedashjr Cc: kwrite-devel, kde-frameworks-devel, anthonyfieroni, #ktexteditor, #kate, asturmlechner, gregormi, dhaumann, cullmann, michaelh,

D14826: inline note interface wip #2

2018-08-14 Thread Sven Brauch
brauch edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14826 To: brauch, michalsrb, dhaumann, cullmann Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars,

D14824: Relicense modelines.xml to MIT license

2018-08-14 Thread Dominik Haumann
dhaumann added a comment. Thanks, Martin just change the kateversion number, which was changed again later by us again. So I will proceed now. Thanks. REPOSITORY R216 Syntax Highlighting BRANCH relicense-modelines-mit (branched from master) REVISION DETAIL

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

2018-08-14 Thread Albert Astals Cid
aacid added a comment. In D14779#308593 , @habacker wrote: > You have remembered that in this case the loader created by ecm_create_qm_loader(kcoreaddons_QM_LOADER kcoreaddons5_qt) must be adjusted to find this - not installed - fake

  1   2   >