D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

vkrause added a comment. In D11776#318339 , @Martchus wrote: > @vkrause Thanks for confirming. So it is not a local issue. Could you find a workaround (beside reverting these changes)? I edit the file `stl` in the build dir to strip out

D15196: avoid word delimiter check at start of keyword

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15196 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D15196: avoid word delimiter check at start of keyword

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2475bc4dd2ca: avoid word delimiter check at start of keyword (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15076: Build failures with KSyntaxHighlighting 5.49

elvisangelaccio added a comment. Hmm, I can only think of renaming the `cantor` folder to something else (but that would probably be annoying for packagers...) REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks Cc:

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH Applications/18.08 REVISION DETAIL https://phabricator.kde.org/D15113 To: fvogt, #frameworks, elvisangelaccio Cc: lbeltrame

D15113: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bfbef9f61a17: Add license text of GPL 2.0, LGPL 2.0 and LGPL 2.1 (authored by fvogt). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15113?vs=40535=40820

D15196: avoid word delimiter check at start of keyword

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY be compatible with old KTextEditor implementation

D8256: Add _XOPEN_SOURCE to C definitions

dfaure added a comment. Indeed, 22:23:51 In file included from /usr/include/sys/mount.h:36: 22:23:51 /usr/include/sys/ucred.h:84:2: error: unknown type name 'u_int'; did you mean 'uint'? 22:23:51 u_int cr_version; /* structure layout version */ 22:23:51

KDE CI: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesu%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kdesu kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:11 + Build duration: 29 sec and counting

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.11/4/ Project: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:13 + Build duration: 1 min 31 sec and counting

D15207: precompute attribute format for context & rules

This revision was automatically updated to reflect the committed changes. Closed by commit R216:91d29a45389e: precompute attribute format for context rules (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15207: precompute attribute format for context & rules

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, tests are unstable :/ I did run them here now X times, they are stable. Perhaps depending on which highlightings got parsed in which order. Why should then the id's be equal

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/205/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Sep 2018 16:19:43 + Build duration: 8 min 15 sec and counting

D15207: precompute attribute format for context & rules

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2321fc443483: try to fix unit tests (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15207?vs=40827=40830#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/32/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Sep 2018 16:52:18 + Build duration: 3 min 44 sec and

D15211: ::match and ::doMatch => const

cullmann updated this revision to Diff 40834. cullmann added a comment. avoid duplicate storage of pattern REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15211?vs=40833=40834 BRANCH master REVISION DETAIL

D15211: ::match and ::doMatch => const

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY make ::match and ::doMatch const ATM the keyword

D15211: ::match and ::doMatch => const

cullmann updated this revision to Diff 40835. cullmann added a comment. disallow dynamic for stuff we didn't implement REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15211?vs=40834=40835 BRANCH master REVISION DETAIL

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:06 + Build duration: 41 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 204 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/204/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Sep 2018 16:08:38 + Build duration: 3 min 5 sec and counting

D15207: precompute attribute format for context & rules

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY avoid costly lookup, e.g. 3% of runtime of

D7909: Add syntax support for Crystal Programming Language

cullmann added a comment. Hi, any update on this? REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, cullmann Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks,

D15207: precompute attribute format for context & rules

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D15207 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 150 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/150/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Sep 2018 16:19:43 + Build duration: 3 min 2 sec and counting

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#318737 , @cullmann wrote: > Hi, any update on this? Not yet! :) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause,

D8532: [WIP] Restrict file extractor with Seccomp

detlefe added a comment. I'm just an interested user and cannot comment on the question of external plugins. But before this enters a deep sleep, I wonder if at least the //current// patch should find its way into the extractors or into kfilemetadata. A whitelist is the real thing, and

D13700: implement reading of the replaygain tags

astippich added inline comments. INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:944 > Could you check if it is not faster to use QLatin1String here ? At least if my interpretations of callgrind are correct, it's exactly the same. REPOSITORY R286 KFileMetaData REVISION DETAIL

D13700: implement reading of the replaygain tags

astippich updated this revision to Diff 40824. astippich marked 5 inline comments as done. astippich added a comment. - add documentation, remove unrelated changes and debug info - get rid of string comparisons for id3v2 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.11/6/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:10:11 + Build duration: 45 sec and counting

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.11 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.11/14/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:15 + Build duration: 7 min 57 sec and counting

D15207: precompute attribute format for context & rules

cullmann updated this revision to Diff 40826. cullmann added a comment. inline MatchResult, very often used, no need to waste time for calls fix scoping in Repository::definitionForMimeType REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15207: precompute attribute format for context & rules

cullmann added a comment. I inlined the MatchResult, it is used the whole time and given it is purely internal, one doesn't need to waste cycles for having calls to get the two ints and the reference to the stringlist. The implicit constructor now doesn't play around with the stringlist

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 151 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/151/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Sep 2018 16:52:18 + Build duration: 2 min 17 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 206 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/206/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 Date of build: Sat, 01 Sep 2018 16:52:18 + Build duration: 2 min 5 sec and counting

D13700: implement reading of the replaygain tags

bruns added inline comments. INLINE COMMENTS > taglibextractor.cpp:252 > +if (!lstID3v2.isEmpty()) { > +TagLib::ID3v2::UserTextIdentificationFrame *userTextFrame; > +userTextFrame = > TagLib::ID3v2::UserTextIdentificationFrame::find(mpegFile.ID3v2Tag(), >

D15211: ::match and ::doMatch => const

cullmann updated this revision to Diff 40836. cullmann added a comment. lower m_dynamic to the three rules that support it at all REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15211?vs=40835=40836 BRANCH master REVISION DETAIL

D15194: Draw a line separating PlasmaComponents tab bar from its content area

ngraham added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:21 + Build duration: 4 min 25 sec and counting

KDE CI: Frameworks solid kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20FreeBSDQt5.11/4/ Project: Frameworks solid kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:19 + Build duration: 4 min 0 sec and counting

KDE CI: Frameworks kinit kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kinit kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:14 + Build duration: 2 min 39 sec and counting

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:18 + Build duration: 3 min 50 sec and counting

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.11/4/ Project: Frameworks khtml kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:12 + Build duration: 2 min 45 sec and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.11/4/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:10 + Build duration: 2 min 54 sec and counting

KDE CI: Frameworks kjs kf5-qt5 FreeBSDQt5.11 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20FreeBSDQt5.11/3/ Project: Frameworks kjs kf5-qt5 FreeBSDQt5.11 Date of build: Sat, 01 Sep 2018 15:12:17 + Build duration: 3 min 17 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 149 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/149/ Project: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 Date of build: Sat, 01 Sep 2018 16:08:38 + Build duration: 6 min 10 sec and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/30/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 01 Sep 2018 16:08:38 + Build duration: 30 min and

D15207: precompute attribute format for context & rules

cullmann added a comment. :=) The second lookup round over all included rules in the context did really hide some things. Now we properly keep track which context is needed to be used for the lookup. 2321fc443483fb5669f9092980c7ab25bf78778d

D15213: Link 16px icon folders to 16@2

rizzitello retitled this revision from "link 16 to 16@2" to "Link 16px icon folders to 16@2". rizzitello added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham,

D15212: Create links for 16@2 icons

rizzitello edited the summary of this revision. rizzitello added reviewers: VDG, Plasma. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15212 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15213: link 16 to 16@2

rizzitello created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rizzitello requested review of this revision. REVISION SUMMARY Create simlinks for all size 16 folders to 16@2 See D6313 Todo : add

D15194: Draw a line separating PlasmaComponents tab bar from its content area

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15212: Create links for 16@2 icons

rizzitello created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rizzitello requested review of this revision. REVISION SUMMARY Signed-off-by: Chris Rizzitello REPOSITORY R266 Breeze Icons BRANCH 2xScaleLinks REVISION DETAIL

D15212: Create links for 16@2 icons

rizzitello abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15212 To: rizzitello, #vdg, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns