D13880: [KMoreTools] Reduce menu hierarchy

2018-09-15 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH arcpatch-D13880 REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

2018-09-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R304:9f54611a472d: [KMoreTools] Reduce menu hierarchy (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13880?vs=41581=41716 REVISION DETAIL

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 71 - Unstable!

2018-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/71/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 15 Sep 2018 21:56:22 + Build duration: 1 min 36 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 112 - Unstable!

2018-09-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/112/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 15 Sep 2018 21:56:22 + Build duration: 3 min 17 sec and counting JUnit Tests Name: (root)

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-15 Thread Dominik Haumann
dhaumann added a comment. I commented on some things - I did not try this, though. What I would like to see is a comment // KF6: Merge KTextEditor::AnnotationViewInterfaceV2 into KTextEditor::AnnotationViewInterface (kossebau). For me, this comment is really important, since this

D15527: Remove assumption about the barcode aspect ratio from the QML integration

2018-09-15 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15527 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15526: Fix rendering glitches caused by rounding errors in Code 128

2018-09-15 Thread Sune Vuorela
svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15526 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

2018-09-15 Thread Dominik Haumann
dhaumann added a comment. FYI: This now landed with 88be459559448d9d30b33f33b3ffd31fc41327c7 (cf. https://commits.kde.org/kinit/88be459559448d9d30b33f33b3ffd31fc41327c7) REPOSITORY R303 KInit REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-15 Thread jonathan poelen
jpoelen added a comment. Sorry to answer so late, I had trouble logging in. I think I misinterpreted the use of `includedDefinitions()`. For me, this function lists the languages ​included by the rules and which influence the colors. While the inclusion of a keyword list has no

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

2018-09-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 41718. ngraham added a comment. - Only allow one upload job at a time; if one is already going, restart it REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15318?vs=41374=41718 BRANCH samba-auto-re-upload-after-save

D15318: Automatically re-upload saved files located on remote locations instead of asking first

2018-09-15 Thread Nathaniel Graham
ngraham retitled this revision from "[WIP] Automatically re-upload saved files located on remote locations instead of asking first" to "Automatically re-upload saved files located on remote locations instead of asking first". ngraham edited the summary of this revision. ngraham edited the test

D15318: Automatically re-upload saved files located on remote locations instead of asking first

2018-09-15 Thread Nathaniel Graham
ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, bruns

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

2018-09-15 Thread Christophe Giboudeaux
On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote: > Hi all, > > Please see below. If someone could please take a look and fix this failure > that would be appreciated. > > On another note, the Marble build recently broke with a similar error - has > something been changed in

D15511: Add support for Code 128 barcodes

2018-09-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:fa3f31329aea: Add support for Code 128 barcodes (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15511?vs=41659=41685 REVISION DETAIL

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

2018-09-15 Thread Luca Beltrame
lbeltrame added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15426 To: fvogt, #frameworks, elvisangelaccio, dfaure Cc: ngraham, bruns, kde-frameworks-devel, michaelh

Re: ABI break in KNewStuff

2018-09-15 Thread Jonathan Riddell
On Fri, Sep 14, 2018 at 06:05:26PM +0100, David Edmundson wrote: > Packagers, > > There's an ABI break in KNewStuff 5.55 > > (2ad3e66d81b63495a59d012f673af7bd854b53d7) > > It's released now, I don't think we have any option as fixing it would mean we > have 2 ABI breaks. > > Can people please

Re: ABI break in KNewStuff

2018-09-15 Thread David Edmundson
>2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest KNewStuff release 5.50, Oh. Thank goodness for people running various CI builds. @packagers, sorry for the noise @Jonathan That's handy. Go ahead and revert.

D15526: Fix rendering glitches caused by rounding errors in Code 128

2018-09-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15526 AFFECTED FILES

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-09-15 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 41694. kossebau added a comment. fix crash due to (no longer needed) circular dependencies on view object constrctions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=41225=41694 BRANCH

D15525: Fix rendering Aztec codes with an aspect ratio != 1

2018-09-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D15525 AFFECTED FILES src/lib/aztecbarcode.cpp

D15527: Remove assumption about the barcode aspect ratio from the QML integration

2018-09-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY So far this only really worked for square 2d barcodes but produced very narrow results for 1d codes. Now the 1d codes

Re: ABI break in KNewStuff

2018-09-15 Thread Jonathan Riddell
Now reverted On Sat, 15 Sep 2018 at 11:56, David Edmundson wrote: > > >2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest > >KNewStuff release 5.50, > > Oh. Thank goodness for people running various CI builds. > @packagers, sorry for the noise > > @Jonathan > That's handy.

D6513: Add support for Attica tags support

2018-09-15 Thread Dan Leinir Turthra Jensen
leinir reopened this revision. leinir added a comment. This revision is now accepted and ready to land. In D6513#326519 , @rikmills wrote: > In D6513#326071 , @ngraham wrote: > > > FYI, this included

D6513: Add support for Attica tags support

2018-09-15 Thread Rik Mills
rikmills added a comment. In D6513#326071 , @ngraham wrote: > FYI, this included an ABI change to `SearchRequest` that broke Discover: https://bugs.kde.org/show_bug.cgi?id=398412 I see this revision has been reverted in master in

D14757: Warn user before copy/move operation if available space is not enough

2018-09-15 Thread Nathaniel Graham
ngraham added a comment. We don't actually need to create a messagebox because it's up to the caller to display the error in an appropriate manner. For example, Dolphin shows errors inline rather than with dialog boxes. So we shouldn't create a messagebox at all. Let's see if we can