D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Anthony Fieroni
anthonyfieroni added a comment. LGTM +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D15623 To: jtamate, #frameworks, sitter Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 42018. ngraham added a comment. - Address review comments and do it better REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15583?vs=41873=42018 BRANCH fix-hyphen-in-name (branched from master) REVISION DETAIL

D15421: [server] Add surface data proxy mechanism

2018-09-20 Thread Roman Gilg
romangg added a dependent revision: D15627: [xwl] Drag and drop between Xwayland and Wayland native clients. REVISION DETAIL https://phabricator.kde.org/D15421 To: romangg, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I like the brick wall metaphor, which does a good job of communicating the point, while being visually distinct from the shield. Looks great to me! Let's see if any other VDG folks

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham
ngraham planned changes to this revision. ngraham added a comment. Actually it looks like we shouldn't even use it anyway for other reasons per the documentation: https://doc.qt.io/qt-5/qdir.html#separator They recommend always using `/` directly like you indicate, so I'll do that.

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh,

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis
ndavis added a comment. https://developer.gnome.org/icon-naming-spec/ > | security-high | The icon used to indicate that the security level of a connection is known to be secure, using strong encryption and a valid certificate.

D15559: Python bindings: use cmake_parse_arguments, fix documentation

2018-09-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This is technically not 100% source compatible, but since the callers were already passing "TARGET" (and others) as documented, I guess it's fine. REPOSITORY R240 Extra CMake Modules

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as pointed out in D13700

D15611: [KCollapsibleGroupBox] Respect styles that disable widget animations

2018-09-20 Thread Kai Uwe Broulik
broulik added a comment. `SH_Widget_Animate` is deprecated in favor of `SH_Widget_Animation_Duration` introduced in Qt 5.10, so perhaps this needs an `ifdef` REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks Cc: broulik, ngraham,

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis added a comment. Hmm. Something is preventing me from changing the name of firewall-applet to firewall-applet-panic (apps/22) and vice versa. I own all of the files in that directory (noah:users), but the file names keep being reset to their current state. REPOSITORY R266 Breeze

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41973. ndavis added a comment. Fix mixed up firewall-applet and firewall-applet-panic (22px) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11880?vs=41972=41973 BRANCH firewalld-icons (branched from master)

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich added a comment. The removal of the convertWCharsToQString function is safe, right? It was never exported REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15614 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY If the notification is deleted from the hash, when the notification::id is

D15623: Finish the notification before removing it from the hash

2018-09-20 Thread Kai Uwe Broulik
broulik added a reviewer: sitter. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D15623 To: jtamate, #frameworks, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck added a comment. Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10. Would KMessageWidget need the same change? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks Cc: broulik,

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-20 Thread Stefan Brüns
bruns added a comment. Can you rebase, please? And upload the patch with `arc diff`, to have the full context available. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel,

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-20 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Anthony Fieroni
anthonyfieroni added a comment. In Qt 5.9 (if i remember correct) was introduced to not have trailing '/' so, QDir::separator should not be used, so better get folder as copy for (QString folder : folders) { if (!folder.endsWith(QLatin1Char('/')) { folder +=

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15618 To: pstefan, #breeze, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham
ngraham added reviewers: Breeze, VDG. ngraham added a comment. Wow, that was fast. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15618 To: pstefan, #breeze, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks, this looks perfect for the 16px size! But we'll need the same change for the 22, 24, and 23 px sizes too. Could you do those, too? REPOSITORY R266 Breeze Icons

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck updated this revision to Diff 41978. cfeck retitled this revision from "[KCollapsibleGroupBox] Respect styles that disable widget animations" to "[KCollapsibleGroupBox] Respect style's widget animation duration". cfeck edited the summary of this revision. cfeck edited the test plan for

D15559: Python bindings: use cmake_parse_arguments, fix documentation

2018-09-20 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R240:b322901ca22f: Python bindings: use cmake_parse_arguments, fix documentation (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D15583: [Balooctl] fix directory parent check

2018-09-20 Thread Christoph Feck
cfeck resigned from this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15583 To: ngraham, #baloo, #dolphin, bruns, #frameworks Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan
pstefan created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pstefan requested review of this revision. REVISION SUMMARY Response to bug 398850 TEST PLAN Works for me REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. In D15611#328821 , @cfeck wrote: > Indeed Breeze style was already updated to return the actual configured duration on Qt 5.10. > >

D15614: remove usage of own TString to QString conversion function

2018-09-20 Thread Matthieu Gallien
mgallien added a comment. In D15614#328722 , @astippich wrote: > The removal of the convertWCharsToQString function is safe, right? It was never exported It is a static function. So it is absolutely safe to remove it. REPOSITORY R286

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis retitled this revision from "Add firewalld icons" to "Add firewall-config and firewall-applet icons". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15615: bump required taglib version

2018-09-20 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY some of the functionality added in D12320

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis added a comment. Regular F6275107: Screenshot_20180920_052849.png Panic F6275109: Screenshot_20180920_053034.png Not sure if I want to try to cause an error on my own system just to show how the

D11880: Add firewalld icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41971. ndavis added a comment. 1. Updating D11880 : Add firewall-config and firewall-applet icons # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject,

D11880: Add firewall-config and firewall-applet icons

2018-09-20 Thread Noah Davis
ndavis updated this revision to Diff 41972. ndavis added a comment. 1. Updating D11880 : Add firewall-config and firewall-applet icons # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject,

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Christoph Feck
cfeck added a comment. In D15611#328845 , @ngraham wrote: > In D15611#328821 , @cfeck wrote: > > > Would KMessageWidget need the same change? > > > Yeah, I think so. No sense in having a

D15611: [KCollapsibleGroupBox] Respect style's widget animation duration

2018-09-20 Thread Nathaniel Graham
ngraham added a comment. That would only affect the speed of appearing and disappearing though, right? Not the total duration that is status on the screen. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D15611 To: cfeck, #frameworks, ngraham Cc: broulik,

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfecto! REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D15618 To: pstefan, #breeze, #vdg, ngraham Cc: ngraham, kde-frameworks-devel,

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15618 To: pstefan, #breeze, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan
pstefan updated this revision to Diff 41987. pstefan added a comment. Add missing sizes REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15618?vs=41982=41987 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15618 AFFECTED FILES

D15618: Add plus symbol to document-new.svg

2018-09-20 Thread Phil Stefan
pstefan added a comment. Oops, sorry. Should be fixed now! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15618 To: pstefan, #breeze, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-09-20 Thread Andres Betts
abetts added a comment. In D15194#328651 , @romangg wrote: > If there are more items than space available in the list a line is drawn already now to indicate that there are more items to come by scrolling down. Does this not conflict with the

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

2018-09-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/52/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 20 Sep 2018 14:11:22 + Build duration: 1 min 17 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 108 - Still Unstable!

2018-09-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/108/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 20 Sep 2018 14:11:22 + Build duration: 4 min 3 sec and counting JUnit Tests Name: (root)