D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#331727 , @ngraham wrote: > @bruns, do you know if Solid (and by extension, the Places panel) shows Windows disks when Dolphin is run on Windows? > > Side note: does anyone run Dolphin on Windows? Do we

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli added a comment. In D14631#303886 , @aacid wrote: > As far as i can see none of these headers get installed so should they all be renamed to _p.h ? > > Also if the headers don't get installed how do you use the new classes?

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli updated this revision to Diff 42324. emateli marked 15 inline comments as done. emateli added a comment. - Code style fixes - use .insert instead of [] - Indent Q_OBJECT - use isEmpty instead of len==0 - use aggregate initialization - protected -> private - added parent

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#331700 , @davidedmundson wrote: > They don't. > > Why are you changing the if (windows) code path above the elif? Note this is `_WIN32_WCE`, i.e. dead code. WCE is no more supported by any half way

D15721: Make lock on plasmavault icon visible with breeze-dark

ndavis added a comment. In D15721#331723 , @ngraham wrote: > FYI, this earned a place in next week's Usability & Productivity report . :) Thanks, I really like that

D15721: Make lock on plasmavault icon visible with breeze-dark

ngraham added a comment. In D15721#331785 , @ndavis wrote: > Thanks, I really like that series. It gives a real feeling of forward momentum for KDE. Yep, that's one of the big reasons why I do it. :) REPOSITORY R266 Breeze Icons

D15739: [Places panel] Don't show Root by default

ngraham added a comment. Thanks @bruns! So it looks like the Windows code can go after all. @davidedmundson? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, davidedmundson Cc: bruns, davidedmundson, abetts, svenmauch, broulik,

D15740: Use non deprecated fastInsert in baloo

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Replace the deprecated uds insert method by fastInsert.

D7446: [Places panel] Add a Recently Used item by default

svenmauch added a comment. While I wouldn't use it (yet?) I think it's a great addition and would benefit a lot of people. I give it a +1, especially if D15739 gets approved aswell. ;) REPOSITORY R241 KIO REVISION DETAIL

D15721: Make lock on plasmavault icon visible with breeze-dark

ndavis added a comment. In D15721#331388 , @ngraham wrote: > Can you provide steps to reproduce the problem so I can test it? In my naive testing, the `plasmavault` icon looks like a lock and shows up fine on both Breeze Light and Breeze Dark.

D15739: [Places panel] Don't show Root by default

svenmauch added a comment. All arguments make sense. It even looks a lot better without the red folder icon. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh,

D15635: Use String to store UDS_USER and UDS_GROUP of String type.

dfaure accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15635 To: jtamate, dfaure, #baloo, #frameworks, ngraham Cc: ngraham, broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15739: [Places panel] Don't show Root by default

broulik added a comment. +1 it's an entry I always hide when I setup someone's computer REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

broulik added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15402 To: broulik, #dolphin, ngraham Cc: kde-frameworks-devel, kfm-devel,

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

anthonyfieroni added a comment. Looks good +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15402 To: broulik, #dolphin, ngraham Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros,

D15741: Use correct MaximumSize

broulik created this revision. broulik added reviewers: Frameworks, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The maximum size for local thumbnails was raised form 5

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli updated this revision to Diff 42298. lsartorelli added a comment. Added remainder message box with keyboard shortcut, to have back the menu bar. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42101=42298 REVISION DETAIL https://phabricator.kde.org/D15644

D15740: Use non deprecated fastInsert in baloo

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15740 To: jtamate, dfaure, #frameworks, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15745: Implement Media and MediaEndpoint API

mweichselbaumer created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES src/CMakeLists.txt

D15718: Do not index the path if the path has no execute permissions.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten, bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:60 > > -QCOMPARE(extractedTitle, QStringLiteral("Title1")); > -QCOMPARE(extractedArtist, QStringLiteral("Artist1")); > -QCOMPARE(extractedAlbum, QStringLiteral("Album1")); > +QCOMPARE(extractedTitle,

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

aacid added a comment. In D14631#331827 , @emateli wrote: > @aacid Would be great if you'd point me towards making them installable. Only the dialog itself should be exported. install(FILES ${KIOWidgets_HEADERS}

D15718: Do not index the path if the path has no execute permissions.

smithjd added a comment. xattrs are no good for vaults because the xattr is ignored for the mountpoint, only restored when the volume is unmounted. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15718 To: smithjd, ngraham, #baloo, ltoscano Cc: ltoscano, marten,

D15740: Use non deprecated fastInsert in baloo

ngraham accepted this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15740 To: jtamate, dfaure, #frameworks, broulik, #baloo, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15740: Use non deprecated fastInsert in baloo

ngraham added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15740 To: jtamate, dfaure, #frameworks, broulik, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15644: Provide option to hide menu bar for Ksysguard

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Wonderful. I think the warning is good enough for now until we can come up with a better way of handling this. Code looks good! Can you provide your full name and email address so I can

D15745: Implement Media and MediaEndpoint API

broulik added a reviewer: drosca. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

mweichselbaumer updated this revision to Diff 42313. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42300=42313 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES src/CMakeLists.txt src/a2dp-codecs.h src/interfaces/org.bluez.Media1.xml

D15635: Use String to store UDS_USER and UDS_GROUP of String type.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:95af521127c1: Use String to store UDS_USER and UDS_GROUP of String type. (authored by jtamate). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15635?vs=42044=42314

D15740: Use non deprecated fastInsert in baloo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a931be1d7e3a: Use non deprecated fastInsert in baloo (authored by jtamate). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15740?vs=42283=42315 REVISION DETAIL

D15739: [Places panel] Don't show Root by default

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

mweichselbaumer marked 5 inline comments as done. mweichselbaumer added inline comments. INLINE COMMENTS > broulik wrote in media_p.h:37 > Any particular reason this class must inherit `QObject`, you don't seem to be > using `signal` or `slot` in it MediaPrivate will later act as parent for

D15721: Make lock on plasmavault icon visible with breeze-dark

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah thanks. For some reason Cuttlefish was not displaying the icon properly. :/ Can confirm the problem and that this fixes it! Will land the patch shortly. REPOSITORY R266 Breeze

D15721: Make lock on plasmavault icon visible with breeze-dark

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f729894087c6: Make lock on plasmavault icon visible with breeze-dark (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/109/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Sep 2018 16:51:05 + Build duration: 1 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/53/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 25 Sep 2018 16:51:05 + Build duration: 4 min 17 sec and counting JUnit Tests Name: (root)

D15721: Make lock on plasmavault icon visible with breeze-dark

ngraham added a comment. FYI, this earned a place in next week's Usability & Productivity report . :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15721 To: ndavis, #vdg, ngraham Cc:

D11880: Add firewall-config and firewall-applet icons

ngraham accepted this revision. ngraham added a comment. Never mind, it's a Cuttlefish issue. Everything looks good to me. Do we have final sign-off by other #VDG folks? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from

D15739: [Places panel] Don't show Root by default

davidedmundson added a comment. No idea. It isn't the same as adding root as it adds every drive quite deliberately. There is a solid windows device back end, but it needs asking someone. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham,

D15739: [Places panel] Don't show Root by default

ngraham added a subscriber: bruns. ngraham added a comment. @bruns, do you know if Solid (and by extension, the Places panel) shows Windows disks when Dolphin is run on Windows? Side note: does anyone run Dolphin on Windows? Do we distribute it at all? REPOSITORY R241 KIO REVISION

D15745: Implement Media and MediaEndpoint API

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks good apart from the coding style. Also it would be great to have at least basic autotest. INLINE COMMENTS > media.h:95 > + > +friend class MediaPrivate; > +}; Not

D15745: Implement Media and MediaEndpoint API

broulik added inline comments. INLINE COMMENTS > media_p.h:35 > + > +class MediaPrivate : public QObject > +{ I think this needs `Q_DECL_HIDDEN` > media_p.h:37 > +{ > +Q_OBJECT > + Any particular reason this class must inherit `QObject`, you don't seem to be using `signal` or `slot` in

D15745: Implement Media and MediaEndpoint API

drosca added inline comments. INLINE COMMENTS > broulik wrote in media_p.h:35 > I think this needs `Q_DECL_HIDDEN` Why? This class is not exported by default, afaik it is only needed if MediaPrivate was declared inside Media class (eg. Media::MediaPrivate), which it is not. REPOSITORY R269

D15644: Provide option to hide menu bar for Ksysguard

lsartorelli added a comment. Thank you very much, I am so happy and proud for my first patch. Here my details: Name: Luca Surname: Sartorelli Mail: dj3...@gmail.com And here is the patch for gwenview: https://phabricator.kde.org/D15747 Just added you as reviewer 2

D11880: Add firewall-config and firewall-applet icons

ngraham added a comment. Hmm, I still get the issue in Cuttlefish after clearing the cache. Is anyone else able to reproduce this issue with viewing the icons in Cuttlefish and turning on "Inverted"? REPOSITORY R266 Breeze Icons BRANCH firewalld-icons (branched from master)

D15739: [Places panel] Don't show Root by default

ngraham added a comment. Do four +1s amount to any formal Accept statuses? ;-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg Cc: abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. They don't. Why are you changing the if (windows) code path above the elif? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To:

D15402: [Thumbnails] Paint larger "one thumbnail" tile only when needed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems fine to me. Code looks sane and behavior appears to be unchanged. Maybe faster, but that might just be confirmation bias talking. :) REPOSITORY R320 KIO Extras REVISION DETAIL

D15718: Do not index the path if the path has no execute permissions.

ngraham added a comment. So the goal is to be able to turn off indexing for certain files? Baloo already has a global toggle to stop indexing anything, and you can also add folders to the exclude lists. But stepping back even farther: //why// do we want to turn off indexing for

D15741: Use correct MaximumSize

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15741 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham,

D15739: [Places panel] Don't show Root by default

ngraham added a comment. In D15739#331700 , @davidedmundson wrote: > They don't. > > Why are you changing the if (windows) code path above the elif? Because that's the windows equivalent of adding Root. I reasoned that if we don't

D15644: Provide option to hide menu bar for Ksysguard

ngraham added a comment. Actually, reading over this again, is it really necessary to add a `showMessage` parameter to `toggleShowMenuBar`? In general bool-only arguments are frowned upon because they're not very readable; enums are preferred in their place. But do we even need that