D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:c413d83851c5: remove own implementation of QString to TString conversion for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-28 Thread Alexander Stippich
astippich updated this revision to Diff 42525. astippich added a comment. - use suggested test pattern REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15714?vs=42270=42525 BRANCH taglib_write_unicode REVISION DETAIL

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

2018-09-28 Thread Christoph Feck
cfeck accepted this revision. cfeck added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > icoutils_common.cpp:85 > +// QTBUG-70812: for files with incorrect bits per pixel, > QImageReader::canRead() returns > +// false but it can still correctly

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-28 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:152 > +<< QStringLiteral("audio/opus") > +<< QStringLiteral("€") > ; ^ unicodeTestStringSuffix ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich,

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-28 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibwritertest.cpp:73 > Can this give failures on windows similar to D14122 > ? Yes, probably. Although, this gives also a pointer to a different approach: // Add some unicode characters,

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-09-28 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY as a preparation for more test data, move all tags that

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-28 Thread Stefan Brüns
bruns added a comment. +1 @svuorela ? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:209 > +QWindow *parentWindow = q->transientParent(); > +bool inDock = parentWindow && !parentWindow->mask().isNull() && > KWindowSystem::compositingActive(); > + How does parentWindow->mask relate to being a dock or

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

2018-09-28 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Looping over `word` without bounds check may cause illegal memory accesses,

D15643: Android: Allow passing a relative path as the apk dir

2018-09-28 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R240:453ba4fee312: Android: Allow passing a relative path as the apk dir (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: Re: KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Still Failing!

2018-09-28 Thread Ben Cooksley
On Wed, Sep 19, 2018 at 7:25 AM Ben Cooksley wrote: > > On Wed, 19 Sep 2018, 02:50 David Faure, wrote: >> >> Hmm So we need to kill it? > > > Except regular kill doesn't work. It's immune to that. > > Process Explorer (Sysinternals) and Task Manager (built in) can kill it > though, not

D15805: [Fstab] Remove Tru64 (__osf__) support

2018-09-28 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL https://phabricator.kde.org/D15805 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15806: [Fstab] Remove AIX support

2018-09-28 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH os_cleanup REVISION DETAIL https://phabricator.kde.org/D15806 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

2018-09-28 Thread Laurent Montel
mlaurent accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 156 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/156/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Sep 2018 11:06:10 + Build duration: 2 min 41 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 231 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/231/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 28 Sep 2018 11:06:10 + Build duration: 13 min and counting JUnit Tests Name: (root)

D15643: Android: Allow passing a relative path as the apk dir

2018-09-28 Thread Aleix Pol Gonzalez
apol added a comment. Are you sure you applied the patch properly? You are getting the warning that we are guarding against. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15643 To: apol, #frameworks, #gcompris Cc: jjazeix, kde-frameworks-devel,

D15643: Android: Allow passing a relative path as the apk dir

2018-09-28 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 42483. apol added a comment. Rebased REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15643?vs=42046=42483 BRANCH arcpatch-D15643 REVISION DETAIL https://phabricator.kde.org/D15643 AFFECTED FILES

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --it creates a much better and consistent visual effect when applets pop

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added a comment. F6291922: εικόνα.png (before) F6291928: εικόνα.png (after) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos,

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Nathaniel Graham
ngraham added a comment. A big improvement! Even better would be a little downward-pointing triangle pointing to the thing that spawned it. Here's a visual example from macOS with a vertical Dock: F6291932: macOS.png REPOSITORY R242 Plasma Framework

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Kai Uwe Broulik
broulik added a comment. The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on all side for regular panel popups REPOSITORY R242 Plasma Framework (Library) REVISION

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Andres Betts
abetts added a comment. I like both ideas so far. Great improvement! Would it be too hard to create the pointer triangle? I think it make so much sense. That way the poppup doesn't feel like it is floating out of nowhere. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D15812: Don't crash if person gets removed

2018-09-28 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH person-remove (branched from master) REVISION DETAIL https://phabricator.kde.org/D15812 To: poboiko, #frameworks, dvratil, apol, davidedmundson Cc: kde-frameworks-devel,

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

2018-09-28 Thread Vlad Zagorodniy
zzag added a comment. Ping. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D15353 To: zzag, #kwin Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

2018-09-28 Thread Stefan Brüns
bruns added a comment. The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the commit message. INLINE COMMENTS > kwalletd.cpp:685 > +const auto errorStr = >

D15704: increase test coverage of taglibwriter

2018-09-28 Thread Alexander Stippich
astippich updated this revision to Diff 42519. astippich added a comment. - remove untested mime types and sort REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15704?vs=42196=42519 BRANCH taglib_write_mimetypes REVISION DETAIL

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-09-28 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:73 > If safeguarding against bad editors is really necessary, better do it here. > Alternatively, you can use C++11 unicode string literals, e.g. > `QString(u"€")` > If you save that one as e.g. latin1 and try

D15778: Log wallet open failure errors

2018-09-28 Thread Arjun AK
arjun added a comment. I don't see a merge button, Am i supposed to push it via git? REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15220: implement more basic tags for taglibwriter

2018-09-28 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:0f16dd4d4cbf: implement more basic tags for taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15220?vs=41856=42518

D15704: increase test coverage of taglibwriter

2018-09-28 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_write_mimetypes REVISION DETAIL https://phabricator.kde.org/D15704 To: astippich, mgallien, bruns Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov,

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Alexander Stippich
astippich added a comment. In D15715#333567 , @bruns wrote: > Thx! Can you also add some line breaks at ~80 chars? ;-) sure :) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich,

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_write_string REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D15715: remove own implementation of QString to TString conversion for taglibwriter

2018-09-28 Thread Stefan Brüns
bruns added a comment. Thx! Can you also add some line breaks at ~80 chars? ;-) REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15715 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D15704: increase test coverage of taglibwriter

2018-09-28 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:ae3c38293421: increase test coverage of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15704?vs=42519=42521#toc REPOSITORY R286 KFileMetaData CHANGES

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 58 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/58/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 29 Sep 2018 01:54:43 + Build duration: 5 min 22 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/114/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 29 Sep 2018 01:54:43 + Build duration: 3 min 12 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/111/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 29 Sep 2018 03:59:28 + Build duration: 1 min 16 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/55/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 29 Sep 2018 03:59:28 + Build duration: 4 min 33 sec and counting JUnit Tests Name: (root)

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:209 > How does parentWindow->mask relate to being a dock or not? > > Also we need to be a bit careful on names. > _NET_WM_WINDOW_TYPE_DOCK is all panels, including the standard plasma one. The idea was first

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 42536. mvourlakos added a comment. - dont use mask() to identify popups placement REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15821?vs=42510=42536 BRANCH maskPositioning REVISION DETAIL

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos
mvourlakos added inline comments. INLINE COMMENTS > dialog.cpp:910 > const bool outsideParentWindow = ((winInfo.windowType(NET::AllTypesMask) > == NET::Dock) || (item->window()->flags() & Qt::X11BypassWindowManagerHint)) > -&& item->window()->mask().isNull(); > +

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added a comment. In D15814#13 , @broulik wrote: > The idea is fine in principle but Plasma may also set a mask on its panels, noticeably in non-composited case for rounded corners, so when I disable compositing I get borders on

D15812: Don't crash if person gets removed

2018-09-28 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. Thanks! REPOSITORY R307 KPeople BRANCH person-remove (branched from master) REVISION DETAIL https://phabricator.kde.org/D15812 To: poboiko, #frameworks, dvratil, apol, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

2018-09-28 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: ngraham, anthonyfieroni. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ico files mostly contain PNGs these days which

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 42489. mvourlakos added a comment. - do not consider dock for !compositing REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15814?vs=42480=42489 BRANCH dockBorders REVISION DETAIL

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added a comment. In D15814#10 , @ngraham wrote: > A big improvement! Even better would be a little downward-pointing triangle pointing to the thing that spawned it. Here's a visual example from macOS with a vertical Dock:

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Nathaniel Graham
ngraham added a comment. A downward-pointing triangle doesn't make sense for pop-ups with a standard Plasma panel because pop-ups appear to slide out of panels, and they're always touching one another. So there is never a question about what the parent is. Latte has a different visual style

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Andres Betts
abetts added a comment. In D15814#85 , @mvourlakos wrote: > In D15814#10 , @ngraham wrote: > > > A big improvement! Even better would be a little downward-pointing triangle pointing to the

D15818: [Exe Thumbnailer] Ignore depth > 32

2018-09-28 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: anthonyfieroni. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The depth information is read unaltered from the `ico` file

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

2018-09-28 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15819 To: broulik, ngraham, anthonyfieroni Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15805: [Fstab] Remove Tru64 (__osf__) support

2018-09-28 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R245:6311a18d64ac: [Fstab] Remove Tru64 (__osf__) support (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15805?vs=42444=42470 REVISION DETAIL

D15812: Don't crash if person gets removed

2018-09-28 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Frameworks, dvratil, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Currently, right after removing a person (which i.e. removes it

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 157 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/157/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 28 Sep 2018 11:18:35 + Build duration: 6 min 9 sec and counting JUnit Tests Name:

D15806: [Fstab] Remove AIX support

2018-09-28 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R245:05b26d0b23d9: [Fstab] Remove AIX support (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15806?vs=42445=42471 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 232 - Still Unstable!

2018-09-28 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/232/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 28 Sep 2018 11:19:35 + Build duration: 12 min and counting JUnit Tests Name: (root)

D15812: Don't crash if person gets removed

2018-09-28 Thread Igor Poboiko
poboiko closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15812 To: poboiko, #frameworks, dvratil, apol, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14162: Figure out the escaped path list on kconfig

2018-09-28 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 42504. apol added a comment. Removed optimisation REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14162?vs=39182=42504 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14162 AFFECTED FILES

D5197: Make it possible to use the fetched translations

2018-09-28 Thread Aleix Pol Gonzalez
apol abandoned this revision. Herald added a project: KDE Edu. Herald added a subscriber: kde-edu. REPOSITORY R325 KAlgebra REVISION DETAIL https://phabricator.kde.org/D5197 To: apol, #frameworks Cc: kde-edu, ltoscano, narvaez, apol

D14162: Fix issue when reading path lists

2018-09-28 Thread Aleix Pol Gonzalez
apol retitled this revision from "Figure out the escaped path list on kconfig" to " Fix issue when reading path lists". apol edited the summary of this revision. apol edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D14162 To:

D14162: Fix issue when reading path lists

2018-09-28 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D14162 To: apol, #frameworks, dfaure Cc: dfaure, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15643: Android: Allow passing a relative path as the apk dir

2018-09-28 Thread Johnny Jazeix
jjazeix accepted this revision. jjazeix added a comment. This revision is now accepted and ready to land. works fine, sorry for the doubt, I probably badly applied it last time. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D15643 REVISION DETAIL

D15818: [Exe Thumbnailer] Ignore depth > 32

2018-09-28 Thread Anthony Fieroni
anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15818 To: broulik, anthonyfieroni Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef,

D14162: Fix issue when reading path lists

2018-09-28 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R237:5f340fc84d89: Fix issue when reading path lists (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14162?vs=42504=42506 REVISION DETAIL

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mvourlakos requested review of this revision. REVISION SUMMARY --pop up positioning that was introduced in order to a dock pop up

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos
mvourlakos added a comment. F6292209: εικόνα.png [BEFORE: popup placement in plasma panel in !compositing] F6292214: εικόνα.png [AFTER: popup placement in plasma panel in !compositing] REPOSITORY R242

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added reviewers: broulik, davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15821: fix pop up positioning for !compositing mode

2018-09-28 Thread Michail Vourlakos
mvourlakos added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15821 To: mvourlakos, #plasma, broulik, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Michail Vourlakos
mvourlakos added a comment. @ngraham @abetts I searched a bit the "downward-pointing triangle" case but I dont think it can be drawn based on the current plasma theme implementation. Plasma themes are svg(s) so the borders images can also have borders so it isnt just drawing a triangle

D15814: show all borders for pop up windows in a dock

2018-09-28 Thread Nathaniel Graham
ngraham added a comment. Ok, no problem! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15814 To: mvourlakos, #plasma, broulik, davidedmundson Cc: abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns