D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread Michal Malý
madcatx added a comment. Ah, sorry, apparently there is ERR_CANNOT_RMDIR and ERR_COULD_NOT_RMDIR which translate to the same value with the latter being deprecated. I'll update the patch to use ERR_CANNOT_RMDIR. REPOSITORY R320 KIO Extras REVISION DETAIL

D15891: Fix monochrome icons missing stylesheets

2018-10-03 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9e71a0266047: Fix monochrome icons missing stylesheets (authored by ndavis, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D15891: Fix monochrome icons missing stylesheets

2018-10-03 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. It looks like this was the reason why your new monochrome Firewall icons didn't correctly invert their colors in Cuttlefish. Fixed now for those and all other affected icons. REPOSITORY

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 233 - Still Unstable!

2018-10-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/233/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Oct 2018 14:30:58 + Build duration: 9 min 46 sec and counting JUnit Tests Name:

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread Michal Malý
madcatx added a comment. Well, this (https://api.kde.org/frameworks/kio/html/deprecated.html#_deprecated15) marks KIO::ERR_COULD_NOT_RMDIR as deprecated. Is there an alternative I should use instead? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15871

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 57 - Still Unstable!

2018-10-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/57/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Oct 2018 13:33:58 + Build duration: 2 min 2 sec and counting JUnit Tests Name: (root)

D14449: Modify device usage information

2018-10-03 Thread Shubham
shubham added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, bruns

D14449: Modify device usage information

2018-10-03 Thread Shubham
shubham added a comment. won't the pie chart representation look good, as we have in windows? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread David Faure
dfaure added a comment. kio_file returns KIO::ERR_CANNOT_RMDIR when trying to delete a non-empty directory, maybe kio_smb could do the same? Although I see that the above isn't dependent on the command being executed But well, is there any other operation that would return ENOTEMPTY? If

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread Michal Malý
madcatx updated this revision to Diff 42807. madcatx added a comment. Changed the KIO error code from ERR_INTERNAL to more specific ERR_CANNOT_RMDIR. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15871?vs=42645=42807 REVISION DETAIL

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-03 Thread Hannah von Reth
vonreth added a comment. Please fallback on looking up perl from path if that perl does not exists. Purely relying on a hardcoded path would break the capability of relocating kdoctools. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 To: zrax Cc:

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-03 Thread Michael Hansen
zrax created this revision. Herald added projects: Frameworks, Documentation. Herald added a subscriber: kde-doc-english. zrax requested review of this revision. REVISION SUMMARY If a PERL_EXECUTABLE is passed on the CMake command line, e.g. because the default one in PATH is insufficient,

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Michael Hansen
zrax added a comment. No, I do not have push permissions. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-03 Thread Manuel Weichselbaumer
mweichselbaumer edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15912: Don't silently error if damage is sent before buffer

2018-10-03 Thread David Edmundson
davidedmundson updated this revision to Diff 42820. davidedmundson added a comment. Leave useless code in REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15912?vs=42766=42820 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15912 AFFECTED

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes. Closed by commit R246:2e364ebbf240: Fix compile failure on Windows targets (authored by zrax, committed by cgiboudeaux). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D15745: Implement Media and MediaEndpoint API

2018-10-03 Thread Manuel Weichselbaumer
mweichselbaumer updated this revision to Diff 42813. mweichselbaumer added a comment. Added autotests and additional test: mediaendpointconnector CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42313=42813 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-03 Thread Michael Hansen
zrax added a comment. PERL_EXECUTABLE is set by cmake's FindPerl module (https://cmake.org/cmake/help/v3.0/module/FindPerl.html), so it should always be defined. This only fixes the case where it's overridden on the command line (or cmake-gui, etc). REPOSITORY R238 KDocTools REVISION

D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-10-03 Thread Dominik Haumann
dhaumann added a comment. Hm, two separator lines, even touching each other sounds like a hack. Is there no better way? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15194 To: ngraham, #plasma, #vdg Cc: dhaumann, romangg, abetts,

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Dominik Haumann
dhaumann added a comment. Btw, can you commit yourself, or shall we push this? If so, can someone take care of this, since I am not available for the next 10 days. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann,

D15909: Fix compile failure on Windows targets

2018-10-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D15909 To: zrax, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

Re: QtCreator-style block highlighting (and colours) in Kate(part)?

2018-10-03 Thread Dominik Haumann
No and no :) But feel free to create/add a color scheme called Qt Creator. Greetings Dominik René J.V. Bertin schrieb am Di., 2. Okt. 2018, 21:21: > Hi, > > I quite like Qt Creator's feature that highlights blocks (in code) by > applying a gradient of background darkening that makes code less

KDE Applications on Android sprint

2018-10-03 Thread Aleix Pol
Hi, We're entertaining the idea of organising a sprint about Android applications towards the end of November in València [1]. If you think you'd be interested in joining, please let me know and add yourself to the kde-android mailing list [2]. Cheers! Aleix [1]

D15912: Don't silently error if damage is sent before buffer

2018-10-03 Thread Roman Gilg
romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. For 5.52. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D15912 To: davidedmundson, #kwin, romangg Cc: romangg, kde-frameworks-devel,

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin,

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. Ping! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik,

D15932: [UDisks2] Power down drive on remove if supported

2018-10-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15932 To: bruns, #frameworks Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15932: [UDisks2] Power down drive on remove if supported

2018-10-03 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY It is preferable to to do a controlled shutdown prior to disconnecting and eventually

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. In D7446#336214 , @davidedmundson wrote: > This is in frameworks, recentdocuments is in kio-extras. > > Are you sure you can do this? Not sure I catch your meaning. The `recentdocuments:/` kioslave has been

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-03 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15871 To: madcatx, elvisangelaccio, sitter, dfaure Cc: dfaure, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun,

D15853: Change drive-harddisk to more adaptable style

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. Thanks again for this lovely icon, @ndavis. Next up, we need a variant of it that communicates "I'm the OS/root volume!" See https://bugs.kde.org/show_bug.cgi?id=399307 This supports one of the next open tasks for T8349: Improve Places panel usability and

D15932: [UDisks2] Power down drive on remove if supported

2018-10-03 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15932 To: bruns, #frameworks Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY #VDG is finalizing a guideline for the use of

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis updated this revision to Diff 42829. ndavis added a comment. Change standard name breeze-dark battery icons to symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15934?vs=42828=42829 BRANCH other-desktop-compatibility (branched from

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread David Faure
dfaure added a comment. I guess the implicit part of the question is "what if kio-extras isn't installed ?". I assume it will lead to a broken item. So this should probably use a check like `KProtocolInfo::isKnownProtocol("recentdocuments")` REPOSITORY R241 KIO REVISION DETAIL

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Andrew Crouthamel
acrouthamel added a comment. +1 from me, makes sense. I say that as a guy who stares at server racks all day. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add 16 and 22 px battery and bluetooth icons with names that should be compatible with

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-10-03 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I think I'm fine with it now, but please wait until next Monday (Oct 8) before pushing, so it doesn't break the upcoming KF5 release. I'm not 100% confident (given that earlier

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The current Breeze icon used for the default Network(`network-workgroup`) is not ideal

D7446: [Places panel] Add a Recently Used item by default

2018-10-03 Thread David Edmundson
davidedmundson added a comment. This is in frameworks, recentdocuments is in kio-extras. Are you sure you can do this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc: svenmauch,

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15932: [UDisks2] Power down drive on remove if supported

2018-10-03 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great with the unencrypted and LUKS-unencrypted single- and multi-partition ext4 disks that I tried out. Code change looks sane too. Wonderful work! REPOSITORY R245 Solid

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-03 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. How can I test this? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D15934 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

2018-10-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/113/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 03 Oct 2018 13:33:58 + Build duration: 1 min 22 sec and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 158 - Still Unstable!

2018-10-03 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/158/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 03 Oct 2018 14:30:58 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

D14449: Modify device usage information

2018-10-03 Thread Nathaniel Graham
ngraham added a comment. A pie chart could work. But is there something wrong with the current representation? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: ngraham, pino, rkflx, dhaumann, kde-frameworks-devel,

D14449: Modify device usage information

2018-10-03 Thread Pino Toscano
pino added a comment. In D14449#335788 , @shubham wrote: > won't the pie chart representation look good, as we have in windows? That would be way too much wasted space for eye candy. REPOSITORY R241 KIO REVISION DETAIL