D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer updated this revision to Diff 42861. mweichselbaumer added a comment. Fixed style issues and smart pointer construction CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42813=42861 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer marked 3 inline comments as done and an inline comment as not done. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15947: Start drawing emblems in the bottom-right corner

2018-10-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15947 To: ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 260 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/260/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 04 Oct 2018 16:49:55 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 1

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Remove NoInputNoOutputAgent and it's good to go. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham,

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-04 Thread Hannah von Reth
vonreth added a comment. ah sorry I took this for a config file, everything is fine then. Note to myself: Don't review code on the phone REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 To: zrax Cc: vonreth, kde-doc-english, kde-frameworks-devel,

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca added a comment. Alright, last thing: Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to inform user that something is trying to connect anyway. REVISION DETAIL

D15947: Start drawing emblems in the bottom-right corner

2018-10-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY While writing a HIG page about emblems (D15897 ),

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer added a comment. In D15745#336593 , @drosca wrote: > Alright, last thing: > > Why NoInputNoOutputAgent? That should be implemented by the application, and not be part of library. In almost all cases you actually want to

D7446: [Places panel] Add a Recently Used item by default

2018-10-04 Thread Nathaniel Graham
ngraham updated this revision to Diff 42865. ngraham added a comment. Only create "Recently Used" if the protocol is available because `kio-extras` is installed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=42277=42865 BRANCH arcpatch-D7446

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. Sure! External hard drive: F6303952: Device notifier - external hard drive.png iPhone F6303953: Device notifier - iPhone.png (The duplicate entries are caused by

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 415 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/415/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Oct 2018 16:49:55 + Build duration: 6 min 57 sec and counting JUnit Tests Name: (root) Failed:

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca added a comment. In D15745#336662 , @mweichselbaumer wrote: > In D15745#336644 , @drosca wrote: > > > Remove NoInputNoOutputAgent and it's good to go. > > > Agree. Is it ok to move it

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer updated this revision to Diff 42877. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15745?vs=42861=42877 REVISION DETAIL https://phabricator.kde.org/D15745 AFFECTED FILES autotests/CMakeLists.txt autotests/fakebluez/CMakeLists.txt

D15943: [balooctl] Monitor also for index changes

2018-10-04 Thread Stefan Brüns
bruns added a comment. Looks sane in general. Can you extend the summary a bit, e.g. "Connect to the scheduler DBus interface to "? Thx REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15943 To: poboiko, #frameworks, #baloo Cc: bruns, kde-frameworks-devel,

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. You should apply for a developer account! https://community.kde.org/Infrastructure/Get_a_Developer_Account I'll land this one. REPOSITORY R241 KIO BRANCH arc_rootdetails (branched from master) REVISION DETAIL https://phabricator.kde.org/D15945 To:

D8532: [WIP] Restrict file extractor with Seccomp

2018-10-04 Thread Fabian Vogt
fvogt added a comment. AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs. The best design would be (IMO, not sure how well the current architecture fits) to have a fully sandboxed executable which can only communicate with baloo over

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca added a comment. In D15745#336615 , @mweichselbaumer wrote: > In D15745#336593 , @drosca wrote: > > > Alright, last thing: > > > > Why NoInputNoOutputAgent? That should be implemented by

D15941: Fix invalid char constant

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. Whoops! Thanks for fixing this. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15941 To: poboiko, #baloo, #frameworks, broulik Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer added a comment. In D15745#336644 , @drosca wrote: > Remove NoInputNoOutputAgent and it's good to go. Agree. Is it ok to move it to mediaendpointconnector? REVISION DETAIL https://phabricator.kde.org/D15745 To:

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-04 Thread Igor Poboiko
poboiko updated this revision to Diff 42886. poboiko added a comment. Fixed typos REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15939?vs=42848=42886 REVISION DETAIL https://phabricator.kde.org/D15939 AFFECTED FILES src/file/fileindexscheduler.cpp

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca added a comment. Thanks. I'll need your full name + e-mail if you don't have dev account to push it. REVISION DETAIL https://phabricator.kde.org/D15745 To: mweichselbaumer, drosca Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread Manuel Weichselbaumer
mweichselbaumer added a comment. In D15745#336711 , @drosca wrote: > Thanks. > I'll need your full name + e-mail if you don't have dev account to push it. You're welcome. It's been a pleasure to contribute to this lib. Manuel

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Failure!

2018-10-04 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/33/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 04 Oct 2018 20:10:31 + Build duration: 3.8 sec and counting CONSOLE OUTPUT Started by

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-04 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Uhm, I guess than this can go in then. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 To: zrax, ltoscano Cc: ltoscano, vonreth, kde-doc-english,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 416 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/416/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Oct 2018 19:25:06 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 262 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/262/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 04 Oct 2018 20:10:31 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 2

D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Andreas Kainz
andreaska accepted this revision. REPOSITORY R241 KIO BRANCH better-network-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg, nicolasfella, andreaska Cc: broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 261 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/261/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 04 Oct 2018 19:25:06 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 2

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

2018-10-04 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_editicon (branched from master) REVISION DETAIL https://phabricator.kde.org/D15952 To: thsurrel, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R241:31c07fa8d6c7: [Places panel] use more appropriate network icon (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15931?vs=42823=42885 REVISION

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

2018-10-04 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of https://phabricator.kde.org/D15938 for dolphin TEST PLAN In

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
This revision was automatically updated to reflect the committed changes. Closed by commit R269:5f12404807cc: Implement Media and MediaEndpoint API (authored by mweichselbaumer, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15745?vs=42877=42878#toc REPOSITORY

D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH better-network-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg, nicolasfella Cc: broulik, acrouthamel, kde-frameworks-devel,

D15952: [KFilePlacesView] Change icon for the 'Edit' context menu entry in Places panel

2018-10-04 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15952 To: thsurrel, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 417 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/417/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 04 Oct 2018 20:10:31 + Build duration: 7 min 25 sec and counting JUnit Tests Name: (root) Failed:

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-04 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 42903. kossebau added a comment. Improve rendering in scaled mode REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8708?vs=41828=42903 BRANCH addAnnotationItemDelegate REVISION DETAIL

D15023: [server] Add selectionChanged signal

2018-10-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH 0selectionChangeXwl REVISION DETAIL https://phabricator.kde.org/D15023 To: romangg, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 34 - Fixed!

2018-10-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/34/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 05 Oct 2018 03:54:06 + Build duration: 13 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 418 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/418/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 05 Oct 2018 03:54:06 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/115/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 05 Oct 2018 01:48:17 + Build duration: 2 min 55 sec and counting JUnit Tests Name: (root)

D15932: [UDisks2] Power down drive on remove if supported

2018-10-04 Thread Stefan Brüns
bruns updated this revision to Diff 42905. bruns added a comment. - do not create additional connections on the system bus - avoid disconnecting optical drives, no need to power down REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15932?vs=42824=42905

D15935: Don't show an emblem for mounted disks, only unmounted disks

2018-10-04 Thread Nathaniel Graham
ngraham retitled this revision from "Don't show a emblem for mounted disks, only unmounted disks" to "Don't show an emblem for mounted disks, only unmounted disks". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: broulik,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/59/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 05 Oct 2018 01:48:17 + Build duration: 5 min 28 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 05 Oct 2018 03:54:18 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1

D15421: [server] Add surface data proxy mechanism

2018-10-04 Thread David Edmundson
davidedmundson added a comment. Seems ok, I need to re-read it in the context of the other patches that I'm getting through. INLINE COMMENTS > surface_interface.h:268 > + * Setting a data proxy is only allowed when the client owning this > surface > + * has not creted a data device

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 263 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/263/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 05 Oct 2018 03:54:06 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

2018-10-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 05 Oct 2018 03:54:18 + Build duration: 6 min 4 sec and counting JUnit Tests Name: (root)

D15935: Don't show a emblem for mounted disks, only unmounted disks

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment. I think that's a sensible idea. Can you also evaluate the implications for Device Notifier? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D15935 To: ngraham, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment. For Bluetooth we currently use: - disabled: grayed out/softened icon - active: black icon - paired: black icon with dots next to each other That "padlock" doesn't communicate "paired" to me and is inconsistent with Plasma's icon REPOSITORY R266 Breeze

D15931: [Places panel] use more appropriate network icon

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment. +1 Oxygen uses a globe for "network-workgroup" and a folder with a cable as "folder-network", someone might wanted to have a globe icon here for recognizability ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc:

D15745: Implement Media and MediaEndpoint API

2018-10-04 Thread David Rosca
drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > manager_p.cpp:46 > , m_bluezProfileManager(nullptr) > +, m_media(nullptr) > , m_initialized(false) No need because it is smart pointer. >

D15932: [UDisks2] Power down drive on remove if supported

2018-10-04 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > udisksstorageaccess.cpp:186 > Device drive(drivePath); > +QDBusConnection c = > QDBusConnection::connectToBus(QDBusConnection::SystemBus, > "Solid::Udisks2::Drive::" + drivePath); > + Why this change?

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment. > It is actual part of the Breeze Plasma theme though: Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be fixed to use that one instead. Not sure I would like the padlock when my headphones

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336409 , @broulik wrote: > > It is actual part of the Breeze Plasma theme though: > > Interesting. I have never seen it used, though. Then the Bluetooth applet (and likely Network manager applet) need to be

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-04 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks, vhanda. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY Right now, if a file was moved / removed while baloo_file was

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336261 , @ngraham wrote: > How can I test this? Or even, how did you test this? I tested it by comparing the icons and names with Adwaita and Papirus, then asking an Xfce user to see if the icons worked

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-10-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. Great stuff. Only found some typos and very minor things, feel free to fix and push. INLINE COMMENTS > mtpdevice.cpp:119 > +{ > +QList list; > +for (const MTPStorage *storage : m_storages) { Technically this is missing a

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis added a comment. In D15934#336349 , @broulik wrote: > For Bluetooth we currently use: > > - disabled: grayed out/softened icon > - active: black icon > - paired: black icon with dots next to each other That "padlock" doesn't

D15934: Add battery and bluetooth icons for other DE compatibility

2018-10-04 Thread Noah Davis
ndavis updated this revision to Diff 42846. ndavis added a comment. Add symbolic links REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15934?vs=42829=42846 BRANCH other-desktop-compatibility (branched from master) REVISION DETAIL

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense, thanks! REPOSITORY R241 KIO BRANCH arc_rootdetails (branched from master) REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks, ngraham Cc:

D15941: Fix invalid char constant

2018-10-04 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY I assume that was a typo. Compiler pointed out that as a warning.

D15941: Fix invalid char constant

2018-10-04 Thread Kai Uwe Broulik
broulik added a comment. I think you updated the wrong diff here REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941 To: poboiko, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D15941: Fix invalid char constant

2018-10-04 Thread Igor Poboiko
poboiko added a comment. In D15941#336481 , @broulik wrote: > I think you updated the wrong diff here True. Sorry, messed up with arc. Will revert it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D15941: Fix invalid char constant

2018-10-04 Thread Igor Poboiko
poboiko updated this revision to Diff 42853. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42851=42853 REVISION DETAIL https://phabricator.kde.org/D15941 AFFECTED FILES src/tools/balooctl/configcommand.cpp To: poboiko, #baloo, #frameworks,

D15943: [balooctl] Monitor also for index changes

2018-10-04 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Frameworks, Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. TEST PLAN 1. Run `balooctl monitor` 2. In different terminal session, run `balooctl

D15944: [balooctl] Fix "index" command with already indexed, but moved file

2018-10-04 Thread Igor Poboiko
poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY If I move a file (while baloo was not running) and perform `balooctl

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Any folder laying in the / partition was excluded to have its 'Mounted on'

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel added a comment. F6303519: before.png F6303521: after.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh,

D15941: Fix invalid char constant

2018-10-04 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941 To: poboiko, #baloo, #frameworks, broulik Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D15941: Fix invalid char constant

2018-10-04 Thread Igor Poboiko
poboiko updated this revision to Diff 42851. poboiko added a comment. [balooctl] Monitor also for state changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42850=42851 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15941

D15941: Fix invalid char constant

2018-10-04 Thread Igor Poboiko
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ade5188979c4: Fix invalid char constant (authored by poboiko). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15941?vs=42853=42854 REVISION DETAIL

D7446: [Places panel] Add a Recently Used item by default

2018-10-04 Thread Nathaniel Graham
ngraham added a comment. In D7446#336245 , @dfaure wrote: > I guess the implicit part of the question is "what if kio-extras isn't installed ?". > I assume it will lead to a broken item. > > So this should probably use a check like

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks everyone who so far looked at this, especially @dhaumann for detailed comments. I am tempted to interpret the lack of further comments, especially the lack of principal objections as an implicit +1 on this patch as it is now :) While I still am

D15945: [KPropertiesDialog] Show mount information for folders in / (root)

2018-10-04 Thread Thomas Surrel
thsurrel added a comment. Someone will have to land this, I don't have a developer account, thanks ! REPOSITORY R241 KIO BRANCH arc_rootdetails (branched from master) REVISION DETAIL https://phabricator.kde.org/D15945 To: thsurrel, #frameworks, ngraham Cc: ngraham,