D15277: [mtp] Move MTP device handling from kioslave to kiod-module

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH mtp_next (branched from master) REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent,

D16018: Fix align of doxygen comments

buschinski changed the repository for this revision from R32 KDevelop to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16018 To: buschinski, #ktexteditor Cc: kdevelop-devel, cullmann, kwrite-devel, kde-frameworks-devel, glebaccon, antismap,

D16018: Fix align of doxygen comments

buschinski added a comment. This did not work for templates as "isComment" uses line attributes and at the time the template is inserted it is always "C/C++ Code/Data"-attribute never a comment. It only becomes a "doxygen comment"-attribute after the template "editing" is finished.

D15999: Add icons with added background to system.svgz

ngraham added a task: T9658: Rethink blur-by-default for Breeze SDDM login screen theme for Plasma 5.15. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16018: Fix align of doxygen comments

buschinski updated this revision to Diff 43088. buschinski edited the summary of this revision. buschinski edited the test plan for this revision. Herald added a project: KDevelop. Herald added a subscriber: kdevelop-devel. REPOSITORY R32 KDevelop CHANGES SINCE LAST UPDATE

D16018: Fix align of doxygen comments

buschinski added a comment. In D16018#338441 , @cullmann wrote: > ... > For the code: > Hmm, why do you use rtrim? That removes trailing spaces, that won't help the startsWith checks. Or do I misread that? You are absolutely right,

D15999: Add icons with added background to system.svgz

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham,

D15973: Add a 'Propreties' entry in the places panel context menu

elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodel.cpp:963 > + > +KPropertiesDialog::showDialog(this->url(index), parent); > +} We usually don't use `this->` REPOSITORY R241 KIO BRANCH arc_properties (branched

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. I never experienced such corruption, though, but sanity check shouldn't hurt. INLINE COMMENTS > main.cpp:204 > +if (arr.length() <= 1) { > +stream << "Malformed term (short): " << arr << "\n"; > +continue; I'm

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/115/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:03:40 + Build duration: 6 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/29/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:07:36 + Build duration: 19 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:05:09 + Build duration: 20 min and counting JUnit Tests Name: (root)

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 43020. croick added a comment. - check for interrupted signal calls when polling - create path string to socket only once - add comments REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34673=43020 BRANCH

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/39/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:05:37 + Build duration: 1 hr 8 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/55/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:08:37 + Build duration: 1 hr 11 min and counting JUnit Tests Name: (root)

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich updated this revision to Diff 43028. astippich added a comment. - explicitly test for supported mimetype REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15825?vs=42529=43028 BRANCH refactor_taglib_extractor_tests REVISION DETAIL

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

astippich added a comment. In D15825#334087 , @bruns wrote: > There are some more common tags with identical values, i.e. AlbumArtist, Composer and Lyrics - any reason you kept these? These are the tags directly supported by taglib (e.g.

D15947: Start drawing emblems in the bottom-right corner

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH emblems-start-in-bottom-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D15947 To: ngraham, #vdg, dfaure Cc: kde-frameworks-devel, michaelh,

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43034. astippich added a comment. - add seperate, translatable string for IEC binary prefixes REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=42563=43034 BRANCH translate_units REVISION DETAIL

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel marked an inline comment as done. REPOSITORY R241 KIO BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

safaalfulaij added inline comments. INLINE COMMENTS > kformatprivate.cpp:124 > +{ KFormat::UnitPrefix::Milli, 1e-3, bpow(-10), tr("m", "SI prefix > for 10^⁻3") , QString() }, > +{ KFormat::UnitPrefix::Unity, 1.0, 1.0 , QString() > , QString()}, > +

D15999: Add icons with added background to system.svgz

pstefan created this revision. pstefan added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pstefan requested review of this revision. REVISION SUMMARY Added duplicates of system.svgz' icons' with added background. The background

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. pstefan added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

pstefan edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/56/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:06:01 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/65/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:05:36 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/42/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:10:46 + Build duration: 31 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/59/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:03:41 + Build duration: 54 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:05:09 + Build duration: 1 hr 2 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 264 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/264/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:07:42 + Build duration: 1 hr 23 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:10:33 + Build duration: 1 hr 20 min and counting JUnit Tests Name: (root)

D16001: ktextedit: lazy load the QTextToSpeech object

pino closed this revision. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D16001 To: pino, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

bruns added inline comments. INLINE COMMENTS > poboiko wrote in main.cpp:204 > I'm not sure this check is needed - the other one (`posOfNonNumeric < 0`) > seem to be covering this case. > There shouldn't be an empty `QByteArray`, right? See `word[0]` access directly after. I have fixed to many

D16001: ktextedit: lazy load the QTextToSpeech object

pino created this revision. pino added a reviewer: mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Create the QTextToSpeech object on demand, i.e. only at the first request to speak a text.

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 88 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/88/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:10:33 + Build duration: 36 min and counting JUnit Tests Name: (root) Failed: 2

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 234 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/234/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:11:18 + Build duration: 36 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/23/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:07:36 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root)

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich added a comment. In D15833#333933 , @svuorela wrote: > What's the origin/license of these files ? How are they created ? Forgot to mention it, I added this information to the summary. In D15833#333944

D15968: kreadconfig: make the tool slightly more useful

dfaure added a comment. Will you port the kreadconfig usage in startkde to add --ignore-globals --ignore-cascading in order to preserve performance? Maybe it would be better to preserve behaviour compatibility and rather make globals and cascading "opt in"? REPOSITORY R237 KConfig

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich updated this revision to Diff 43031. astippich added a comment. - update aiff and wav test files so that they are smaller REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15833?vs=42551=43031 BRANCH taglib_extractor_additional_tests

D16001: ktextedit: lazy load the QTextToSpeech object

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH lazy-qtexttospeech (branched from master) REVISION DETAIL https://phabricator.kde.org/D16001 To: pino, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Thanks! I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the dot

D15829: make units and prefixes of formatValue translatable

astippich updated this revision to Diff 43038. astippich added a comment. - fixup spaces REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15829?vs=43034=43038 BRANCH translate_units REVISION DETAIL https://phabricator.kde.org/D15829 AFFECTED FILES

D15829: make units and prefixes of formatValue translatable

astippich added a comment. In D15829#338296 , @safaalfulaij wrote: > Thanks! > I think this solved all my issues. I can for meter unit change the formatting so that `tr("%1 %2", "no Prefix")` is translated to `"%1%2"` and choose to keep the

D11880: Add firewall-config and firewall-applet icons

ndavis added a comment. In D11880#337514 , @dfaure wrote: > This commit breaks the unittest "scalabletest" : > > FAIL! : ScalableTest::test_scalable(icons:Applications) The following icons are not available in a scalable directory: > >

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 419 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/419/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:07:42 + Build duration: 27 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/118/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:08:21 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/77/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 10:08:37 + Build duration: 30 min and counting JUnit Tests Name: (root) Failed: 4

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/77/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:08:21 + Build duration: 1 hr 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/30/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:10:46 + Build duration: 1 hr 17 min and counting JUnit Tests Name: (root)

D16007: [KNewFileMenu] Don't open an empty QFile

elvisangelaccio created this revision. elvisangelaccio added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. elvisangelaccio requested review of this revision. REVISION SUMMARY Fixes the following Qt warning when opening the context menu

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 159 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/159/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 10:11:18 + Build duration: 1 hr 30 min and counting JUnit Tests Name:

D15833: extend test coverage to all supported mimetypes for taglibextractor

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15833 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15947: Start drawing emblems in the bottom-right corner

This revision was automatically updated to reflect the committed changes. Closed by commit R302:1c564d0b5eb4: Start drawing emblems in the bottom-right corner (authored by ngraham). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15947?vs=42864=43030

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel updated this revision to Diff 43035. thsurrel added a comment. Don't use this-> REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42984=43035 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15859: allow non-local file:// redirect to a M$-WebDav URL

bruns added a comment. There are a few things which would be good to test: Try if the following URLs work (on windows): - file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document - file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document -

D15859: allow non-local file:// redirect to a M$-WebDav URL

This revision was automatically updated to reflect the committed changes. Closed by commit R241:1c7b47cb677b: allow non-local file:// redirect to a Windows WebDav URL (authored by mkoller). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15859?vs=42626=43070#toc REPOSITORY R241 KIO

D15859: allow non-local file:// redirect to a M$-WebDav URL

mkoller added a comment. file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works since it's standard URL syntax. file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not, since it's not a valid URL syntax. 443 is not enabled, so I can't test it, but

D15973: Add a 'Propreties' entry in the places panel context menu

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodel.cpp:957 > > +void KFilePlacesModel::requestProperties(const QModelIndex , QWidget > *parent) > +{ Why is this in the model, rather than

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 420 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/420/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 07 Oct 2018 18:23:18 + Build duration: 4 min 24 sec and counting CONSOLE OUTPUT [...truncated

D15510: Introduce HKDF

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qca_basic.h:1081 > > +class QCA_EXPORT HKDF : public Algorithm > +{ Missing class documentation. Missing \since tag. > qca-botan.cpp:234 > +public: > +

D15973: Add a 'Properties' entry in the places panel context menu

abetts retitled this revision from "Add a 'Propreties' entry in the places panel context menu" to "Add a 'Properties' entry in the places panel context menu". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham, dfaure Cc:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 265 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/265/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 07 Oct 2018 18:23:18 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1

D15973: Add a 'Properties' entry in the places panel context menu

thsurrel updated this revision to Diff 43071. thsurrel added a comment. Show the KPropertiesDialog from the view instead of the model REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=43035=43071 BRANCH arc_properties (branched from master) REVISION

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

akrutzler updated this revision to Diff 43074. akrutzler marked 4 inline comments as done. akrutzler added a comment. - Rebase - Reserve memory for lists/vectors in advance. - Prepend "static" to all class-level functions - Fix typos REPOSITORY R320 KIO Extras CHANGES SINCE LAST

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

akrutzler retitled this revision from "[RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module" to "[mtp] Move MTP device handling from kioslave to kiod-module". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio,

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

akrutzler added a comment. Great! Is there anything else left to do @elvisangelaccio and @mlaurent before I land this? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent,

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

elvisangelaccio accepted this revision. elvisangelaccio added a comment. Awesome job, Andreas <3 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel,

D15277: [mtp] Move MTP device handling from kioslave to kiod-module

ngraham edited the summary of this revision. ngraham added a task: T9390: Next Gen MTP. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15277 To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel,

D16018: Fix align of doxygen comments

buschinski created this revision. buschinski added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. buschinski requested review of this revision. REVISION SUMMARY After https://bugs.kde.org/show_bug.cgi?id=360456

D14072: Don't try to restore invalid user places

dfaure added a comment. This commit breaks kfileplacesmodeltest. $ bin/kfileplacesmodeltest testInitialState testInitialList testInternalBookmarksHaveIds - Start testing of KFilePlacesModelTest * Config: Using QtTest library 5.12.0, Qt 5.12.0 (x86_64-little_endian-lp64

D14072: Don't try to restore invalid user places

dfaure added a comment. More generally, please please run the unittests after changing a class. I hate that I currently am the one doing this, on the day of the release, which forces me to bugfix such things, or delay the release. REPOSITORY R241 KIO REVISION DETAIL

D15859: allow non-local file:// redirect to a M$-WebDav URL

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. +2, assuming the commit log doesn't have M$ anymore (the phab review does, but you don't use arc apparently so I guess the two things are unrelated) REPOSITORY R241 KIO REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptrace scope

dfaure added a reviewer: ossi. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

bruns added a comment. In D11880#338464 , @dfaure wrote: > I don't really know, but see https://phabricator.kde.org/D4254 for the full reasoning of the unittest. As far as I understand it, the themes are marked as scalable with a

D15999: Add icons with added background to system.svgz

pstefan updated this revision to Diff 43051. pstefan added a comment. Fix z-layering issue for the "-translucent" icons. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=43009=43051 BRANCH master REVISION DETAIL

D16018: Fix align of doxygen comments

cullmann added a comment. Hi, thanks for the patch to improve the indentation handling. A case to reproduce would help. For me, the identation is messed up in Kate if I do indent/unindent of such comments and the "keep extra spaces" option is off. But I think that has nothing to do with

D16020: KFilePlacesModel: fix previous commit to avoid duplicating devices

dfaure created this revision. dfaure added a reviewer: jtamate. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. TEST PLAN kfileplacesmodeltest REPOSITORY R241 KIO BRANCH master

D14072: Don't try to restore invalid user places

dfaure added a comment. Possible fix in https://phabricator.kde.org/D16020 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14072 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11880: Add firewall-config and firewall-applet icons

dfaure added a comment. I don't really know, but see https://phabricator.kde.org/D4254 for the full reasoning of the unittest. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D11880 To: ndavis, #vdg, #breeze, ngraham Cc: dfaure, bruns, abetts, alex-l,

D16007: [KNewFileMenu] Don't open an empty QFile

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16007 To: elvisangelaccio, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

dfaure added a comment. This looks like the kind of commit where a review by Oswald Buddenhagen would be useful. INLINE COMMENTS > kcrash.cpp:672 > +// wait while DrKonqi is running and the socket connection > exists > +while (kill(pid, 0) >= 0 &&

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch renames these icons so that their names follow the convention and

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

ngraham updated this revision to Diff 43081. ngraham added a comment. Do it right REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16028?vs=43080=43081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16028 AFFECTED FILES

D16028: Change "hint" to "visibility-hidden" and "visiblity" to "visibility-visible"

ngraham abandoned this revision. ngraham added a comment. For some reason `arc` doesn't want to apply this: Checking patch dev/null => icons-dark/actions/22/hint.svg... error: dev/null: does not exist in index Checking patch icons-dark/actions/16/hint.svg =>

D15999: Add icons with added background to system.svgz

filipf added a comment. Would the background be grey and the icon itself black in all color schemes? (apropos how Inkscape shows it:) Could we make it adaptable to the color scheme? I don't know if the code applies, but they managed to do it here:

D15973: Add a 'Properties' entry in the places panel context menu

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham, dfaure Cc: dfaure, elvisangelaccio,

D15999: Add icons with added background to system.svgz

ngraham added a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh, ngraham,

D15859: allow non-local file:// redirect to a M$-WebDav URL

bruns added a comment. In D15859#338583 , @mkoller wrote: > file://some.server:80/DavWWWRoot/pwa/some/path/to/a/document clearly works since it's standard URL syntax. > file://some.server@80/DavWWWRoot/pwa/some/path/to/a/document does not,

D15999: Add icons with added background to system.svgz

ngraham removed a dependent revision: D16031: [SDDM theme] remove blur and increase UI contrast so it's not required. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: filipf, kde-frameworks-devel, michaelh,