D16049: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Alex Debus
alexde abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16049 To: alexde, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-10-09 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Otherwise good to go ... INLINE COMMENTS > taglibwritertest.cpp:75 > +// source encoding: "€µ" > +static const QChar data[4] = { 0x20ac, 0xb5 }; > +QString

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/118/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 01:59:36 + Build duration: 7 min 54 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 62 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/62/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 01:59:36 + Build duration: 1 hr 40 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:23:18 + Build duration: 1 min 40 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 66 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/66/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:24:53 + Build duration: 5 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/119/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:25:42 + Build duration: 6 min 43 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 79 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/79/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:26:12 + Build duration: 6 min 13 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 116 - Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:28:37 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 237 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/237/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:28:25 + Build duration: 13 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 429 - Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 04:25:27 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 8 - Failure!

2018-10-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/8/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 04:24:53 + Build duration: 40 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.11 - Build # 13 - Failure!

2018-10-09 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.11/13/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 04:28:37 + Build duration: 44 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 33 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/33/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 00:17:05 + Build duration: 2 min 14 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 00:21:59 + Build duration: 3 min 20 sec and counting JUnit Tests Name: (root)

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-09 Thread Igor Poboiko
poboiko added a comment. > Does this run at startup? If so, this will erase the entries of files on a removable volume not already mounted. Whoa, thanks for the notice. Not cool, forgot about it. Probably need to add some checks in IndexCleaner, about the device. But how does it

D16060: Reduce double and triple lookups to the frames hash

2018-10-09 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Everything runs, tests pass REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-10-09 Thread Alexander Stippich
astippich added a comment. Sorry, I should have written this more clearly, but you got it right. It's for the new formats. For the most common tags, taglib directly provides the implementation for all its supported tag formats and one can call e.g. tag->artist(). For the others, one has to

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-10-09 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16059: remove compile time check for taglib version

2018-10-09 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: svuorela, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY cleanup the check for the taglib version, which is

D16018: Fix align of doxygen comments

2018-10-09 Thread Bernd Buschinski
buschinski updated this revision to Diff 43201. buschinski added a comment. Changed to (correct) ktexteditor repository. Someday... I will learn how to use phabricator :) REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16018?vs=43088=43201 REVISION

D15638: force-finish canberra notifications on close()

2018-10-09 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D15638 To: sitter, broulik, jtamate Cc: kde-frameworks-devel, jtamate, michaelh, ngraham, bruns

D15638: force-finish canberra notifications on close()

2018-10-09 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R289:d4f51fdc1d53: force-finish canberra notifications on close() (authored by sitter). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15638?vs=42037=43212

D15999: Add icons with added background to system.svgz

2018-10-09 Thread Nathaniel Graham
ngraham added a subscriber: broulik. ngraham added a comment. This came up in D16031#339966 : @broulik suggested putting a drop shadow behind the icon, and I gave it a try with your new icons. The result was radically improved contrast and a

D15638: force-finish canberra notifications on close()

2018-10-09 Thread Christoph Feck
cfeck added subscribers: dfaure, cfeck. cfeck added a comment. @dfaure, worth a respin? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D15638 To: sitter, broulik, jtamate Cc: cfeck, dfaure, kde-frameworks-devel, jtamate, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 6 - Fixed!

2018-10-09 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/6/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Oct 2018 11:25:41 + Build duration: 2 hr 14 min and counting JUnit Tests

D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme

2018-10-09 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY When kwin focus stealing prevention is high or extreme, I had to activate

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-10-09 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:20b89972b643: get rid of the raw KFileItem pointers in KCoreDirListerCache (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10742?vs=42345=43240

D16084: Add Media and MediaEndpoint API header generation

2018-10-09 Thread Manuel Weichselbaumer
mweichselbaumer created this revision. mweichselbaumer added a reviewer: drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mweichselbaumer requested review of this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D16084

Fwd: KDE CI: Administration » Dependency Build Extragear kf5-qt5 WindowsMSVCQt5.11 - Build # 11 - Failure!

2018-10-09 Thread Ben Cooksley
Hi all, Looks like something has changed recently in Baloo (or CMake) regarding how it handles searching for LMDB? I've checked and the library is definitely present (both the .dll and the .lib are presented, named liblmdb.dll and liblmdb.lib respectively) so it seems to be a CMake find issue...

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/116/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 09 Oct 2018 22:51:43 + Build duration: 1 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 60 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/60/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 09 Oct 2018 22:51:44 + Build duration: 1 min 23 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 00:21:59 + Build duration: 6 min 48 sec and counting JUnit Tests Name: (root)

D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16091 To: alexde, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16049: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham
ngraham added a comment. No problem at all, just Abandon this one (available via the Add Action... button on the bottom of the page. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16049 To: alexde, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh,

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2018-10-09 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/45/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 00:17:05 + Build duration: 5 min 55 sec and counting JUnit Tests Name:

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-09 Thread Nathaniel Graham
ngraham added a comment. ...And that's why we committed this for 5.52. :-) Now we have a month to fix it--and we should make sure we do! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15939 To: poboiko, #baloo, #frameworks, vhanda, ngraham Cc: smithjd, bruns,

D16049: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This doesn't apply cleanly: Checking patch src/filewidgets/kfileplacesview.cpp... Hunk #1 succeeded at 745 (offset 3 lines). error: while searching for:

D15999: Add icons with added background to system.svgz

2018-10-09 Thread Filip Fila
filipf added a comment. So what I suggested and tried to sketch in D16031 was to scale the icon down a bit inside the circles just so it's proportionally more satisfactory to the eye. I also removed the faint outer border to not oversaturate the new

D16059: remove compile time check for taglib version

2018-10-09 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D16059 To: astippich, svuorela, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Alex Debus
alexde created this revision. alexde added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not have

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-10-09 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thanks for the explanation. Looks good then, just update the summary. You could add another column to the tests, "hasFullImplementation", and do an Q_EXPECT_FAIL if not set. But thats

D16049: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Alex Debus
alexde added a comment. > Also, you might want to set up arc, which makes it much simpler and faster to submit patches, and easier for me too. I tried it again, but I forgot to add the "Differential Revision" and did not expect //arc diff// to automatically upload the diff. That is why

D16091: Added missing Icons to Places Panel code from KIO

2018-10-09 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Perfect, thanks! Since you submitted a new revision rather than updating D16049 , you'll want to formally Abandon that one. In the future, now that