KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 06:04:18 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 9 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/9/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 06:04:18 + Build duration: 34 min and counting

D11282: less expensive findByUrl in KCoreDirListerCache

2018-10-10 Thread Jaime Torres Amate
jtamate abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: kde-frameworks-devel, bruns, mwolff, michaelh, ngraham

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 61 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/61/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:23:18 + Build duration: 2 hr 21 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/40/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:24:53 + Build duration: 2 hr 31 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:25:42 + Build duration: 2 hr 29 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 162 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/162/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 04:28:25 + Build duration: 2 hr 32 min and counting JUnit Tests Name:

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Failure!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 10 Oct 2018 04:23:12 + Build duration: 2 hr 50 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.11 - Build # 14 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.11/14/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 10 Oct 2018 09:50:21 + Build duration: 4 min 52 sec and counting

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.10 - Build # 50 - Failure!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 09:49:04 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated 100.94

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Failing!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.10/51/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 09:59:12 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...truncated

D15099: add a new property headerVisible

2018-10-10 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R236:9069ae42435c: add a new property headerVisible (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15099?vs=40504=43278 REVISION DETAIL

D15098: make push/pop part of ConfigModule API

2018-10-10 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:abfc94c6093a: make push/pop part of ConfigModule API (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15098?vs=40701=43276#toc REPOSITORY R296 KDeclarative CHANGES SINCE

D14580: support for multi pages kcms

2018-10-10 Thread Marco Martin
mart updated this revision to Diff 43279. mart added a comment. - Merge branch 'master' into arcpatch-D14580 REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=40629=43279 BRANCH arcpatch-D14580 REVISION DETAIL

D14580: support for multi pages kcms

2018-10-10 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R295:58e3b29efb99: support for multi pages kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14580?vs=43279=43280 REVISION DETAIL

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 42 - Failure!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/42/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 13:51:33 + Build duration: 5 min 26 sec and counting CONSOLE OUTPUT [...truncated

D13757: Move parsing .desktop file for folder Comment to file KIO

2018-10-10 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D13867: [KMessageWidget] Pass widget to standardIcon()

2018-10-10 Thread Kai Uwe Broulik
broulik planned changes to this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13867 To: broulik, #frameworks, cfeck, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16060: Reduce double and triple lookups to the frames hash

2018-10-10 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D16060 To: apol, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: DBus thread shutdown issue on Windows

2018-10-10 Thread David Faure
[Adjusting CC list] On mercredi 10 octobre 2018 11:55:01 CEST Ben Cooksley wrote: > On Thu, Oct 4, 2018 at 3:15 PM Thiago Macieira > > wrote: > > On Wednesday, 3 October 2018 18:12:08 PDT David Faure wrote: > > > On another note, if Qt knows this part of Windows is broken, why is it > > > even

D16060: Reduce double and triple lookups to the frames hash

2018-10-10 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > framesvg.cpp:967 > { > -references[svg] = references[svg] - 1; > -//qCDebug(LOG_PLASMA) << this << svg << references[svg]; > -if (references[svg] < 1) { > -references.remove(svg); > +auto it = references.find(svg); > +

kiowidgets_kdirmodeltest fail

2018-10-10 Thread Jaime
Hello, About https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/ I'm only able to reproduce the crash 1/7 times I run ctest -j3, never if I run the test alone or run make test. I've tried applying what

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. @cullmann @dhaumann So, what to do? :) Do you think if we delay one more month you will find time to give this the wanted deeper review? Or will this continue to (understandable) lack your motivation given you are so far not a consumer of this new API?

D15417: [AppImage Thumbnailer] Avoid creating QTemporaryFile

2018-10-10 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec93501d3318: [AppImage Thumbnailer] Avoid creating QTemporaryFile (authored by broulik). Herald added projects:

D13034: Add mechanism to notify other clients of config changes over DBus

2018-10-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R237:8579ec54838b: Add mechanism to notify other clients of config changes over DBus (authored by davidedmundson). CHANGED PRIOR TO COMMIT

D13033: Expose getter method for KConfig::addConfigSources

2018-10-10 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:8e5608346337: Expose getter method for KConfig::addConfigSources (authored by davidedmundson). REPOSITORY R237

D16060: Reduce double and triple lookups to the frames hash

2018-10-10 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:967 > if we're calling deref without it being paired with ref then we have bigger > problems. :D fair enough REPOSITORY R242 Plasma Framework (Library) BRANCH master

D16060: Reduce double and triple lookups to the frames hash

2018-10-10 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in framesvg.cpp:967 > Can we assume `references` always contains `svg`? if we're calling deref without it being paired with ref then we have bigger problems. REPOSITORY R242 Plasma Framework (Library) BRANCH master

D15741: Use correct MaximumSize

2018-10-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R320:1b334712ed0f: Use correct MaximumSize (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15741?vs=42291=43306 REVISION DETAIL

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-10-10 Thread Alexander Stippich
astippich marked an inline comment as done. astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:75 > can you change this to `data[2]` ... > Facepalm myself ... I should have spotted this myself :) REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-10-10 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH taglib_write_unicode REVISION DETAIL https://phabricator.kde.org/D15714 To: astippich, mgallien, bruns Cc: smithjd, svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D15714: add a string suffix to test data and use for unicode testing of taglibwriter

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. astippich marked an inline comment as done. Closed by commit R286:196b1289152c: add a string suffix to test data and use for unicode testing of taglibwriter (authored by astippich). CHANGED PRIOR TO COMMIT

D16112: add wma files/asf tags as supported mimetype and add test data

2018-10-10 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add preliminary support for wma files/asf tags

D14111: Install MIME type definition for text/x-rst ourselves for now

2018-10-10 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. I see how this is no simple matter. Given I could solve my needs locally, no need to add things to maintain where no-one else seems to have a need. So discarding, no bad feelings. Given that rst is around since ages and yet nobody

D16108: When re-using runners when reloading, reload their configuration

2018-10-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When configuration is changed, runners are reloaded but their

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:52920c0003d6: move testing of common tags of test files to a new data-driven test for… (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D15825: move testing of common tags of test files to a new data-driven test for taglibextractor

2018-10-10 Thread Alexander Stippich
astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData BRANCH refactor_taglib_extractor_tests REVISION DETAIL https://phabricator.kde.org/D15825 To: astippich, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns, svuorela. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Instead of querying the tags directly through

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 43 - Still Failing!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 16:27:44 + Build duration: 3 min 24 sec and counting CONSOLE OUTPUT [...truncated

D15833: extend test coverage to all supported mimetypes for taglibextractor

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:601059a3c0b6: extend test coverage to all supported mimetypes for taglibextractor (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D16059: remove compile time check for taglib version

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d6d86adbd773: remove compile time check for taglib version (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16059?vs=43191=43326

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 117 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/117/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 11 Oct 2018 03:56:46 + Build duration: 9 min 29 sec and counting JUnit Tests Name: (root)

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d472f470bacb: use own extractor for testing the taglibwriter (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43339=43370

D16112: add wma files/asf tags as supported mimetype and add test data

2018-10-10 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d7c6fa57d243: add wma files/asf tags as supported mimetype and add test data (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16112?vs=43332=43371#toc REPOSITORY R286

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/41/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 06:56:37 + Build duration: 3 hr 47 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.9 - Build # 34 - Failure!

2018-10-10 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.9/34/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 09:49:04 + Build duration: 1 hr 15 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.9 - Build # 35 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.9/35/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 11:04:51 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed: 0

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Alexander Stippich
astippich marked 2 inline comments as done. astippich added a comment. Sorry, that was really stupid REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH use_extractor_for_writertest REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

Re: kiowidgets_kdirmodeltest fail

2018-10-10 Thread David Faure
On mercredi 10 octobre 2018 22:11:12 CEST Albert Astals Cid wrote: > El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > > Hello, > > > > About > > > > https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/ > >

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.9/44/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 20:05:00 + Build duration: 5 min 33 sec and counting JUnit Tests Name: (root) Failed:

D15047: Export the StorageDevices object.

2018-10-10 Thread Nathaniel Graham
ngraham added reviewers: Baloo, bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43361. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=40344=43361 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

2018-10-10 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D11529: Balooctl: Deindex unfound files with check command.

2018-10-10 Thread James Smith
smithjd removed a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun,

D16112: add wma files/asf tags as supported mimetype and add test data

2018-10-10 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH supported_wma_asf REVISION DETAIL https://phabricator.kde.org/D16112 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

Re: kiowidgets_kdirmodeltest fail

2018-10-10 Thread Albert Astals Cid
El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > Hello, > > About > https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/429/testReport/junit/(root)/TestSuite/kiowidgets_kdirmodeltest/ > > I'm only able to reproduce the crash 1/7 times I run ctest

D13034: Add mechanism to notify other clients of config changes over DBus

2018-10-10 Thread David Edmundson
davidedmundson added a comment. Thanks, resolved. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik, dfaure Cc: bcooksley, dfaure, broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

2018-10-10 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY The properties dialog was not showing anything in the window title and in

D13216: Overhaul the file index scheduler.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43355. smithjd marked an inline comment as done. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState

D15047: Export the StorageDevices object.

2018-10-10 Thread Stefan Brüns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. You still have not addressed the raised issues. This gets annoying ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo,

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2018-10-10 Thread Dominik Haumann
dhaumann added a comment. @graesslin ping REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43353. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43363. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43361=43363 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-10-10 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, abrahams

Re: kiowidgets_kdirmodeltest fail

2018-10-10 Thread Albert Astals Cid
El dimecres, 10 d’octubre de 2018, a les 23:09:49 CEST, David Faure va escriure: > On mercredi 10 octobre 2018 22:11:12 CEST Albert Astals Cid wrote: > > El dimecres, 10 d’octubre de 2018, a les 16:33:43 CEST, Jaime va escriure: > > > Hello, > > > > > > About > > > > > >

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Alexander Stippich
astippich updated this revision to Diff 43339. astippich added a comment. - fix stupid mistakes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16111?vs=43330=43339 BRANCH use_extractor_for_writertest REVISION DETAIL

D13034: Add mechanism to notify other clients of config changes over DBus

2018-10-10 Thread Ben Cooksley
bcooksley added a comment. This change broke the build of KConfig on Qt 5.9 (casting issue in QTest) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik, dfaure Cc: bcooksley, dfaure, broulik, zzag, kde-frameworks-devel, michaelh,

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43357. smithjd added a comment. - Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15047?vs=43353=43357 BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-10-10 Thread Nathaniel Graham
ngraham added reviewers: Baloo, poboiko. ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=373430 and/or https://bugs.kde.org/show_bug.cgi?id=353559? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo,

D11529: Balooctl: Deindex unfound files with check command.

2018-10-10 Thread James Smith
smithjd removed a dependency: D15047: Export the StorageDevices object.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik, bruns Cc: bruns, kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun,

D15047: Export the StorageDevices object.

2018-10-10 Thread James Smith
smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16111 To: astippich, mgallien, bruns, svuorela Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D16111: use own extractor for testing the taglibwriter

2018-10-10 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:5 > #include "writedata.h" > - > +#include > +#include double slash > taglibwritertest.cpp:56 > +QCOMPARE(result.properties().value(Property::Album), > QVariant(QStringLiteral("Album1") + stringSuffix)); > +

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd added a comment. https://bugs.kde.org/show_bug.cgi?id=353559 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

2018-10-10 Thread Ralf Habacker
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14787 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 430 - Still Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/430/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 21:39:20 + Build duration: 21 min and counting JUnit Tests Name: (root) Failed: 1

D14785: Fix DialogNativeTest in multi screen configuration

2018-10-10 Thread Ralf Habacker
habacker added a comment. ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14785 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13425: File indexer closing improvements.

2018-10-10 Thread James Smith
smithjd updated this revision to Diff 43368. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=43363=43368 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

2018-10-10 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mainhub.cpp:72 > m_config->forceConfigUpdate(); > -// FIXME!! > -//m_fileIndexer.updateConfig(); Unrelated change REPOSITORY R293 Baloo

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 275 - Unstable!

2018-10-10 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/275/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 21:39:20 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 1

D13425: File indexer closing improvements.

2018-10-10 Thread Stefan Brüns
bruns added a comment. The summary does in no way match the change. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D15983: React to config updates inside indexer

2018-10-10 Thread Stefan Brüns
bruns added a comment. Looks good in general, but have to think a little bit more about it .. INLINE COMMENTS > fileindexscheduler.cpp:125 > > +// This should be above content indexing, because there can be files > that should not be indexed in the DB > +// (i.e. if config was

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 276 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/276/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 10 Oct 2018 22:53:55 + Build duration: 9 min 27 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 431 - Fixed!

2018-10-10 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/431/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 10 Oct 2018 22:53:55 + Build duration: 22 min and counting JUnit Tests Name: (root) Failed: 0

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-10 Thread James Smith
smithjd added a comment. https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the storagedevices object was required: https://phabricator.kde.org/D15047. The alternative,