D15985: [balooctl] Print current state & indexing file when monitor starts

bruns added a comment. In D15985#341854 , @poboiko wrote: > Indexing /some/file1Indexing /some/file2: OK > Are you sure its file1...file2 and not the same file twice? If it is the same, we can set m_currentFile in 71 and suppress the

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. I have to admit, I don't know how to implement a version with flags correctly. Did I understand you correctly in that an overload with signature addPage(QWidget *page, const QString , const QString = QString(), const QString = QString(), bool manage =

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16163 To: astippich, bruns Cc: kde-frameworks-devel, #baloo,

D16135: refactor tests for taglibextractor

astippich added a comment. In D16135#341549 , @bruns wrote: > Can you split this up in two patches, the first one updating the test files and fixing the values in the tests, and the second one doing the refactoring? see D16162

D16154: fix Service(Type)Browser documentation

sitter updated this revision to Diff 43468. sitter added a comment. use QStringLiteral REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16154?vs=43465=43468 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16154 AFFECTED FILES

D16162: harmonize test data for vorbis comment tags

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY harmonize the test data for all files with vorbis comments so that

D15985: [balooctl] Print current state & indexing file when monitor starts

bruns added a comment. Also, is your running baloo_file using current master? Otherwise, it may return a file finished long ago, see D15994 . REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc:

D15985: [balooctl] Print current state & indexing file when monitor starts

bruns added a comment. In D15985#341854 , @poboiko wrote: > In D15985#341811 , @bruns wrote: > > > No, definitely not, see D15995 . > > > I don't see how it

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. That's weird. I caught it only once and thought that it is because I trivially forgot the endl. But now I cannot reproduce it anymore. Seems like it should be fine, since we do emit finished signal, which will write the 'OK' part. Sorry for the noise. REVISION

D16137: Add an option to KConfigDialog to fit page contents horizontally

aacid added a comment. In D16137#341984 , @kadabash wrote: > I have to admit, I don't know how to implement a version with flags correctly. Look at kcmodule.h for example you'll see some flags defined there, then there's a setButtons

D16163: refactor taglibextractor to functions specific for metadata type

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Refactor the specific extraction funtions in taglibextractor so

D16167: Instead of copying and clearing the file list, just move it

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This makes it more explicit the list of files is now owned by the

D16154: fix Service(Type)Browser documentation

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servicebrowser code sample: - now uses our coding style - correctly references

D16162: harmonize test data for vorbis comment tags

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Thx REPOSITORY R286 KFileMetaData BRANCH harmonize_vorbis REVISION DETAIL https://phabricator.kde.org/D16162 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D16135: refactor tests for taglibextractor

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Looks good, thanks. REPOSITORY R286 KFileMetaData BRANCH refactor_tests REVISION DETAIL https://phabricator.kde.org/D16135 To: astippich, mgallien, bruns, svuorela Cc:

D16163: refactor taglibextractor to functions specific for metadata type

mgallien added a comment. In D16163#342046 , @astippich wrote: > To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? This page is a very good reference:

D16163: refactor taglibextractor to functions specific for metadata type

bruns added inline comments. INLINE COMMENTS > taglibextractor.h:31 > +#include > #include > Keep the includes in the implementation and just do a forward declaration of the types (possible as you only use these as pointer types in the header). REPOSITORY R286 KFileMetaData REVISION

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43498. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43413=43498 BRANCH config-dialog-content-fit (branched from

D15959: Wait for the extraction process to finish before scheduling

bruns added a comment. In D15959#341722 , @poboiko wrote: > In D15959#339523 , @bruns wrote: > > > This works for me: > > > >void FileIndexScheduler::scheduleIndexing() > >{ > > -

D16166: Pass the FileIndexerConfig as const to the individual indexers

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Also make maxUncommitedFiles() const, used in the

D16165: Don't crash on invalid exiv2 data

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY The file from bug 375131 crashes `baloo_file_extractor`. The problem

D16165: Don't crash on invalid exiv2 data

astippich added a comment. I guess bugs 352856 353848 361259 will also be fixed by this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun,

D16163: refactor taglibextractor to functions specific for metadata type

bruns added a comment. In D16163#342046 , @astippich wrote: > To be on the safe side here: I am allowed to modify private member functions regarding binary compatibility, right? Non-virtual methods do not affect the class layout or the

D16162: harmonize test data for vorbis comment tags

This revision was automatically updated to reflect the committed changes. Closed by commit R286:1aab09a628ae: harmonize test data for vorbis comment tags (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16162?vs=43485=43489

D16163: refactor taglibextractor to functions specific for metadata type

astippich added a comment. In D16163#342057 , @mgallien wrote: > In D16163#342046 , @astippich wrote: > > > To be on the safe side here: I am allowed to modify private member functions regarding

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash updated this revision to Diff 43499. kadabash added a comment. Restore binary compatibility and introduce alignment flags REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43498=43499 BRANCH config-dialog-content-fit (branched from

D16137: Add an option to KConfigDialog to fit page contents horizontally

kadabash added a comment. Sorry for the duplicate updates, I messed up my Arcanist commands. Thanks for your help so far, I tried to follow your suggestions in the above change. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To: kadabash Cc:

D16165: Don't crash on invalid exiv2 data

bruns added a comment. Can you enhance the Summary a little bit? It took me some time to notice `Exiv2::Value::toFloat()` is the same as `Exiv2::Value::toFloat(0)` (default argument), and accessing an inexisting element (i.e. n >= count()) triggers undefined behaviour, according to the

D16163: refactor taglibextractor to functions specific for metadata type

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > taglibextractor.h:44 > +} > + > namespace KFileMetaData can also be written as namespace TagLib::ID3v2 { class Tag; } namespace TagLib::MP4 { class

D16168: [Tags] Lower default log level to warning, add to categories file

bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The tags: ioslave had the old default log level of "all", switch

D16168: [Tags] Lower default log level to warning, add to categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R293:73430a7ce762: [Tags] Lower default log level to warning, add to categories file (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

kossebau updated this revision to Diff 43516. kossebau added a comment. Updating: - bump since to 5.53 - remove todo question about background paiting, assumed not to be required task of the delegate given the current code - implement todo about catching destroyed user delegate (not

D16135: refactor tests for taglibextractor

astippich updated this revision to Diff 43490. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16135?vs=43409=43490 BRANCH refactor_tests REVISION DETAIL https://phabricator.kde.org/D16135 AFFECTED FILES

D16163: refactor taglibextractor to functions specific for metadata type

astippich updated this revision to Diff 43500. astippich added a comment. - use forward declaration REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16163?vs=43486=43500 BRANCH refactor_taglib REVISION DETAIL https://phabricator.kde.org/D16163

D16168: [Tags] Lower default log level to warning, add to categories file

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R293 Baloo BRANCH debug_cleanup REVISION DETAIL https://phabricator.kde.org/D16168 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc: ngraham,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 42 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/42/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:33:42 + Build duration: 32 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/32/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Oct 2018 05:32:54 + Build duration: 58 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 43 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/43/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 24 min and counting JUnit Tests Name: (root)

D16141: Disable unmount option for / or /home

broulik added a comment. Why would you be unable to unmount `/home`? If you're logged in as root (not saying that one should or can), whose home is `/root` you can surely unmount `/home` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks,

D15959: Wait for the extraction process to finish before scheduling

poboiko added a comment. In D15959#339523 , @bruns wrote: > This works for me: > >void FileIndexScheduler::scheduleIndexing() >{ > -if (m_threadPool.activeThreadCount() || m_indexerState == Suspended) { > +if

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. Woops! `startedIndexingFile` does not print a newline. I guess I can just add `m_out << endl`... REVISION DETAIL https://phabricator.kde.org/D15985 To: poboiko, #baloo, #frameworks, bruns, ngraham Cc: ngraham, bruns

D16141: Disable unmount option for / or /home

thsurrel added a comment. In D16141#341553 , @ngraham wrote: > However, I'm afraid this doesn't actually work for me: That's strange, it is the same code than in Dolphin (and it works for me). Could you have a look at the

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.10 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 06:05:50 + Build duration: 2 min 27 sec and counting JUnit Tests Name:

D15983: React to config updates inside indexer

poboiko marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15983 To: poboiko, #baloo, #frameworks Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15983: React to config updates inside indexer

poboiko updated this revision to Diff 43446. poboiko added a comment. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. Address raised issues REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15983?vs=42971=43446 BRANCH

D16141: Disable unmount option for / or /home

thsurrel added a comment. In D16141#341738 , @dfaure wrote: > This whole method could put placesModel->url(index) into a local variable to avoid calling it so many times, though. Should I do that here or in a different patch ?

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 69 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 3 min 17 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.11 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.11/11/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Fri, 12 Oct 2018 06:09:03 + Build duration: 2 min 36 sec and counting

D16145: Adapt autotest to new menu structure

gregormi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix REVISION DETAIL https://phabricator.kde.org/D16145 To: nicolasfella, gregormi, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15826: [Balooshow] Avoid out-of-bounds access when accessing corrupt db data

poboiko added a comment. I'm not entirely sure how translating system works, but won't it pop up as 4 identical lines in i.e. `Lokalize`, causing frustration to our translators? It would also mean that if we would want to change the message, we would have to do it in 4 different lines.

D15985: [balooctl] Print current state & indexing file when monitor starts

bruns added a comment. In D15985#341751 , @poboiko wrote: > Woops! `startedIndexingFile` does not print a newline. I guess I can just add `m_out << endl`... No, definitely not, see D15995 . REVISION

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 33 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/33/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Fri, 12 Oct 2018 09:36:44 + Build duration: 2 min 33 sec and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/63/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:20:13 + Build duration: 42 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 37 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/37/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:34:26 + Build duration: 30 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.9 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.9/38/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 06:05:50 + Build duration: 11 min and counting JUnit Tests Name: (root)

D16141: Disable unmount option for / or /home

thsurrel added a comment. If logged in as root, wouldn't QDir::homePath() return /root and not /home/ ? You should be able to unmount /home in that case. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: broulik, ngraham,

D15939: Perform checks for unindexed files and stale index entries on startup

poboiko added a comment. In D15939#341094 , @smithjd wrote: > https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner and checked for removeable volumes before removing index entries. Exporting the

D16141: Disable unmount option for / or /home

dfaure added a comment. +1 This whole method could put placesModel->url(index) into a local variable to avoid calling it so many times, though. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: dfaure, broulik, ngraham,

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/59/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 12 Oct 2018 05:58:14 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed: 4

D16141: Disable unmount option for / or /home

thsurrel edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16141 To: thsurrel, #frameworks, ngraham Cc: broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D15985: [balooctl] Print current state & indexing file when monitor starts

poboiko added a comment. In D15985#341811 , @bruns wrote: > No, definitely not, see D15995 . I don't see how it is a problem. The problem is not that it's not written to terminal (it is), but that it