D16007: [KNewFileMenu] Don't open an empty QFile

2018-10-14 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d60d369140c3: [KNewFileMenu] Dont open an empty QFile (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16007?vs=43024=43575 REVISION

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-14 Thread David Faure
dfaure added a comment. You're right. Fixed, thanks. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16196: add a description property to KFileMetaData

2018-10-14 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: mgallien, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the description property to KFileMetaData, as the

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-14 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY provide a list of supported mimetypes similar to the

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cf3b0d102855: kio_help: Fix crash in QCoreApplication when accessing help://. (authored by mpyne). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16189?vs=43569=43593

Password field security and information leaking

2018-10-14 Thread Ivan Čukić
Hi all, We are using QLineEdit (and QML equivalent) all over KDE for passwords. This is an issue for types of attacks that extract raw process memory because the passwords can be leaked. QLineEdit stores the current value as plain text in a QString. Which means that while the password entry

D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good, but this might be worth fixing in QTest::qWaitForWindowActive itself, for all other unittests using that (including Qt's own). REPOSITORY R241 KIO REVISION DETAIL

D15510: Introduce HKDF

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I would certainly like a style reformat, but I'm not sure who is the current/active maintainer for this code. REPOSITORY R486 QCA Library BRANCH master REVISION DETAIL

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Sune Vuorela
svuorela added a comment. from a source & binary compatibility point of view, this looks great. I guess we should maybe plan deprecating (and at kf6 time remove) the old ones ? (But this is not an objection to the current change) I'm not a KConfigWidgets maintainer, so I will not

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. See also https://phabricator.kde.org/D16183 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure Cc: dfaure,

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-14 Thread Harald Sitter
sitter added a comment. KF5 style is to always `{}` single line if-else, no? REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16183: KCrash: fix crash (ironic heh) when used in an app without QCoreApplication

2018-10-14 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D16183 To: dfaure, heikobecker, aacid, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme

2018-10-14 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:63093179579c: Avoid waiting for user actions when kwin Focus stealing prevention is high or… (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D11869: epubextractor: Add property ReleaseYear

2018-10-14 Thread Alexander Stippich
astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. Herald edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. Any objections? Otherwise I will merge this on michaelh's behalf REPOSITORY R286 KFileMetaData

Re: Password field security and information leaking

2018-10-14 Thread Albert Astals Cid
El diumenge, 14 d’octubre de 2018, a les 11:19:17 CEST, Ivan Čukić va escriure: > Hi all, > > > We are using QLineEdit (and QML equivalent) all over KDE for passwords. This > is an issue for types of attacks that extract raw process memory because the > passwords can be leaked. > > QLineEdit

D16154: fix Service(Type)Browser documentation

2018-10-14 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH master REVISION DETAIL https://phabricator.kde.org/D16154 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16072: Avoid waiting for user actions when kwin Focus stealing prevention is high or extreme

2018-10-14 Thread Jaime Torres Amate
jtamate added a comment. Created https://bugreports.qt.io/browse/QTBUG-71137 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16072 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

2018-10-14 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. Funny, I just noticed the same thing yesterday and was just about to make a patch but then saw this REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16189 To: mpyne, #frameworks, sitter, dfaure, broulik Cc:

D16165: Don't crash on invalid exiv2 data

2018-10-14 Thread Stefan Brüns
bruns added a comment. In D16165#342975 , @poboiko wrote: > > Yeah, that's true. I guess that should be also not too hard to fix. > But there is two parts of the bug. The first one is what you mentioned, while the second is

D11869: epubextractor: Add property ReleaseYear

2018-10-14 Thread Nathaniel Graham
ngraham added a comment. Go for it! REPOSITORY R286 KFileMetaData BRANCH releaseyear (branched from master) REVISION DETAIL https://phabricator.kde.org/D11869 To: michaelh, astippich Cc: ngraham, bruns, kde-frameworks-devel, astippich, #baloo, mgallien, ashaposhnikov, michaelh,

D13424: Run a file changed check when the file watches are updated.

2018-10-14 Thread James Smith
smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 280 - Unstable!

2018-10-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/280/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 14 Oct 2018 16:10:14 + Build duration: 29 min and counting JUnit Tests Name: (root) Failed: 1

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-14 Thread Alexander Stippich
astippich updated this revision to Diff 43601. astippich added a comment. - move mimetype list to private REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43587=43601 BRANCH mimetypes_embedded_image REVISION DETAIL

Re: KDE apps have missing icons when not on Breeze

2018-10-14 Thread Dominik Haumann
On Sat, Sep 1, 2018 at 1:09 AM Albert Astals Cid wrote: > > El dissabte, 1 de setembre de 2018, a les 1:02:00 CEST, Dominik Haumann va > escriure: > > ...so should we revert the hack we did in Kate? > > Well, this won't be available until wuite some time in the future (Qt 5.12) > so I'd say for

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Tim __
kadabash updated this revision to Diff 43607. kadabash added a comment. Generalize page flags to options not related to alignment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16137?vs=43499=43607 BRANCH config-dialog-content-fit (branched from

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Nathaniel Graham
ngraham added a comment. +1, nice to see this. Once it lands, feel free to start porting apps to use it--for the ones where it'll be acceptable to depend on Frameworks 5.52 as a minimum version. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To:

Re: KDE apps have missing icons when not on Breeze

2018-10-14 Thread Dominik Haumann
Ah, just saw https://phabricator.kde.org/D14983 - so it's handled automatically. Thanks & cheers Dominik On Sun, Oct 14, 2018 at 7:53 PM Dominik Haumann wrote: > > On Sat, Sep 1, 2018 at 1:09 AM Albert Astals Cid wrote: > > > > El dissabte, 1 de setembre de 2018, a les 1:02:00 CEST, Dominik

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Tim __
kadabash added a comment. In D16137#342973 , @aacid wrote: > That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Sune Vuorela
svuorela added a comment. > Did you imagine something like what I changed in D16137#343060 (the latest change) ? I think Albert imagined something like that. It is at least what I imagined when I read his comments. I think I also like it

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-14 Thread Stefan Brüns
bruns added a comment. Exercise: 1. Take a USB memory stick 2. plug it into one USB port 3. run "stat " 4. unmount, plug into different port 5. run "stat " again You will get different device ids for each port. If you plug in a different stick, the device id will be there,

D11869: epubextractor: Add property ReleaseYear

2018-10-14 Thread Stefan Brüns
bruns added a comment. Looks fine, go for it. Very unfortunate michaelh vanished, hope he's well ... REPOSITORY R286 KFileMetaData BRANCH releaseyear (branched from master) REVISION DETAIL https://phabricator.kde.org/D11869 To: michaelh, astippich Cc: bruns,

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-14 Thread Albert Astals Cid
aacid added a comment. That's almost good, but the flag name should be more general, think like for example you would remove the manage bool and convert it to a flag too, so that if it the future someone needs to add a new flag, they can add it to that enum and don't need a new parameter.

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-14 Thread Matthieu Gallien
mgallien added inline comments. INLINE COMMENTS > embeddedimagedata.h:62 > + */ > +QStringList readMimetypes() const; > + You can make it static because you are returning a static member. It means that you should probably return by const reference (even if I do not remember if it is

Re: Password field security and information leaking

2018-10-14 Thread Ivan Čukić
> Is this a problem at all? > I mean, by default applications can't read other applications memory so the > only one that can try this kind of attacks is the root user. Yes it is a problem. It would be like saying no need to encrypt the hard drive - the privilege system is enough. Some of the

D16165: Don't crash on invalid exiv2 data

2018-10-14 Thread Igor Poboiko
poboiko added a comment. In D16165#342550 , @bruns wrote: > Unfortunately 375131 is quite vague, they all speak about "baloo" hanging, but as "baloo" is not a single process, it is impossible to tell for sure which process crashes or hangs. >

Re: Password field security and information leaking

2018-10-14 Thread Michael Pyne
On Sun, Oct 14, 2018 at 11:19:17AM +0200, Ivan Čukić wrote: > Hi all, > > > We are using QLineEdit (and QML equivalent) all over KDE for passwords. This > is an issue for types of attacks that extract raw process memory because the > passwords can be leaked. > > *snip* > > Transporting

D15939: Perform checks for unindexed files and stale index entries on startup

2018-10-14 Thread James Smith
smithjd added a comment. In D15939#341728 , @poboiko wrote: > In D15939#341094 , @smithjd wrote: > > > https://phabricator.kde.org/D11529 was already up for review, implemented the index cleaner

D13216: Overhaul the file index scheduler.

2018-10-14 Thread James Smith
smithjd updated this revision to Diff 43623. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 436 - Unstable!

2018-10-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/436/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 03:38:57 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 281 - Fixed!

2018-10-14 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/281/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 03:38:57 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 164 - Still Unstable!

2018-10-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/164/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 15 Oct 2018 03:39:37 + Build duration: 26 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 239 - Still Unstable!

2018-10-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/239/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 15 Oct 2018 03:39:37 + Build duration: 13 min and counting JUnit Tests Name: (root)