D16283: implement more tags for asf metadata

2018-10-18 Thread Alexander Stippich
astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibextractor.cpp:739 > this makes me always wonder why we don't do: > > // decltype(data.albumArtists) == QStringList > for (attribute : lstAsf) { > QString t = TStringToQString(attribute.toString()); >

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, makes sense! REPOSITORY R39 KTextEditor BRANCH remove__fromincludeguards REVISION DETAIL https://phabricator.kde.org/D16300 To: kossebau, #kate, cullmann Cc: cullmann,

D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:e92ed94d9d1a: Remove PLASMA_NO_KIO option (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16295?vs=43857=43872 REVISION

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 244 - Still Unstable!

2018-10-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/244/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Oct 2018 14:45:28 + Build duration: 2 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 439 - Fixed!

2018-10-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/439/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 18 Oct 2018 17:11:58 + Build duration: 5 min 25 sec and counting JUnit Tests Name: (root) Failed:

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Ben Cooksley
bcooksley added a comment. In certain instances `#pragma once` fails when using MSVC, while traditional `#define` include guards are fully reliable. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16300 To: kossebau, #kate, cullmann Cc: bcooksley, broulik,

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY Names containing a double underscore (__) are reserved to the

D16301: Remove ComponentInstaller

2018-10-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When a dataengine failed to load it would ask PackageKit to install it but it's

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D16300#345405 , @broulik wrote: > It could have just gone `#pramga once` conjunctive "could" -> not specified in KF policies if possible. Seems even Qt devs are undecided about it and rejected it again,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 284 - Fixed!

2018-10-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/284/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 18 Oct 2018 17:11:58 + Build duration: 20 min and counting JUnit Tests Name: (root) Failed: 0

D16283: implement more tags for asf metadata

2018-10-18 Thread Alexander Stippich
astippich updated this revision to Diff 43885. astippich marked 3 inline comments as done. astippich added a comment. - fix comment and simplify iterating - cleanup REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16283?vs=43822=43885 BRANCH

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-18 Thread Harald Sitter
sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This elevates a problem with newer SMB protocol versions and smbclient not supporting

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R39:38a9214aaa0e: Remove double underscore (__) from header include guards (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 169 - Still Unstable!

2018-10-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/169/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 18 Oct 2018 14:45:28 + Build duration: 9 min 38 sec and counting JUnit Tests Name:

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-18 Thread Harald Sitter
sitter added a comment. This diff does somewhat depend on D16298 as currently KDNSSD can easily lock indefinitely on resolving services. We could kinda bypass this with a timeout on service resolution, that would however have the disadvantage of either

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Allen Winter
winterz added a comment. fyi, krazy in strict mode will check for leading and trailing underscores on the include guards. I don't run krazy in strict mode on the EBN, however. I could make this a standard check if we want so the EBN would pick it up too. REPOSITORY R39 KTextEditor

D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. ++ REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16295 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson,

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Kai Uwe Broulik
broulik added a comment. It could have just gone `#pramga once` REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16300 To: kossebau, #kate, cullmann Cc: broulik, cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, sars, dhaumann

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Thanks, this is looking better. I will test it out later. It's not a huge deal, but `40` might be clearer and more readable than `qPow(4*M_E, 9)`. Then you could avoid adding the `` import too. REPOSITORY R241 KIO REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Tested this out and couldn't actually make it work the way I asked--with the FAT32 file size limit checked first. I think I see why: there are two `total size > available space?` checks that output `ERR_DISK_FULL` on error, and both of them execute first. The FAT32

D16301: Remove ComponentInstaller

2018-10-18 Thread Aleix Pol Gonzalez
apol added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol, bruns, kde-frameworks-devel, michaelh, ngraham

D16281: update epub test data and test for comment property

2018-10-18 Thread Alexander Stippich
astippich updated this revision to Diff 43887. astippich added a comment. - fix test file REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16281?vs=43820=43887 BRANCH description_test_preparation REVISION DETAIL https://phabricator.kde.org/D16281

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43895. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system" to "Warn user before copy/move job if the file size exceeds the maximum possible file size in

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 > }; Please add a comment with `@since` to this >

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > job_error.cpp:248 > break; > +case KIO::ERR_FILE_TOO_LARGE_FOR_FAT32: > +result = i18n("The file named %1 cannot be transferred because its > size is greater than 4 GB," Should also be handled in `KIO::rawErrorDetail(...)`,

D16306: [Codecs] Remove unneeded const_cast

2018-10-18 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, poboiko, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QByteArray accepts a const char* in the constructor, no

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > cfeck wrote in copyjob.cpp:1622 > Does this even work on a -m32 system? `(1ul << 32) -1` then ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-10-18 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Frameworks. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY This is necessary to allow QIcons with a KIconEngine as engine to deserialize properly. BUG: 399989 TEST PLAN Ran the PoC in

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > copyjob.cpp:1622 > + > +if (fileSystem == KFileSystemType::Fat && (*it).size > > 4294967296) { // 4 GB = 4294967296 Bytes > +q->setError(ERR_FILE_TOO_LARGE_FOR_FAT32); why not `1 << 32 - 1` ? Also note the `- 1`, 2 ^

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Dominik Haumann
dhaumann added a comment. Thanks! Qt decided against #pragma once. I wouldn't want to use it in KDE unless it is decided on kde-frameworks-devel. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16300 To: kossebau, #kate, cullmann Cc: dhaumann, winterz,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43890. shubham retitled this revision from "Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System" to "Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32

D16301: Remove ComponentInstaller

2018-10-18 Thread Stefan Brüns
bruns added a comment. https://github.com/hughsie/PackageKit/blob/master/src/org.freedesktop.PackageKit.Transaction.xml Method InstallPackages This requires of course we already have a valid package name. For this we probably have to rely on appstream, but need to define an

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Thank you for indulging me  REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > bruns wrote in copyjob.cpp:1622 > why not `1 << 32 - 1` ? > Also note the `- 1`, 2 ^ 32 is 0, as FAT32 uses a uint32_t for the file > size. Does this even work on a -m32 system? REPOSITORY R241 KIO REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham updated this revision to Diff 43894. shubham added a comment. Cache file system time instead of creating it every time REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43890=43894 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. Maybe we could cache the value of `KFileSystemType::fileSystemType()` somewhere so we don't need to calculate it again for every file, since it's the same for every one. INLINE COMMENTS > job_error.cpp:249 > +case KIO::ERR_FILE_TOO_LARGE_FOR_FAT32: > +

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-18 Thread Alexander Stippich
astippich added a comment. I've decided to name it similar to the extractor plugins REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16197: provide a list of supported mimetypes for embeddedimagedata

2018-10-18 Thread Alexander Stippich
astippich updated this revision to Diff 43888. astippich marked an inline comment as done. astippich added a comment. - remove read prefix REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16197?vs=43819=43888 BRANCH mimetypes_embedded_image

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size(4 GB) in FAT32 file system

2018-10-18 Thread Shubham
shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-18 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > bruns wrote in job_error.cpp:249 > %1 with quotes please, as it can contain whitespace, so it would be hard to > spot where the filename ends. > I would also prefer a sentence where the reason is given first, e.g. > `The destination filesystem

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-18 Thread Nathaniel Graham
ngraham added a comment. FWIW, in practice the workgroup is much less prominent to even unnecessary in a macOS or Linux shared file environment. I've only ever seen shares on multiple workgroups used in a Windows environment. REPOSITORY R320 KIO Extras REVISION DETAIL

D16291: Center icons properly if size doesn't fit

2018-10-18 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D16291 To: broulik, dfaure, cfeck, ngraham, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16291: Center icons properly if size doesn't fit

2018-10-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: dfaure, cfeck, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When requesting an icon size that cannot be served, the pixmap is

D16291: Center icons properly if size doesn't fit

2018-10-18 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R302:2699d36365fa: Center icons properly if size doesnt fit (authored by broulik). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16291?vs=43847=43848 REVISION

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in a File System

2018-10-18 Thread Shubham
shubham added a comment. Is there any predefined function which returns the file size limit for a given file system? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham,

D16291: Center icons properly if size doesn't fit

2018-10-18 Thread Kai Uwe Broulik
broulik updated this revision to Diff 43847. broulik edited the test plan for this revision. broulik added a comment. - Also properly create new pixmap REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16291?vs=43845=43847 REVISION DETAIL

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This allows a user to move the windoow before creating the popup

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16294 To: davidedmundson, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

2018-10-18 Thread Stefan Brüns
bruns added a comment. In D15070#345218 , @cgiboudeaux wrote: > In D15070#344900 , @bruns wrote: > > > In D15070#344884 , @cgiboudeaux wrote: > > > >

D16298: prevent avahi signal racing

2018-10-18 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > avahi-remoteservice.cpp:104 > + > +new org::freedesktop::Avahi::ServiceResolver( > +s.service(), FTR: this is obviously leaking and was doing so before as well. I'll fix it after this diff. REPOSITORY R272 KDNSSD REVISION

D16298: prevent avahi signal racing

2018-10-18 Thread Harald Sitter
sitter added reviewers: mdawson, broulik. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16298: prevent avahi signal racing

2018-10-18 Thread Harald Sitter
sitter marked 2 inline comments as done. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D16298 To: sitter, mdawson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

2018-10-18 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D15070#344900 , @bruns wrote: > In D15070#344884 , @cgiboudeaux wrote: > > > In D15070#344871 , @bruns wrote: > > > >

D16295: Remove PLASMA_NO_KIO

2018-10-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is a remnant of the Active days and didn't even compile. This patch only

D16298: prevent avahi signal racing

2018-10-18 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY https://github.com/lathiat/avahi/issues/9 Avahi has upstream signal races which can have any number of side effect

D16298: prevent avahi signal racing

2018-10-18 Thread Harald Sitter
sitter updated this revision to Diff 43863. sitter added a comment. typo-- && make isOurMsg const REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16298?vs=43861=43863 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16298 AFFECTED FILES

D16298: prevent avahi signal racing

2018-10-18 Thread Kai Uwe Broulik
broulik added a comment. Not sure if evil or genius ;) Looks sane, as sane as it gets, obviously. INLINE COMMENTS > avahi_listener_p.h:29 > + > +// Assits with listening to Avahi for all signals and then checking if the > +// a given dbus message is meant for us or not. *Assists >

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgtest.cpp:172 > +positioner.setGravity(Qt::BottomEdge); > +positioner.setConstraints(XdgPositioner::Constraint::FlipX | > XdgPositioner::Constraint::FlipX); > +

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > xdgtest.cpp:202 > QImage image(buffer->address(), size.width(), size.height(), > QImage::Format_ARGB32_Premultiplied); > -image.fill(QColor(255, 0, 0, 255)); > +image.fill(QColor(0, 0, 255, 255)); > Also, you could use Qt::blue. :-)

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-18 Thread Friedrich W. H. Kossebau
kossebau marked 2 inline comments as done. kossebau added a comment. In D8708#344872 , @dhaumann wrote: > Feel free to push this for 5.52 (you'd have to adapt the @since 5.53 again). Thanks for review again :) Would prefer waiting for

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

2018-10-18 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 43868. kossebau marked an inline comment as done. kossebau added a comment. update to Dominik's last review: - remove __ from include guard - add comment that Option::view is always set REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-18 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, Dolphin. ngraham added a comment. Wow, awesome work. What more is needed to support Windows? Support for the `WS-Discovery` protocol? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: