D16301: Remove ComponentInstaller

2018-10-19 Thread Kai Uwe Broulik
broulik added a comment. > Method InstallPackages Thanks for the insight. In any case, the way the code "works" right now is probably not what we want. It has been unused for years and is unlikely to come back in that form, so we can rm it. If we were to support something like this we

D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH oob REVISION DETAIL https://phabricator.kde.org/D16306 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 442 - Unstable!

2018-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/442/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Oct 2018 06:57:08 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 1

D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread Laurent Montel
mlaurent added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16306 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16318: [xdgshell] Add positioner constraint adjustment flag operators

2018-10-19 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Used in kwin REPOSITORY R127 KWayland BRANCH master REVISION

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Nathaniel Graham
ngraham added a comment. `1ul << 32) -1` needs a comment explaining what it means, for people like me with puny brains. :) There are //two// checks in this file that result in an `ERR_DISK_FULL` if there is not enough space. The FAT32 check is now before the second one, but not the

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-19 Thread Harald Sitter
sitter added a comment. It's available as an API, but it is not used to publish **shares** it seems. In fact, if I am reading Microsoft's arcticle on smb1 correctly then ws-discovery is also not

D15645: Add scheme selection menu with a "System" entry.

2018-10-19 Thread Nathaniel Graham
ngraham added reviewers: broulik, cfeck, elvisangelaccio. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

2018-10-19 Thread Amish Naidu
amhndu added a comment. Ping. Can someone please review ? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham updated this revision to Diff 43930. shubham marked 5 inline comments as done. shubham added a comment. File size limit check for a given file system before (m_totalSize > m_freeSpace) check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added inline comments. INLINE COMMENTS > ngraham wrote in job_error.cpp:253 > Unrelated and incorrect change: `https` is correct here, so please revert. That was my previous commit where I changed http -> https. Don't know why it affected my local branch. REPOSITORY R241 KIO

D16318: [xdgshell] Add positioner constraint adjustment flag operators

2018-10-19 Thread Vlad Zagorodniy
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16318 To: davidedmundson, #kwin, zzag Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham updated this revision to Diff 43938. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=43930=43938 REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/core/global.h src/core/job_error.cpp To: shubham,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > job_error.cpp:1078 > +description = xi18n("The file %1 cannot be > transeferred," > +" because the the destination's filesystem does > not support files that large", errorText); > +solutions <<

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-19 Thread Tim __
kadabash updated this revision to Diff 43944. kadabash added a comment. Fit page content horizontally *and* vertically Vertical fitting only occurs on displays that Qt deems large enough. Displays that are just high enough to fit the content vertically are apparently sometimes not

D15999: Add icons with added background to system.svgz

2018-10-19 Thread Nathaniel Graham
ngraham added a comment. So to recap recent discussions, here are the requested changes: - (Required) Create a version of the `go-previous` icon with this same style, and name it `go-previous-translucent` - (Required) Make the background circle more opaque and/or darker - (Optional,

D14938: Force ki18n to build with the libintl.so path

2018-10-19 Thread Hannah von Reth
vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. its not optimal to patch this on our side but lets do it for now REPOSITORY R877 Craft Blueprints for KDE BRANCH ki18n_libintl_lib (branched from master) REVISION DETAIL

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added a comment. @bruns Apart from these, does the code seems sane to you? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-19 Thread Ben Cooksley
bcooksley added a comment. It might be worth getting in touch with the Samba developers, as I believe they've worked with the people at Microsoft who look after the SMB parts of Windows - and they'd know best what is done in regards to discovery of shares these days. Turning to Google

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-19 Thread Shubham
shubham added a comment. @ngraham No, please recheck, the check is before the first m_totalSize > m_freeSpace check REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, elvisangelaccio, #frameworks Cc: cfeck, bruns, kde-frameworks-devel,

D14938: Force ki18n to build with the libintl.so path

2018-10-19 Thread Hannah von Reth
This revision was automatically updated to reflect the committed changes. Closed by commit R877:ccfb970b3206: Force ki18n to build with the libintl.so path (authored by sdepiets, committed by vonreth). REPOSITORY R877 Craft Blueprints for KDE CHANGES SINCE LAST UPDATE

D8532: [WIP] Restrict file extractor with Seccomp

2018-10-19 Thread Detlef Eppers
detlefe added a comment. In D8532#336584 , @fvogt wrote: > AFAICT this won't actually protect much - the open DBus socket is enough to execute arbitrary programs. > > The best design would be (IMO, not sure how well the current architecture

D15999: Add icons with added background to system.svgz

2018-10-19 Thread Nathaniel Graham
ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D8532: [WIP] Restrict file extractor with Seccomp

2018-10-19 Thread Detlef Eppers
detlefe added a comment. Dropping one more comment, in case someone wants to give it a try: Apparmor profile transitions don't work if a seccomp filter has been installed before. This makes it probably rather difficult to integrate DrKonqi into an Apparmor policy. REPOSITORY R293 Baloo

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-19 Thread Nathaniel Graham
ngraham added a comment. In D16299#345718 , @sitter wrote: > What I'd really like to know is if windows 10 actually has dnssd nowadays, and if it is enabled by default, and whether smb is published if/when dnssd is enabled.

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 245 - Still Unstable!

2018-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/245/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Oct 2018 11:44:12 + Build duration: 2 min 31 sec and counting JUnit Tests Name:

D16313: Use QMenu::addSeparator

2018-10-19 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arc_addseparator (branched from master) REVISION DETAIL https://phabricator.kde.org/D16313 To: thsurrel, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16313: Use QMenu::addSeparator

2018-10-19 Thread Thomas Surrel
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5001954b022a: Use QMenu::addSeparator (authored by thsurrel). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16313?vs=43913=43914 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 443 - Fixed!

2018-10-19 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/443/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Oct 2018 12:04:58 + Build duration: 6 min 18 sec and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 170 - Still Unstable!

2018-10-19 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/170/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 19 Oct 2018 11:44:13 + Build duration: 40 min and counting JUnit Tests Name: (root)

D16311: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2018-10-19 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This ensure hovering a broken mount will not freeze the UI. I

D16306: [Codecs] Remove unneeded const_cast

2018-10-19 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:2e3dafe5a892: [Codecs] Remove unneeded const_cast (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16306?vs=43898=43910 REVISION DETAIL

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2018-10-19 Thread Kai Uwe Broulik
broulik retitled this revision from "[KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob" to "RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame

D16166: Pass the FileIndexerConfig as const to the individual indexers

2018-10-19 Thread Stefan Brüns
bruns added a reviewer: dfaure. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D16166 To: bruns, #baloo, #frameworks, poboiko, ngraham, dfaure Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16301: Remove ComponentInstaller

2018-10-19 Thread Aleix Pol Gonzalez
apol added a comment. FWIW my +1 is to removing it. The Appstream assessment is all right but fixing something nobody uses sounds like a waste of time. :P REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16301 To: broulik, #plasma, mart Cc: apol,

D16313: Use QMenu::addSeparator

2018-10-19 Thread Thomas Surrel
thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R241 KIO BRANCH arc_addseparator (branched from master) REVISION DETAIL

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

2018-10-19 Thread Harald Sitter
sitter added a comment. Done some research on ws-discovery. gsoap is the only free c implementation I could find. There are some python, js and java implementations but they'll probably not help us nearly as much (unless someone wants to write a daemon or helper binary to bridge the