D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis created this revision. snoordhuis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. snoordhuis requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16751

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. there is 2 alternatives 1. remove the icon from devices section and keep it in places section with some icon change in the top one 2. keep it in the places section but change the label to root or system and it will always be top of all other hd with the

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

2018-11-08 Thread Shubham
shubham removed a reviewer: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, elvisangelaccio Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis added a reviewer: Localization. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg, #localization Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Ben Cooksley
bcooksley added a comment. This change broke the build of KIO on Windows - can someone please take a look and correct this? https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/71/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16466 To:

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis removed a dependent revision: D16749: Various grammar and capitalization fixes for UI consistency. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis reclaimed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis updated this revision to Diff 45106. snoordhuis added a comment. Removed incorrect changes to MinimizeAll's main.js file REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16751?vs=45096=45106 BRANCH master REVISION DETAIL

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis added a dependent revision: D16749: Various grammar and capitalization fixes for UI consistency. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

2018-11-08 Thread Laurent Montel
mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure, mlaurent Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-08 Thread Samuel Noordhuis
snoordhuis abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 253 - Still Unstable!

2018-11-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/253/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Nov 2018 15:28:21 + Build duration: 3 min 28 sec and counting JUnit Tests Name:

D16733: Capture package metadata before install start

2018-11-08 Thread José Manuel Santamaría Lema
joselema removed a commit: R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D16733 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema added a commit: R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 179 - Fixed!

2018-11-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/179/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 08 Nov 2018 15:28:21 + Build duration: 14 min and counting JUnit Tests Name: (root)

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. In D15739#356010 , @davidc wrote: > I do think changing the default label of `Root`'s mounted device would prevent the confusion of the one user who wanted it removed from Devices. Okay great, I will submit a

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment. In D15739#356309 , @Codezela wrote: > In D15739#356269 , @ndavis wrote: > > > In D15739#356026 , @Codezela wrote: > > > > >

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons use a different style and are blurry. Perhaps you should try making the styles more similar to the 64 px style and

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Andrew Crouthamel
acrouthamel added a comment. In D15739#331468 , @broulik wrote: > +1 it's an entry I always hide when I setup someone's computer > > > you can still get to / on your machine in one click using the appropriate disk entry on the bottom of the

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. The image in this patch is out of date since it was added before other changes were made; I need to update it and will do so later today. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, tcanabrava Cc:

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. In D15739#356310 , @ndavis wrote: > In D15739#356309 , @Codezela wrote: > > > i know that the icons size is adjustable i mean make the default more bigger first time u run

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. Oh gosh, how did we miss this? Yikes, I'm very sorry about that. @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. If not, maybe @ndavis should commandeer this revision and finish it up. REPOSITORY

D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Ben Cooksley
bcooksley added a comment. Thanks for sorting that out. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16466 To: bruns, #frameworks, broulik, apol Cc: kossebau, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. In D15739#356269 , @ndavis wrote: > In D15739#356026 , @Codezela wrote: > > > maybe there is 2 alternatives > > > > 1. remove the icon from devices section and keep it

D15999: Add icons with added background to system.svgz

2018-11-08 Thread Phil Stefan
pstefan updated this revision to Diff 45137. pstefan added a comment. - Hardcoded background color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15999?vs=44890=45137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D15999

D16617: fix extraction of GPS altitude for exif data

2018-11-08 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > exiv2extractor.cpp:285 > +if (it != data.end()) { > +alt = it->value().toFloat(); > +it =

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356470 , @ngraham wrote: > Now that I think about it, you can probably commandeer it and finish it up now, and once it's ready we can land it with @andreyorst's authorship information. Does that sound okay?

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356335 , @ngraham wrote: > Oh gosh, how did we miss this? Yikes, I'm very sorry about that. > > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. If

D16404: [Bookmarks Runner] Cleanup tests CMakeList

2018-11-08 Thread Stefan Brüns
bruns added a comment. Anyone? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. Now that I think about it, you can probably commandeer it and finish it up now, and once it's ready we can land it with @andreyorst's authorship information. Does that sound okay? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912

D16671: Refactor embedded image extractor for greater extensibility

2018-11-08 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > embeddedimagedata.cpp:204 > +TagLib::ByteVector pictureData = (*itApe).second.binaryData(); > +int dataPosition = pictureData.find('\0') + 1; > +return QByteArray(pictureData.data() + dataPosition, > pictureData.size() -

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D15739#356003 , @ngraham wrote: > This blows up the places tests; will fix them in this patch. It will also break the test in dolphin :( REPOSITORY R241 KIO REVISION DETAIL

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns added a comment. @pino - you have not answered for a week. You have set this to "Needs Revision", which removes it from the "Needs Review" queue for everyone else. If you wan't to see an extractor based on libspectre, thats fine, but then **you** have to write it. REPOSITORY

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns removed a reviewer: pino. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

2018-11-08 Thread Stefan Brüns
bruns requested review of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. In D15739#356449 , @elvisangelaccio wrote: > In D15739#356003 , @ngraham wrote: > > > This blows up the places tests; will fix them in this patch. > > > It will also

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. If you do need to, you click on the Add Action... button that's above the comment text box and choose "Commandeer Revision" Anyway, I agree, let's wait for @andreyorst for a bit. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add an icon for people that like to have Root (`/`) as a Places bookmark REPOSITORY R266

D15999: Add icons with added background to system.svgz

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. Ahh, much better! Reviewing... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15999 To: pstefan, ngraham, #vdg Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: #vdg, kde-frameworks-devel, michaelh, ngraham, bruns

D8912: Added a set of Game Folder icons

2018-11-08 Thread Nathaniel Graham
ngraham added a comment. All right, let's wait then. You wanna keep an eye on this and make sure it doesn't get lost again? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8912 To: andreyorst, #vdg Cc: ngraham, kde-frameworks-devel, ndavis, michaelh, bruns

D16770: [ftp kio-slave] Fix deletion of directory with non-latin parent path

2018-11-08 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY KRemoteEncoding::directory() returns the encoded path of the directpry, while

D16677: Add BrightScript syntax

2018-11-08 Thread Daniel Levin
dlevin added a comment. Just double checking whether any additional actions required from my side or 'landing' a patch means it will be a part of the next release automatically. If so then where I could find a release roadmap? Thanks in advance! REPOSITORY R216 Syntax Highlighting

D8912: Added a set of Game Folder icons

2018-11-08 Thread Noah Davis
ndavis added a comment. In D8912#356508 , @ngraham wrote: > All right, let's wait then. You wanna keep an eye on this and make sure it doesn't get lost again? Sure. Is there anything special I have to do to commandeer it if he doesn't

D16772: Add folder-root icon

2018-11-08 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16772 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8912: Added a set of Game Folder icons

2018-11-08 Thread Andrey Orst
andreyorst added a comment. > @andreyorst, if you're still around, we can review this patch and land it once necessary changes are made. Yeah, I'm here! I'd like to make desired changes myself. > Nice job on the 64 px icons! However, I noticed that the 16 and 22 px icons use a

D16677: Add BrightScript syntax

2018-11-08 Thread Dominik Haumann
dhaumann added a comment. Unless you have a KDE commit account you can not commit yourself. Unfortunately we cannot see on Phabricator whether you have one or not. We can integrate this patch and then it will be in the next KDE Frameworks release, i.e. early next month. REPOSITORY R216

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment. In D15739#356254 , @ngraham wrote: > This argument doesn't make any sense to me. It's still there available via one click. I continue to fail to see how this change makes it not "easily accessible through Dolphin at

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 78 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/78/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Nov 2018 17:15:11 + Build duration: 3 min 28 sec and counting CONSOLE OUTPUT

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Noah Davis
ndavis added a comment. In D15739#356026 , @Codezela wrote: > maybe there is 2 alternatives > > 1. remove the icon from devices section and keep it in places section with some icon change in the top one You mean hide the root

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 77 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/77/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Nov 2018 17:02:41 + Build duration: 2 min 19 sec and counting CONSOLE OUTPUT

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, tcanabrava Cc: Codezela, davidc, tcanabrava, ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, acrouthamel,

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 79 - Still Failing!

2018-11-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/79/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Nov 2018 17:32:21 + Build duration: 4 min 14 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 80 - Fixed!

2018-11-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/80/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 08 Nov 2018 17:40:41 + Build duration: 3 min 37 sec and counting

D16466: [KSambaShare] Add unit test for "net usershare info" parser

2018-11-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. Only saw the note from @bcooksley now, pushed an intermediate disabling of the new test for windows, so the build at least passes: 160df8ed7b49f68e74d30cf4343a6251ed4085d8 Seems some