D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#359595 , @rjvbb wrote: > > Please, let's find the root causes and fix things at the base instead of adding such > > "we" (tried to not make this a "you" vs. "others" thing in the language, but

D16894: [ECM] use a macro to test compiler flag support

rjvbb added inline comments. INLINE COMMENTS > apol wrote in KDECompilerSettings.cmake:195 > Why can't we just use check_cxx_compiler_flag? We could of course. I worked under the assumption that is not done currently because checking only ID+version is faster. CMake's check_cxx_compiler_flag

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. > _If_ it is found that the root bug is in KTextEditor, sure. Each KTextEditor::ViewPrivate has a KateViewInternal instance that inherits QWidget and overrides the contextMenuEvent() method. In that override it obains a QMenu from ViewPrivate::contextMenu()

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

bruns added a comment. In D16498#359676 , @poboiko wrote: > It seems like you've pushed something that was not intended to be pushed (XML extractor parts) No. Phabricator is just stupid. REPOSITORY R286 KFileMetaData REVISION DETAIL

D16878: Resolve symlinks in exclude folders

bruns added a comment. Because it can never be consistent. What happens when I create two symlinks to the same folder, and put one link into includeFolders, the other one in excludeFolders? What really should happen, the indexer should **never** follow symlinks, but only add files by

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. So multiple contextMenu signals arrive in Kate too except they don't have any visible consequence. Let's see what the KTextEditor devs have to say about this. I'd rather stay away from getting too familiar with that framework, KXMLGUI even more.

D16905: Add a generic sorting options icon

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16905: Add a generic sorting options icon

ngraham added a comment. In D16905#360028 , @ndavis wrote: > You mean sort of like the arrow on `view-sort-ascending` but going both ways? F6425832: Screenshot_20181115_143752.png Exactly!

D16905: Add a generic sorting options icon

trickyricky26 planned changes to this revision. trickyricky26 added a comment. I have adjusted the arrows to fit the `view-sort-ascending` style: F6425856: sorting-icon-22-alt.png 22px F6425879: sorting-icon-16-alt.png

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360055 , @trickyricky26 wrote: > I have adjusted the arrows to fit the `view-sort-ascending` style: > > F6425856: sorting-icon-22-alt.png 22px > F6425879:

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added reviewers: VDG, Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze Cc: kde-frameworks-devel,

D16905: Add a generic sorting options icon

trickyricky26 added a comment. I do agree that the 22px version is clearer with two lines in between the arrows: F6425790: sorting-icon-22-alt.png To fit this into the 16px was difficult, however: F6425793: sorting-icon-16-alt.png

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

kossebau added a comment. In D16882#359888 , @rjvbb wrote: > > _If_ it is found that the root bug is in KTextEditor, sure. > See https://bugs.kde.org/show_bug.cgi?id=401069#c2 That looks like good work onto finding the

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. Friedrich W. H. Kossebau wrote on 20181115::17:41:58 re: "D16882 <https://phabricator.kde.org/D16882>: [KDevelop/Shell] prevent duplicate added contextmenu actions" > Please tell, are you not serious about using the CTags plugin and maintain

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb abandoned this revision. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16905: Add a generic sorting options icon

ndavis added subscribers: ngraham, ndavis. ndavis accepted this revision as: ndavis. ndavis added a comment. This revision is now accepted and ready to land. It looks good to me, but since @ngraham reported bug #393318, I'd like his opinion as well. Also, put this at the bottom of your

D16905: Add a generic sorting options icon

ngraham added a comment. Generally that was what I was looking for, thanks! I wonder how it would look with a vertical line or two between the arrows, though. Might make the concept a bit clearer? REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master)

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R295 KCMUtils BRANCH arc_focussearch (branched from master) REVISION DETAIL

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360021 , @ngraham wrote: > I was imagining vertical lines, not horizontal. A bit more like this (WARNING: exceptionally crude mockup approaching) > > F6425824: sorting-icon-22.png

D16751: Various grammar and capitalization fixes for UI consistency

ltoscano added a comment. Please see the comments in D16749 and D16750 , many of them apply also here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg, #localization Cc:

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel added a dependent revision: D16914: [Runners KCM] Focus the search field by default. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16905: Add a generic sorting options icon

ngraham added a comment. I was imagining vertical lines, not horizontal. A bit more like this (WARNING: exceptionally crude mockup approaching) F6425824: sorting-icon-22.png REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched

D16905: Add a generic sorting options icon

ndavis added a comment. In D16905#360075 , @trickyricky26 wrote: > So should I include the renaming of the existing icons and adding of the ascending and descending versions of these new ones in this revision? That way applications that use

D16905: Add a generic sorting options icon

ngraham added a comment. +1 to everything @ndavis is saying. I love the new double-arrow versions! Those are just what I had in mind. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham,

D16852: Add Documents to the default list of Places

acrouthamel added a comment. I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something? FAIL! :

D16905: Add a generic sorting options icon

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16905: Add a generic sorting options icon

ndavis added a comment. I think your original design looked the best. I don't think having lines extend to the area between the arrows makes the meaning significantly clearer. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16905: Add a generic sorting options icon

trickyricky26 added a comment. So should I include the renaming of the existing icons and add ascending and descending versions of these new ones in this revision? That way applications that use `view-sort-ascending` for alphabetical order will have it replaced, but I guess that's okay

D16878: Resolve symlinks in exclude folders

poboiko added a comment. In D16878#359442 , @bruns wrote: > IMHO we should just disallow specifying symlinks in both include/excludeFolders. The user can just use exludeFolders = /storage/stuff if he wants to exclude it. Why not? This

D16498: [KFileMetaData] Add extractor for DSC conforming (Encapsulated) Postscript

poboiko added a comment. It seems like you've pushed something related to XML extractor as well REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16498 To: bruns, #frameworks, #baloo, astippich, ngraham, poboiko Cc: pino, kde-frameworks-devel, ashaposhnikov,

D16876: [balooctl] Add possibility to create a copy of the index without freelist

poboiko added a comment. In D16876#359454 , @bruns wrote: > You are replicating `mdb_copy -c` here. > [...] Yep, I know. It's just there is no proper documentation for this issue (well, this applies for the whole baloo - T7843:

D16885: Delete the correct item in removeDesktop

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f25eadc92c47: Delete the correct item in removeDesktop (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16885?vs=45488=45504 REVISION

D16877: Cleanup windowInterface in tests before windowManagement is destroyed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16877 To: davidedmundson, #kwin, mart Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16880 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16883: Add VirtualDesktops to PlasmaWindowModel

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D16883 To: davidedmundson, #kwin, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16880: Update PlasmaWindowModel test to reflect VirtualDesktop changes

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f1c8b16a0026: Update PlasmaWindowModel test to reflect VirtualDesktop changes (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D16894: [ECM] use a macro to test compiler flag support

rjvbb created this revision. rjvbb added a reviewer: Build System. rjvbb added a project: Build System. Herald added a project: Frameworks. Herald added a subscriber: kde-buildsystem. rjvbb requested review of this revision. REVISION SUMMARY It is crucial not to add unsupported compiler options

D16877: Cleanup windowInterface in tests before windowManagement is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R127:06c18f5869f3: Cleanup windowInterface in tests before windowManagement is destroyed (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D16883: Add VirtualDesktops to PlasmaWindowModel

This revision was automatically updated to reflect the committed changes. Closed by commit R127:98b0ad34b68f: Add VirtualDesktops to PlasmaWindowModel (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16883?vs=45483=45512 REVISION

D16894: [ECM] use a macro to test compiler flag support

apol added inline comments. INLINE COMMENTS > KDECompilerSettings.cmake:195 > +# CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION > VERSION_LESS 6.0.0 > +macro (KDE_CHECK_CXX_COMPILER_FLAG _RESULT _FLAG) > +# treat the arguments following _FLAG as a boolean expression