D16951: Add mouse button icons

ndavis added a comment. In D16951#361317 , @ngraham wrote: > What about making the MMB turn white when it has the blue highlight? white MMB F642: Screenshot_20181118_005525.png white MMB

D16951: Add mouse button icons

ngraham added a comment. What about making the MMB turn white when it has the blue highlight? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16951: Add mouse button icons

ndavis added a comment. In D16951#361294 , @ngraham wrote: > Much better shape! > > What do you think about making the mouse wheel detached from the top of the mouse so it looks more like a wheel and less like a notch? Then also you might

D16913: Add the possibility to give focus to the KPluginSelector search field

ngraham added a comment. Why does this need a timer? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16852: Add Documents to the default list of Places

acrouthamel added a comment. In D16852#360940 , @elvisangelaccio wrote: > @acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out Ok, I created D16967

D16951: Add mouse button icons

abetts added a comment. Looks good to me +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16852: Add Documents to the default list of Places

acrouthamel added a dependent revision: D16967: Add Documents shortcut detection. REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel, #frameworks, #dolphin, ngraham Cc: davidc, elvisangelaccio,

D16951: Add mouse button icons

ngraham added a comment. Much better shape! What do you think about making the mouse wheel detached from the top of the mouse so it looks more like a wheel and less like a notch? Then also you might not need to omit it from `input-mouse-click-middle`' REPOSITORY R266 Breeze Icons

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

D16946: Port more search providers to HTTPS

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Those are mostly services with more complex URLs changes than just adding the extra 's' to get to HTTPS. The

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/128/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:16:45 + Build duration: 12 min and counting JUnit Tests Name: (root)

D16934: Add help-browser symlink to 16px and 22px directories

trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16934 To: trickyricky26, #breeze, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/32/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:18:42 + Build duration: 17 min and counting JUnit Tests Name: (root)

firewall-applet icons break breeze auto tests

Hi Noah, At the moment breeze-icons auto tests are failing with this error (both for icons and icons-dark) The following icons are not available in a scalable directory: firewall-applet-shields_up firewall-applet-panic firewall-applet firewall-applet-error This is because the test

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/53/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:21:25 + Build duration: 29 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 263 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/263/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:53:33 + Build duration: 5 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/72/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:16:45 + Build duration: 54 min and counting JUnit Tests Name: (root) Failed:

D16954: Add find module for Google's libphonenumber

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is currently in use by plasma-phone-components, but will also be needed by

D16929: Remove dead search provider

vkrause added a comment. In D16929#360646 , @cgiboudeaux wrote: > In D16929#360570 , @vkrause wrote: > > > Remove more dead search providers, just checking for non-resolving domains isn't enough.

D16929: Remove dead search provider

vkrause updated this revision to Diff 45632. vkrause added a comment. Restore dictfr.desktop, that actually still works, just not with HTTPS. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16929?vs=45609=45632 BRANCH master REVISION DETAIL

D16949: Support for TLS 1.3 (part of Qt 5.12)

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D16949 AFFECTED FILES src/core/ktcpsocket.cpp

Frameworks minimum Qt version raised to 5.9

I just executed the policy that says last three Qt versions, i.e. 5.9, 5.10 and 5.11 Cheers, Albert

D16951: Add mouse button icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add left, middle and right click icons for KDE Connect FEATURE: 399295 FIXED-IN:

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 15 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/15/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 17 Nov 2018 10:16:03 + Build duration: 8 min 34 sec and counting JUnit Tests Name:

D16951: Add mouse button icons

ndavis added a subscriber: nicolasfella. ndavis added a comment. @nicolasfella Will these work for you? Let me know if you need thumb buttons as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: nicolasfella,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 262 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/262/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:22:00 + Build duration: 31 min and counting JUnit Tests Name: (root)

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb updated this revision to Diff 45642. rjvbb added a comment. New patch, same purpose, active principle as outlined in the reopening comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16882?vs=45471=45642 REVISION DETAIL https://phabricator.kde.org/D16882 AFFECTED

kdoctools test if running uninstalled

Hey Ralf, the kdoctools_install test fails when running uninstalled (i.e. like how CI does) since it can't find kf5/kdoctools/customization I tried to make it work but doesn't seem it's going to be easy since meinproc really looks for the "kf5/kdoctools/customization" hierarchy that is

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/50/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:17:15 + Build duration: 56 min and counting JUnit Tests Name: (root)

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

pino created this revision. pino added a reviewer: kossebau. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY The Qt5Help CMake modules contain the Qt5::qhelpgenerator

D16951: Add mouse button icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/67/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:17:45 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/76/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:17:15 + Build duration: 28 min and counting JUnit Tests Name: (root)

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R32 KDevelop. REPOSITORY R32 KDevelop REVISION DETAIL https://phabricator.kde.org/D16882 To: rjvbb, #kdevelop, kossebau Cc: kossebau, kde-frameworks-devel,

D16857: Do not disconnect all StorageAccess signals when unmounting

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks, this fixes the bug for me. I think we can ship it on the stable branch (`Applications/18.12`) REPOSITORY R318 Dolphin BRANCH arc_remount_local (branched

Re: Regression in Frameworks - DBus Hangs

El diumenge, 11 de novembre de 2018, a les 11:29:51 CET, Albert Astals Cid va escriure: > El diumenge, 11 de novembre de 2018, a les 6:51:39 CET, Ben Cooksley va > escriure: > > On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley wrote: > > > > > > On Sat, Nov 3, 2018 at 4:41 PM Ben Cooksley wrote: >

Re: Regression in Frameworks - DBus Hangs

On Sat, Nov 17, 2018 at 9:31 PM Albert Astals Cid wrote: > > El diumenge, 11 de novembre de 2018, a les 11:29:51 CET, Albert Astals Cid va > escriure: > > El diumenge, 11 de novembre de 2018, a les 6:51:39 CET, Ben Cooksley va > > escriure: > > > On Thu, Nov 8, 2018 at 8:15 PM Ben Cooksley

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/130/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 10:15:28 + Build duration: 4 min 34 sec and counting JUnit Tests Name:

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb reclaimed this revision. rjvbb added a comment. This revision now requires changes to proceed. Re-opening because I found an actual flaw in KDevelop after noticing that context menu duplication still occurred when only the active view receives the aboutToShowContextMenu signal.

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/74/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:15:27 + Build duration: 50 min and counting JUnit Tests Name: (root) Failed:

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. In D16905#360586 , @trickyricky26 wrote: > - Fix naming of ascending and descending versions; make ascending versions less confusing; fix symlink sort-name > > I have flipped the naming of the ascending and

D7700: Show list of tags in PlacesView

elvisangelaccio added inline comments. INLINE COMMENTS > kfileplacesmodel.h:66 > +UnknownType, > +TagsType > }; This is missing a `///< @since 5.53` comment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 added a comment. I am sure that in ascending, the lines get longer further down (representing larger file sizes etc.). The thing I am not quite sure about is the direction of the arrows. In D16905#360524 , @cfeck wrote: > On

D16951: Add mouse button icons

ndavis added a comment. In D16951#360965 , @rizzitello wrote: > I think the Mouse itself needs a bit more curve with less box. I kind of agree. I was just copying the existing `dialog-input-devices` icon, but I suppose I could change

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/10/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 17 Nov 2018 11:23:28 + Build duration: 2 hr 8 min and counting JUnit Tests

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3f0c617e22ab: disconnect contextmenu from all aboutToXXContextMenu receivers (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16927?vs=45597=45664#toc REPOSITORY R39

D16857: Do not disconnect all StorageAccess signals when unmounting

This revision was automatically updated to reflect the committed changes. Closed by commit R318:e710a6431160: Do not disconnect all StorageAccess signals when unmounting (authored by thsurrel). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/84/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:21:13 + Build duration: 1 hr 8 min and counting JUnit Tests Name: (root) Failed:

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. In D16905#360938 , @trickyricky26 wrote: > I am sure that in ascending, the lines get longer further down (representing larger file sizes etc.). The thing I am not quite sure about is the direction of the arrows.

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

rjvbb added a comment. In case anyone wonders why this has gone undetected: I think because of an undocumented feature, the fact `aboutToShowContextMenu` was called for all views. Indeed, with the KTextEditor fix in place the duplication issue occurs also without loading the CTags plugin (=

D16951: Add mouse button icons

rizzitello added a comment. I think the Mouse itself needs a bit more curve with less box. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: rizzitello, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/66/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:20:01 + Build duration: 1 hr 1 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/26/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:18:42 + Build duration: 1 hr 1 min and counting JUnit Tests Name: (root)

D16852: Add Documents to the default list of Places

elvisangelaccio added a comment. @acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel,

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/33/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 11:23:28 + Build duration: 1 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/41/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 10:21:25 + Build duration: 1 hr 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.9/27/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 11:23:28 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed:

D16927: KTextEditor : disconnect contextmenu from all aboutToXXContextMenu receivers

cullmann added a comment. You are right. Please add some comment why one disconnects all things and push it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D16927 To: rjvbb, #ktexteditor, #frameworks, cullmann Cc: cullmann, kde-frameworks-devel, kwrite-devel,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 updated this revision to Diff 45667. trickyricky26 added a comment. - Switch arrow directions in ascending and descending variants REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45611=45667 BRANCH add-sort-options-icon

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel,

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis added a comment. See if yo can shorten the title down to 50 characters and if not that, see if you can get it down to below 80. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To:

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 retitled this revision from "Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme" to "Add new generic sorting icons; rename existing sorting icons". REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master)

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. Great! That will work. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel,

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. `sort.svg` uses the older version of your style. Make it a relative symlink to `view-sort.svg`. F6429080: Screenshot_20181117_130528.png

D16963: Fix running kdoctools-install autotest without kdoctools installed

aacid added a comment. Cool test passes now, **BUT** see comment INLINE COMMENTS > KF5DocToolsMacros.cmake:205 > set(_bootstrapOption "--srcdir=${KDocTools_BINARY_DIR}/src") > -set(_extraDependency "docbookl10nhelper") > elseif (CMAKE_CROSSCOMPILING AND

Re: firewall-applet icons break breeze auto tests

El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va escriure: > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > > Hi Noah, > > > > At the moment breeze-icons auto tests are failing with this error (both for > > icons and icons-dark) > > > > The

Increasing KF5 cmake requirement to 3.6?

The KF5 minimum cmake requirement sits at 3.0 I doubt anyone is using that to build KF5 so it's a bit of a "lie". I'm going to suggest it to increase it to 3.6, it would still most probably be a lie since i don't think any of use uses such an old (2 years version) either, but it'll be a

D16905: Add new generic sorting icons and rename existing alphabetic sorting icons to -name scheme

ndavis accepted this revision. ndavis added a comment. Unless someone has a final request, I think this is ready to land. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg,

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 added a comment. That was not supposed to be there anymore after we changed the name. I'm going to remove `sort.svg` REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis,

D16963: Fix running kdoctools-install autotest without kdoctools installed

habacker added a reviewer: aacid. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D16963 To: habacker, aacid Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16963: Fix running kdoctools-install autotest without kdoctools installed

habacker created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. habacker requested review of this revision. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D16963

Re: firewall-applet icons break breeze auto tests

On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > Hi Noah, > > At the moment breeze-icons auto tests are failing with this error (both for > icons and icons-dark) > > The following icons are not available in a scalable directory: > firewall-applet-shields_up >

D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Good find. No idea why it was not like this from the start. Untested (besides grepping my local Qt 5.11 CMake Config files to confirm myself that's really the place where the

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 updated this revision to Diff 45684. trickyricky26 added a comment. - Remove old sort.svg icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45667=45684 BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16964: Change archive-* action icons to represent archives

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16964 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. The margins on the 32px icons are different from other 32px icons. The existing ones use a 4px margin on each side. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli,

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 added a comment. Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on each size. So that graphic should be updated, or if the 4px margins only apply to

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 updated this revision to Diff 45689. trickyricky26 added a comment. - Change margins to 4px in 32px icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16905?vs=45684=45689 BRANCH add-sort-options-icon (branched from master)

D16963: Fix running kdoctools-install autotest without kdoctools installed

habacker marked an inline comment as done. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D16963 To: habacker, aacid Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D16905: Add new generic sorting icons; rename existing sorting icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:64b3a8fa6ff7: Add new generic sorting icons; rename existing sorting icons (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/132/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 20:36:21 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

RE: Increasing KF5 cmake requirement to 3.6?

> -Original Message- > I'm going to suggest it to increase it to 3.6, it would still most probably be a lie > since i don't think any of use uses such an old (2 years version) either We currently do still build the latest KDE Frameworks, Plasma, and Applications on/for openSUSE Leap 42.3

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis added a comment. In D16905#361148 , @trickyricky26 wrote: > Ok I will change that, however the graphic on the Icons HIG Page (https://hig.kde.org/_images/Breeze-icon-design-5.png) says a inner size of 28px which means 2px margins on

D16905: Add new generic sorting icons; rename existing sorting icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16905 To: trickyricky26, #vdg, #breeze, ndavis Cc: cfeck, emateli, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D16963: Fix running kdoctools-install autotest without kdoctools installed

habacker updated this revision to Diff 45690. habacker added a comment. - fix parallel builds REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16963?vs=45685=45690 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16963 AFFECTED FILES

D16905: Add new generic sorting icons; rename existing sorting icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I will land this now. There's nothing left that needs to be done. REPOSITORY R266 Breeze Icons BRANCH add-sort-options-icon (branched from master) REVISION DETAIL

D16934: Add help-browser symlink to 16px and 22px directories

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This is a very simple change that doesn't need much reviewing. I see no reason not to land this now. REPOSITORY R266 Breeze Icons BRANCH fix-help-browser-symlink (branched from

D16934: Add help-browser symlink to 16px and 22px directories

This revision was automatically updated to reflect the committed changes. Closed by commit R266:ae50e26abbad: Add help-browser symlink to 16px and 22px directories (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/75/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 20:31:29 + Build duration: 4 min 38 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/131/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 17 Nov 2018 20:31:29 + Build duration: 1 min 30 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/76/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sat, 17 Nov 2018 20:36:21 + Build duration: 4 min 31 sec and counting JUnit Tests Name: (root)

Re: Increasing KF5 cmake requirement to 3.5?

El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va escriure: > > -Original Message- > > I'm going to suggest it to increase it to 3.6, it would still most > probably be a lie > > since i don't think any of use uses such an old (2 years version) either > > We

Re: firewall-applet icons break breeze auto tests

On Saturday, November 17, 2018 11:17:15 AM EST Albert Astals Cid wrote: > El dissabte, 17 de novembre de 2018, a les 14:03:45 CET, Noah Davis va escriure: > > On Saturday, November 17, 2018 5:37:36 AM EST Albert Astals Cid wrote: > > > Hi Noah, > > > > > > At the moment breeze-icons auto tests

D16963: Fix running kdoctools-install autotest without kdoctools installed

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Works, I'm not a kdoctools *real* expert so maybe you want to wait for someone else to approve, but i'd say just commit, i mean i don't think it's worse than what we have now and the test

D16964: Change archive-* action icons to represent archives

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH change-archive-action-icons (branched from master) REVISION DETAIL

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/13/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 17 Nov 2018 10:19:48 + Build duration: 14 hr and counting JUnit Tests

D16966: Fix typo in i18n message (cmdline option description)

aspotashev created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R290 KPackage BRANCH opt-i18n REVISION DETAIL https://phabricator.kde.org/D16966 AFFECTED

D16951: Add mouse button icons

ngraham added a comment. +1 for more curves. That rectangle doesn't particular scream "I'm a mouse!" to me. `dialog-input-devices` itself is pretty lousy, honestly. It would also use a bit of sprucing up rather than copying its style. REPOSITORY R266 Breeze Icons REVISION DETAIL

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, ngraham, bruns

D16964: Change archive-* action icons to represent archives

ndavis accepted this revision. ndavis added a comment. In D16964#361229 , @ngraham wrote: > Beautiful, just what I had in mind! Amazing what a little zipper will do. @ndavis, does this look good to you too? It's consistent with other

  1   2   >