D18243: Fix qmake module generation for Qt 5.12.1

2019-01-14 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Patch by Eike Ziller from https://github.com/KDAB/GammaRay/pull/526 in response to Qt

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

2019-01-14 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY A client (kscreen-doctor especially) can disconnect whilst kwin

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49457. jriddell added a comment. - style fixes whitespace REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49456=49457 BRANCH arcpatch-D10716 REVISION DETAIL https://phabricator.kde.org/D10716 AFFECTED

D18243: Fix qmake module generation for Qt 5.12.1

2019-01-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:79bf23008f66: Fix qmake module generation for Qt 5.12.1 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18243?vs=49447=49449

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Nathaniel Graham
ngraham added a subscriber: starbuck. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

2019-01-14 Thread loh tar
loh.tar updated this revision to Diff 49452. loh.tar retitled this revision from "DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection" to "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection". loh.tar edited

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. lgtm REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Fabian Vogt
fvogt requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

2019-01-14 Thread Oswald Buddenhagen
ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. yay, i finally have "some" time for this. ^^ it took me a while to get a coherent picture of the problem and solution, because your description unnecessarily dwells on the

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

2019-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 14 Jan 2019 17:02:47 + Build duration: 6 min 18 sec and counting JUnit Tests Name:

D18243: Fix qmake module generation for Qt 5.12.1

2019-01-14 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D18243 To: vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49454. jriddell added a comment. - revert enum, make strings const, add licence header REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49442=49454 BRANCH arcpatch-D10716 REVISION DETAIL

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49456. jriddell added a comment. - make string const, follow normal code style of pointer * being with variable name not the type REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49454=49456 BRANCH

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49459. jriddell added a comment. - make test lgpl, link configcore instead of service REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49457=49459 BRANCH arcpatch-D10716 REVISION DETAIL

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell marked 3 inline comments as done. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell marked an inline comment as done. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

2019-01-14 Thread Vlad Zagorodniy
zzag added a comment. If I understand it correctly, KWin tries to notify whether the changes have been applied successfully after the interface was unbound, but before OutputConfigurationInterface object is deleted, is it correct? (sorry if that's a stupid question) REPOSITORY R127

D11235: [DrKonqi] Request change of ptrace scope from KCrash

2019-01-14 Thread Oswald Buddenhagen
ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > debuggerlaunchers.cpp:57 > if ( pid > 0 ) { > +queryPtrace(pid); > m_monitor->startMonitoring(pid); according to my reading of the

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

2019-01-14 Thread David Edmundson
davidedmundson added a comment. Yep REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18248 To: davidedmundson, #kwin Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

2019-01-14 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. OK, makes sense. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D18248 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, michaelh,

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

2019-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/3/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 14 Jan 2019 17:02:47 + Build duration: 13 min and counting BUILD ARTIFACTS

D18248: Guard resource deletion in OuptutConfiguration::sendApplied

2019-01-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:9b0a3dcfeae0: Guard resource deletion in OuptutConfiguration::sendApplied (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D18191: Rebuild AAR when Java sources change

2019-01-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:400ce7bc5f93: Rebuild AAR when Java sources change (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18191?vs=49265=49470 REVISION

D18192: Remove unused forward declaration

2019-01-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:b2c0b2748447: Remove unused forward declaration (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18192?vs=49266=49471 REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

2019-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 14 Jan 2019 17:02:47 + Build duration: 18 min and counting BUILD ARTIFACTS

D18249: [datamodel] Rework items insert/remove

2019-01-14 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > datamodel.cpp:55-61 > +const QHash roles = sourceModel()->roleNames(); > +m_roleIds.reserve(roles.count()); > +for (auto i = roles.constBegin(); i != roles.constEnd(); ++i) { > m_roleIds[QString::fromUtf8(i.value())] =

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > fvogt wrote in suprocess.h:75 > Just use 0 instead - the enum isn't meant for that apparently. This is still there, so not done yet. The enum SuErrors is (apparently) not meant to be used by callers of exec as they have different accessibility.

D18249: [datamodel] Rework items insert/remove

2019-01-14 Thread Anthony Fieroni
anthonyfieroni created this revision. anthonyfieroni added reviewers: davidedmundson, broulik, ngraham, mart, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY I give a try to rework

D17816: Support for xattrs on kio copy/move

2019-01-14 Thread Cochise César
cochise updated this revision to Diff 49487. cochise marked 3 inline comments as done. cochise added a comment. Use subjobs on file_copy and other small fixes Not using subjobs in KIO::copy, as it breakes the tests. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17797: Include applets/22

2019-01-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d5a2b47c2d37: Include applets/22 (authored by nicolasfella, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17797?vs=49294=49495

D18253: Move the Android API level checks to runtime

2019-01-14 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This doesn't make notifications on API level < 23 work yet, but it allows us to build against lower API levels and

D18253: Move the Android API level checks to runtime

2019-01-14 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Maybe we could print something for adb logcat that says that notifications won't be working? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL

22.-26. March 2019, Leipzig - KDE Privacy Sprint

2019-01-14 Thread Sandro Knauß
Hi, The Privacy sprint is coming we're happy to announce the preliminary date as 22.-26. March 2019 in Leipzig, Germany and we're looking forward to seeing you there. So please give us feedback, if you want to come. You can also get reimbursement via https://reimbursements.kde.org We're

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-14 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > zzag wrote in test_plasma_virtual_desktop.cpp:280 > QVERIFY why? we want to compare the number of rows, no? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D17691 To: mart, #plasma, #kwin Cc: zzag, davidedmundson, hein,

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-14 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > mart wrote in test_plasma_virtual_desktop.cpp:280 > why? we want to compare the number of rows, no? What if rowsChanged is never emitted? In KWin, we usually do QVERIFY(spy.wait()); REPOSITORY R127 KWayland REVISION DETAIL

D18178: fix environment setup of klanguagename test

2019-01-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R265:5ba6283e4ec1: fix environment setup of klanguagename test (authored by sitter). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18178?vs=49224=49433

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-14 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in plasma-virtual-desktop.xml:56 > This needs to be in a version 2 and done at the end with appropriate bumps > everywhere. This isn't done. REPOSITORY R127 KWayland REVISION DETAIL

D18191: Rebuild AAR when Java sources change

2019-01-14 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D18191 To: vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > jriddell wrote in suprocess.h:75 > yes > autotests/kdesutest.cpp:40:45: error: ‘KDESu::SuProcess::SuErrors ok’ is > private within this context Just use 0 instead - the enum isn't meant for that apparently. REPOSITORY R299 KDESu REVISION

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell marked an inline comment as done. REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49442. jriddell marked 2 inline comments as done. jriddell added a comment. - Just use 0 instead - the enum isnt meant for that apparently. REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49440=49442 BRANCH

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Harald Sitter
sitter added a comment. BUILD_TESTING easy fix: https://phabricator.kde.org/source/knotifyconfig/browse/master/CMakeLists.txt$60 REPOSITORY R299 KDESu REVISION DETAIL https://phabricator.kde.org/D10716 To: jriddell, sitter, fvogt Cc: fvogt, kde-frameworks-devel, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

2019-01-14 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 14 Jan 2019 12:39:35 + Build duration: 6 min 42 sec and counting JUnit Tests Name:

D17528: Refactor SlaveInterface::calcSpeed

2019-01-14 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > fvogt wrote in slaveinterface.cpp:114 > What does this actually test for? This results in a fast ramp up when the transfer has stalled for more than ~8 seconds, like at the begin of a transfer. Likely needs a comment. > fvogt wrote in

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell marked an inline comment as done. jriddell added inline comments. INLINE COMMENTS > fvogt wrote in suprocess.h:75 > Still necessary? yes autotests/kdesutest.cpp:40:45: error: ‘KDESu::SuProcess::SuErrors ok’ is private within this context REPOSITORY R299 KDESu REVISION DETAIL

D17528: Refactor SlaveInterface::calcSpeed

2019-01-14 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > fvogt wrote in slaveinterface.cpp:111 > This is undefined behaviour if the vector is empty. Initial item is set to {0,0} before calcSpeed is called. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17528 To: chinmoyr,

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-14 Thread Marco Martin
mart updated this revision to Diff 49425. mart added a comment. - verify the signal has been emitted REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17691?vs=47854=49425 BRANCH phab/virtualdesktoprows REVISION DETAIL

D17528: Refactor SlaveInterface::calcSpeed

2019-01-14 Thread Fabian Vogt
fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > slaveinterface.cpp:102 > +// Note for future reference: A list is maintained for sizes and times. > +// Minimum list size is 1 and maximum list size is

D10716: handle wrong password when using sudo which asks for another password

2019-01-14 Thread Jonathan Riddell
jriddell updated this revision to Diff 49440. jriddell added a comment. - only build tests if BUILD_TESTING is set - use QStringLiteral REPOSITORY R299 KDESu CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10716?vs=49244=49440 BRANCH arcpatch-D10716 REVISION DETAIL

D17691: Add rows info to the plasma virtual desktop protocol

2019-01-14 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > plasmavirtualdesktop_interface.h:55 > + * Sets how many rows the virtual desktops should be laid into > + * @since 5.53 > + */ Wrong version. > davidedmundson wrote in plasmavirtualdesktop_interface.h:51 > Is this even implemented?? I

D18178: fix environment setup of klanguagename test

2019-01-14 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D18178 To: sitter, aacid, rikmills Cc: kde-frameworks-devel, michaelh, ngraham, bruns