D18563: Don' allow '/' in new directory's name

shubham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't allow '/' in new directory's name

shubham retitled this revision from "Don' allow '/' in new directory's name" to "Don't allow '/' in new directory's name". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18527: List Android as officially supported

vkrause added a comment. In D18527#400726 , @bcooksley wrote: > If the following could be corrected before this is landed that would be appreciated: >

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 15 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/15/ Project: kf5-qt5 AndroidQt5.11 Date of build: Sun, 27 Jan 2019 10:18:39 + Build duration: 2 min 23 sec and counting CONSOLE OUTPUT

D18563: Don' allow '/' in new directory's name

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY UNIX system does not support '/' in any valid identifier name, but for Windows its

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Jan 2019 12:17:20 + Build duration: 3 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 37 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/37/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 27 Jan 2019 10:18:40 + Build duration: 12 min and counting JUnit Tests

D18434: exiv2extractor: add support for bmp, gif, webp, tga

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH covergiftgabmp REVISION DETAIL https://phabricator.kde.org/D18434 To: kossebau, #baloo, #dolphin, astippich Cc: aacid, kde-frameworks-devel, ashaposhnikov, michaelh,

D18475: Add AsciiDoc support

dhaumann added a comment. Running the katesyntaxhighlighting indexer tells me: katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists: "admonition" Could you fix this? Usually, keyword completion should be context

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 27 Jan 2019 11:29:50 + Build duration: 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/4/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 Jan 2019 11:29:50 + Build duration: 1 min 25 sec and counting BUILD ARTIFACTS

D18380: KIO: make file dialog columns resizable again (and movable)

rjvbb added a comment. > But still, isn't there another way? Now the header and view are locked together. One doesn't work without the other. What's the problem with that? The custom header class isn't public. I did indeed use it for stuff that were not part of a class, or of the

D18526: Fix memory leak when passing icon data to Java

This revision was automatically updated to reflect the committed changes. Closed by commit R289:874cb8e5a728: Fix memory leak when passing icon data to Java (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18526?vs=50262=50372

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Jan 2019 11:51:30 + Build duration: 3 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/5/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 Jan 2019 11:51:30 + Build duration: 1 min 34 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 27 Jan 2019 11:51:30 + Build duration: 47 sec and counting JUnit Tests Name:

D18450: Add extractor for AppImage files

astippich added a comment. I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building libappimage, but now I can't get it to work in KFileMetaData because cmake complains that

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 27 Jan 2019 11:29:50 + Build duration: 4 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/6/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 27 Jan 2019 12:17:20 + Build duration: 1 min 29 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/7/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 27 Jan 2019 12:17:20 + Build duration: 1 min 6 sec and counting JUnit Tests Name:

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50382. andreasgr added a comment. Drop custom colors and backgrounds. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50263=50382 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED

D18380: KIO: make file dialog columns resizable again (and movable)

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I too would quite like the to have resizeable columns back. But the approach you've chosen looks a little too complicated. Also, the fact that KDirOperatorDetailView::event needs

D18380: KIO: make file dialog columns resizable again (and movable)

ngraham added a comment. In D18380#400896 , @markg wrote: > In QHeaderView code, what we want is "QHeaderView::Interactive" [1] followed by QHeaderView::resizeSection [2]. Exactly as [1] described! QHeaderView merely lacks a convenience

D18563: Don't allow '/' in new directory's name

ngraham requested changes to this revision. ngraham added reviewers: Frameworks, Dolphin. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > knewfilemenu.cpp:907 > if (name.contains(QLatin1Char('/'))) { > +// Allow creating directory tree

D18380: KIO: make file dialog columns resizable again (and movable)

markg added a comment. In D18380#400903 , @ngraham wrote: > In D18380#400896 , @markg wrote: > > > In QHeaderView code, what we want is "QHeaderView::Interactive" [1] followed by

D18450: Add extractor for AppImage files

TheAssassin added a comment. In D18450#400865 , @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400893 , @dhaumann wrote: > Running the katesyntaxhighlighting indexer tells me: > > katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists:

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

mwolff resigned from this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: loh.tar, anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D18434: exiv2extractor: add support for bmp, gif, webp, tga

This revision was automatically updated to reflect the committed changes. Closed by commit R286:6bc922351db0: exiv2extractor: add support for bmp, gif, webp, tga (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18434?vs=50016=50400

D18380: KIO: make file dialog columns resizable again (and movable)

markg added a comment. In D18380#400910 , @rjvbb wrote: > > But still, isn't there another way? Now the header and view are locked together. One doesn't work without the other. > > What's the problem with that? The custom header class isn't

D18475: Add AsciiDoc support

nibags added a comment. If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal). I have done this in some highlight files REPOSITORY R216 Syntax Highlighting

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham,

D18450: Add extractor for AppImage files

kossebau added a comment. In D18450#400865 , @astippich wrote: > I am having troubles getting it to build (Kubuntu 18.10). Unfortunately, I could not find pre-build packages for libappimage. I have overcome two small issues in building

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

rjvbb added a comment. > like René says, this is quite surprising Hmmm, did I say exactly that? :) The surpising bit is that this hasn't been an issue for much longer although maybe even that is not so surprising. I continue to think that the check is not reliable as is. For

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. In D16894#400949 , @dfaure wrote: > This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?".

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb updated this revision to Diff 50399. rjvbb added a comment. Renamed macro and parameter names as announced in my last comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16894?vs=45786=50399 REVISION DETAIL https://phabricator.kde.org/D16894 AFFECTED FILES

D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang

dfaure accepted this revision. dfaure added a comment. If it fixes the issue, this can go in, but like René says, this is quite surprising, since the default behavior (CMP0025 off) is that the compiler is called "Clang" on Apple platforms as well. See `cmake --help-policy CMP0025`

D16894: [ECM] use a macro to add compiler flags conditionally

dfaure added a comment. This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?". I think this should be something like TRY_IF. Then it's clearer that no harm will occur

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50388. andreasgr added a comment. - Drop unused 'admonition' keyword list. - Rename itemData elements to start with capital letters. - Enable escaping in block and section titles. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50390. andreasgr added a comment. - Added test AsciiDoc. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50388=50390 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50391. andreasgr added a comment. Fix diff. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50390=50391 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES

D18563: Don't allow '/' in new directory's name

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't allow '/' in new directory's name

shubham updated this revision to Diff 50410. shubham added a comment. Don't create directory tree on Windows, instead create a directory REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18563?vs=50367=50410 BRANCH dir REVISION DETAIL

D18516: Fix end of folding region in rules with lookAhead=true

nibags removed a reviewer: KTextEditor. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18516 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, #ktexteditor Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns,

D18563: Don't allow '/' in new directory's name

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't allow '/' in new directory's name

shubham added a comment. If there already exists a folder named a, then creating directory named a/b still works, and creates a child directory named b inside a. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin Cc:

D18563: Don't allow '/' in new directory's name

shubham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17991: Refactor the way device backends are built and registered

pino added a comment. ping? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18516: Fix end of folding region in rules with lookAhead=true

nibags added a comment. Some highlighters use endRegion+lookAhead to determine the end of a region when a new one starts, that is, they don't consider the text with endRegion+lookAhead as part of the fold region. This behavior was present before the implementation of KSyntaxHighlighting