D18904: [FileCopyJob] Clean up after file copy operation is cancelled

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Ah, the free space check in CopyJob doesn't take into account that it's an overwrite? Heh, two bugs canceling each other, in a way ;-) In the situation I describe, there *is* space to

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/33/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 08:54:59 + Build duration: 16 min and counting BUILD ARTIFACTS

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar updated this revision to Diff 53501. loh.tar added a comment. - Do nothing in persistent selection mode CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19621?vs=53470=53501 REVISION DETAIL https://phabricator.kde.org/D19621 AFFECTED FILES src/view/kateview.cpp To:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:39:58 + Build duration: 27 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/40/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:41:12 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/14/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:43:28 + Build duration: 36 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/14/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:43:28 + Build duration: 35 min and counting JUnit Tests Name:

D19586: [CopyJob] Treat URL as dirty when renaming file as conflict resolution

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19586 To: broulik, dfaure, chinmoyr Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:41:13 + Build duration: 1 hr 25 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:39:58 + Build duration: 1 hr 24 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/52/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 10:15:39 + Build duration: 51 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 11:14:16 + Build duration: 31 min and counting BUILD ARTIFACTS

D19621: ViewPrivate: Make deselection by arrow keys more handy

brauch added a comment. Hm, so shift-selecting with Shift+Left 5 times, then pressing Shift+Right once clears the selection? Just for the statistics, deselecting one character is a feature I use all the time. Why is this behaviour helpful? If you want to clear the selection, press Esc.

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar added a comment. > 2. Please test with right to left text layout, and mixed text layout. Can't say what is to be expect in such case, so test is difficult for me REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: brauch, dhaumann, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 46 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/46/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 08:54:59 + Build duration: 34 min and counting BUILD ARTIFACTS

D19313: Remove URLs being fetched when listing job is `completed`

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio, #frameworks, #dolphin, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:44:19 + Build duration: 39 min and counting JUnit Tests Name:

D19583: [KUiServerJobTracker] Update destUrl before finishing the job

dfaure added a comment. Looks ok, but the commit log is missing an actual use case. In which case does the dest URL change, exactly? REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19583 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/47/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:42:10 + Build duration: 48 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/12/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:45:06 + Build duration: 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kemoticons » kf5-qt5 WindowsMSVCQt5.11 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kemoticons/job/kf5-qt5%20WindowsMSVCQt5.11/30/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 09 Mar 2019 09:41:06 + Build duration: 59 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:46:17 + Build duration: 1 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/48/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 10:30:37 + Build duration: 23 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 49 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/49/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 09 Mar 2019 09:43:15 + Build duration: 1 hr 44 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/21/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:44:53 + Build duration: 1 hr 44 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:45:06 + Build duration: 1 hr 48 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 11:47:42 + Build duration: 17 min and counting BUILD ARTIFACTS

D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann added a comment. @brauch I think you misunderstood: Select a text in any Qt application (line edit, ...), and then see what happens if you or without holding shift down. This patch is a good one, we just need to sort out possible regressions, and that's it. REPOSITORY R39

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/25/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:38:24 + Build duration: 8 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/51/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:42:10 + Build duration: 33 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/31/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:44:53 + Build duration: 51 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/39/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:45:50 + Build duration: 1 hr 3 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/34/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:42:10 + Build duration: 1 hr 32 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/11/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:43:28 + Build duration: 1 hr 32 min and counting BUILD ARTIFACTS

D19620: Use a searchbar similar to the one in okular

ognarb edited the summary of this revision. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 To: ognarb, #vdg, #frameworks, ndavis, ngraham Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:45:49 + Build duration: 1 hr 51 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/50/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 08:54:59 + Build duration: 7 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/16/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:40:28 + Build duration: 29 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/26/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:44:53 + Build duration: 49 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/43/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:45:50 + Build duration: 1 hr 3 min and counting JUnit Tests

D19620: Use a searchbar similar to the one in okular

ognarb updated this revision to Diff 53505. ognarb added a comment. Add icons REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19620?vs=53488=53505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19620 AFFECTED FILES

D19313: Remove URLs being fetched when listing job is `completed`

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This makes a lot of sense. I trust that you checked that kdirmodeltest still passes? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19313 To: dpalacio,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 11:16:12 + Build duration: 31 min and counting BUILD ARTIFACTS

D19629: Change media-skip* and media-seek* style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19629?vs=53494=53510 REVISION

KDE CI: Frameworks » frameworkintegration » kf5-qt5 SUSEQt5.10 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20SUSEQt5.10/10/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 09:38:49 + Build duration: 16 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/23/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:39:57 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/15/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:40:39 + Build duration: 16 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:40:28 + Build duration: 19 min and counting JUnit Tests Name:

D19585: [CopyJob] Report results after finishing copy

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. It makes more sense to me to do the final report when we're fully done. How about adding a case statement for STATE_SETTING_DIR_ATTRIBUTES to the switch in slotReport? This

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/13/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 09:45:06 + Build duration: 58 min and counting JUnit Tests Name:

D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann added a comment. Looks good, now just the autotest is missing :-) REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns, demsking, cullmann,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/53/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 09 Mar 2019 11:16:12 + Build duration: 8 min 42 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 11:45:56 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar updated this revision to Diff 53508. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Add autotest REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19621?vs=53501=53508 REVISION DETAIL

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53516. ndavis edited the test plan for this revision. ndavis added a comment. Rename window-maximized to window-restore for better 3rd party compatibility REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19557: Update css

ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469=53521 BRANCH master REVISION DETAIL

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ngraham added a comment. Also `window-shade`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. @valeriymalov - are you going to update this? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D11828: Simplify orPostingIterator and make it faster

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks, poboiko Cc: fvogt, kde-frameworks-devel, #frameworks, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19557: Update css

bruns added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? The logo is just 2 colors, and the PNG is smaller than the JPEG, without introducing artifacts. I would definitely prefer a PNG

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19644: Reduce balooctl index/clear memory usage

davispuh created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davispuh requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D19644 AFFECTED FILES

D19633: Improve consistency of window-* and add more

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19635: Fix for showing argument hint tree on non-primary screen.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given all other calls use m_parent->... for the screenGeometry call, this looks sane. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D19575: Add collapse-all and expand-all action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY go-up/down is more appropriate because go-top/bottom is supposed to be for skipping to the

D19621: ViewPrivate: Make deselection by arrow keys more handy

cullmann added a comment. I think for the bidi stuff, one needs to honor the if (m_viewInternal->m_view->currentTextLine().isRightToLeft()) flag. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann,

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I guess this is ok, please increment the version of the syntax file and this can go in. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R216 Syntax Highlighting BRANCH octave-weak-delimiter REVISION DETAIL https://phabricator.kde.org/D19570 To: sirgienko, #framework_syntax_highlighting,

D19575: Add collapse-all and expand-all action icons

trickyricky26 updated this revision to Diff 53522. trickyricky26 added a comment. - Use design by @ndavis with tighter spacing REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53430=53522 BRANCH collapse-expand-all-icons (branched from

D19633: Improve consistency of window-* and add more

ndavis added a comment. In D19633#427913 , @ngraham wrote: > Neat! Very helpful, thanks. > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 Yes, but I'm not sure

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19641 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19644: Reduce balooctl index/clear memory usage

bruns added a comment. A transaction can not be split up, thats the reason it is a transaction ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19644 To: davispuh Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

sirgienko updated this revision to Diff 53515. sirgienko added a comment. Increase syntax file version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19570?vs=53292=53515 BRANCH octave-weak-delimiter REVISION DETAIL

D19532: Don't crash when no contexts are present

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7289a7088065: fix highlighter crash for broken hl file (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19532?vs=53234=53517#toc REPOSITORY R216 Syntax Highlighting

D19635: Fix for showing argument hint tree on non-primary screen.

tfry created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. tfry requested review of this revision. REVISION SUMMARY If the texteditor window is on a secondary screen of a multi-screen desktop, *and* the argument hint has

D11828: Simplify orPostingIterator and make it faster

bruns updated this revision to Diff 53527. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=36944=53527 BRANCH speedup_orpostingoperator REVISION DETAIL https://phabricator.kde.org/D11828 AFFECTED FILES

D19633: Improve consistency of window-* and add more

ngraham added a comment. Neat! Very helpful, thanks. While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham,

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19639 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add window-keep-above/below Add window-maximize/maximized/minimize Change

D19532: Don't crash when no contexts are present

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I will commit the minimal needed fix to get this solved. REPOSITORY R216 Syntax Highlighting BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh,

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Perhaps in addition to the message, one should just add a menu entry in Tools like "Read Only Mode", then the user can turn it of again. And as said, I think one needs some

D19621: ViewPrivate: Make deselection by arrow keys more handy

brauch added a comment. Sorry, yeah, I misunderstood! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns,

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Once D19575 lands, the style of `go-top` will

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These icons had subtle alignment issues. They weren't even always visible, but it's a

D19557: Update css

ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

bruns added a comment. In D19557#428096 , @ognarb wrote: > Lol 128x128 png image 6kb, 129x129 png image 2kb The new PNG is fuzzy, thats probably the reason it does not compress well. Try exporting it with inkscape, and check if the

D19557: Update css

ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella created this revision. nicolasfella added reviewers: VDG, apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH settings REVISION DETAIL

D19644: Reduce balooctl index/clear memory usage

davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added reviewers: dhaumann, bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19644 To: davispuh, dhaumann, bruns, ngraham Cc: bruns, kde-frameworks-devel,

D19557: Update css

ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

bruns added a comment. and now, apply optipng and you are down to 2kB REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19644: Reduce balooctl index/clear memory usage

davispuh updated this revision to Diff 53549. davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added a comment. Don't create transaction for every file REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D19644: Reduce balooctl index/clear memory usage

davispuh added a comment. In D19644#428074 , @bruns wrote: > Do not create a new transaction per file, thats costly. Still less expensive than single transaction for 1k files REPOSITORY R293 Baloo REVISION DETAIL

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 53551. nicolasfella added a comment. - Use i18n REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=53550=53551 BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150 AFFECTED FILES

  1   2   >