D19092: Add bison minimum version of 2.4.1 due to %code

This revision was automatically updated to reflect the committed changes. Closed by commit R309:6b46411622b0: Add bison minimum version of 2.4.1 due to %code (authored by hindenburg). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19092?vs=51902=55031

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 55033. hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. - Add ensureInitialized(), entry() changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=55025=55033 BRANCH

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 4 inline comments as done. hoffmannrobert added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:362 > There is one thing I've been wondering back and forth about: the alternative > way of doing this, which is to call init() unconditionally and testing the

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/17/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 29 Mar 2019 14:02:13 + Build duration: 1 min 22 sec and counting JUnit Tests Name:

D20032: Convert string formatting tests to be data driven

apol added a subscriber: mgallien. apol added inline comments. INLINE COMMENTS > bruns wrote in propertyinfotest.cpp:71 > Still not convinced? Not really, but if @mgallien, who is the maintainer, is fine with it, I'm fine too. After all it's still better than what we used to have. REPOSITORY

D20032: Convert string formatting tests to be data driven

bruns added a comment. @apol - do you have a proposal how to avoid the "weird struct" and still keep it readable? Preferably, no repetition of the Property, and no extra explicit constructors. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20032 To: bruns,

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks! Looks nice now. I don't see you in the list of developer accounts, so I guess you need someone to push this for you? REPOSITORY R241 KIO BRANCH add_skipStat REVISION

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. Yes, please, and https://phabricator.kde.org/D19784 too. REPOSITORY R241 KIO BRANCH add_skipStat REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc:

D19764: Fix Minimap with QtCurve style

sars added reviewers: dhaumann, cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19764 To: sars, brauch, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: CI system maintainability

On Fri, Mar 29, 2019 at 10:33 PM Friedrich W. H. Kossebau wrote: > > Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > > Le

Re: CI system maintainability

On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl wrote: > > Hi, Hi, > > (Sorry for top-posting) > > I fear that a mandatory reviews would add too juch strain on smaller teams. > If there's just one person with an intimate knowledge of the code-base, plus > two co-developers, then who

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. @otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name. REPOSITORY R266

D20092: New class KOSRelease - a parser for os-release files

aacid added a comment. Just to make sure, have you checked the log to make sure everyone involved in the class agrees to GPL -> LGPL? REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20092 To: sitter, apol Cc: aacid, mpyne, kde-frameworks-devel,

D5656: Adds method to force the reloading of a document

pedroarthurp abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc: kde-frameworks-devel, anthonyfieroni, nalvarez, kwrite-devel, gennad, domson, michaelh, ngraham, bruns, demsking,

Re: CI system maintainability

On Fri, Mar 29, 2019 at 10:35 PM David Faure wrote: > > On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote: > > CI: sometime I look at it, sometime not, sometime some guys informs me that > > it's broken (I remember that Luca told me some days ago that a package > > didn't compile, so I

Re: CI system maintainability

On Fri, Mar 29, 2019 at 9:56 PM Kevin Ottens wrote: > > Hello, > > On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > > I and others tried to get more reviews done in the past, but actually I > > merged more than once stuff that I reviewed but it did break the CI. > >

D20102: [timeline] Fix missing/misplaced SlaveBase::finished() calls

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH timeline REVISION DETAIL https://phabricator.kde.org/D20102 To: bruns, #baloo, #frameworks, poboiko, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20104: [balooshow] Several extensions basic file information output

bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.cpp:171 > Could we use user-friendly terms here? balooctl is a lowlevel tool, I see no reason to. Also, ISODate is completely self describing and non-anbiguous (Timezone, Year/Day/Month ordering, ...) REPOSITORY R293 Baloo

D19764: Fix Minimap with QtCurve style

brauch accepted this revision. brauch added a comment. This revision is now accepted and ready to land. Looks sensible, and I think I've even seen this bug already somewhere. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19764 To: sars, brauch, dhaumann,

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 01:06:21 + Build duration: 13 min and counting BUILD ARTIFACTS

D20104: [balooshow] Several extensions basic file information output

ngraham added inline comments. INLINE COMMENTS > main.cpp:171 > + << > QDateTime::fromSecsSinceEpoch(time.mTime).toString(Qt::ISODate) > + << QLatin1String("\n\tCtime: ") << time.cTime << QChar(' ') > + << >

D20101: [timeline] Canonicalize Url

bruns updated this revision to Diff 55049. bruns added a comment. use explicit type name REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20101?vs=55007=55049 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20101 AFFECTED FILES

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/38/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 02:36:17 + Build duration: 13 min and counting BUILD ARTIFACTS

D20104: [balooshow] Several extensions basic file information output

bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.cpp:171 > Still, not everyone who uses it would know what "Ctime" means (for example). > It's not a huge deal... but I think it would be nice. The meaning of ctime is too complex to be grasped in one or two words. Anyone who

D20102: [timeline] Fix missing/misplaced SlaveBase::finished() calls

This revision was automatically updated to reflect the committed changes. Closed by commit R293:fb3fb089c4bc: [timeline] Fix missing/misplaced SlaveBase::finished() calls (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20102?vs=55008=55052

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/37/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 30 Mar 2019 01:19:52 + Build duration: 3 min 51 sec and counting BUILD ARTIFACTS

D20087: Enable glGetGraphicsResetStatus support by default on Qt >= 5.13

ngraham added a comment. Given the testing already done by users, yeah, I think this is safe to land. +1 REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D20087 To: davidedmundson, apol Cc: ngraham, apol, kde-frameworks-devel, michaelh, bruns

D20104: [balooshow] Several extensions basic file information output

ngraham added inline comments. INLINE COMMENTS > bruns wrote in main.cpp:171 > balooctl is a lowlevel tool, I see no reason to. Also, ISODate is completely > self describing and non-anbiguous (Timezone, Year/Day/Month ordering, ...) Still, not everyone who uses it would know what "Ctime" means

D20100: [timeline] Fix warning, add missing UDS entry for "."

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7cd2b04b8ef1: [timeline] Fix warning, add missing UDS entry for . (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20100?vs=55006=55050 REVISION

D20104: [balooshow] Several extensions basic file information output

This revision was automatically updated to reflect the committed changes. Closed by commit R293:919fa25cef0b: [balooshow] Several extensions basic file information output (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20104?vs=55010=55051

D20100: [timeline] Fix warning, add missing UDS entry for "."

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH timeline REVISION DETAIL https://phabricator.kde.org/D20100 To: bruns, #baloo, #frameworks, poboiko, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20101: [timeline] Canonicalize Url

ngraham added inline comments. INLINE COMMENTS > kio_timeline.cpp:134 > { > +auto canonicalUrl = canonicalizeTimelineUrl(url); > +if (url != canonicalUrl) { Any reason not to make the type explicit? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D20101 To:

D20104: [balooshow] Several extensions basic file information output

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right. REPOSITORY R293 Baloo BRANCH timeline REVISION DETAIL https://phabricator.kde.org/D20104 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel,

D20101: [timeline] Canonicalize Url

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3f3b6560f963: [timeline] Canonicalize Url (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20101?vs=55049=55054 REVISION DETAIL

D20101: [timeline] Canonicalize Url

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20101 To: bruns, #baloo, #frameworks, poboiko, ngraham, astippich Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileitem.cpp:362 > + > +if (!item.m_bInitCalled && m_bInitCalled) { > +item.init(); There is one thing I've been wondering back and forth about:

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 20:35:11 CET Dr.-Ing. Christoph Cullmann wrote: > I and others tried to get more reviews done in the past, but actually I > merged more than once stuff that I reviewed but it did break the CI. That I hope we'll get fixed at some point. It's a big big advantage

Re: CI system maintainability

Hello, A Merge Request in GitLab does not necessarily imply the need for a review by e person. It can just run a pipeline to validate that the code isn't broken. If the pipeline fails, the merge button is not available. We use GitLab at work and we have it set up like this: * Main branches

Re: CI system maintainability

+1 for this. I think running tests before merging is more acceptable than having mandatory reviews. On 29 March 2019 11:10:52 GMT+00:00, Ovidiu-Florin Bogdan wrote: >Hello, > >A Merge Request in GitLab does not necessarily imply the need for a >review by e person. It can just run a pipeline to

D20105: ecm_add_wayland_client_protocol: Improve error messages

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6b27bbf0b954: ecm_add_wayland_client_protocol: Improve error messages (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: CI system maintainability

On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > Having mandatory reviews for a central and complex component like akonadi > > looks like a very good and obvious idea. > > Yep. Looking at the 18.12 -> 19.04

Re: CI system maintainability

Hello, On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > On 2019 M03 28, Thu 16:04:01 CET Boudhayan Gupta wrote: > > As a user, I simply do not want unreviewed crap running on my computer. > > Yes, crap, because no software engineer writes bug-free code all the time, > > and if

D20059: Take clang-cl into account.

cmollekopf added a comment. FWIW, I have meanwhile used this patch to build all kube dependencies on linux and osx as well, and it seems like it doesn't break anything. I think clang-cl should receive all arguments it understands with this patch. REPOSITORY R240 Extra CMake Modules

D19092: Add bison minimum version of 2.4.1 due to %code

ltoscano added a comment. Not on the 19.04 branch, the dependency freeze happened few weeks ago - you may want to ask to release-team@ for an exception if you think it's important there too. REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL

D19092: Add bison minimum version of 2.4.1 due to %code

pino added a comment. In D19092#440060 , @ltoscano wrote: > Not on the 19.04 branch, ... This is a Framework (kservice). REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL

D20105: ecm_add_wayland_client_protocol: Improve error messages

zzag added a comment. Hmm it looks like we're using ancient `code` option. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20105 To: apol, #kwin, #frameworks, zzag Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: CI system maintainability

Am Donnerstag, 28. März 2019, 23:06:17 CET schrieb laurent Montel: > Le jeudi 28 mars 2019, 18:27:42 CET Friedrich W. H. Kossebau a écrit : > > Am Donnerstag, 28. März 2019, 16:56:33 CET schrieb laurent Montel: > > > Le jeudi 28 mars 2019, 16:11:12 CET Friedrich W. H. Kossebau a écrit : > > > >

Re: CI system maintainability

On jeudi 28 mars 2019 16:56:33 CET laurent Montel wrote: > CI: sometime I look at it, sometime not, sometime some guys informs me that > it's broken (I remember that Luca told me some days ago that a package > didn't compile, so I fixed it). I think the solution to all this is quite simple. If

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/71/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 28 Mar 2019 21:34:53 + Build duration: 11 hr and counting JUnit Tests Name: projectroot

D19092: Add bison minimum version of 2.4.1 due to %code

ltoscano added a comment. Ups, sorry! So according https://community.kde.org/Schedules/Frameworks there are no special provisions when the change doesn't touch translatable strings and the change is properly tested. REPOSITORY R309 KService BRANCH bison_min_version (branched from

D20105: ecm_add_wayland_client_protocol: Improve error messages

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20105 To: apol, #kwin, #frameworks, zzag Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: CI system maintainability

Hello, On Friday, 29 March 2019 09:43:44 CET Volker Krause wrote: > On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > > Having mandatory reviews for a central and complex component like > > > akonadi > > > looks

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert marked 4 inline comments as done. hoffmannrobert added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:361 > What about the other way around? I think this needs the symmetrical test to > call item.init() if needed > (and the corresponding unittest, write it

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert updated this revision to Diff 55025. hoffmannrobert added a comment. - Fix cmp() #3, add test for cmp()/init(), simplifications REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19887?vs=54934=55025 BRANCH add_skipStat REVISION DETAIL

D19887: KFileItem: call stat() on demand, add SkipMimeTypeDetermination option

hoffmannrobert edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19887 To: hoffmannrobert, dfaure, #frameworks, #dolphin Cc: kde-frameworks-devel, michaelh, ngraham, bruns