D20556: Keep empty Json metadata docs out of DocumentData DB

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case a document is marked for content

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Please bump the minimum required version for `KF5BalooWidgets` to 19.07.70. INLINE COMMENTS > informationpanelcontent.cpp:121 > +connect(m_configureButtons,

D20525: [InformationPanel] Use the new inline configuration mode

elvisangelaccio added a comment. About the UI, I noticed that when the panel is in "configure" mode, it's still possible to right-click it and click the "Configure" entry, which will do nothing. We could fix this by disabling the entry once clicked. Another idea: make the entry checkable

D20555: Don't use qAsConst over a temporary variable

This revision was automatically updated to reflect the committed changes. Closed by commit R268:abe32ec59939: Dont use qAsConst over a temporary variable (authored by mlaurent). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20555?vs=56238=56239

D20557: Install krcc.h header

aacid added a subscriber: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20557 To: aacid Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

sh-zam created this revision. sh-zam added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Find C++ shared lib path using regex. This change makes finding path independent

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadatawidget.h:93 > + * Switch between regular (view) and configuration mode. > + * @since 5.58 > + */ Should be `@since 19.08.0` (baloo-widgets follows the KDE Applications versioning) REPOSITORY R824 Baloo Widgets

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > Why are you using it without Android.cmake? I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some variables as it expects to run as a toolchain. Later today, I will

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56257. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56243=56257 BRANCH arcpatch-D20558 REVISION DETAIL

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

This revision was automatically updated to reflect the committed changes. Closed by commit R242:18a2ca50ab09: SvgItem, IconItem: drop smooth property override, update node on change (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/74/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Apr 2019 22:07:42 + Build duration: 15 min and counting BUILD ARTIFACTS

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me, can you land it? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem,

D20557: Install krcc.h header

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D20557 AFFECTED FILES src/CMakeLists.txt To:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/67/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 14 Apr 2019 22:07:43 + Build duration: 12 min and counting BUILD ARTIFACTS

Re: New framework: KCalCore

вт, 9 апр. 2019 г. в 20:10, Volker Krause : > > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > > > KCalCore is an implementation of

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam updated this revision to Diff 56244. sh-zam added a comment. improved name and code flow REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56151=56244 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 AFFECTED

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R39 KTextEditor BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham Cc: cullmann, kossebau,

D20536: Use consistent default Kickoff user icon

ngraham added a comment. This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20536 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma,

D20536: Use consistent default Kickoff user icon

GB_2 added a comment. In D20536#450246 , @ngraham wrote: > This makes it inconsistent with the default user avatar shown in the Users KCM though. That's kinda odd. Ok, then we could rename that 128px icon to something different.

D19850: Make AppStream generation opt-in

ngraham added a comment. Ping! Can we land this or a variant of it? REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH antialiasoxygenclockhands REVISION DETAIL https://phabricator.kde.org/D20550 To: kossebau, #vdg, #plasma, ngraham Cc: kde-frameworks-devel, michaelh,

D20556: Keep empty Json metadata docs out of DocumentData DB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D20556 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov,

D20536: Use consistent default Kickoff user icon

GB_2 updated this revision to Diff 56263. GB_2 added a comment. Change name of blue user icon, will need to make a patch for `user-manager` too REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56196=56263 BRANCH

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

cullmann accepted this revision. REPOSITORY R39 KTextEditor BRANCH arcpatch-D20542 REVISION DETAIL https://phabricator.kde.org/D20542 To: meven, #ktexteditor, ngraham, cullmann Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars,

D20536: Use consistent default Kickoff user icon

GB_2 added a dependency: D20564: Change default user avatar. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20536 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20536: Use consistent default Kickoff user icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, assuming D20564 is approved and lands. REPOSITORY R266 Breeze Icons BRANCH use-consistent-default-kickoff-user-icon (branched from master)

D20565: Ensure not to fold the end marker

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to avoid a deceptive look With recent fixes

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure added a comment. Urgh. Indeed. And looking around I find many inline virtuals in apparently public headers... http://www.davidfaure.fr/2019/inline_virtual_dtors.diff (though maybe some of these don't have d pointers at all...) About KBookmarkOwner, the lack of an explicit

D20557: Install krcc.h header

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Can't remember what use case I had in mind back then... Probably someone asked me to implement this REPOSITORY R243 KArchive BRANCH master REVISION DETAIL

D20519: Fix double delete on broken files

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D20519 To: aacid, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/36/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 14 Apr 2019 18:51:13 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/77/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 14 Apr 2019 22:07:43 + Build duration: 3 min 15 sec and counting JUnit Tests

D20557: Install krcc.h header

This revision was automatically updated to reflect the committed changes. Closed by commit R243:4b1927e954fb: Install krcc.h header (authored by aacid). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20557?vs=56242=56251 REVISION DETAIL

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem,

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

GB_2 added a comment. Ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20140 To: ndavis, #plasma, #vdg Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450198 , @sh-zam wrote: > Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. Sure, add it. Why are you using it without

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

This revision was automatically updated to reflect the committed changes. Closed by commit R240:24538afeaf61: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

hallas added inline comments. INLINE COMMENTS > dfaure wrote in kbookmarkowner.h:120 > One day we'll probably wonder how many tabs are actually open, to avoid > saying "Bookmark Tabs As Folder" if there's only one tab. So I'd prefer for > that and make this an int rather than a bool. > >

D20526: fix extracting of some properties to match what was writen

astippich added a comment. IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. How about inserting the TStringList entry by entry, without using the contactsFromString method? That would

D20525: [InformationPanel] Use the new inline configuration mode

meven added a comment. I like this change. This will make D19243 D19241 irrelevant and fix indirectly the bug 389571. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns,

D20528: Change properties attributes for consistency

astippich added a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20528 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D20530: Fix signed/unsigned warning after statx change

dfaure created this revision. dfaure added reviewers: meven, fvogt, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY file.cpp:947:60: warning: comparison between signed and unsigned integer

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 259 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sun, 14 Apr 2019 10:49:01 + Build duration: 4 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/76/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 14 Apr 2019 10:49:01 + Build duration: 7 min 31 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/89/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 14 Apr 2019 10:49:01 + Build duration: 10 min and counting BUILD ARTIFACTS

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added a comment. Looks to me a call to KateLayoutCache::updateViewCache may help at some point. But have no idea where to place and with which parms. In KateLayoutCache::displayViewLine is "limit=0" on second call. REPOSITORY R39 KTextEditor REVISION DETAIL

D20513: Remove last traces of KFileMetaDataWidget from information panel

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadataconfigurationdialog.h:35 > * @brief Dialog which allows to configure which meta data should be shown > *in the KFileMetaDataWidget. > */ Can you please also update this comment? It should mention

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

elvisangelaccio added inline comments. INLINE COMMENTS > filemetadatawidget.cpp:53 > { > +QCheckBox* check; > QLabel* label; I'd call it `checkBox` for better clarity. > filemetadatawidget.cpp:113-114 > row.value->deleteLater(); > +if (row.check) > +

D20534: avoid conflicting shortcuts for switching tabs

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY use ALT + Home/End for top/bottom of view REPOSITORY R39 KTextEditor BRANCH master REVISION

D20523: Remove a dead declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R824:c51ec36cee75: Remove a dead declaration (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20523?vs=56165=56186 REVISION DETAIL

D20534: avoid conflicting shortcuts for switching tabs

cullmann added reviewers: Kate, ngraham, dhaumann. cullmann added a comment. Ok with that? Follow up of https://phabricator.kde.org/D7497 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel,

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns marked an inline comment as done. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin Cc: elvisangelaccio, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20513: Remove last traces of KFileMetaDataWidget from information panel

This revision was automatically updated to reflect the committed changes. Closed by commit R318:05a4d27813e3: Remove last traces of KFileMetaDataWidget from information panel (authored by bruns). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D20513: Remove last traces of KFileMetaDataWidget from information panel

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R318 Dolphin BRANCH arcpatch-D20513 REVISION DETAIL https://phabricator.kde.org/D20513 To: bruns, #frameworks, apol, ngraham, #dolphin,

D20525: [InformationPanel] Use the new inline configuration mode

bruns updated this revision to Diff 56194. bruns added a comment. rebase REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20525?vs=56168=56194 BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20525 AFFECTED FILES src/CMakeLists.txt

D20536: Use consistent default Kickoff user icon

GB_2 updated this revision to Diff 56196. GB_2 added a comment. Use symlinks instead of copying the icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20536?vs=56195=56196 BRANCH use-consistent-default-kickoff-user-icon (branched from master)

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added a comment. Yes! A short test looked very promising. Will play a little more, because had done some changes to this patch here :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund,

D20529: add license to python test files

bruns added a subscriber: bcooksley. bruns added a comment. @bcooksley - these tests currently fail to run under Windows: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5 WindowsMSVCQt5.11/149/testReport > "C:/CI/workspace/Frameworks/kfilemetadata/kf5-qt5

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns edited the summary of this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D20524 To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20530: Fix signed/unsigned warning after statx change

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20530 To: dfaure, meven, fvogt, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KCalCore

On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > Hi, > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > KCalCore is an implementation of the iCalendar standard based on libical, I wonder about the name, which doesn't mean much outside the circle of PIM

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

elvisangelaccio added a comment. Hmm, it seems you need to rebase this patch: $ arc patch D20524 INFO Base commit is not in local repository; trying to fetch. Created and checked out branch arcpatch-D20524. This diff is against commit

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Ok, I can reproduce the issue you mention. I will take a look. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Please try if my last commit fixed that: https://cgit.kde.org/ktexteditor.git/commit/?id=a9f97f1be115c1e4ede391b6d3d5e2aed6350992 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann

D20495: KateIconBorder: Fix folding popup width and height

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Works ok for me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20495 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel,

D20495: KateIconBorder: Fix folding popup width and height

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4396efe1cdce: KateIconBorder: Fix folding popup width and height (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20495?vs=56071=56184

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns updated this revision to Diff 56192. bruns added a comment. remove one more reference in comments REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20513?vs=56152=56192 BRANCH arcpatch-D20513 REVISION DETAIL https://phabricator.kde.org/D20513

D20513: Remove last traces of KFileMetaDataWidget from information panel

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadataconfigurationdialog.h:35 > Can you please also update this comment? It should mention > `Baloo::FileMetaDataWidget`. Good catch ... REPOSITORY R318 Dolphin REVISION DETAIL

D20536: Use consistent default Kickoff user icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY Add the 22px default user icon that is used everywhere else. F6771466: Consistent

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. :=) Nice that it helps. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh,

D20525: [InformationPanel] Use the new inline configuration mode

bruns edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20534: avoid conflicting shortcuts for switching tabs

cullmann added a comment. Upsa, pushed it with my copyright update :/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20534 To: cullmann, #kate, ngraham, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added inline comments. INLINE COMMENTS > elvisangelaccio wrote in filemetadatawidget.h:47-49 > Can you add some apidox for this enum? In particular, it's not so clear what > `ReStart` is used for. Sure, just wanted to see if the (UI) design itself is deemed appropriate. REPOSITORY

D20534: avoid conflicting shortcuts for switching tabs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:9f2ffd36c587: avoid conflicting shortcuts for switching tabs (authored by cullmann). REPOSITORY R39 KTextEditor

D20528: Change properties attributes for consistency

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. 10 lines removed, 1 added, 10 times more functionality  REPOSITORY R286 KFileMetaData BRANCH properties_consistency REVISION DETAIL https://phabricator.kde.org/D20528 To: astippich,

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

loh.tar added a comment. Did anyone tried this patch? While coding my focus was only on behavior while enter text. Now I notice that the folding is "broken" in a way that the view jumps to the bottom :-S First digging indicate that makeVisible(..) is called twice, and the second time

D17857: DocumentPrivate: Don't jump view when edit using 'scroll past last line'

cullmann added a comment. Didn't try folding :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: swestersund, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D19445: Handle variant list in formatting functions

astippich added a dependent revision: D20528: Change properties attributes for consistency. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D19445 To: astippich, ngraham, bruns Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D20529: add license to python test files

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY silence EBN REPOSITORY R286 KFileMetaData BRANCH py_license

D20523: Remove a dead declaration

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20523 To: bruns, #baloo, #frameworks, ngraham, astippich Cc: gennad, domson, ashaposhnikov, astippich, spoorun,

D20528: Change properties attributes for consistency

astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Move all the handling of (string-)lists into the member function,

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

dfaure added inline comments. INLINE COMMENTS > hallas wrote in kbookmarkowner.h:120 > Good point (both of them) > > What are our binary compatibility promises? Is //every// version of > frameworks always binary backwards compatible? Or do we have a window every > now and then where we can

D20523: Remove a dead declaration

elvisangelaccio accepted this revision. REPOSITORY R824 Baloo Widgets BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D20523 To: bruns, #baloo, #frameworks, ngraham, astippich, elvisangelaccio Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20530: Fix signed/unsigned warning after statx change

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Thanks ! To have statx you need glibc 2.28 (released last august) and linux 4.11 even older. Debian stable has glibc 2.19... REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D20526: fix extracting of some properties to match what was writen

mgallien created this revision. mgallien added reviewers: astippich, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY Currently, one can write and read through taglib extractor

D20519: Fix double delete on broken files

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Good catch. I'd still prefer if such changes would come with a unittest, because it will be hard otherwise to immediately detect (while developing) that changes don't introduce

D20529: add license to python test files

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH py_license REVISION DETAIL https://phabricator.kde.org/D20529 To: astippich, bruns Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19445: Handle variant list in formatting functions

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > propertyinfotest.cpp:91 > { Property::BitRate, true, 1470, > QStringLiteral("14.7 Mbit/s")}, > +{ Property::BitRate,

D20526: fix extracting of some properties to match what was writen

bruns added a comment. In D20526#449560 , @astippich wrote: > IMHO for searching, the separation from a single string into multiple entries is the best thing to do, from a metadata editing point of view not so much. > How about inserting

D20525: [InformationPanel] Use the new inline configuration mode

ngraham added a reviewer: VDG. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D20525 To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg Cc: meven, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

ngraham added a comment. In D20524#449668 , @elvisangelaccio wrote: > Hmm, it seems you need to rebase this patch: Worked for me: INFO Base commit is not in local repository; trying to fetch. Created and checked out branch

D20284: Fix l/100 km to MPG conversion

madcatx marked 2 inline comments as done. madcatx added inline comments. INLINE COMMENTS > aacid wrote in fuel_efficiency.cpp:36 > I understand what you mean here, but i don't think that reciprocal is the > word that describes this (are you a native speaker? if so maybe it's juts > that my

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

bruns added a comment. In D20524#449784 , @ngraham wrote: > In D20524#449668 , @elvisangelaccio wrote: > > > Hmm, it seems you need to rebase this patch: > > > Worked for me: > >INFO

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

meven created this revision. meven added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY CCBUG: 406305 REPOSITORY R39 KTextEditor BRANCH close-file

D20284: Fix l/100 km to MPG conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R292:bc7495095baa: Fix l/100 km to MPG conversion (authored by madcatx, committed by aacid). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=56203=56215

D20510: SvgItem, IconItem: drop "smooth" property override, update node on change

kossebau added a comment. A good example to see how the smooth property was broken is the animation of the analog clock's hands (best enable second hand to see often): the Hand.qml has "smooth: !anim.running" set as property for the SvgItem. Without this patch, the hand during animation

D20284: Fix l/100 km to MPG conversion

madcatx updated this revision to Diff 56201. madcatx added a comment. Added an inverse test with initial value in MPG REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=55574=56201 REVISION DETAIL https://phabricator.kde.org/D20284

D20284: Fix l/100 km to MPG conversion

madcatx updated this revision to Diff 56203. madcatx added a comment. More obvious explanation of the meaning of `m_isReciprocal` REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20284?vs=56201=56203 REVISION DETAIL

D20525: [InformationPanel] Use the new inline configuration mode

ngraham added a comment. +1, this is a much nicer UI. Some of the text gets cut off horizontally though when the panel is narrow: F6771538: Screenshot_20190414_081327.png I imagine it would be even worse in German or with a Romance language.

  1   2   >