This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8e00726eda1f: Manipulate bytes instead of characters
(authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE
bruns added inline comments.
INLINE COMMENTS
> ngraham wrote in fstabdevice.cpp:88
> Hmm, hard to tell without some context or knowing what the original string is.
@hallas:
cat /proc/mounts
REPOSITORY
R245 Solid
BRANCH
add_handling_of_fuseiso (branched from master)
REVISION DETAIL
bruns added a comment.
The UDisksDeviceBackend class serves two functions:
- shared data cache for UDisksDevice instances
- static factory of instances
The manager has everything it needs to function as a factory. The
UDisksDeviceBackend would become a representation of the
broulik added a comment.
You mean I kill that entire `DeviceBackend` wrapper and have `Device` do all
the things with all the data stored in the `DeviceManager`?
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D19677
To: broulik, #frameworks, bruns
Cc: apol,
ngraham added inline comments.
INLINE COMMENTS
> hallas wrote in fstabdevice.cpp:88
> Certainly :D I am also struggling a bit with how to best describe these FUSE
> mounted devices, @ngraham do you have any good suggestions?
Hmm, hard to tell without some context or knowing what the original
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/121/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Mon, 27 May 2019 14:06:54 +
Build duration:
7 min 33 sec and counting
JUnit Tests
Name:
bruns added a comment.
I think just checking for the property existance is correct:
> /usr/lib/udev/rules.d/40-usb-media-players.rules
>
>> ATTRS{vendor}=="*Apple*", ATTRS{model}=="*iPod*",
ENV{ID_MEDIA_PLAYER}="apple_ipod"
>> ATTRS{model}=="*[iI][tT][uU][nN][eE][sS]*",
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored
by jpoelen).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21421?vs=58696=58742
REVISION
elvisangelaccio accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D21367
To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
dfaure added a comment.
My suggestion is to call this qlogging-categories5.
The 'q' prefix is missing to make this qt-specific rather than cross-toolkit.
The "logging" instead of "debug" is because this affects all types of
messages, and this is all about what's called "logging
jpoelen added a comment.
I forgot to ask about running the tests. Is it normal that system syntax
files take precedence if we have an `index.katesyntax`? Currently I have to run
the tests by setting the environment variable `XDG_DATA_DIRS`.
REPOSITORY
R216 Syntax Highlighting
BRANCH
broulik added a comment.
However in `queryDeviceInterface` we actually check for it being `"1"`
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21425
To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
hallas added inline comments.
INLINE COMMENTS
> bruns wrote in fstabdevice.cpp:88
> @hallas:
> cat /proc/mounts
This is what I have in mounts:
fuseiso on /home/dha/mnt1 type fuse.fuseiso
(rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)
so there just isn't a whole lot of information -
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/114/
Project:
kf5-qt5 FreeBSDQt5.12
Date of build:
Mon, 27 May 2019 07:04:06 +
Build duration:
13 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/111/
Project:
kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 May 2019 07:04:05 +
Build duration:
12 min and counting
BUILD ARTIFACTS
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:39d1db6e49da: Export SortFilterModel sort column to QML
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
aacid closed this revision.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D21418
To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/104/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Mon, 27 May 2019 07:04:06 +
Build duration:
12 min and counting
BUILD ARTIFACTS
broulik updated this revision to Diff 58706.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.
- Limit to `usb` subsystem only
- Add docs
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 58708.
meven added a comment.
Remove decl of removed function checkOverwrite
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21401?vs=58646=58708
BRANCH
arcpatch-D21401
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R40:09053597e699: Avoid double overwrite check (authored by
meven).
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21402?vs=58647=58709
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:fb2ea92822d2: Use native dialog overwrite check (authored
by meven).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21401?vs=58708=58710
REVISION DETAIL
meven added a comment.
Good part is that the overwrite check dialog will now be a native one analog
to other apps instead of a KMessageBox, providing consistency outside of KDE.
REPOSITORY
R39 KTextEditor
BRANCH
arcpatch-D21401
REVISION DETAIL
https://phabricator.kde.org/D21401
To:
Lekensteyn updated this revision to Diff 58714.
Lekensteyn set the repository for this revision to R241 KIO.
Lekensteyn added a comment.
Using camelCase now.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21367?vs=58640=58714
REVISION DETAIL
meven added inline comments.
INLINE COMMENTS
> ltoscano wrote in renamefiledialog.h:5
> We do, but people sign it on a vuluntary basis:
>
> https://ev.kde.org/rules/fla.php
>
> Also, there is this which pre-dates the FLA but it is useful too (and still
> in use):
>
>
broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, bruns.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
This avoids us creating wrapper objects for UDev devices we
broulik added a dependent revision: D21425: [UDev Backend] Filter for
ID_MEDIA_PLAYER already when querying.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D21379
To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
poboiko edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21427
To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
I've encountered weird regression. Here is the description:
poboiko edited the summary of this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21427
To: poboiko, #frameworks, #baloo, bruns
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
30 matches
Mail list logo
