D21855: [IdUtils] Fix aliasing warning

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY memcpy with a small fixed size is optimized by all

D21855: [IdUtils] Fix aliasing warning

bruns added a reviewer: thiago. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480765 , @poboiko wrote: > Actually, there is an issue with that code right now, which I wanted to fix, but forgot. > The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed

D21855: [IdUtils] Fix aliasing warning

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4651988e2963: [IdUtils] Fix aliasing warning (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21855?vs=59939=59948 REVISION DETAIL

D21509: [UnIndexedFileIteratorTest] Add tests

poboiko retitled this revision from "[baloo_file] Index renamed folders inside UnindexedFileIndexer" to "[UnIndexedFileIteratorTest] Add tests". poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21509 To: poboiko, #frameworks,

D21509: [baloo_file] Index renamed folders inside UnindexedFileIndexer

poboiko updated this revision to Diff 59951. poboiko added a comment. Rebase on master. Since we now reindex folder always when cTime changes, revert `nameChanged()` routine Cover the case when we feed `UnIndexedFileIterator` with path that ends with `/` REPOSITORY R293 Baloo

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

This revision was automatically updated to reflect the committed changes. Closed by commit R293:381e2cd92379: [PostingIterator] Move positions() method to VectorPositionInfoIterator (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/124/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 16 Jun 2019 17:28:13 + Build duration: 2 min 5 sec and counting JUnit Tests Name:

D15739: [Places panel] Don't show Root by default

elvisangelaccio accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D15739 REVISION DETAIL https://phabricator.kde.org/D15739 To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio Cc: meven, elvisangelaccio, Codezela, davidc, tcanabrava, ndavis, romangg, bruns,

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

poboiko added a comment. Actually, there is an issue with that code right now, which I wanted to fix, but forgot. The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed on `QString` instead of `QByteArray` - unicode symbols inside term can consist of two

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21835 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov,

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3e3cd7e63336: [WriteTransactionTest] Clear mixup of QString and QByteArray (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21844?vs=59913=59941

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7420bc056326: [TermGenerator] Use UTF-8 ByteArray for termList (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21839?vs=59896=59942 REVISION

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21839 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 123 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/123/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 16 Jun 2019 17:15:28 + Build duration: 11 min and counting JUnit Tests Name:

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

poboiko added a comment. > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects. Yep, that's what I've suggested (if I understood you correctly). I guess, we can put the trimming part right to `termList()`, it will

D21855: [IdUtils] Fix aliasing warning

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21862: [QueryTest] Restructure tests to allow easier extension

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The test documents are not touched by the individual

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480777 , @poboiko wrote: > > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects. > > Yep, that's what I've suggested (if I understood you

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The (somewhat arbitrary) term truncation was applied to

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D21844 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel,

D21861: Add default variables for variables interface

dhaumann added a comment. Btw, if there is a better place for initialization, I'd happily move the code to some other place. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n,

D21861: Add default variables for variables interface

dhaumann created this revision. dhaumann added reviewers: cullmann, gregormi. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Add set of default variables that mostly match Qt

D21863: [TermGenerator] Insert an empty position between independent terms

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Terms of a phrase have adjacent positions, but independent

D21864: [QueryTest] Test if independent phrases are really independent

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Tags (and KFileMetaData properties) call

D21863: [TermGenerator] Insert an empty position between independent terms

bruns added a dependent revision: D21864: [QueryTest] Test if independent phrases are really independent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21863 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21862: [QueryTest] Restructure tests to allow easier extension

bruns added a dependent revision: D21864: [QueryTest] Test if independent phrases are really independent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21862 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21855: [IdUtils] Fix aliasing warning

thiago added a comment. +1 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21855: [IdUtils] Fix aliasing warning

bruns added a comment. In D21855#480990 , @thiago wrote: > +1 Thx for the confirmation! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc:

D13425: File indexer closing improvements.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien, #baloo, poboiko Cc: ngraham, mgallien, kde-frameworks-devel, bruns, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH phrasestorage_fixes REVISION DETAIL https://phabricator.kde.org/D21865 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a99bb98143c6: [TermGenerator] Do Term truncation prior to UTF-8 conversion (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21865?vs=59964=59968

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1a573d5fe373: [TermGenerator] Leave single term phrases out of the PositionDB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 127 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/127/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 17 Jun 2019 00:18:32 + Build duration: 18 min and counting JUnit Tests Name:

D21855: [IdUtils] Fix aliasing warning

thiago added a comment. Alternative: return (quint64(devId) << 32) | inode; Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich,

D21855: [IdUtils] Fix aliasing warning

bruns added a comment. In D21855#480992 , @thiago wrote: > Alternative: return (quint64(devId) << 32) | inode; > > Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match. Thats the problem here -

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Any search phrase consisting of a single term only can be

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D21866 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov,

D21313: Create specific directory for Qt logging categories file

vkrause added a comment. In D21313#480401 , @kossebau wrote: > @apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY touchFile expects a QString argument, not QByteArray. Use

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

kossebau added a comment. Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I know you are just following the example of what was done for appstreamcli, but IMHO this has already been a bad hack, screwing over the fine granular design of all the ECM

D21313: Create specific directory for Qt logging categories file

bcooksley added a comment. The Binary Factory uses the tooling shipped as part of the KDE SDK (which always builds everything from scratch, and I don't know if part of that includes ECM, hence why the issue doesn't show up there). The CI system on the other hand uses it's own tooling

D17241: WIP:Disable highlighting after 512 characters on a line.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:1b7a2c69e492: WIP:Disable highlighting after 512 characters on a line. (authored by cullmann). REPOSITORY R39

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann added a comment. Then let's try that. Even for all cases without hitting the limit the new code is faster. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17241 To: cullmann, vkrause, dhaumann, mwolff, sars Cc: zetazeta, mwolff, brauch, kwrite-devel,

D17241: WIP:Disable highlighting after 512 characters on a line.

cullmann added a comment. 4daee27406cad0001f30bca4bf551495e0624d23 > = - addConfigEntry(ConfigEntry(LineLengthLimit, "Line Length Limit", QString(), 4096)); +