D22081: [Fstab] Select appropriate icon for home or root directory

This revision was automatically updated to reflect the committed changes. Closed by commit R245:541a3d3a0573: [Fstab] Select appropriate icon for home or root directory (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22081?vs=60601=60628

D22069: Localize long number strings

ngraham added a comment. @ilic As far as I can tell, the locale needs to be set again to french because it's in a new function. At the end of the function, it doesn't matter that English was set as the default locale because the next test won't be re-using that state; it will revert to the

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60631. meven added a comment. Allow to filter mimetype with ?type=mimetype1[,mimetype2] REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60602=60631 BRANCH recents-docs-ioslave REVISION DETAIL

D22080: [Fstab] Show mounted "overlay" filesystems

broulik accepted this revision. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

broulik accepted this revision. REPOSITORY R245 Solid BRANCH fstab_overlayfs REVISION DETAIL https://phabricator.kde.org/D22081 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22049 To: bshah, mart, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

ngraham accepted this revision. ngraham added a comment. Yep, looks good to me too. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

ngraham accepted this revision. REPOSITORY R245 Solid BRANCH fstab_overlayfs REVISION DETAIL https://phabricator.kde.org/D22081 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/42/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 09:00:58 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D22080: [Fstab] Show mounted "overlay" filesystems

fvogt accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

ilic added inline comments. INLINE COMMENTS > klocalizedstringtest.cpp:222 > + > +QLocale::setDefault(QLocale(QLocale::French)); > +QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(), The French locale is already being set in line 45 using setlocale, for which the system has to have

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/43/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 09:02:39 + Build duration: 2 min 11 sec and counting JUnit Tests Name:

D22069: Localize long number strings

ilic added a comment. I'm not sure about what happens with global state, but at any rate, what I expected is that in klocalizedstringtest.cpp exactly one character is modified, replacing dot with comma in string " 4.20". Do you have fr_FR.utf8 glibc locale installed on your system?

D22069: Localize long number strings

ngraham edited the summary of this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

ngraham added a comment. Thanks :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. With this and D22080 applied, there's an entry for / now: F6932935: Screenshot_20190625_092256.png On a

D22080: [Fstab] Show mounted "overlay" filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R245:54a501f00bbe: [Fstab] Show mounted overlay filesystems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22080?vs=60600=60627 REVISION DETAIL

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60633. meven added a comment. Allow to override default 30 results limit REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60631=60633 BRANCH recents-docs-ioslave REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/127/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Jun 2019 10:33:33 + Build duration: 15 min and counting BUILD ARTIFACTS

D22082: WIP Add an ioslave to access KActivityStat data

meven added a reviewer: lunakl. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, lunakl Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

mart accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22076 To: broulik, #plasma, mart, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 10:33:32 + Build duration: 14 min and counting BUILD ARTIFACTS

D22049: pluginloader: Change behavior of X-KDE-ParentApp

This revision was automatically updated to reflect the committed changes. Closed by commit R242:7ae271987ca2: pluginloader: Change behavior of X-KDE-ParentApp (authored by bshah). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22073: [KCM GridDelegate] Silence warning

This revision was automatically updated to reflect the committed changes. Closed by commit R296:94479bd7f3e2: [KCM GridDelegate] Silence warning (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22073?vs=60585=60639 REVISION DETAIL

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

This revision was automatically updated to reflect the committed changes. Closed by commit R296:3df42d7f0eb6: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate… (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/130/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 10:33:33 + Build duration: 4 min 31 sec and counting JUnit Tests

D22082: WIP Add an ioslave to access KActivityStat data

meven added a subscriber: ivan. meven added a comment. I have added you @ivan as you were the main author of KAcvitiesStat and might be interested in the review. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham,

D22069: Localize long number strings

ngraham added a comment. Yeah, I do. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22069 To: ngraham, #localization, #frameworks, broulik Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

meven edited reviewers, added: ivan; removed: lunakl. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22082 To: meven, #frameworks, ngraham, ivan, lunakl Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/108/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 14:00:05 + Build duration: 2 min 41 sec and counting JUnit Tests

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60646. meven added a comment. Implement proper logging, add url filter parameter REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60633=60646 BRANCH recents-docs-ioslave REVISION DETAIL

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added reviewers: meven, apol, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol,

D13083: Respect custom directory icons in iconNameForURL()

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D13048 REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a comment. Abandoning in favor of D13048 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham reclaimed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 60654. romangg added a comment. - D-pointer DmaBufBuffer - Only allow one create request in any case - Params in private interface class - typedef for LinuxDmabufUnstableV1Interface - Small cleanup - Set buffer privates and delete impl on

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 99 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 14:00:05 + Build duration: 3 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 103 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/103/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Jun 2019 14:00:05 + Build duration: 3 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/109/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 14:10:37 + Build duration: 2 min 34 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/104/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Jun 2019 14:10:36 + Build duration: 3 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/100/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 14:10:36 + Build duration: 3 min 50 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 201 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/201/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 25 Jun 2019 14:00:06 + Build duration: 4 min 38 sec and counting JUnit

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 60649. ngraham added a comment. - Don't stat non-local files - Reduce the size of the change - Still works REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=34715=60649 REVISION DETAIL

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik, meven, apol, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

ngraham added reviewers: ivan, broulik, Plasma, Frameworks. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22091 To: meven, ivan, broulik, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D22091 AFFECTED FILES

D22082: WIP Add an ioslave to access KActivityStat data

meven updated this revision to Diff 60653. meven added a comment. Add activity filtering REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22082?vs=60646=60653 BRANCH recents-docs-ioslave REVISION DETAIL https://phabricator.kde.org/D22082

D10747: Implement zwp_linux_dmabuf_v1

romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, sgureev,

D22083: introduce concept of header and footer for kpageview

ngraham added a subscriber: ndavis. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22083 To: mart, #plasma, #frameworks, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

cfeck added inline comments. INLINE COMMENTS > kpageview.cpp:458 > + > +if (d->pageHeader == header) { > +return; This check is duplicated. > kpageview.cpp:476 > +} > + > +} Please remove this empty line. > kpageview.h:163 > +/** > + * Set a widget as the header

D22093: Don't show progress window for jobs that don't report progress

nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Most plugins (all but the youtube one) don't report any progress

D22083: introduce concept of header and footer for kpageview

ngraham accepted this revision as: VDG. ngraham added a comment. This seems to work quite well. For the remaining padding on the left, top, and bottom, does that come from Breeze, or would it need to be removed here? Or does it come from here and we should work around it in Breeze?

D22095: Fix CMake add_custom_command() paren highlighting

smokris added a reviewer: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh, genethomas,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 136 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/136/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Jun 2019 18:38:59 + Build duration: 15 min and counting BUILD ARTIFACTS

D22095: Fix CMake add_custom_command() paren highlighting

smokris updated this revision to Diff 60669. smokris added a comment. Updated cmake.xml + cmake.xml.tpl version number. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22095?vs=60662=60669 REVISION DETAIL https://phabricator.kde.org/D22095

D21861: Add default variables for variables interface

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f58c2af9b4de: fix unit test for all operating systems (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21861?vs=60614=60665#toc REPOSITORY R39 KTextEditor CHANGES

D21861: Add default variables for variables interface

cullmann added a comment. Ok, use now some self-defined env var with value set by the test itself, that should help on all operating systems. We don't need to check if HOME is ok. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 120 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/120/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 18:38:59 + Build duration: 12 min and counting BUILD ARTIFACTS

D22095: Fix CMake add_custom_command() paren highlighting

smokris created this revision. smokris added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. smokris requested review of this revision. REVISION SUMMARY The CMake syntax highlighter was getting

D21861: Add default variables for variables interface

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Actually my fix will only help for Unices, on Windows, this will still fail ;=) Either we guard that for Windows or we check there more env vars. REPOSITORY R39 KTextEditor

D22095: Fix CMake add_custom_command() paren highlighting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting, cullmann Cc:

D22095: Fix CMake add_custom_command() paren highlighting

cullmann added a comment. Ah, I missed: the version should be updated. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22095 To: smokris, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad,

D22069: Localize long number strings

safaalfulaij added a comment. This is great! Thanks! Same issue in here: https://phabricator.kde.org/D13219 I'm not sure if this is the correct way of fixing it, but I think there isn't any other prvoided by Qt, other then `QLocale::toString`. Maybe it's the easy way here :) REPOSITORY

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 203 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/203/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 25 Jun 2019 21:27:56 + Build duration: 8 min 19 sec and counting JUnit

D7446: [Places panel] Revamp the Recently Saved section

meven planned changes to this revision. meven added a comment. I have started D22082 enrolling the plan set in the previous comment. Once this task has done enough progress and has landed some of its work, I will be able to revisit this diff.

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/101/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 25 Jun 2019 21:27:56 + Build duration: 4 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 105 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/105/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 25 Jun 2019 21:27:56 + Build duration: 7 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/110/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 25 Jun 2019 21:27:56 + Build duration: 36 min and counting JUnit Tests Name:

D22093: Don't show progress window for jobs that don't report progress

apol added a comment. I think it's valuable information that the job is in progress. How about making the progress bar indeterminate? https://doc.qt.io/qt-5/qml-qtquick-controls2-progressbar.html#indeterminate-prop REPOSITORY R495 Purpose Library REVISION DETAIL