D23157: Expose technology property in battery interface

2019-08-15 Thread Méven Car
meven retitled this revision from "Add technology property to battery interface" to "Expose technology property in battery interface". REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23157 To: meven, #frameworks, broulik Cc: kde-frameworks-devel,

D23171: Avoid enabling kcrash if it's only included via a plugin

2019-08-15 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. the logic is awesome, the checking with the static is not super pretty but saves significantly useless checks REPOSITORY R285 KCrash BRANCH master REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

2019-08-15 Thread Méven Car
meven updated this revision to Diff 63796. meven added a comment. Group boolean fields together REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=62026=63796 BRANCH arcpatch-D17595 REVISION DETAIL https://phabricator.kde.org/D17595 AFFECTED FILES

D17595: Upstream Dolphin's file rename dialog

2019-08-15 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:60 > Just run `uncrustify-kf5` from the repo kde-dev-scripts. I am very happy to learn about this one. This script cannot work with a single file it seems and most of the

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-15 Thread Méven Car
meven updated this revision to Diff 63786. meven marked 9 inline comments as done. meven added a comment. Remove unnecessary pointer use, code formatting REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63724=63786 BRANCH master

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-15 Thread Ivan Čukić
ivan added inline comments. INLINE COMMENTS > GtkEventSpy.cpp:68 > +QDateTime visited; > +QList *applications; > + No need for this to be a pointer to a list. Make it just `QList applications`. > GtkEventSpy.cpp:70 > + > +Bookmark(){ > +applications = new QList(); The

D23171: Avoid enabling kcrash if it's only included via a plugin

2019-08-15 Thread David Edmundson
davidedmundson added a comment. Alternatively we could just kill the Q_COREAPP_STARTUP_FUNCTION as most apps already explicitly call KCrash::initialize() to get round distros compiling with link-as-needed? REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D23171 To:

D23157: Add technology property to battery interface

2019-08-15 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23157 To: meven, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23171: Avoid enabling kcrash if it's only included via a plugin

2019-08-15 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If a Qt app happens to load our plasma-integration plugin it shouldn't change how bug reporting works.

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-15 Thread Christoph Cullmann
cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann,

D23157: Expose technology property in battery interface

2019-08-15 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R245:eb82729b438f: Expose technology property in battery interface (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23157?vs=63745=63784 REVISION

D23171: Avoid enabling kcrash if it's only included via a plugin

2019-08-15 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R285:e64b8314e201: Avoid enabling kcrash if its only included via a plugin (authored by davidedmundson). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

2019-08-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 15 Aug 2019 08:56:53 + Build duration: 1 min 18 sec and counting JUnit Tests Name:

D22471: [KProcessList] Split command line and process name

2019-08-15 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R244:969e01dc8d60: [KProcessList] Split command line and process name (authored by davidedmundson). REPOSITORY R244

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-15 Thread Méven Car
meven updated this revision to Diff 63829. meven added a comment. run uncrustify-kf5 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62464=63829 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-15 Thread Méven Car
meven updated this revision to Diff 63830. meven added a comment. run uncrustify-kf5 REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23112?vs=63786=63830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23112 AFFECTED

D23131: Define install location for JAR/AAR files for Android

2019-08-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:6faff48245c2: Define install location for JAR/AAR files for Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D22775: Allow date range filtering of resource events using Date Term

2019-08-15 Thread Méven Car
meven added a comment. gentle ping @ivan Waiting for this to move on on D22144 and then D7446 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan,

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-15 Thread Chinmoy Ranjan Pradhan
chinmoyr added inline comments. INLINE COMMENTS > file.cpp:524 > while (true) { > QByteArray res = mFile->read(bytes); > This doesn't support error reporting. Why not refactor this loop using read(char *, qint64)? I believe you can accommodate your changes inside the loop

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

2019-08-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 15 Aug 2019 15:01:15 + Build duration: 6 min 39 sec and counting JUnit Tests Name:

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-15 Thread Christoph Cullmann
cullmann added a comment. If the highlighting still is OK after removing them, sure, but it looks like the language wanted explicitly have different colors for stuff using the same default style. Perhaps one could use some of the new default styles in some places. And I would always

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-15 Thread Alexander Saoutkin
feverfew abandoned this revision. feverfew added inline comments. INLINE COMMENTS > feverfew wrote in file.cpp:524 > I think that would be appropriate for a separate revision which I'm doing. > This revision is only to handle the case outlined in the summary. Actually I've realised using the

D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

2019-08-15 Thread Christoph Cullmann
cullmann added a comment. I think the current way we handle that is OK. If people start to include keywords between "incompatible" languages, any chosen direction is not really desirable. If somebody has time, for sure it makes sense to document the current status quo. REPOSITORY R216

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-15 Thread jonathan poelen
jpoelen added a comment. If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen,

D23193: Add support for Belarusian currency

2019-08-15 Thread Shubham
shubham added reviewers: Frameworks, ngraham. shubham added a subscriber: Frameworks. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D23193 To: shubham, #frameworks, ngraham Cc: #frameworks, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23193: Add support for Belarusian currency

2019-08-15 Thread Shubham
shubham created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. shubham requested review of this revision. REVISION SUMMARY FEATURE: 339448 REPOSITORY R292 KUnitConversion BRANCH currency REVISION DETAIL

D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23194 To: feverfew, dfaure, fvogt, chinmoyr, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23194: Making FileJob behave consistently.

2019-08-15 Thread Alexander Saoutkin
feverfew created this revision. feverfew added reviewers: dfaure, fvogt, chinmoyr, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. REVISION SUMMARY This patch does the following: 1. Makes sure the

D23137: C++: contracts are not in C++20

2019-08-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I agree with this. It wasn't accepted for C++20, we can add it with the right syntax after it got into the next standard. REPOSITORY R216 Syntax Highlighting BRANCH

D23134: fix additionalDeliminator attribute

2019-08-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:ff06ba217e40: fix additionalDeliminator attribute (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23134?vs=63771=63835#toc REPOSITORY R216

D14632: keyword rule: Spport for keywords inclusion from another language/file

2019-08-15 Thread jonathan poelen
jpoelen added a comment. I don't think using the original word delimiters is a good thing. Let's imagine that c.xml lists the functions of the libc and a language that allows them to be used as `ffi.C.printf` (luajit for the curious). The separators of the 2 languages are not the same and

D23137: C++: contracts are not in C++20

2019-08-15 Thread Christoph Cullmann
cullmann closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23137 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann,

D23159: Prevent error() being emitted when purposefully reading 0 bytes

2019-08-15 Thread Alexander Saoutkin
feverfew added inline comments. INLINE COMMENTS > chinmoyr wrote in file.cpp:524 > This doesn't support error reporting. Why not refactor this loop using > read(char *, qint64)? I believe you can accommodate your changes inside the > loop cleanly then. I think that would be appropriate for a

D23134: fix additionalDeliminator attribute

2019-08-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the test. With git diff -w the patch looks fine. REPOSITORY R216 Syntax Highlighting BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL

D23196: have the app icon as fallback icon in Snore

2019-08-15 Thread Piyush Aggarwal
brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY by this patch, apps with a set WindowIcon will have that icon as

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

2019-08-15 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Only interpolation with variable (`#{$...}`) and beginning of the string

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-15 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 63846. brute4s99 added a comment. took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well! REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23133?vs=63674=63846 BRANCH

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

2019-08-15 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 16 Aug 2019 03:08:12 + Build duration: 5 min 12 sec and counting JUnit Tests