daandemeyer created this revision.
daandemeyer added a reviewer: KTextEditor.
daandemeyer added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this revision.
REVISION SUMMARY
davidedmundson added a comment.
kmymoney to pick one example uses KPageWidgetModel without a KPageDialog. No
idea if the title is shown or not elsewhere, but it shows it's a risky business
changing it.
Personally I don't understand what problem we're trying to solve.
I also think
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Makes sense; this shouldn't assert.
REPOSITORY
R293 Baloo
BRANCH
fixCrashWithEmptyFolder
REVISION DETAIL
https://phabricator.kde.org/D23200
To: tcanabrava, #baloo, astippich,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> renamefiledialog.cpp:215
> +connect(job, ::result, this, ::deleteLater);
> +connect(job, ::error, this, ::slotError);
> +
This can't possibly work,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/20/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 16 Aug 2019 12:32:44 +
Build duration:
1 min 27 sec and counting
JUnit Tests
Name:
ngraham created this revision.
ngraham added reviewers: VDG, elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Right now too-long labels get right-elided, which among other minor
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23201
To: ngraham, #vdg, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
feverfew added inline comments.
INLINE COMMENTS
> chinmoyr wrote in file.cpp:520
> A loop is required here. The docs don't really specify anything about reading
> data in one go.
Exactly. The docs weren't specific at all. smb/sftp would read once, and return
the result. the file slave would
tcanabrava updated this revision to Diff 63863.
tcanabrava added a comment.
- Remove debug line
- return null instead of asserting
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23200?vs=63858=63863
BRANCH
fixCrashWithEmptyFolder
REVISION DETAIL
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
Please just return without message, and also change the one below.
Searchstore is used by krunner (via baloorunner), and it searches as you
type, so a term could be invalid for
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/49/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Fri, 16 Aug 2019 12:32:44 +
Build duration:
7 min 57 sec and counting
BUILD ARTIFACTS
ngraham added a comment.
I can't get the new currency to actually show up in KRunner when I test the
patch. Does it work for you?
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D23193
To: shubham, #frameworks, ngraham
Cc: #frameworks, kde-frameworks-devel,
ngraham abandoned this revision.
ngraham added a comment.
Yeah, after living with this for a while I haven't managed to convince myself
either. Let's focus on fixing the title redundancy and layout issues another
way.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
ngraham added reviewers: Baloo, astippich, bruns, poboiko.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D23200
To: tcanabrava, #baloo, astippich, bruns, poboiko
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh, astippich,
tcanabrava created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
tcanabrava requested review of this revision.
REPOSITORY
R293 Baloo
BRANCH
fixCrashWithEmptyFolder
REVISION DETAIL
https://phabricator.kde.org/D23200
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/48/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Fri, 16 Aug 2019 11:53:56 +
Build duration:
1 min 17 sec and counting
CONSOLE OUTPUT
[...truncated
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/19/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 16 Aug 2019 11:53:56 +
Build duration:
1 min 42 sec and counting
JUnit Tests
Name:
feverfew updated this revision to Diff 63861.
feverfew added a comment.
Addressing comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23194?vs=63841=63861
BRANCH
ConsistentRead (branched from master)
REVISION DETAIL
feverfew updated this revision to Diff 63876.
feverfew added a comment.
Unnecessary min version upgraded
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23207?vs=63875=63876
BRANCH
fixSFTP (branched from master)
REVISION DETAIL
chinmoyr added inline comments.
INLINE COMMENTS
> sitter wrote in AuthBackend.h:61
> I didn't check super carefully but at a glance the backend api is not public
> API so we could probably refactor this right now already.
>
> Also, shouldn't the callerID be a const ref?
the mac backend
feverfew added inline comments.
INLINE COMMENTS
> chinmoyr wrote in file.h:117
> Nitpick; why not just closeFile() ?
That's how sftp does it, so for consistency.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23194
To: feverfew, dfaure, fvogt, chinmoyr, apol
Cc:
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
fixCrashWithEmptyFolder
REVISION DETAIL
https://phabricator.kde.org/D23200
To: tcanabrava, #baloo, astippich, bruns, poboiko, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo,
daandemeyer created this revision.
daandemeyer added a reviewer: Framework: Syntax Highlighting.
daandemeyer added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this
feverfew created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
feverfew requested review of this revision.
REPOSITORY
R320 KIO Extras
BRANCH
fixSFTP (branched from master)
REVISION DETAIL
chinmoyr updated this revision to Diff 63880.
chinmoyr marked 6 inline comments as done.
chinmoyr added a comment.
Addressed comments.
REPOSITORY
R283 KAuth
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21795?vs=59775=63880
BRANCH
master
REVISION DETAIL
hallas created this revision.
hallas added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
hallas requested review of this revision.
REVISION SUMMARY
Optimize KProcessList::processInfo on unix so that it doesn't iterate over all
processes and then filter the list to
feverfew added inline comments.
INLINE COMMENTS
> file.cpp:550
> +// Make sure data gets to disk.
> +if (mFile->flush())
> +written(bytesWritten);
Flushing on every write IMO is a bit expensive, but I don't like the fact that
close() can't report errors and so we
feverfew marked 4 inline comments as done.
feverfew added inline comments.
INLINE COMMENTS
> chinmoyr wrote in filejob.h:48
> Document the methods in SlaveBase as well.
I've used @see to help me out. Is that enough? I don't want to duplicate the
docs, especially if someone changes it and
feverfew retitled this revision from "Fixing finished() called after error() in
smb slave. Do not call finished() in open/read/write/seek operations" to
"Fixing implementation of FileJob interface in smb/sftp slaves".
feverfew edited the summary of this revision.
feverfew edited the test plan
brute4s99 marked 3 inline comments as done.
brute4s99 added inline comments.
INLINE COMMENTS
> broulik wrote in notifybysnore.cpp:163
> The explicit call to `actualSize` shouldn't be neccessary
just to be sure :)
but if there's a check implemented already somewhere within QIcon, I'd happily
brute4s99 updated this revision to Diff 63888.
brute4s99 added a comment.
updated
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23196?vs=63847=63888
BRANCH
arcpatch-D23196
REVISION DETAIL
https://phabricator.kde.org/D23196
AFFECTED FILES
broulik added inline comments.
INLINE COMMENTS
> notifybysnore.cpp:159
> +} else {
> +Qstring iconPath = QString(m_iconDir.path() + QLatin1Char('/')
> ++ QString::number(notification->id()) +
> QStringLiteral(".png"));
Did you even compile this?
Also,
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> renamefiledialog.cpp:67
> +{
> +const QSize minSize = minimumSize();
> +setMinimumSize(QSize(320, minSize.height()));
This returns an invalid size
bruns added inline comments.
INLINE COMMENTS
> ivan wrote in GtkEventSpy.cpp:126
> No need to compare chars with strings:
>
> if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'')
missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII
-> `if
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/11/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 17 Aug 2019 03:07:14 +
Build duration:
13 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/31/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 17 Aug 2019 03:06:52 +
Build duration:
14 min and counting
JUnit Tests
Name: projectroot
bruns added inline comments.
INLINE COMMENTS
> dfaure wrote in renamefiledialog.cpp:119
> Oops yes I meant items.first().url().path(). OK for fileName(), path() is
> faster but this code path isn't speed critical.
anything wrong with `KFileItem::name()`?
REPOSITORY
R241 KIO
REVISION DETAIL
ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.
Another tiny change, and I think it is ready to land. Unless someone else
sees other issues.
INLINE COMMENTS
> GtkEventSpy.cpp:126
> +
> +if (exec.at(0) ==
brute4s99 added a reviewer: broulik.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D23196
To: brute4s99, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
meven updated this revision to Diff 63854.
meven marked 14 inline comments as done.
meven added a comment.
uncrustify file, typo fixes, add error slot
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17595?vs=63796=63854
BRANCH
arcpatch-D17595
REVISION
meven marked 4 inline comments as done.
meven added a comment.
Btw the licensing issue is not resolved yet.
I will update the license once this has cleared.
INLINE COMMENTS
> dfaure wrote in renamefiledialog.cpp:119
> items.first().path() would be simpler and faster.
> (that doesn't give
meven marked 4 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17595
To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann,
pino, kde-frameworks-devel, LeGast00n,
GB_2 added a comment.
Don't use the unicode ellipsis. We use three dots everywhere.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19620
To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n,
chinmoyr requested changes to this revision.
chinmoyr added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> filejob.cpp:181
> +slaveDone();
> +// Scheduler::doJob(this);
> +q->emitResult();
Nitpick; spacing gotcha
> filejob.h:48
> /**
> -
44 matches
Mail list logo
