D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-20 Thread Méven Car
meven added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Definitely. Do you have an idea who ? BTW, I have one change planned for this

D5856: Use KDirWatch removeDir/addDir instead of stopDirScan/restartDirScan

2019-08-20 Thread Méven Car
meven added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. ping @dfaure Is it still valid ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5856 To: dfaure, aacid Cc: kde-frameworks-devel, meven, LeGast00n, michaelh,

D11554: Add warnings to why some actions might be invalid

2019-08-20 Thread Méven Car
meven added inline comments. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. INLINE COMMENTS > kauthaction.cpp:126 > +if (!d->valid) > +qCWarning(KAUTH) << "Backend does not recognize action: " << > name; > } else { Code style, use {} even

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. Btw, do all highlighting files using the include statement in lists use kateversion="5.53"? If not, we should fix it. In fact, we should extend our highlightingindexer to

D13757: Move parsing .desktop file for folder Comment to file KIO

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. Theres's also the directory icon reading which potentially blocks, so doing both in the KIO slave improves the situation without having to introduce new API and rewrite everything and the kitchen sink. REPOSITORY R241 KIO REVISION DETAIL

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the items outside the menu, it looks weird. This fixes it.

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23285 To: GB_2, #plasma, #frameworks, #vdg, filipf, apol Cc: #vdg, #frameworks,

D23061: Possiblity to change Definition data after loading

2019-08-20 Thread Nikita Sirgienko
sirgienko added a comment. Mm, any changes? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23061 To: sirgienko, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, GB_2, bmortimer, domson, michaelh, genethomas,

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D22946: Include API to generically implement --replace arguments

2019-08-20 Thread Aleix Pol Gonzalez
apol added a comment. ping REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks Cc: broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 updated this revision to Diff 64096. GB_2 added a comment. Only affect desktop REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23286?vs=64094=64096 BRANCH prevent-dragging-simplekcm-contents-outside-view (branched from master) REVISION DETAIL

D22775: Allow date range filtering of resource events using Date Term

2019-08-20 Thread Méven Car
meven added a comment. gentle ping @ivan REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22775 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-08-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 20 Aug 2019 06:59:16 + Build duration: 1 min 2 sec and counting JUnit Tests Name:

D23272: JavaScript: remove unnecessary "Conditional Expression" context

2019-08-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks very reasonable to me, thanks. REPOSITORY R216 Syntax Highlighting BRANCH javascript REVISION DETAIL https://phabricator.kde.org/D23272 To: nibags,

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-20 Thread Méven Car
meven added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela,

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-20 Thread Méven Car
meven added a comment. I'v added @dfaure as reviewer. David feel free to not review this if you think somebody else would be better suited. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc:

D11554: Add warnings to why some actions might be invalid

2019-08-20 Thread Méven Car
meven added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D11554 To: carewolf, vkrause, #frameworks Cc: kde-frameworks-devel, meven, LeGast00n, michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23285 To: GB_2, #plasma, #frameworks, #vdg, filipf Cc: #vdg,

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. Can we keep it on mobile? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Filip Fila
filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D23285 To: GB_2, #plasma,

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Hannah von Reth
vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks, vonreth Cc: kde-frameworks-devel, vonreth,

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, Frameworks, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY You should not be able to drag the contents outside the view, it looks weird.

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, bruns

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Filip Fila
filipf added a comment. +1 visually If the behavior is important on mobile let's keep it there of course, but on desktop it feel out of place. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg Cc: filipf, broulik,

D23262: disable autouic again - it breaks builds

2019-08-20 Thread Harald Sitter
sitter added a comment. https://gitlab.kitware.com/cmake/cmake/issues/19615 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D23047: Properly turn real into integer

2019-08-20 Thread Aleix Pol Gonzalez
apol added a comment. ping REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D23047 To: apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23272: JavaScript: remove unnecessary "Conditional Expression" context

2019-08-20 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4bc333ee2509: JavaScript: remove unnecessary Conditional Expression context (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23149: Only build tests when DBus is available

2019-08-20 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH dbustest REVISION DETAIL https://phabricator.kde.org/D23149 To: nicolasfella, bcooksley, broulik, bruns, #frameworks, apol Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n,

D23149: Only build tests when DBus is available

2019-08-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R245:f7149af10e4b: Only build tests when DBus is available (authored by nicolasfella). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23149?vs=63732=64104 REVISION

D23124: Remove unused DBus XML file

2019-08-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:ee235f11c13a: Remove unused DBus XML file (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23124?vs=63655=64103 REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

2019-08-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 20 Aug 2019 11:32:59 + Build duration: 3 min 16 sec and counting JUnit Tests Name:

D23313: improve code in Snore backend

2019-08-20 Thread Piyush Aggarwal
brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-20 Thread Albert Astals Cid
aacid updated this revision to Diff 64176. aacid edited the summary of this revision. aacid removed a subscriber: ltoscano. aacid added a comment. update commit log REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23119?vs=63633=64176 BRANCH

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting and some improvements (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23278?vs=64078=64182#toc REPOSITORY

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
jpoelen added a comment. The other files that use the include statement are also in version 5.53. If highlightingindexer adds a version check, it is also necessary to check that the included files are of the same or lower version. Ideally, this should also be done for IncludeRules.

D23312: JSP: support of

2019-08-20 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 345003 REPOSITORY R216 Syntax Highlighting BRANCH jsp (branched from

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 96 - Fixed!

2019-08-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 21 Aug 2019 03:03:52 + Build duration: 2 min 58 sec and counting BUILD ARTIFACTS

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

2019-08-20 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > kwindowsystem.cpp:458 > > +static QWindow* setMainWindowHelper(QWindow *subWindow, WId mainWindowId) > +{ Coding style: For pointers or references, use a single space before '*' or '&', but not after.

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. In D23286#515329 , @GB_2 wrote: > I will fix it there, but it won't disable click and drag to scroll the view if it's scrollable. It just disables click and drag scroll when there is no scrollbar Right, that's

D23300: Add FictionBook 2 icons

2019-08-20 Thread Yuri Chornoivan
yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

2019-08-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Interesting design! However having that triangular part jutting out of the side is pretty unusual, and not seen in any other MimeType icons. Maybe move that shape fully inside

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. Ah ok. REPOSITORY R296 KDeclarative BRANCH prevent-dragging-simplekcm-contents-outside-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg, davidedmundson Cc: ngraham, filipf, broulik, #vdg,

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-20 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Yes, it may surprise you, but i did actually run the tests before submitting this code change. REPOSITORY R263

D23300: Add FictionBook 2 icons

2019-08-20 Thread Yuri Chornoivan
yurchor created this revision. yurchor added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. yurchor requested review of this revision. REVISION SUMMARY FictionBook 2 icons from Okular (design by Vladimir Prohorenkov, my implementation).

D23300: Add FictionBook 2 icons

2019-08-20 Thread Yuri Chornoivan
yurchor updated this revision to Diff 64152. yurchor added a comment. Remove extra font dependencies REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64148=64152 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23300 AFFECTED

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg, davidedmundson Cc: ngraham, filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-20 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Declensions: https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension REPOSITORY R263

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 added a comment. > This would disable it when using a touch swipe or a touchpad on the desktop too though, right? That doesn;t seem desirable. I think we on;y want scroll overshoot disabled when using a scroll wheel; for all other cases, IMO it should be on. That's how it is now,

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks, vonreth Cc:

D23291: have application's icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23291 AFFECTED FILES

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. Just on Windows, or does this fix the problem on Linux too? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2,

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Björn Feber
GB_2 added a comment. In D23286#515322 , @ngraham wrote: > +1, but maybe this doesn't go far enough. How about doing it for `ScrollablePage` instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this. I will fix

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Kai Uwe Broulik
broulik accepted this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman,

D23291: have application's icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23291 To: brute4s99 Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64118. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23291?vs=64116=64118 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23291 AFFECTED FILES src/notifybysnore.cpp To: brute4s99 Cc:

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2019-08-20 Thread Kai Uwe Broulik
broulik added a comment. In D16311#353808 , @dfaure wrote: > This map will keep growing and growing... Are you sure? It didn't grow during my testing, even after moving places around and adding and removing items. It could always

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64111. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64110=64111 BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 AFFECTED FILES src/notifybysnore.cpp To:

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal
This revision was automatically updated to reflect the committed changes. Closed by commit R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64111=64112

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. +1, but maybe this doesn't go far enough. How about doing it for `ScrollablePage` instead? That would fix https://bugs.kde.org/show_bug.cgi?id=403837 as well as this. REPOSITORY R296 KDeclarative BRANCH prevent-dragging-simplekcm-contents-outside-view (branched

D23196: have the app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64114. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64113=64114 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Piyush Aggarwal
This revision was automatically updated to reflect the committed changes. Closed by commit R289:a9b61d5b0cb8: avoid duplicate notifications from showing up on Windows and remove whitespaces (authored by brute4s99). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23133?vs=63846=64122#toc

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a comment. landed it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: nicolasfella, ngraham, broulik,

D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH prevent-dragging-simplekcm-contents-outside-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D23286 To: GB_2, #plasma, #frameworks, #vdg,

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64110. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64085=64110 BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 AFFECTED FILES src/notifybysnore.cpp To:

D23282: add `-pid` parameter to Snore backend calls

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a comment. had some non-unix line endings, so updated the diff. REPOSITORY R289 KNotifications BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks, vonreth Cc: kde-frameworks-devel, vonreth,

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

2019-08-20 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > kfileplacesview.cpp:1089 > // it after the remove only). > connect(model, SIGNAL(rowsRemoved(QModelIndex,int,int)), > this, SLOT(adaptItemSize()), Qt::QueuedConnection); I think David F means you should connect here

D23047: Properly turn real into integer

2019-08-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D23047 To: apol, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64113. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63984=64113 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64115. brute4s99 retitled this revision from "have the app icon as fallback icon in Snore" to "have 1024x1024 app icon as fallback icon in Snore". brute4s99 added a comment. removed `actualSize` in favour of always passing an icon of size 1024x1024 to

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
This revision was automatically updated to reflect the committed changes. Closed by commit R289:e96bf17d8cac: have 1024x1024 app icon as fallback icon in Snore (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64119=64120

D23196: have the app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman,

D23196: have 1024x1024 app icon as fallback icon in Snore

2019-08-20 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 64119. brute4s99 added a comment. changed line endings to Unix style REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64115=64119 BRANCH arcpatch-D23196 REVISION DETAIL

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

2019-08-20 Thread Piyush Aggarwal
brute4s99 added a subscriber: nicolasfella. brute4s99 added a comment. In D23133#515156 , @ngraham wrote: > Just on Windows, or does this fix the problem on Linux too? that problem has been fixed by @nicolasfella on master of