D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

apol added a comment. Makes sense, but I feel some explanation is missing ^^' Put it in the commit message? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

apol abandoned this revision. apol added a comment. https://commits.kde.org/krunner/ae5a477b9d41e33137c4c8447e3fbe6e4b72cf32 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt, davidedmundson Cc: aacid, kde-frameworks-devel,

D23312: JSP: support of

This revision was automatically updated to reflect the committed changes. Closed by commit R216:433e5d85979c: JSP: support of script and style ; use IncludeRule ##Java (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23312?vs=64183=64259#toc REPOSITORY R216 Syntax

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64236. yurchor added a comment. Optimize SVG with svgcleaner + svgo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64212=64236 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23300

D22708: [WIP] Add a kded module infra for fuse mount services

feverfew added a comment. In D22708#516128 , @ngraham wrote: > Oh good. :) Is there anywhere I can follow the progress? All my work goes on KIOFuse goes into review here: https://gitlab.com/Vogtinator/kio-fuse/merge_requests

D22708: [WIP] Add a kded module infra for fuse mount services

feverfew added a comment. In D22708#516132 , @ngraham wrote: > In D22708#516131 , @feverfew wrote: > > > In D22708#516128 , @ngraham wrote: > > > > >

D23300: Add FictionBook 2 icons

ndavis added a comment. Reduce the size of the SVGs by optimizing them with one of these tools: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23323 AFFECTED FILES src/core/ktcpsocket.cpp

D22708: [WIP] Add a kded module infra for fuse mount services

feverfew added a comment. In D22708#507449 , @ngraham wrote: > What? Don't worry, all is fine. I've taken over Chinmoy's work on this for now. We agreed on a better way to go about integrating KIOFuse into KIO. REPOSITORY R241 KIO

D22708: [WIP] Add a kded module infra for fuse mount services

ngraham added a comment. Oh good. :) Is there anywhere I can follow the progress? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22708 To: chinmoyr Cc: feverfew, ngraham, andriusr, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22708: [WIP] Add a kded module infra for fuse mount services

ngraham added a comment. In D22708#516131 , @feverfew wrote: > In D22708#516128 , @ngraham wrote: > > > Oh good. :) Is there anywhere I can follow the progress? > > > All my work goes on

D9175: Migrate some more QRegExps to QRegularExpression

dhaumann updated this revision to Diff 64248. dhaumann added a comment. - Rebase from 2016 to year 2019. I don't even know whether it still compiles... REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9175?vs=23538=64248 BRANCH QRegExpCleanup2

D23313: improve code in Snore backend

brute4s99 abandoned this revision. brute4s99 added a comment. in that case I should rather leave this diff. I agree this would be messy for the history. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23313 To: brute4s99, broulik Cc: kde-frameworks-devel,

D23313: improve code in Snore backend

broulik added a comment. I don't really see the point in this cleanup as it only messes up git history and doesn't actually follow coding style better INLINE COMMENTS > notifybysnore.cpp:141 > + > +void NotifyBySnore::notify(KNotification* notification, KNotifyConfig > *config) > +{ The

D23300: Add FictionBook 2 icons

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64186. yurchor added a comment. Be consistent with existing book-style icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64152=64186 BRANCH master REVISION DETAIL

D22946: Include API to generically implement --replace arguments

davidedmundson requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n,

D22946: Include API to generically implement --replace arguments

davidedmundson added inline comments. INLINE COMMENTS > kdbusservice.cpp:129 > +d->registered = bus->registerService(d->serviceName > + , (options & Replace) ? > QDBusConnectionInterface::ReplaceExistingService : >

D23047: Properly turn real into integer

This revision was automatically updated to reflect the committed changes. Closed by commit R302:ee1d424f1cb9: Properly turn real into integer (authored by apol). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23047?vs=63418=64204 REVISION DETAIL

D22723: Fix RunnerManager::queryFinished()

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in runnermanager.cpp:360 > can you explain why we need this? In checkTearDown we have the code that reacts to the job being done. If we don't set it to true we'll never be looking at whether all jobs are done because we'll

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64206. yurchor added a comment. Total unbrutalization REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64186=64206 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23300 AFFECTED FILES

D23300: Add FictionBook 2 icons

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH betterhack REVISION DETAIL https://phabricator.kde.org/D22758 To: fvogt, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23300: Add FictionBook 2 icons

ngraham added a comment. Better, thanks! Any chance you could make the gray background color a bit different? Maybe lighter, or some other color? That particular gray isn't a very attractive color IMO. It's very brutalist. :) REPOSITORY R266 Breeze Icons REVISION DETAIL

D22723: Fix RunnerManager::queryFinished()

davidedmundson added inline comments. INLINE COMMENTS > runnermanager.cpp:360 > > +teardownRequested = true; > checkTearDown(); can you explain why we need this? REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D22723 To: apol, #frameworks, fvogt,

D23300: Add FictionBook 2 icons

ngraham added a comment. Haha that pink might be a bit too un-brutalist. :) Orange-on-pink isn't exactly the best color combination. A blue background of some sort might be nicer with the orange polygon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300

D23300: Add FictionBook 2 icons

yurchor edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23314: Fix runnertest exiting early

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Some runner uses KIO, which creates a quitLock which kills the

D23315: Port runnertest to QGuiApplication

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Runners deal with icons and therefor use pixmaps and such

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Edit. On testing this doesn't seem to work. See runnertest (with D23314 ) REPOSITORY R308 KRunner REVISION DETAIL

D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R308:54e18b0d9b0d: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly (authored by fvogt).

D23314: Fix runnertest exiting early

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D23314 To: davidedmundson, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22859: Add Q_PROPERTIES interface to KDescendantsProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:ed7cdfcc3898: Add Q_PROPERTIES interface to KDescendantsProxyModel (authored by davidedmundson). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D23315: Port runnertest to QGuiApplication

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D23315 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/3/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 21 Aug 2019 13:02:30 + Build duration: 15 min and counting JUnit Tests Name:

D23300: Add FictionBook 2 icons

yurchor updated this revision to Diff 64212. yurchor added a comment. Use blue background REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23300?vs=64206=64212 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23300 AFFECTED FILES

D23314: Fix runnertest exiting early

This revision was automatically updated to reflect the committed changes. Closed by commit R308:f53b34e179ce: Fix runnertest exiting early (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23314?vs=64190=64215 REVISION DETAIL

D23315: Port runnertest to QGuiApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R308:54d55441ec7e: Port runnertest to QGuiApplication (authored by davidedmundson). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23315?vs=64192=64216 REVISION DETAIL

D23312: JSP: support of

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Nice simplification. REPOSITORY R216 Syntax Highlighting BRANCH jsp (branched from master) REVISION DETAIL https://phabricator.kde.org/D23312 To: jpoelen,

D22723: Fix RunnerManager::queryFinished()

davidedmundson added a comment. Makes sense, thanks. (well makes sense, within the confines of the mess that is RunnerManager) This morning I accepted Fabian's patch, but it wasn't complete. Can you merge these two lines from your patch: https://phabricator.kde.org/P455

D23300: Add FictionBook 2 icons

ngraham added a subscriber: ndavis. ngraham added a comment. LGTM. @ndavis? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23300 To: yurchor, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns