D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-08-29 Thread Marcin Dłubakowski
mdlubakowski marked 4 inline comments as done. mdlubakowski added a comment. First of all, sorry for the mess I made here with Arcanist. My SSD died recently and I lost original repository with those changes, so I used `arc patch` to pull it back, updated the code and pushed here with `arc

D23555: Add @since 5.62 for newly added setters

2019-08-29 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23555 To: meven, ivan, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23552: ECM: remove set_package_properties from FindCanberra

2019-08-29 Thread David Faure
dfaure abandoned this revision. dfaure added a comment. Ah, I didn't realize there was no warning if calling set_package_properties with different properties. Good idea. Done in https://commits.kde.org/knotifications/06f5a4a6f8622913cb9cecd89b98cf762a489823 REPOSITORY R240 Extra

D23556: Add version requirement to dependency KActivitiesStats

2019-08-29 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R320:bca85c1c50c1: Add version requirement to dependency KActivitiesStats (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23556?vs=64918=64923

D23555: Add @since 5.62 for newly added setters

2019-08-29 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R159:91f28c34cf74: Add @since 5.62 for newly added setters (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23555?vs=64917=64924

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Méven Car
meven updated this revision to Diff 64927. meven added a comment. Adapt kio tests to changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7446?vs=64880=64927 BRANCH arcpatch-D7446 REVISION DETAIL https://phabricator.kde.org/D7446 AFFECTED FILES

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun,

D23344: assert slave command finality

2019-08-29 Thread Harald Sitter
sitter added a comment. Shoes! I meant shoes!  REPOSITORY R241 KIO BRANCH assert REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23559: Incorporated feedback

2019-08-29 Thread Marcin Dłubakowski
mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D23559 AFFECTED FILES

D23500: Support for native Matlab strings

2019-08-29 Thread Benjamin Buch
bbuch updated this revision to Diff 64926. bbuch added a comment. Highlighting of keywords, variables and operators as such for Matlab source files Currently, Matlab source files display keywords, variables, and operators as normal text. So they don't get any special highlighting and

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

2019-08-29 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 29 Aug 2019 09:23:21 + Build duration: 4 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

2019-08-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/42/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 29 Aug 2019 10:49:31 + Build duration: 8 min 12 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kiconthemes » kf5-qt5 SUSEQt5.12 - Build # 35 - Failure!

2019-08-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 29 Aug 2019 05:31:01 + Build duration: 3 hr 48 min and counting CONSOLE OUTPUT

D23344: assert slave command finality

2019-08-29 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:830c56744f2b: assert slave command finality (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23344?vs=64826=64928 REVISION DETAIL

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-29 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > klistopenfiles.cpp:29 > + > +class ListOpenFilesJobPrivate : public QObject > +{ I wonder if this actually needs to be a QObject, given that you use connect-to-pointer-to-member-function? > hallas wrote in klistopenfiles.cpp:44 > Should I also

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-29 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

2019-08-29 Thread Nicolas Fella
nicolasfella removed a reviewer: markg. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, spoorun, anthonyfieroni,

D23556: Add version requirement to dependency KActivitiesStats

2019-08-29 Thread Ivan Čukić
ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D23556 To: meven, #frameworks, kossebau, ivan Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe,

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

2019-08-29 Thread Benjamin Buch
bbuch added a comment. Added changes to D23500 . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: bbuch, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-08-29 Thread Marcin Dłubakowski
mdlubakowski updated this revision to Diff 64930. mdlubakowski added a comment. Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22510?vs=61918=64930 BRANCH arcpatch-D22510 REVISION DETAIL https://phabricator.kde.org/D22510 AFFECTED

D22510: Added dialog to set execute permission for executable file when trying to run it.

2019-08-29 Thread Marcin Dłubakowski
mdlubakowski marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks, dfaure, cfeck, pino Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in atticaprovider.cpp:355 > That'd be good, except the rest of the KNewStuff API is all QList based. > It'll want doing for KF6, but since QList is being deprecated for that > anyway, i'm thinking we'll end up with a general

D23344: assert slave command finality

2019-08-29 Thread David Faure
dfaure added a comment. LOL, so even the joke (about you writing buggy code) was buggy, good one ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde updated this revision to Diff 64946. alexde added a comment. Add new 32px icons. The root is now less faint and uses the original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64944=64946 BRANCH ROOT (branched from

D23555: Add @since 5.62 for newly added setters

2019-08-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > query.h:101 > void addUrlFilters(const QStringList ); > +/* > + * @since 5.62 One issue here: for doxygen to pick this up and thus add to generated docs, the comment has to start with `/**`. Fixing myself this time, as I have the

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde updated this revision to Diff 64935. alexde added a comment. Improve the root logo layout and change the root's color to the offical color 1ED4E5 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64668=64935 BRANCH ROOT (branched from

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde updated this revision to Diff 64944. alexde added a comment. Also add the new 64px breeze icon. Add new 22 px icons. Transparent background, less faint, original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64935=64944

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-29 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 64934. leinir added a comment. - Debug-- - Ensure data is actually loaded properly, also from cache - Include the right header - Adapt the Discover comments delegate (and add a nesting indicator) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-29 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde added a comment. In D23464#521662 , @ndavis wrote: > I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > meven wrote in CMakeLists.txt:68 > See D23556 Thanks for the quick fixes :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure

D23344: assert slave command finality

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23537: extend state verification to open connection commands

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23552: ECM: remove set_package_properties from FindCanberra

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R283

D23381: Allow splitting lists using ;

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R237

D22528: KIO FTP: Fix file copy hanging when copying to existing file

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D22968: Make it possible to modify contacts

2019-08-29 Thread Jonah Brüchert
jbbgameich added inline comments. INLINE COMMENTS > peopleqmlplugin.cpp:64 > qmlRegisterUncreatableType(uri, 1, 0, "ActionType", > QStringLiteral("You cannot create ActionType")); > +qmlRegisterSingletonType(uri, 1, 0, > "Manager", [] (QQmlEngine*, QJSEngine*) -> QObject* { return new

D23344: assert slave command finality

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R241

D22805: set autorcc and autouic by default

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240

D23262: disable autouic again - it breaks builds

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R240

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-29 Thread Fuk Sitter
fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R320

D23555: Add @since 5.62 for newly added setters

2019-08-29 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > One issue here: for doxygen to pick this up and thus add to generated docs, > the comment has to start with `/**`. Fixing myself this time, as I have the > code in front of me

Re: detect the Qt version KF5 frameworks were built against in CMake?

2019-08-29 Thread René J . V . Bertin
Friedrich W. H. Kossebau wrote: > Can you specifiy some more what you mean by "pull in"? Adding indirect dependencies of the target framework needed for it to link successfully, as you deduced below. > It also assumes you use compatible build flags for Qt and do not have e.g. Of course, the

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Alex Debus
alexde added a comment. > The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint. Rethinking it, I think it's wrong. The white background belongs to the logo and should not be removed as the white circle and the root symbol belong together,

D16395: Update the "About KDE" text

2019-08-29 Thread Fu Sitter
fusitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R263

D23515: Format class: add functions to know if XML files set style attributes

2019-08-29 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. What I currently dislike is that `definitionHasXyz` implies the Definition class has something, which is not correct, since it's about whether the Format has an override. I

D23515: Format class: add functions to know if XML files set style attributes

2019-08-29 Thread Christoph Cullmann
cullmann added a comment. As we have already members like hasX would it make sense to have hasItalicOverride() to be more consistent? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting,

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread TrickyRicky
trickyricky26 added a comment. My thoughts on your submission: For the 16px and 22px designs, I would with the designs @ndavis proposed here: In D23464#521662 , @ndavis wrote: > F7290924: mimetypes.tar.gz

D23500: Support for native Matlab strings

2019-08-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:20e4bb60aa40: Support for native Matlab strings (authored by bbuch, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23515: Format class: add functions to know if XML files set style attributes

2019-08-29 Thread Christoph Cullmann
cullmann added a comment. Shall we go with the definitionHasX style or change it? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel,

D23344: assert slave command finality

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, fsitter

D23262: disable autouic again - it breaks builds

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fusitter. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns, fusitter

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D21795 To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter Cc: bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns,

D23381: Allow splitting lists using ;

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23381 To: apol, #frameworks Cc: bcooksley, dfaure, kossebau, sitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, fsitter

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fsitter. REPOSITORY R320 KIO Extras BRANCH fixSFTP (branched from master) REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc: bcooksley, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n,

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

2019-08-29 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: cullmann, bbuch Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

2019-08-29 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann edited reviewers, added: bbuch; removed: cullmann. cullmann added a comment. Ok, then we can abandon this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23498 To: cullmann, bbuch Cc: kwrite-devel,

D23500: Support for native Matlab strings

2019-08-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, this seems ok for me, will add the needed test references myself (make test complaints about missing ones). REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D23500

D23500: Support for native Matlab strings

2019-08-29 Thread Christoph Cullmann
cullmann added a comment. I see, there is already some highlight.m test, I will just add your test case to that stuff. REPOSITORY R216 Syntax Highlighting BRANCH arcpatch-D23500 REVISION DETAIL https://phabricator.kde.org/D23500 To: bbuch, cullmann Cc: dhaumann, kwrite-devel,

D22968: Make it possible to modify contacts

2019-08-29 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 64963. apol added a comment. Don't get creative naming classes on the qml plugin REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64834=64963 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968

D22968: Make it possible to modify contacts

2019-08-29 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2019-08-29 Thread Ben Cooksley
bcooksley removed a subscriber: fusitter. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: bcooksley, valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

2019-08-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 30 Aug 2019 03:17:49 + Build duration: 9 min 5 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 105 - Fixed!

2019-08-29 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/105/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 30 Aug 2019 03:18:34 + Build duration: 9 min 27 sec and counting BUILD ARTIFACTS

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-29 Thread David Hallas
hallas updated this revision to Diff 64973. hallas marked 2 inline comments as done. hallas added a comment. Review comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21760?vs=64911=64973 BRANCH add_list_processes_with_open_files (branched from

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-29 Thread David Hallas
hallas added a comment. @dfaure - Overall, what do you think about the approach of subclassing KJob? Did it turn out like you had thought? And is this the solution we should go with, or was one of the other solutions better? INLINE COMMENTS > dfaure wrote in klistopenfiles.cpp:29 > I

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-29 Thread David Hallas
hallas added a comment. One thing, when this is ready to land I will address the Windows support so that we do not get broken builds :) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D21760 To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns,

D23552: ECM: remove set_package_properties from FindCanberra

2019-08-29 Thread Christophe Giboudeaux
cgiboudeaux added a comment. I'd do the opposite, remove `DESCRIPTION` and `URL` from knotification's CMakeLists.txt and only leave the `PURPOSE` line. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23552 To: dfaure, cgiboudeaux, sitter Cc: kossebau,

D23464: Add breeze icons for ROOT cern files

2019-08-29 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a

D23555: Add @since 5.62 for newly added setters

2019-08-29 Thread Méven Car
meven created this revision. meven added reviewers: ivan, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-29 Thread Méven Car
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > "5.62" of course :) Thanks D23555 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To:

D23556: Add version requirement to dependency KActivitiesStats

2019-08-29 Thread Méven Car
meven created this revision. meven added reviewers: Frameworks, kossebau. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. meven requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-29 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:68 > Please add a min version, as the code seems to rely on new API only added > recently: > > find_package(KF5ActivitiesStats 5.62.0 QUIET) See D23556

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-29 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe,

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

2019-08-29 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns