KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 30 Aug 2019 09:18:13 + Build duration: 8 min 0 sec and counting JUnit Tests Name:

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

This revision was automatically updated to reflect the committed changes. Closed by commit R320:28fdc41f1d45: Fixing implementation of FileJob interface in smb/sftp slaves (authored by feverfew). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64978. leinir added a comment. - Add a kf6 todo item (our api's QListey and should become QVectory) - Adopt a more pleasant comments layout REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64934=64978 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64979. leinir added a comment. - Switch to using a FileDialog-like property for changedEntries REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64978=64979 BRANCH knsquick-feature-parity-with-kns (branched

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:355 > Fair enough. I do try to make sure to use vectors as much as possible in new > API, but consistency is also a good argument. :) Think i might just pop in a TODO

D23576: Add property lastScan to WirelessDevice and associated change signal

meven created this revision. meven added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. meven requested review of this revision. REVISION SUMMARY To properly use the

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > wirelessdevice.h:133 > + * The time when the last "LastScan" property change was received > + * @since 5.62.0 > + * @return Add something like: @note will always return invalid QDateTime when runtime NM < 1.12 > wirelessdevice.h:228

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven retitled this revision from "Add property lastScan to WirelessDevice and associated change signal" to "Add property lastScanTime and lastRequestTime to WirelessDevice". meven edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. The KJob usage turned out exactly like I thought it would, I still think it's the right thing to do :-) INLINE COMMENTS > hallas wrote in klistopenfiles.cpp:29 > The primary

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a dependent revision: D23578: Before requesting a scan, check the time threshold. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScan to WirelessDevice and associated change signal

meven updated this revision to Diff 64983. meven added a comment. Change parameters REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64981=64983 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED FILES

D23194: Making FileJob behave consistently.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3154fc3e096e: Making FileJob behave consistently. (authored by feverfew). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23194?vs=64673=64976 REVISION DETAIL

D23576: Add property lastScan to WirelessDevice and associated change signal

jgrulich added a comment. In D23576#522340 , @meven wrote: > I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives. > This would be used to compute the time elapsed between

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > wirelessdevice.cpp:250 > +} else if (property == QLatin1String("LastScan")) { > +lastScanTime = QDateTime::currentDateTime(); > +Q_EMIT q->lastScanTimeChanged(lastScanTime); Don't use QDateTime::currentDateTime() as it might

D23576: Add property lastScan to WirelessDevice and associated change signal

meven added a comment. I am hesitant to add a second field "previousScan" that would store the previous lastScan timeStamp when a new one arrives. This would be used to compute the time elapsed between the scans which is necessary to do since Network manager requires scans to be at least

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir updated this revision to Diff 64986. leinir marked 18 inline comments as done. leinir added a comment. - Fiddle with the downloaditems sheet layout a touch REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21721?vs=64979=64986 BRANCH

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 65002. meven added a comment. Convert the LastScan value to a QDateTime, update function and doc in consequence REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64987=65002 BRANCH master REVISION

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 4 inline comments as done. meven added a comment. I have implemented the CLOCK_BOOTTIME conversion to QDateTime in `QDateTime NetworkManager::clockBootTimeToQDateTime` REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich

D23464: Add breeze icons for ROOT cern files

alexde added a reviewer: ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added inline comments. INLINE COMMENTS > jgrulich wrote in wirelessdevice.cpp:250 > Then cannot you work with it as with qlonglong? It shouldn't matter then if > it's in CLOCK_BOOTIME . I need to be able to know the elapsed time since LastScan. So it doesn't matter as long as I manage

D23586: Improve code that detects useful elements in an Svg file

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Detect any that contains a "-[a-z]" (i.e. a dash and a lowercase letter. So far

D23515: Format class: add functions to know if XML files set style attributes

nibags added a comment. I also like `hasXXOverride()`. In the case of **bold**, **italic**, **underline** and **strikeout**, functions such as `hasXXOverride()` are needed, since they are boolean values that can be turned off. But for the case **color**, **selectedColor**,

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

jgrulich added inline comments. INLINE COMMENTS > meven wrote in wirelessdevice.cpp:250 > LastScan is in CLOCK_BOOTIME which is complicated to work with. > So I use naively the signal time rather than the LastScan value. > This will need a bit of work just to work with it: >

D23587: Skip test on wayland

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's using some API that isn't available TEST PLAN Noise gone REPOSITORY R242 Plasma Framework (Library) BRANCH

D23587: Skip test on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R242:ea88d2aa51d2: Skip test on wayland (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23587?vs=65007=65008 REVISION DETAIL

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23490 To: nhiga, #frameworks, cfeck, pino, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#522270 , @trickyricky26 wrote: > As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep

D23587: Skip test on wayland

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23587 To: apol, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven updated this revision to Diff 64987. meven added a comment. Mention nm version limitation REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23576?vs=64983=64987 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23576 AFFECTED

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven marked 2 inline comments as done. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D23576 To: meven, jgrulich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

meven added a comment. In D23576#522341 , @jgrulich wrote: > In D23576#522340 , @meven wrote: > > > I am hesitant to add a second field "previousScan" that would store the previous lastScan

D23584: Cache windows thumbnails

broulik created this revision. broulik added reviewers: dfaure, pali, vonreth, antlarr. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY When the timestamp of the file changes, the

D23579: WIP: port ftp slave to new error reporting system

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This system is a bit inspired by an earlier patch I threw together in a half hour to prevent the actual logic code from

D23588: remove unnecessary check

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY setDevicePixelRatio already checks if it needs to enable m_textureChanged. TEST PLAN

D23515: Format class: add functions to know if XML files set style attributes

dhaumann added a comment. I believe you still need the hasTextColorOverride etc. hasTextColor is different and matches from the meaning isBold etc. Background: The styleOverrides are yet another concept: if the user changes a color of a highlighting in the Highlighting Text Styles tab,

D23464: Add breeze icons for ROOT cern files

ndavis added a comment. In D23464#522459 , @alexde wrote: > In D23464#522270 , @trickyricky26 wrote: > > > As @noahdvs mentioned above, the white background should be removed and the entire symbol

D23464: Add breeze icons for ROOT cern files

ngraham added a comment. If the 16px and 22px versions include the ring, then it needs to be in the larger versions as well. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis,

D23584: Cache windows thumbnails

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23584 To: broulik, dfaure, pali, vonreth, antlarr, ngraham Cc: kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe,

D23584: Cache windows thumbnails

This revision was automatically updated to reflect the committed changes. Closed by commit R320:1658029fd29e: Cache windows thumbnails (authored by broulik). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23584?vs=65001=65012 REVISION DETAIL

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 65006. meven added a comment. Lazily construct the KConfig but keep the instance as long as no config changes has occured REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=64816=65006 BRANCH arcpatch-D23523_1

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

nibags updated this revision to Diff 65018. nibags added a comment. - Update function names REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23516?vs=64780=65018 BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 AFFECTED FILES

D23515: Format class: add functions to know if XML files set style attributes

cullmann accepted this revision. cullmann added a comment. Think this is fine now, thanks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel,

D22968: Make it possible to modify contacts

jbbgameich accepted this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 31 Aug 2019 03:21:03 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D23597: Bulk port away from foreach

kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Few are left as they are with code which needs further analysis and

D23515: Format class: add functions to know if XML files set style attributes

nibags updated this revision to Diff 65017. nibags added a comment. - Update function names REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23515?vs=64779=65017 BRANCH format-new-functions REVISION DETAIL https://phabricator.kde.org/D23515

D23515: Format class: add functions to know if XML files set style attributes

dhaumann added a comment. Yes, that is also fine with me, please do the changes and proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel,