D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski marked 3 inline comments as done. mdlubakowski added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:390 > Can you split this into two "else if" conditions? It will be more readable > (both the condition, and the comment). This only duplicates a trivial "canRun > =

D23991: GIT_SILENT fix comment about passwords in debug output

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23991 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D23990 To: dfaure, apol, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH ahmad/url-debug-output-passwords (branched from master) REVISION DETAIL https://phabricator.kde.org/D23991 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

ahmadsamir updated this revision to Diff 66227. ahmadsamir added a comment. Remove redundant comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23991?vs=66217=66227 BRANCH ahmad/url-debug-output-passwords (branched from master) REVISION DETAIL

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. Ooh, I'm so excited that this will be landing soon! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham Cc: meven, trickyricky26, andreask, huftis, svenmauch,

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23994 To: dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23985: Consider UNC paths as NetworkShare context

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, looks great. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D23985 To: broulik, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n,

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:920784722205: [Exe Thumbnailer] Match 16 bit executables and dont request icon types… (authored by broulik).

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 83 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/83/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 16:04:02 + Build duration: 8 min 47 sec and counting JUnit Tests Name:

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

dfaure closed this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D23995 To: dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thank you! REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23994 To: dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

ngraham added a comment. I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham,

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

This revision was automatically updated to reflect the committed changes. Closed by commit R241:fdb10a52bfe8: Fixed interaction with DOS/Windows executables in KRun::runUrl (authored by mdlubakowski, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski added a comment. In D23989#532692 , @ngraham wrote: > I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts? I would say yes, since I imagine this may be

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

dfaure added inline comments. INLINE COMMENTS > broulik wrote in kcombobox.cpp:59 > With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind > autocompletes history entries rather than paths when hitting tab. Good catch! More precisely, history entries are offered in the lineedit

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D23990 To: dfaure, apol, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski updated this revision to Diff 66226. mdlubakowski added a comment. - Incorporated feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23989?vs=66215=66226 BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D23995 To: dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/82/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 14:24:54 + Build duration: 7 min 21 sec and counting JUnit Tests Name:

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

dfaure created this revision. dfaure added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY It is set by setLineEdit when the deprecated bool autoCompletion hasn't previously

D22365: KNotification macOS native support by NSNotificationCenter

Inoki added a comment. In D22365#532294 , @rjvbb wrote: > I haven't been able to give this much attention, sorry. > > After backporting the patch to OS X 10.9 it does work so I presume it'll work even better with the full functionality

D24004: Teach kwaylandscanner about PrimarySelection

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY This allows generating the skeleton classes for the primary selection protocol.

KDE CI: Frameworks » kplotting » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20WindowsMSVCQt5.13/7/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 19:39:58 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/8/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 19:51:53 + Build duration: 1 min 15 sec and counting CONSOLE OUTPUT

D22365: KNotification macOS native support by NSNotificationCenter

rjvbb added a comment. > Yeah, you're right that we should check system version for back-compatibility. Actually, I didn't want to suggest that. I haven't checked, but I think that the Qt requirement already ensures that the Cocoa APIs that you are using are present. > AFAIU,

D24010: Fix generating properties that start with an uppercase letter

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY We were not adjusting the property name to the getter letter-casing. TEST PLAN See

D24002: Sort files alphabetically in cmake list

zzag added inline comments. INLINE COMMENTS > CMakeLists.txt:49-50 > shell_interface.cpp > surface_interface.cpp > subcompositor_interface.cpp > textinput_interface.cpp Open vim, select all relevant lines in visual mode, and run sort command. REPOSITORY R127 KWayland

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/7/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 19:42:33 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure added a comment. Done, I released a KIO 5.62.1 and informed packagers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

ngraham added a comment. Thanks a bunch! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23989 To: mdlubakowski, dfaure, #frameworks Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

[IMPORTANT] Binary Factory & CI System Maintenance

Hi all, As part of changes to help improve the capacity, capability and security of the Binary Factory and CI system, i'm going to be performing a rebuild of several of the physical hosts responsible for performing builds on the CI system. Following these changes, signing operations for Flatpak

D24002: Sort files alphabetically in cmake list

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Adding further files is confusing, since the list is almost alphabetical.

D24003: kwaylandScanner produce version enum per class

gladhorn created this revision. gladhorn added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gladhorn requested review of this revision. REVISION SUMMARY Otherwise it only creates the enum for the first class encountered. REPOSITORY

D24003: kwaylandScanner produce version enum per class

zzag added a comment. FYI, https://phabricator.kde.org/D22362#493722 INLINE COMMENTS > generator.cpp:431 > auto it = std::find_if(m_interfaces.constBegin(), > m_interfaces.constEnd(), [] (const Interface ) { return i.isGlobal(); }); > -if (it !=

D24012: Supress mouse events in KCMs causing window moves

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY If a mouse press is handled by the new input handlers the mouse

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

hallas closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23884 To: hallas, dfaure Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24010: Fix generating properties that start with an uppercase letter

apol updated this revision to Diff 66271. apol added a comment. Also make the property lowercase QML doesn't like properties that start uppercase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66270=66271 BRANCH master REVISION DETAIL

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a reviewer: vkrause. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 82 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/82/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 04:19:22 + Build duration: 10 min and counting BUILD ARTIFACTS

D24010: Fix generating properties that start with an uppercase letter

aacid added a comment. Doesn't this create any change on the other test13 files? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24010 To: apol, #frameworks Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

dfaure created this revision. dfaure added reviewers: davidedmundson, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R127 KWayland BRANCH master REVISION DETAIL

D23815: [KConfig] port away from deprecated methods in Qt 5.14

pino added a comment. In D23815#528543 , @dfaure wrote: > If we want to enable this flag (to "punish" the first KDE developer who upgrades Qt, like me currently), then at least we should only do so in git checkouts, not in release tarballs. >

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/9/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 19:58:08 + Build duration: 2 min 57 sec and counting JUnit Tests

KDE CI: Frameworks » kplotting » kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20WindowsMSVCQt5.13/8/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 19:51:52 + Build duration: 3 min 27 sec and counting JUnit Tests

D22569: [Dialog] Apply window type after changing flags

This revision was automatically updated to reflect the committed changes. Closed by commit R242:67811e152a67: [Dialog] Apply window type after changing flags (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23968: Use app specific location for DB on Android

nicolasfella added a comment. I thought the same thing, but I'm not sure if changing that could break some apps REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

broulik added a comment. This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D22510 To: mdlubakowski, #frameworks,

D22365: KNotification macOS native support by NSNotificationCenter

rjvbb added a comment. I haven't been able to give this much attention, sorry. After backporting the patch to OS X 10.9 it does work so I presume it'll work even better with the full functionality availability. One thing: it has a hardcoded assumption that the Cocoa notication APIs

D23985: Consider UNC paths as NetworkShare context

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Location runner uses `KUriFilter` which translates "\\foo\bar" to smb://foo/bar" but

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/81/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 11:56:46 + Build duration: 23 min and counting JUnit Tests Name: projectroot

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

dfaure created this revision. dfaure added a reviewer: drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I did this the lazy way (s/data()/lock()/) because apparently this is just the q

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

dfaure updated this revision to Diff 66213. dfaure added a comment. link to task REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23988?vs=66212=66213 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23988 AFFECTED FILES src/adapter_p.cpp

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R269 BluezQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D23988 To: dfaure, drosca Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18425 To: broulik, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8e3b39635cb5: [KUrlNavigatorPlacesSelector] Properly identify teardown action (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23968: Use app specific location for DB on Android

apol added a comment. In D23968#532237 , @nicolasfella wrote: > I thought the same thing, but I'm not sure if changing that could break some apps I don't see how many apps would be using a writtableLocation they can't write into. :/

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18425 To: broulik, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 15 Sep 2019 16:55:50 + Build duration: 8 hr 15 min and counting

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:18:41 + Build duration: 53 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/9/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:21:47 + Build duration: 55 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/30/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:00:09 + Build duration: 8 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 00:13:10 + Build duration: 24 min and counting JUnit Tests Name: projectroot

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

mdlubakowski retitled this revision from "Fixed DOS/Windows executable handling by KRun" to "Fixed interaction with DOS/Windows executables in KRun::runUrl". mdlubakowski edited the summary of this revision. mdlubakowski added reviewers: dfaure, Frameworks. REPOSITORY R241 KIO REVISION DETAIL

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

dfaure created this revision. dfaure added reviewers: apol, ngraham, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds. If there were any unittests, I would have run them... If there

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

dfaure closed this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D23988 To: dfaure, drosca Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed DOS/Windows executable handling by KRun

mdlubakowski created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mdlubakowski requested review of this revision. REPOSITORY R241 KIO BRANCH exe-file-handling REVISION DETAIL https://phabricator.kde.org/D23989 AFFECTED FILES

D22510: Added dialog to set execute permission for executable file when trying to run it.

mdlubakowski added a comment. In D22510#532295 , @broulik wrote: > This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works. Indeed it

D23991: GIT_SILENT fix comment about passwords in debug output

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QUrls in debug output always have the password removed (upstream impl.) REPOSITORY R241 KIO BRANCH

D23991: GIT_SILENT fix comment about passwords in debug output

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. There isn't even a QString around in this code, so you could just remove the comment altogether. REPOSITORY R241 KIO BRANCH ahmad/url-debug-output-passwords (branched from master)

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Thanks for the quick fix. INLINE COMMENTS > krun.cpp:366 > +// On Windows, run all executables normally > +bool runWindowsExecutable = true; >

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

broulik added inline comments. INLINE COMMENTS > kcombobox.cpp:59 > Q_Q(KComboBox); > -q->QComboBox::setAutoCompletion(false); // otherwise setLineEdit will > create a completer... > With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind autocompletes history entries

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

dfaure created this revision. dfaure added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN make && ctest REPOSITORY R307 KPeople BRANCH master REVISION DETAIL