D24015: Added scripts to create a webfont out of all breeze action icons

fabianr added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb added inline comments. INLINE COMMENTS > Gruntfile.js:13 > +types: 'eot,woff2,ttf,svg', > +optimize: false > +} why not true? REPOSITORY R266 Breeze Icons REVISION DETAIL

D24015: Added scripts to create a webfont out of all breeze action icons

fabianr added inline comments. INLINE COMMENTS > ognarb wrote in Gruntfile.js:13 > why not true? From https://www.npmjs.com/package/grunt-webfont > optimize > > Type: boolean Default: true > > If false the SVGO optimization will not be used. This is useful in cases > where the optimizer

D24012: Supress mouse events in KCMs causing window moves

anthonyfieroni added inline comments. INLINE COMMENTS > kcmoduleqml.cpp:265-268 > +bool rc = KCModule::event(event); > +if (event->type () == QEvent::MouseButtonPress || event->type() == > QEvent::MouseButtonRelease) { > +event->accept(); > +} Should we check `if (rc &&

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/19/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 07:31:17 + Build duration: 10 min and counting JUnit Tests Name:

D23815: [KConfig] port away from deprecated methods in Qt 5.14

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24002: Sort files alphabetically in cmake list

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c8f110f3a22: Sort files alphabetically in cmake list (authored by gladhorn). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66278=66279 REVISION DETAIL

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/20/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 07:31:17 + Build duration: 18 min and counting BUILD ARTIFACTS

D24002: Sort files alphabetically in cmake list

gladhorn updated this revision to Diff 66278. gladhorn added a comment. Actually sort all files REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24002?vs=66254=66278 BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 AFFECTED

D24002: Sort files alphabetically in cmake list

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH arcpatch-D24002 REVISION DETAIL https://phabricator.kde.org/D24002 To: gladhorn, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

fabianr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. fabianr requested review of this revision. REVISION SUMMARY Added a grunt task for generating (web)fonts out of the breeze action svg icons REPOSITORY R266 Breeze Icons

D24003: kwaylandScanner produce version enum per class

gladhorn added a comment. The unstable primary selection v1 protocol produces code that doesn't compile, after this change it does compile - since it expects the version enums for three classes, but only the first one is actually written into the file. REPOSITORY R127 KWayland REVISION

D24014: [KWayland] Port away from deprecated API in Qt 5.14

zzag added inline comments. INLINE COMMENTS > test_wayland_surface.cpp:396 > > -wl_buffer *blackBuffer = *(m_shm->createBuffer(black).data()); > -auto redBuffer = m_shm->createBuffer(red); > +auto blackBufferPtr = m_shm->createBuffer(black).toStrongRef(); > +

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 64 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/64/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 07:31:17 + Build duration: 16 min and counting BUILD ARTIFACTS

D24020: Support NetworkManager 1.20

arojas added a comment. Actually I don't think this ever worked - the NM include is guarded by an if(NM_0_7), and this is not defined anywhere REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24014: [KWayland] Port away from deprecated API in Qt 5.14

dfaure marked 3 inline comments as done. dfaure added inline comments. INLINE COMMENTS > zzag wrote in test_wayland_surface.cpp:396 > I know it's unrelated, but erasing smart pointer types perhaps is not the > greatest idea. Could you please use concrete type instead of auto while > you're on

D24020: Support NetworkManager 1.20

arojas created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY NetworkManager.pc and libnm-util.pc are no longer available in 1.20. The only header that kdelibs4support is using is

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

arojas updated this revision to Diff 66288. arojas retitled this revision from "Support NetworkManager 1.20" to "Support NetworkManager 1.20 and do actually compile the NM backend". arojas edited the summary of this revision. REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

lbeltrame added a comment. +1 REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

dfaure updated this revision to Diff 66290. dfaure marked 2 inline comments as done. dfaure added a comment. Less auto, more range-for, sorting includes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24014?vs=66276=66290 BRANCH master REVISION DETAIL

D23985: Consider UNC paths as NetworkShare context

This revision was automatically updated to reflect the committed changes. Closed by commit R308:8df6c719617e: Consider UNC paths as NetworkShare context (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23985?vs=66194=66289 REVISION

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure added a comment. I'm going to adopt a different strategy for Frameworks after all, because: - setting this in KDEFrameworksCompilerSettings.cmake would affect much more than frameworks (this stricter set of flags has been adopted by many many applications) - setting this in

D24020: Support NetworkManager 1.20

arojas added a comment. Indeed, after removing the NM_0_7 check this doesn't even compile... REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/20/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 12:20:43 + Build duration: 16 min and counting JUnit Tests Name:

D24015: Added scripts to create a webfont out of all breeze action icons

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2,

D24014: [KWayland] Port away from deprecated API in Qt 5.14

dfaure closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24014 To: dfaure, davidedmundson, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D12992: New elisa icon

lshoravi added a comment. Bumping @abetts REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: ndavis, KonqiDragon, abetts, paullesur, januz, mgallien, alex-l, andreask, kde-frameworks-devel, mfraser, mnesbitt,

D24014: [KWayland] Port away from deprecated API in Qt 5.14

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in test_wayland_surface.cpp:396 > The "Almost Always Auto" crowd would disagree with you, but sure, your > choice. Done. Putting auto everywhere is a

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 12:20:43 + Build duration: 12 min and counting BUILD ARTIFACTS

Re: [IMPORTANT] Binary Factory & CI System Maintenance

On Tue, Sep 17, 2019 at 2:57 PM sithlord48 wrote: > > Can we get a process to build appimages? This needs the tooling for it to be built first. Given that Craft already has the majority of the infrastructure for this, i'd suggest adding appimage support to it which should then make adding

D24025: Don't use KCrash on Android

apol added a comment. In D24025#533418 , @vkrause wrote: > I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 19:32:36 + Build duration: 21 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 84 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/84/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 19:34:13 + Build duration: 20 min and counting CONSOLE OUTPUT [...truncated 1139

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This fixes the crash for me. Thanks! REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc:

D23815: [KConfig] port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D23815 To: dfaure, mdawson, arichardson, vkrause Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 114 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/114/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 19:32:27 + Build duration: 34 min and counting CONSOLE OUTPUT [...truncated 481

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 92 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/92/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 19:33:12 + Build duration: 15 min and counting CONSOLE OUTPUT

D24025: Don't use KCrash on Android

vkrause added a comment. I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go for the dummy. A crash handler/bug reporter is something we certainly want I'd

D24025: Don't use KCrash on Android

vkrause added a comment. In D24025#533428 , @apol wrote: > In D24025#533418 , @vkrause wrote: > > > I think the line between dummy and #ifdef is in the commit message: if we don't want something on

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

dfaure added a comment. Usually I'm the one reviewing patches for KIO, but yeah, for my own patches, who's going to review them? :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns, chinmoyr Cc: chinmoyr, kde-frameworks-devel,

D23902: [KCoreDirLister] replace deprecated foreach with range-for

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister.cpp:833 > qCDebug(KIO_CORE_DIRLISTER) << urlDir; // output urls, not qstrings, > since they might contain a password > -Q_FOREACH

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 19:30:50 + Build duration: 3 min 34 sec and counting JUnit Tests Name:

KDE CI: Frameworks » purpose » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 19:32:27 + Build duration: 11 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 214 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/214/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 19:33:13 + Build duration: 42 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 64 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/64/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 19:34:12 + Build duration: 40 min and counting CONSOLE OUTPUT

D23937: [KDeclarative] Port away from deprecated QWheelEvent methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R296:ff6791c2bd65: [KDeclarative] Port away from deprecated QWheelEvent methods (authored by dfaure). REPOSITORY R296

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 64 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/64/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 19:33:12 + Build duration: 28 min and counting CONSOLE OUTPUT

D24015: Added scripts to create a webfont out of all breeze action icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. FWIW I can confirm that it fixes the bug. I'm not an expert in KIO code but it all looks sensible enough to me, and the autotest passes. Maybe we should land it sooner rather than

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/84/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 21:15:39 + Build duration: 5 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.13/23/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 21:15:38 + Build duration: 6 min 46 sec and counting JUnit Tests

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 48 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/48/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 19:32:27 + Build duration: 2 hr 0 min and counting CONSOLE OUTPUT [...truncated 459

Re: KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 114 - Failure!

We'll need a libaccounts release I guess, master wouldn't have this problem. I created an issue upstream: https://gitlab.com/accounts-sso/libaccounts-qt/issues/4 Aleix On Tue, Sep 17, 2019 at 10:07 PM CI System wrote: > *BUILD FAILURE* > Build URL >

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 87 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/87/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 22:32:21 + Build duration: 1 min 48 sec and counting CONSOLE OUTPUT [...truncated

D23902: [KCoreDirLister] replace deprecated foreach with range-for

ahmadsamir marked 10 inline comments as done. ahmadsamir added a comment. I think I got all the bits I missed before (sorry about the mess). But I'll sleep on it anyway, will submit in the morning (usually I find mistakes in my code when I look at it again in the morning). Thanks.

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/94/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:36:05 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 67 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/67/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:39:13 + Build duration: 8 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 215 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/215/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 22:36:05 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 102 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/102/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:40:30 + Build duration: 7 min 54 sec and counting CONSOLE OUTPUT [...truncated 1062

D23968: Use app specific location for DB on Android

nicolasfella added a comment. Turns out GenricDataLocation is probably writeable if the app has WRITE_EXTERNAL_STORAGE permission. In general this makes sense, but in my use case (plasma-phonebook) I'd prefer to have the database in the app-local storage and not request file system access

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/86/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 22:30:15 + Build duration: 2 min 1 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 100 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/100/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:30:16 + Build duration: 2 min 30 sec and counting CONSOLE OUTPUT [...truncated 1025

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 88 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/88/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 22:39:12 + Build duration: 1 min 40 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 65 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/65/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:36:06 + Build duration: 5 min 9 sec and counting CONSOLE OUTPUT

D23902: [KCoreDirLister] replace deprecated foreach with range-for

dfaure added a comment. Don't confuse the two rules of porting to range-for (for Qt containers) 1. The container should be const, to avoid paying for a detach. So either a local const var, or qAsConst() over a non-const var (but never a temporary returned by a function!) 2. The

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 65 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/65/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:21:00 + Build duration: 8 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 99 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/99/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:21:00 + Build duration: 7 min 23 sec and counting CONSOLE OUTPUT [...truncated 1045

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 115 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/115/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 22:26:10 + Build duration: 3 min 12 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/49/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:26:10 + Build duration: 3 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 89 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/89/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 22:42:55 + Build duration: 3 min 16 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 68 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/68/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:48:22 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Frameworks » ktexteditor » kf5-qt5 WindowsMSVCQt5.13 - Build # 66 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20WindowsMSVCQt5.13/66/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:44:15 + Build duration: 13 min and counting JUnit Tests Name:

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns, chinmoyr, ngraham Cc: ngraham, chinmoyr, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 103 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/103/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:48:27 + Build duration: 22 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 22:21:00 + Build duration: 2 min 22 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/104/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 23:36:08 + Build duration: 7 min 56 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 90 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/90/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 23:36:08 + Build duration: 6 min 50 sec and counting JUnit Tests Name:

D23766: FakeInput: add support for keyboard key press and release

apol added a comment. The patch looks good to me, is there a reason why it wasn't accepted? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 93 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/93/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 19:33:13 + Build duration: 2 hr 6 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 98 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/98/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 19:34:13 + Build duration: 2 hr 22 min and counting CONSOLE OUTPUT [...truncated 1025

Re: KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 114 - Failure!

On mardi 17 septembre 2019 23:53:00 CEST Aleix Pol wrote: > We'll need a libaccounts release I guess, master wouldn't have this problem. > I created an issue upstream: > https://gitlab.com/accounts-sso/libaccounts-qt/issues/4 Thanks. This is why it passed locally. I'll revert the define for now.

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 66 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/66/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 17 Sep 2019 22:30:16 + Build duration: 8 min 17 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 101 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/101/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 17 Sep 2019 22:32:48 + Build duration: 7 min 35 sec and counting CONSOLE OUTPUT [...truncated 1072

D24025: Don't use KCrash on Android

apol added a comment. Why not? it could be useful. The alternative is darkness over what happened there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

nicolasfella added a comment. In D24025#533310 , @broulik wrote: > Can't we make KCrash just no-op on Android? It pretty much is. The problem I'm fixing only started to arise when I blacklisted it on the Android builds because it's 1)

D24025: Don't use KCrash on Android

broulik added a comment. I surely don't want to have apps start to #ifdef a ton of stuff out, which works against the nature of Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 17 Sep 2019 04:19:22 + Build duration: 2 min 36 sec and counting JUnit Tests Name:

Re: [IMPORTANT] Binary Factory & CI System Maintenance

Can we get a process to build appimages? On Mon, Sep 16, 2019 at 3:47 PM Ben Cooksley wrote: > Hi all, > > As part of changes to help improve the capacity, capability and > security of the Binary Factory and CI system, i'm going to be > performing a rebuild of several of the physical hosts

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Otherwise we leave a context dangling with no engine, which is

D24024: Bundle plugin files on Android

nicolasfella created this revision. nicolasfella added reviewers: apol, vkrause. nicolasfella added a project: Android. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We need to tell

D24024: Bundle plugin files on Android

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24024 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, laraque, GB_2, jackyalcine, vatra, michaelh, ognarb, ngraham, bruns,

D24024: Bundle plugin files on Android

vkrause requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24024 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, laraque, GB_2, jackyalcine, vatra, michaelh, ognarb,

D24024: Bundle plugin files on Android

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R307:2ce4d6164797: Bundle plugin files on Android (authored by nicolasfella). REPOSITORY R307 KPeople CHANGES SINCE

D24025: Don't use KCrash on Android

nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We don't want/have KCrash on Android, so diable the pieces there TEST

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 66 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/66/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 17 Sep 2019 13:27:00 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

D24012: Supress mouse events in KCMs causing window moves

ngraham added a comment. +1, fixes the bug. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24012 To: davidedmundson, #plasma Cc: ngraham, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

broulik added a reviewer: dfaure. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

davidedmundson edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24024: Bundle plugin files on Android

vkrause added a comment. sorry, I somehow keep misclicking the approve button, was meant to +2 this too of course REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24024 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, laraque, GB_2, jackyalcine,

D24025: Don't use KCrash on Android

broulik added a comment. Can't we make KCrash just no-op on Android? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   >