D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Eh, it doesn't bother me that much. If you think this is the right thing to do, go ahead. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D24046: Allow triggering sort from QML

2019-10-06 Thread Nicolas Fella
nicolasfella added a comment. In D24046#542147 , @jbbgameich wrote: > why not > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { > QSortFilterProxyModel::sort(column, order); > } >

D24433: Move URL parsing methods from kioslave to query object

2019-10-06 Thread Ismael Asensio
iasensio edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven Cc: kde-frameworks-devel, #dolphin, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D7446: [Places panel] Revamp the Recently Saved section

2019-10-06 Thread David Faure
dfaure added a comment. This commit breaks `kfileplacesmodeltest`, please take a look. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/247/testReport/junit/projectroot/autotests/kiofilewidgets_kfileplacesmodeltest/ REPOSITORY R241

D24434: Fix include path to kjob.h

2019-10-06 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24434 To: hallas, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY See D24424 REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo
guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24436 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo
guoyunhe added a dependent revision: D24424: Create kf5-network.directory. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24436 To: guoyunhe, #breeze Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

2019-10-06 Thread David Faure
dfaure added a comment. Argh, I retagged, but this wasn't pushed yet. Landing and retagging again... REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24434 To: hallas, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24434: Fix include path to kjob.h

2019-10-06 Thread David Faure
dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24434 To: hallas, dfaure, meven, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:34:09 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/37/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:34:45 + Build duration: 24 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/10/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:35:19 + Build duration: 30 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/31/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:35:09 + Build duration: 30 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 88 - Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/88/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 09:34:44 + Build duration: 34 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 248 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/248/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 09:36:36 + Build duration: 48 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/34/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:38:04 + Build duration: 1 hr 5 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/21/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:38:27 + Build duration: 1 hr 23 min and counting JUnit Tests Name:

D7446: [Places panel] Revamp the Recently Saved section

2019-10-06 Thread Méven Car
meven added a comment. In D7446#542407 , @dfaure wrote: > This commit breaks `kfileplacesmodeltest`, please take a look. > >

D24439: Fix test kfileplacesmodeltest after D7446

2019-10-06 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23800: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-06 Thread Friedrich W. H. Kossebau
kossebau added a comment. @mpyne Thanks for the immediate review and testing In D23800#542391 , @mpyne wrote: > I encountered that excluding deprecated components from the build requires a version of x.y.z. (not just x.y) but other than

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:19:51 + Build duration: 1 hr 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 12 - Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/12/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 06 Oct 2019 09:36:21 + Build duration: 2 hr 29 min and counting JUnit Tests

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 68 - Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/68/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 10:57:21 + Build duration: 1 hr 19 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 249 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/249/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 10:25:04 + Build duration: 1 hr 51 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:43:36 + Build duration: 1 hr 43 min and counting JUnit Tests Name:

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY if we do that, window will be corrupted BUG: 412675 TEST PLAN Use Kate, change color theme on a second screen

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Kai Uwe Broulik
broulik added a comment. Can you also check `KRun`, I'm sure we've had issues with startup reporting stuff in the past REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24439: Fix test kfileplacesmodeltest after D7446

2019-10-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24439 To: meven, dfaure, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:36:34 + Build duration: 43 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/12/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:37:43 + Build duration: 1 hr 1 min and counting JUnit Tests Name:

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:39:22 + Build duration: 1 hr 39 min and counting JUnit Tests Name:

D24439: Fix test kfileplacesmodeltest after D7446

2019-10-06 Thread Méven Car
meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY See D7556 REPOSITORY R241 KIO BRANCH master

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:50:45 + Build duration: 1 hr 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 89 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/89/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 10:09:04 + Build duration: 1 hr 20 min and counting BUILD ARTIFACTS

D23411: Fix crash in writer collection and cleanup

2019-10-06 Thread Alexander Stippich
astippich updated this revision to Diff 67372. astippich added a comment. - improve REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23411?vs=64543=67372 BRANCH fixWriterCollection REVISION DETAIL https://phabricator.kde.org/D23411 AFFECTED

D23411: Fix crash in writer collection and cleanup

2019-10-06 Thread Alexander Stippich
astippich added a comment. ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:59:25 + Build duration: 1 hr 41 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:39:37 + Build duration: 1 hr 42 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 110 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/110/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:50:05 + Build duration: 1 hr 51 min and counting JUnit Tests Name:

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/22/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 11:02:00 + Build duration: 1 hr 50 min and counting JUnit Tests Name:

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. Can I merge this? The effect is quiet "evil" here ;=) REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a reviewer: Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. For KRun for me the calls there look properly guarded. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24434: Fix include path to kjob.h

2019-10-06 Thread David Hallas
hallas added a comment. In D24434#542440 , @dfaure wrote: > Argh, I retagged, but this wasn't pushed yet. > Landing and retagging again... Thanks a lot and sorry for the screwups :D REPOSITORY R244 KCoreAddons REVISION DETAIL

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.13/6/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 06 Oct 2019 09:34:00 + Build duration: 39 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 118 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/118/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:36:37 + Build duration: 50 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:37:28 + Build duration: 58 min and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 109 - Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/109/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 09:38:09 + Build duration: 1 hr 11 min and counting JUnit Tests Name:

Call for action: applying version-based deprecation macros for KDE Frameworks API

2019-10-06 Thread Friedrich W. H. Kossebau
Hi, for those who missed things so far, quick recap first (everyone else please jump to next section below): To better assist users of KDE Frameworks in dealing with its deprecated API, we might want to give them more control over visibility of such API to the compiler when building their

D23411: Fix crash in writer collection and cleanup

2019-10-06 Thread Stefan Brüns
bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fixWriterCollection REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n,

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/32/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:05:53 + Build duration: 1 hr 42 min and counting JUnit Tests

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 11 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/11/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:05:59 + Build duration: 1 hr 41 min and counting JUnit Tests Name:

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/17/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:36:15 + Build duration: 1 hr 40 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 119 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/119/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 10:27:34 + Build duration: 1 hr 44 min and counting JUnit Tests Name:

D23411: Fix crash in writer collection and cleanup

2019-10-06 Thread Alexander Stippich
astippich updated this revision to Diff 67376. astippich added a comment. - actually add test file for writercollection REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23411?vs=67372=67376 BRANCH fixWriterCollection REVISION DETAIL

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 11:19:16 + Build duration: 1 hr 49 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 131 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/131/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 06 Oct 2019 09:36:38 + Build duration: 3 hr 51 min and counting BUILD ARTIFACTS

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. You mean if there are such calls? Can do. Btw., Gwenview doesn't render for me any pictures on the second screen either, but I found there no suspicious code :/ REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To:

D24443: Add a plugin system

2019-10-06 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24443: Add a plugin system

2019-10-06 Thread Nicolas Fella
nicolasfella added a comment. Something I'm unsure about is the usage of std::vector in public API. We never really did that, but given Qt6 is ahead we might want to consider doing it from now on REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 250 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/250/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 06 Oct 2019 14:36:33 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 120 - Still Unstable!

2019-10-06 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/120/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 06 Oct 2019 14:36:33 + Build duration: 11 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 132 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/132/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 06 Oct 2019 13:28:36 + Build duration: 1 hr 37 min and counting BUILD ARTIFACTS

D24430: [KCModuleLoader] Show error when QML fails to load

2019-10-06 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24430 To: broulik, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-06 Thread Nathaniel Graham
ngraham added a comment. Is the text in the window mouse-selectable? That would be really nice. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis added a comment. If we're just renaming the category, we don't need to also rename the icon in this case. It would break compatibility with 3rd party icon themes and the only upside is a semantically better name. REPOSITORY R266 Breeze Icons REVISION DETAIL

D24439: Fix test kfileplacesmodeltest after D7446

2019-10-06 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6d8bd6f99a1c: Fix test kfileplacesmodeltest after D7446 (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24439?vs=67369=67384 REVISION DETAIL

D24443: Add a plugin system

2019-10-06 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Plasma. nicolasfella requested review of this revision. REVISION SUMMARY This allows applications/services (e.g. Akonadi, Sink, KHolidays etc) to provide calendar content to other applications/services (e.g.

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a reviewer: dfaure. cullmann added a comment. If possible I would like to have this in 5.63, as otherwise any color scheme change will make all Qt applications on the non-primary screen unusable with scaling. REPOSITORY R252 Framework Integration REVISION DETAIL

D24443: Add a plugin system

2019-10-06 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma

D24412: Add edit-line-width icons

2019-10-06 Thread Nathaniel Graham
ngraham added a comment. Shipit! REPOSITORY R266 Breeze Icons BRANCH add-line-width-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24412: Add edit-line-width icons

2019-10-06 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:2b522d49a7aa: Add edit-line-width icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.13/7/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 06 Oct 2019 10:13:50 + Build duration: 7 hr 14 min and counting JUnit Tests Name:

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Yunhe Guo
guoyunhe added a comment. They can easily rename/link the icon. Correct semantic naming can improve the icon design. In a long view, having the same naming from the freedestop.org specification, to KDE categories, to icons, can reduce confusion. REPOSITORY R266 Breeze Icons REVISION

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 13 - Fixed!

2019-10-06 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/13/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 06 Oct 2019 12:07:12 + Build duration: 7 hr 31 min and counting JUnit Tests