D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Since the static library is only used for autotests, don't waste CPU cycles when

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-11 Thread Kevin Ottens
ervin added a comment. Ah I see what you meant now. I'd rather not do this, it's IMO better if we remove the setting completely when KF6 comes. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau,

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow
hurikhan77 added a comment. In D24539#545019 , @ngraham wrote: > This doesn't apply cleanly on master. Can you rebase it? This is strange because I rebased it to latest master just before submitting it here. Maybe I used an outdated

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis Cc: ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow
hurikhan77 added a comment. Now arc squashed all my commits into one single diff... I'm not sure if I like that. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24539 To: hurikhan77, ngraham, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs,

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow
hurikhan77 updated this revision to Diff 67680. hurikhan77 added a comment. Using single-patch-per-branch approach This feels unnatural... :-\ REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24539?vs=67677=67680 BRANCH fixes/prepare-readahead

D23926: Move "Details" tab to second place in Properties dialog

2019-10-11 Thread Matej Mrenica
mthw added a comment. Any progress on this? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23926 To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, LeGast00n, cblack,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 253 - Fixed!

2019-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/253/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 11 Oct 2019 07:36:33 + Build duration: 15 min and counting BUILD ARTIFACTS

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Kai Krakow
hurikhan77 updated this revision to Diff 67677. hurikhan77 added a comment. Rebase and submit with arc - [Database] Rework handling environment flags - [Database] Disable read-ahead to prevent thrashing REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-11 Thread Kai Krakow
hurikhan77 updated this revision to Diff 67681. hurikhan77 added a comment. Resend diff with arc REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24540?vs=67629=67681 BRANCH fixes/readahead REVISION DETAIL https://phabricator.kde.org/D24540 AFFECTED

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-11 Thread Kai Krakow
hurikhan77 updated this revision to Diff 67684. hurikhan77 edited the summary of this revision. hurikhan77 added a comment. Added depend line according to arc docs REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24540?vs=67681=67684 BRANCH fixes/readahead

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 124 - Still Unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/124/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 07:36:32 + Build duration: 1 hr 22 min and counting JUnit Tests Name:

D22520: Remove Growl support

2019-10-11 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:e2eed147c53c: Remove Growl support (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22520?vs=61942=67687 REVISION DETAIL

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-11 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson Cc: apol, kossebau, davidedmundson, kde-frameworks-devel,

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson, apol Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23802: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67731. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67655=67731

T11859: Reduce bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Kai Krakow
hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77 Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Kai Krakow
hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77 Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. In D24537#545451 , @kossebau wrote: > BTW, when it come to weather status icon, I dream of the possibility to simply compose the current status from base elements, instead of having pre-rendered icons. > > So there

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Christoph Cullmann
cullmann created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Provides a clang-format target if wanted Example usage:

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-11 Thread Kai Krakow
hurikhan77 added a comment. Here's a quote: https://github.com/bmatsuo/lmdb-go/issues/118#issuecomment-325449496 I suspect that we can safely say: The Baloo DB is always bigger than the available RAM (we shouldn't fight with what the desktop needs, so let's say we have maybe 20% of

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Kai Krakow
hurikhan77 renamed this task from "Reduce bad performance impact of running Baloo under certain conditions" to "Understanding and reducing bad performance impact of running Baloo under certain conditions". hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859

T11859: Reduce bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Nathaniel Graham
ngraham added subscribers: Baloo, bruns, Frameworks. ngraham added a project: Frameworks. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77, ngraham Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Carl Schwan
ognarb added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:11 > +# > +# :: > +# need doc REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

T11859: Reduce bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Kai Krakow
hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77 Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 42 - Still Unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/42/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 17:13:00 + Build duration: 52 min and counting JUnit Tests Name:

D24555: Add draw-arrow icons

2019-10-11 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. > The design is based on `draw-line` with an arrowhead. I think this is a good design. I noticed that LibreOffice already uses a different icon for drawing arrows, but I think this one

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R293:198f82eb511f: [Database] Rework handling environment flags (authored by hurikhan77, committed by ngraham). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D24539: [Database] Rework handling environment flags

2019-10-11 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fixes/prepare-readahead REVISION DETAIL https://phabricator.kde.org/D24539 To: hurikhan77, ngraham, #baloo Cc: kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs,

D24495: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67734. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE

D24263: edit mode action

2019-10-11 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL https://phabricator.kde.org/D24263 To: mart, #plasma, #vdg, ngraham Cc: broulik, GB_2, ngraham, kde-frameworks-devel,

D24465: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67718. kossebau added a comment. fix incompleteness of patch WRT to NET::Override While that flag is deprecated for clients, window managing code seems to still need to handle that flag if set by old clients, so tagging it as deprecated might

D24540: [Database] Disable read-ahead to reduce thrashing

2019-10-11 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24540 To: hurikhan77, ngraham, #baloo, bruns Cc: bruns, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D24467: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67732. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24467?vs=67430=67732

D24496: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67735. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24496?vs=67498=67735

D24537: Icons for windy weather

2019-10-11 Thread Volker Krause
vkrause added a comment. Nice! We use the Breeze weather icons in KDE Itinerary too, based on api.met.no data, but so far didn't make use of the wind information in there yet. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis Cc:

D24468: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67737. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D24537: Icons for windy weather

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24537#545420 , @vkrause wrote: > Nice! We use the Breeze weather icons in KDE Itinerary too, based on api.met.no data, but so far didn't make use of the wind information in there yet. In case you want to

D24497: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67736. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

2019-10-11 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23512: Avoid overloading KCModule::changed

2019-10-11 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R265:aa136dbab4ae: Avoid overloading KCModule::changed (authored by davidedmundson). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23512?vs=66716=67721

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 45 - Fixed!

2019-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/45/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 11 Oct 2019 17:13:00 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS

D24537: Icons for windy weather

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. BTW, when it come to weather status icon, I dream of the possibility to simply compose the current status from base elements, instead of having pre-rendered icons. So there would be iconic elements for "cloud", "rain cloud", "snow cloud" etc. as well as "sun"

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 67733. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24466?vs=67429=67733

D24559: simplify the url parsing

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH simplify-proxy-load REVISION DETAIL https://phabricator.kde.org/D24559 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Framework for encrypted storage for apps

2019-10-11 Thread Johan Ouwerkerk
Hi all, Many thanks for the responses so far. To address the various points raised: It is acceptable for me if the user must type their password. Keychain integration etc. are optional extras. QCA looks like it might be a good fit for what I need. One question I have with regards to keychain

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

2019-10-11 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sat, 12 Oct 2019 04:28:59 + Build duration: 8 min 58 sec and counting

D24465: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-11 Thread David Faure
dfaure added a comment. +1 from me REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D24465 To: kossebau, #frameworks, #kwin, dfaure, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

2019-10-11 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krun.cpp:1101 > +return ExecutableFileOpenDialog::OpenOrExecute; > +} else if >

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Carl Schwan
ognarb added a comment. There is probably a way to run clang-format only on a patch. See http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting But should we not prefer running clang format one time, instead of having only some part of the code auto-formatted?

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 125 - Still Unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/125/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 03:16:14 + Build duration: 8 min 56 sec and counting JUnit Tests Name:

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 24 - Still unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/24/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 11 Oct 2019 17:20:40 + Build duration: 10 hr and counting JUnit Tests

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

2019-10-11 Thread Kai Krakow
hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77 Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Aleix Pol Gonzalez
apol added a comment. I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568

D24578: Meson: Add a comment section for comment/uncomment with Kate

2019-10-11 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 138 - Unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/138/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 12 Oct 2019 03:16:14 + Build duration: 1 hr 11 min and counting BUILD ARTIFACTS

D24431: Restore cursor thumbnailer

2019-10-11 Thread Adriaan de Groot
adridg added inline comments. INLINE COMMENTS > CMakeLists.txt:149 > > -# if(X11_Xcursor_FOUND) > -# > -#set(cursorthumbnail_PART_SRCS cursorcreator.cpp) > -# > -#add_library(cursorthumbnail MODULE ${cursorthumbnail_PART_SRCS}) > -# > -#target_link_libraries(cursorthumbnail

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Unstable!

2019-10-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 11 Oct 2019 13:22:00 + Build duration: 2 min 11 sec and counting JUnit Tests Name:

D24560: remove legacy space handling code

2019-10-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the raw data in kioslaverc uses the format "$url $port", this format isn't being read

D24429: [ConfigModule] Expose mainUi component status and error string

2019-10-11 Thread Friedrich W. H. Kossebau
kossebau added a comment. Seems this broke the windows build on CI for some reason, please have a look: https://build.kde.org/view/Failing/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/17/ REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R245:f436762fb366: Dont build static library when BUILD_TESTING=OFF (authored by arojas). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24554?vs=67674=67705 REVISION

D24493: Add draw-highlight action icons

2019-10-11 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R266:71b9713970eb: Add draw-highlight action icons (authored by Rafael Brandmaier rafael.brandma...@kdemail.net). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-11 Thread Aleix Pol Gonzalez
apol added a comment. ok, let's just land this for now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D24554 To: arojas, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-11 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R237:5fa1a3312ab2: Make kconfig_compiler generate ctors with the optional parent arg (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-11 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R237:4c3d37519684: Add convenience for defaults/dirty states to KCoreConfigSkeleton (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D24555: Add draw-arrow icons

2019-10-11 Thread TrickyRicky
trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH add-draw-arrow-icons (branched from master) REVISION DETAIL

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter updated this revision to Diff 67697. sitter added a comment. move away from helper functions to redirect to q-> and instaed call via q-> directly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23579?vs=67695=67697 BRANCH ftp REVISION DETAIL

D24555: Add draw-arrow icons

2019-10-11 Thread TrickyRicky
trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24555 To: trickyricky26, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24493: Add draw-highlight action icons

2019-10-11 Thread TrickyRicky
trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2,

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter retitled this revision from "WIP: port ftp slave to new error reporting system" to "port ftp slave to new error reporting system". sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc:

D24559: simplify the url parsing

2019-10-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY all urls need to have their ports stripped and text set, so de-duplicate the shared

D24558: fix proxy setting loading

2019-10-11 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY when the flag isn't set we'd set the text to urlStr, urlStr however was the original string *with* the port. since we

D24558: fix proxy setting loading

2019-10-11 Thread Harald Sitter
sitter added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24558 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: WIP: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter updated this revision to Diff 67695. sitter marked 24 inline comments as done. sitter added a comment. - rebase - ftpSendCmd now returns a bool (continues to require_result) - openConnection now emits opened() - listDir now finalize()s - debug-- - ftpSendCmd's lazy login now